221548 2021-02-08 05:55:34 -0800 comment blocks cause incorrect reporting of column numbers in stack traces 2022-03-24 21:15:46 -0700 1 1 1 Unclassified WebKit JavaScriptCore Safari 14 All All RESOLVED FIXED InRadar P2 Normal --- 1 dan ysuzuki ashvayka aswan fpizlo jond keith_miller saam webkit-bug-importer ysuzuki oldest_to_newest 1726614 0 dan 2021-02-08 05:55:34 -0800 Consider this JavaScript executing on a webpage, imported as an external script file: window.onload = () => { console.log('something unrelated');const e = new Error("new error");console.log(e.stack);console.log('something unrelated'); } The output of `console.log(e.stack)` in the Safari console is: http://127.0.0.1:8081/build/main.js:2:57 Note the column number. 57 is between the "r" and the "(" in new Error("new error"). This looks good. Now consider this: window.onload = () => {/* something about this comment means the line number gets reported incorrectly in the stack */console.log('something unrelated');const e = new Error("new error");console.log(e.stack);console.log('something unrelated'); } The relevant output is then: http://127.0.0.1:8081/build/main.js:3:161 Now the stack trace is reporting the error occurred at column 161, which does not exist. 1729142 1 webkit-bug-importer 2021-02-15 05:56:12 -0800 <rdar://problem/74347565> 1852592 2 aswan 2022-03-17 19:00:05 -0700 In addition to the original report, this also happens with multi-line strings: window.onload = () => { let s = ` multi line string `;console.log('something unrelated');const e = new Error("new error");console.log(e.stack);console.log('something unrelated'); } This is creating problems for us as we use source maps to translate the locations of javascript errors, but the incorrect column numbers are causing this translation to break. 1852593 3 aswan 2022-03-17 19:03:06 -0700 And fwiw, I think https://bugs.webkit.org/show_bug.cgi?id=213873 is probably due to the same underlying issue. 1854956 4 ysuzuki 2022-03-24 17:28:35 -0700 Thanks! This is fixed in bug 235607 :) Let us add some more test cases to ensure this. *** This bug has been marked as a duplicate of bug 235607 *** 1854965 5 ysuzuki 2022-03-24 17:38:42 -0700 Reopening to attach new patch. 1854966 6 455712 ysuzuki 2022-03-24 17:38:44 -0700 Created attachment 455712 Patch 1855001 7 ews-feeder 2022-03-24 21:15:42 -0700 Committed r291847 (248859@main): <https://commits.webkit.org/248859@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 455712. 455712 2022-03-24 17:38:44 -0700 2022-03-24 21:15:43 -0700 Patch bug-221548-20220324173843.patch text/plain 1798 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjkxODM3CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGEyZTViZWU1YWE3OTRmYjA4ZjE1ODcxM2QxZGI0 MGM0NDgyNWIwZTAuLjQ5ZTBkNjEyNTY1YzBjZWUyYjYxN2MzN2Y2NzE0ZjU2YzZiMGQ0N2IgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTcgQEAKKzIwMjItMDMtMjQgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNv bT4KKworICAgICAgICBBZGQgYWRkaXRpb25hbCByZXBvcnRlZCByZWdyZXNzaW9uIHRlc3RzIHRv IGVuc3VyZSBtdWx0aWxpbmUgdG9rZW4ncyBjb2x1bW4gb2Zmc2V0IGlzIHJlc2V0CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjE1NDgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgYnVnIGlzIGZpeGVk IGFuZCB0ZXN0ZWQgaW4gaHR0cHM6Ly9naXRodWIuY29tL1dlYktpdC9XZWJLaXQvY29tbWl0LzZk MWU1ZDk0OThmMjQ4MDU5ODhhZDgxY2EzMjI4NTg4ZGQwMDBhNTEuCisgICAgICAgIEJ1dCBsZXQn cyBhZGQgcmVwb3J0ZWQgcmVncmVzc2lvbiB0ZXN0cyB0byBlbnN1cmUgdGhhdCB0aGV5IHdpbGwg bm90IHJlcHJvZHVjZS4KKworICAgICAgICAqIHN0cmVzcy9tdWx0aWxpbmUtdG9rZW4tZXJyb3It Y29sdW1uLmpzOiBBZGRlZC4KKyAgICAgICAgKHNob3VsZEJlKToKKyAgICAgICAgKHRocm93Lm5l dy5FcnJvcik6CisKIDIwMjItMDMtMjMgIEdlemEgTG9yZSAgPGdsb3JlQGlnYWxpYS5jb20+CiAK ICAgICAgICAgW0pTQ10gRml4IHJlbW90ZUZ1bmN0aW9uQ2FsbEdlbmVyYXRvciBvbiBNSVBTCmRp ZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy9tdWx0aWxpbmUtdG9rZW4tZXJyb3ItY29sdW1uLmpz IGIvSlNUZXN0cy9zdHJlc3MvbXVsdGlsaW5lLXRva2VuLWVycm9yLWNvbHVtbi5qcwpuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwLi41ODg3YzE5OTRhNTIzMTAxMTc5ZGIwNmYyNGRmYTdmZWI2MmI1NDQzCi0tLSAvZGV2L251 bGwKKysrIGIvSlNUZXN0cy9zdHJlc3MvbXVsdGlsaW5lLXRva2VuLWVycm9yLWNvbHVtbi5qcwpA QCAtMCwwICsxLDI0IEBACitmdW5jdGlvbiBzaG91bGRCZShhY3R1YWwsIGV4cGVjdGVkKSB7Cisg ICAgaWYgKGFjdHVhbCAhPT0gZXhwZWN0ZWQpCisgICAgICAgIHRocm93IG5ldyBFcnJvcignYmFk IHZhbHVlOiAnICsgYWN0dWFsKTsKK30KKworeworICAgIGxldCB7IGxpbmUsIGNvbHVtbiB9ID0g KGZ1bmN0aW9uKCkgey8qCisgICAgICBzb21ldGhpbmcgYWJvdXQgdGhpcyBjb21tZW50IG1lYW5z IHRoZSBsaW5lIG51bWJlciBnZXRzIHJlcG9ydGVkIGluY29ycmVjdGx5IGluIHRoZSBzdGFjawor ICAgICAgKi9jb25zdCBlID0gbmV3IEVycm9yKCJuZXcgZXJyb3IiKTsgcmV0dXJuIGU7CisgICAg fSkoKTsKKyAgICBzaG91bGRCZShsaW5lLCA5KTsKKyAgICBzaG91bGRCZShjb2x1bW4sIDI4KTsK K30KK3sKKyAgICBsZXQgeyBsaW5lLCBjb2x1bW4gfSA9IChmdW5jdGlvbigpIHsKKyAgICAgICAg bGV0IHMgPSBgCittdWx0aQorbGluZQorc3RyaW5nCitgOyBjb25zdCBlID0gbmV3IEVycm9yKCJu ZXcgZXJyb3IiKTsgcmV0dXJuIGU7CisgICAgfSkoKTsKKyAgICBzaG91bGRCZShsaW5lLCAyMCk7 CisgICAgc2hvdWxkQmUoY29sdW1uLCAyMyk7Cit9Cg==