221531 2021-02-07 11:41:37 -0800 Remove a duplicate implementation of EventHandler::mouseDownMayStartSelect() 2021-02-10 14:35:32 -0800 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh katherine_cheney megan_gardner thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1726501 0 wenson_hsieh 2021-02-07 11:41:37 -0800 This method has both const and non-const implementations, but only the non-const version is used. We should remove the (currently unused) const version that just returns `m_mouseDownMayStartSelect`, and mark what is currently the non-`const` version `const` instead. 1726502 1 419543 wenson_hsieh 2021-02-07 11:45:57 -0800 Created attachment 419543 Patch 1726514 2 419543 wenson_hsieh 2021-02-07 13:56:43 -0800 Comment on attachment 419543 Patch Thanks for the review! 1726518 3 ews-feeder 2021-02-07 14:10:44 -0800 Committed r272477: <https://commits.webkit.org/r272477> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419543. 1727796 4 webkit-bug-importer 2021-02-10 14:35:32 -0800 <rdar://problem/74206753> 419543 2021-02-07 11:45:57 -0800 2021-02-07 14:10:44 -0800 Patch bug-221531-20210207114556.patch text/plain 3924 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyNDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTFmZWQzZTRmOTBlZGVl YTQyMjIyYmYxZDA3ODQwNjFiNWU2MTM0OC4uMTU3ODY0NmJjNDc1NGFkNWExYjgyYWI4ZjZmNjJj ZmU4ZmJhMzAxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDIxLTAyLTA3ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBhIGR1 cGxpY2F0ZSBpbXBsZW1lbnRhdGlvbiBvZiBFdmVudEhhbmRsZXI6Om1vdXNlRG93bk1heVN0YXJ0 U2VsZWN0KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIyMTUzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFJlbW92ZSB0aGUgY3VycmVudCBgYm9vbCBtb3VzZURvd25NYXlTdGFydFNlbGVjdCgpIGNvbnN0 YCBtZXRob2Qgd2hpY2gganVzdCByZXR1cm5zIGBtX21vdXNlRG93bk1heVN0YXJ0U2VsZWN0YCwK KyAgICAgICAgYW5kIG1ha2UgdGhlIGN1cnJlbnQgbm9uLWBjb25zdGAgdmVyc2lvbiBvZiB0aGUg bWV0aG9kIGBjb25zdGAgaW5zdGVhZC4gU2luY2UgYG1vdXNlRG93bk1heVN0YXJ0U2VsZWN0KClg IHdhcworICAgICAgICBvbmx5IGludm9rZWQgZnJvbSBub24tY29uc3QgbWV0aG9kcywgdGhlIGZv cm1lciBgY29uc3RgIHZlcnNpb24gd2FzIHVudXNlZC4KKworICAgICAgICBObyBjaGFuZ2UgaW4g YmVoYXZpb3IuCisKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpFdmVudEhhbmRsZXI6Om1vdXNlRG93bk1heVN0YXJ0U2VsZWN0IGNvbnN0KToKKyAg ICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6bW91c2VEb3duTWF5U3RhcnRTZWxlY3QpOiBE ZWxldGVkLgorICAgICAgICAqIHBhZ2UvRXZlbnRIYW5kbGVyLmg6CisgICAgICAgIChXZWJDb3Jl OjpFdmVudEhhbmRsZXI6Om1vdXNlRG93bk1heVN0YXJ0U2VsZWN0IGNvbnN0KTogRGVsZXRlZC4K KyAgICAgICAgKiBwYWdlL1BhZ2UuaDoKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2U6OnRleHRJbnRl cmFjdGlvbkVuYWJsZWQgY29uc3QpOgorCisgICAgICAgIE1ha2UgdGhpcyBnZXR0ZXIgYGNvbnN0 YCwgc28gdGhhdCB3ZSBjYW4gY2FsbCBpdCBpbiBgbW91c2VEb3duTWF5U3RhcnRTZWxlY3QoKSBj b25zdGAuCisKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2U6OnRleHRJbnRlcmFjdGlvbkVuYWJsZWQp OiBEZWxldGVkLgorCiAyMDIxLTAyLTA3ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+ CiAKICAgICAgICAgW0xGQ11bSUZDXSBBIGxpbmUgd2l0aCBubyBjb250ZW50IHNob3VsZCBhbHdh eXMgdGFrZSB0aGUgZmFzdCB2ZXJ0aWNhbCBhbGlnbm1lbnQgcGF0aApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9F dmVudEhhbmRsZXIuY3BwCmluZGV4IDg5YTc1ODY4OGM0YThlODQwZDAzZGMzZTM2OGQzNTliNDI4 ZTA3NGEuLmMyNzMzNmUyZGM4N2UxMmQ3MDQ3NWYxYWFmNjdlMmU4NjFlOWRjNjYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKQEAgLTcwMSw5ICs3MDEsOSBAQCBib29sIEV2ZW50 SGFuZGxlcjo6Y2FuTW91c2VEb3duU3RhcnRTZWxlY3QoY29uc3QgTW91c2VFdmVudFdpdGhIaXRU ZXN0UmVzdWx0cyYgZQogICAgIHJldHVybiBub2RlLT5jYW5TdGFydFNlbGVjdGlvbigpIHx8IFBv c2l0aW9uOjpub2RlSXNVc2VyU2VsZWN0QWxsKG5vZGUpOwogfQogCi1ib29sIEV2ZW50SGFuZGxl cjo6bW91c2VEb3duTWF5U3RhcnRTZWxlY3QoKQorYm9vbCBFdmVudEhhbmRsZXI6Om1vdXNlRG93 bk1heVN0YXJ0U2VsZWN0KCkgY29uc3QKIHsKLSAgICBQYWdlKiBwYWdlID0gbV9mcmFtZS5wYWdl KCk7CisgICAgYXV0byogcGFnZSA9IG1fZnJhbWUucGFnZSgpOwogICAgIGlmIChwYWdlICYmICFw YWdlLT50ZXh0SW50ZXJhY3Rpb25FbmFibGVkKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuaCBiL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmgKaW5kZXggZjc1Zjc2N2QyOTY0MjdiODdhNzdiNzI3 NjUxMGFlMzk4N2Y0M2QzNC4uNWQwNDIwMzhiZjM0YmY4OWZmZTNkYjk5NDc2MzczNzg4OTQ1Mjg3 OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5oCkBAIC0zOTQsOCArMzk0LDYgQEAgcHJp dmF0ZToKICAgICBib29sIGxvZ2ljYWxTY3JvbGxPdmVyZmxvdyhTY3JvbGxMb2dpY2FsRGlyZWN0 aW9uLCBTY3JvbGxHcmFudWxhcml0eSwgTm9kZSogc3RhcnRpbmdOb2RlID0gbnVsbHB0cik7CiAg ICAgCiAgICAgYm9vbCBzaG91bGRTd2FwU2Nyb2xsRGlyZWN0aW9uKGNvbnN0IEhpdFRlc3RSZXN1 bHQmLCBjb25zdCBQbGF0Zm9ybVdoZWVsRXZlbnQmKSBjb25zdDsKLSAgICAKLSAgICBib29sIG1v dXNlRG93bk1heVN0YXJ0U2VsZWN0KCkgY29uc3QgeyByZXR1cm4gbV9tb3VzZURvd25NYXlTdGFy dFNlbGVjdDsgfQogCiAgICAgc3RhdGljIGJvb2wgaXNLZXlib2FyZE9wdGlvblRhYihLZXlib2Fy ZEV2ZW50Jik7CiAgICAgc3RhdGljIGJvb2wgZXZlbnRJbnZlcnRzVGFic1RvTGlua3NDbGllbnRD YWxsUmVzdWx0KEtleWJvYXJkRXZlbnQmKTsKQEAgLTUyOCw4ICs1MjYsNyBAQCBwcml2YXRlOgog ICAgIGJvb2wgc2hvdWxkU2VuZE1vdXNlRXZlbnRzVG9JbmFjdGl2ZVdpbmRvd3MoKSBjb25zdDsK IAogICAgIGJvb2wgY2FuTW91c2VEb3duU3RhcnRTZWxlY3QoY29uc3QgTW91c2VFdmVudFdpdGhI aXRUZXN0UmVzdWx0cyYpOwotCi0gICAgYm9vbCBtb3VzZURvd25NYXlTdGFydFNlbGVjdCgpOwor ICAgIGJvb2wgbW91c2VEb3duTWF5U3RhcnRTZWxlY3QoKSBjb25zdDsKICAgICAKICAgICBGcmFt ZSYgbV9mcmFtZTsKICAgICBSZWZQdHI8Tm9kZT4gbV9tb3VzZVByZXNzTm9kZTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdl LmgKaW5kZXggNjY1N2NkM2QyYzFiNzY4ZTI4NzE1Y2M1NGMxNDI5ZWM3ZDg5MTE2OS4uYzkzYjVl M2EzYjU3ZjE0MmIxNTg2MjkzOWZiM2MyOTY2NmNiNzE5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGFnZS9QYWdlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmgKQEAgLTgz Miw3ICs4MzIsNyBAQCBwdWJsaWM6CiAKICAgICBNb25vdG9uaWNUaW1lIGxhc3RSZW5kZXJpbmdV cGRhdGVUaW1lc3RhbXAoKSBjb25zdCB7IHJldHVybiBtX2xhc3RSZW5kZXJpbmdVcGRhdGVUaW1l c3RhbXA7IH0KIAotICAgIGJvb2wgdGV4dEludGVyYWN0aW9uRW5hYmxlZCgpIHsgcmV0dXJuIG1f dGV4dEludGVyYWN0aW9uRW5hYmxlZDsgfQorICAgIGJvb2wgdGV4dEludGVyYWN0aW9uRW5hYmxl ZCgpIGNvbnN0IHsgcmV0dXJuIG1fdGV4dEludGVyYWN0aW9uRW5hYmxlZDsgfQogICAgIHZvaWQg c2V0VGV4dEludGVyYWN0aW9uRW5hYmxlZChib29sIHZhbHVlKSB7IG1fdGV4dEludGVyYWN0aW9u RW5hYmxlZCA9IHZhbHVlOyB9CiAKICAgICBMb2FkU2NoZWR1bGluZ01vZGUgbG9hZFNjaGVkdWxp bmdNb2RlKCkgY29uc3QgeyByZXR1cm4gbV9sb2FkU2NoZWR1bGluZ01vZGU7IH0K