221521 2021-02-06 11:16:09 -0800 WebCore::genericFamily() should use checked_cf_cast<> 2021-02-10 18:26:32 -0800 1 1 1 Unclassified WebKit Text WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=221428 InRadar P2 Normal --- 1 ddkilzer ddkilzer darin mmaxfield sam webkit-bug-importer oldest_to_newest 1726410 0 ddkilzer 2021-02-06 11:16:09 -0800 WebCore::genericFamily() should use static_cf_cast<>. See notes in Bug 221428 Comment #0: <https://bugs.webkit.org/show_bug.cgi?id=221428#c0> 1726411 1 419512 ddkilzer 2021-02-06 11:18:26 -0800 Created attachment 419512 Patch v1 1726487 2 419512 sam 2021-02-07 10:05:41 -0800 Comment on attachment 419512 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=419512&action=review > Source/WebCore/ChangeLog:10 > + - Switch from dynamic_cf_cast<> to static_cf_cast<> because we Looks like you actually use checked_cf_cast. Probably want to update the ChangeLog comment and title. 1726723 3 419512 ddkilzer 2021-02-08 11:53:00 -0800 Comment on attachment 419512 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=419512&action=review >> Source/WebCore/ChangeLog:10 >> + - Switch from dynamic_cf_cast<> to static_cf_cast<> because we > > Looks like you actually use checked_cf_cast. Probably want to update the ChangeLog comment and title. Ha! This is what happens when I write patches on the weekend now. :) Thanks for catching. 1727900 4 419929 ddkilzer 2021-02-10 17:35:09 -0800 Created attachment 419929 Patch for landing 1727913 5 ews-feeder 2021-02-10 18:25:09 -0800 Committed r272700: <https://commits.webkit.org/r272700> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419929. 1727916 6 webkit-bug-importer 2021-02-10 18:26:32 -0800 <rdar://problem/74216540> 419512 2021-02-06 11:18:26 -0800 2021-02-08 11:53:00 -0800 Patch v1 bug-221521-20210206111825.patch text/plain 1892 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyNDE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzAzY2I3NDdkYTE1MjM1 NTRiMTJlYWFjY2U1Zjg4MWI1ODQ0ZTFhNC4uODQ2Y2UyMjRjOTk0YjI3MzY2MjdjNDY4NWZkMjY3 NWVlMTRhYjkxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTAyLTA2ICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViQ29yZTo6Z2VuZXJp Y0ZhbWlseSgpIHNob3VsZCB1c2Ugc3RhdGljX2NmX2Nhc3Q8PgorICAgICAgICA8aHR0cHM6Ly93 ZWJraXQub3JnL2IvMjIxNTIxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvU3lzdGVtRm9udERhdGFiYXNl Q29yZVRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Z2VuZXJpY0ZhbWlseSk6CisgICAgICAg IC0gU3dpdGNoIGZyb20gZHluYW1pY19jZl9jYXN0PD4gdG8gc3RhdGljX2NmX2Nhc3Q8PiBiZWNh dXNlIHdlCisgICAgICAgICAgYWx3YXlzIGV4cGVjdCBhIENGU3RyaW5nUmVmIHR5cGUgb2JqZWN0 IHRvIGJlIHJldHVybmVkIGZyb20KKyAgICAgICAgICBDVEZvbnREZXNjcmlwdG9yQ29weUF0dHJp YnV0ZSgpLgorCiAyMDIxLTAyLTA1ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAK ICAgICAgICAgW0dQVVByb2Nlc3NdW2lPU10gQXVkaW8gaXMgbG9zdCBhZnRlciBtZWRpYSBwbGF5 YmFjayByZWNvdmVycyBmcm9tIHRoZSBHUFVQcm9jZXNzIGNyYXNoCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9TeXN0ZW1Gb250RGF0YWJhc2VDb3Jl VGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9TeXN0ZW1G b250RGF0YWJhc2VDb3JlVGV4dC5jcHAKaW5kZXggYTAxY2I5OTBkMTUwZjM5ODJlZjZjNTBkMjJl NTJiZjRjNGI2NzBmYy4uM2VkNTc0ODg1NGRlMDJkNWRmMzIyNjI1MDRhMmU2OTJhYTI2NzY3YiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvU3lzdGVt Rm9udERhdGFiYXNlQ29yZVRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2NvY29hL1N5c3RlbUZvbnREYXRhYmFzZUNvcmVUZXh0LmNwcApAQCAtMjkyLDcgKzI5 Miw3IEBAIHN0YXRpYyBTdHJpbmcgZ2VuZXJpY0ZhbWlseShjb25zdCBTdHJpbmcmIGxvY2FsZSwg SGFzaE1hcDxTdHJpbmcsIFN0cmluZz4mIG1hcCwKIHsKICAgICByZXR1cm4gbWFwLmVuc3VyZShs b2NhbGUsIFsmXSB7CiAgICAgICAgIGF1dG8gZGVzY3JpcHRvciA9IGFkb3B0Q0YoQ1RGb250RGVz Y3JpcHRvckNyZWF0ZUZvckNTU0ZhbWlseShjdEtleSwgbG9jYWxlLmNyZWF0ZUNGU3RyaW5nKCku Z2V0KCkpKTsKLSAgICAgICAgYXV0byB2YWx1ZSA9IGFkb3B0Q0YoZHluYW1pY19jZl9jYXN0PENG U3RyaW5nUmVmPihDVEZvbnREZXNjcmlwdG9yQ29weUF0dHJpYnV0ZShkZXNjcmlwdG9yLmdldCgp LCBrQ1RGb250RmFtaWx5TmFtZUF0dHJpYnV0ZSkpKTsKKyAgICAgICAgYXV0byB2YWx1ZSA9IGFk b3B0Q0YoY2hlY2tlZF9jZl9jYXN0PENGU3RyaW5nUmVmPihDVEZvbnREZXNjcmlwdG9yQ29weUF0 dHJpYnV0ZShkZXNjcmlwdG9yLmdldCgpLCBrQ1RGb250RmFtaWx5TmFtZUF0dHJpYnV0ZSkpKTsK ICAgICAgICAgcmV0dXJuIFN0cmluZyB7IHZhbHVlLmdldCgpIH07CiAgICAgfSkuaXRlcmF0b3It PnZhbHVlOwogfQo= 419929 2021-02-10 17:35:09 -0800 2021-02-10 18:25:10 -0800 Patch for landing bug-221521-20210210173508.patch text/plain 1866 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyNjk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjVkMjViYWQwYmFkMmZh NDFlZTIzN2VkMGE3YTI5ZTZkZmZlMTNjYy4uOWYyYjY0ZTQ2MWIwMGExYjRkZjZlYmQwNjVjMDVi OTJkOWU0N2JhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTAyLTEwICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViQ29yZTo6Z2VuZXJp Y0ZhbWlseSgpIHNob3VsZCB1c2UgY2hlY2tlZF9jZl9jYXN0PD4KKyAgICAgICAgPGh0dHBzOi8v d2Via2l0Lm9yZy9iLzIyMTUyMT4KKworICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvU3lzdGVtRm9udERhdGFiYXNlQ29y ZVRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Z2VuZXJpY0ZhbWlseSk6CisgICAgICAgIC0g U3dpdGNoIGZyb20gZHluYW1pY19jZl9jYXN0PD4gdG8gY2hlY2tlZF9jZl9jYXN0PD4gYmVjYXVz ZSB3ZQorICAgICAgICAgIGFsd2F5cyBleHBlY3QgYSBDRlN0cmluZ1JlZiB0eXBlIG9iamVjdCB0 byBiZSByZXR1cm5lZCBmcm9tCisgICAgICAgICAgQ1RGb250RGVzY3JpcHRvckNvcHlBdHRyaWJ1 dGUoKS4KKwogMjAyMS0wMi0xMCAgQ2hyaXN0b3BoZXIgUmVpZCAgPGNocmlzLnJlaWRAc29ueS5j b20+CiAKICAgICAgICAgW1BsYXlTdGF0aW9uXSBBZGQgaW5pdGlhbCBSRVNPVVJDRV9VU0FHRSBp bXBsZW1lbnRhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvY29jb2EvU3lzdGVtRm9udERhdGFiYXNlQ29yZVRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvU3lzdGVtRm9udERhdGFiYXNlQ29yZVRleHQuY3BwCmlu ZGV4IDQ2ODBjNDY1OTUxZDZlNWFkZTlmYTExMGQwOTE0MDJiYjAzZGViNzEuLmYzZTZmYmM4ODJh MGMyZDUxNWI4ZThmNjFmNjljMWQyZTNiZTIzOTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL1N5c3RlbUZvbnREYXRhYmFzZUNvcmVUZXh0LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9TeXN0ZW1Gb250RGF0 YWJhc2VDb3JlVGV4dC5jcHAKQEAgLTI5Myw3ICsyOTMsNyBAQCBzdGF0aWMgU3RyaW5nIGdlbmVy aWNGYW1pbHkoY29uc3QgU3RyaW5nJiBsb2NhbGUsIEhhc2hNYXA8U3RyaW5nLCBTdHJpbmc+JiBt YXAsCiB7CiAgICAgcmV0dXJuIG1hcC5lbnN1cmUobG9jYWxlLCBbJl0gewogICAgICAgICBhdXRv IGRlc2NyaXB0b3IgPSBhZG9wdENGKENURm9udERlc2NyaXB0b3JDcmVhdGVGb3JDU1NGYW1pbHko Y3RLZXksIGxvY2FsZS5jcmVhdGVDRlN0cmluZygpLmdldCgpKSk7Ci0gICAgICAgIGF1dG8gdmFs dWUgPSBhZG9wdENGKGR5bmFtaWNfY2ZfY2FzdDxDRlN0cmluZ1JlZj4oQ1RGb250RGVzY3JpcHRv ckNvcHlBdHRyaWJ1dGUoZGVzY3JpcHRvci5nZXQoKSwga0NURm9udEZhbWlseU5hbWVBdHRyaWJ1 dGUpKSk7CisgICAgICAgIGF1dG8gdmFsdWUgPSBhZG9wdENGKGNoZWNrZWRfY2ZfY2FzdDxDRlN0 cmluZ1JlZj4oQ1RGb250RGVzY3JpcHRvckNvcHlBdHRyaWJ1dGUoZGVzY3JpcHRvci5nZXQoKSwg a0NURm9udEZhbWlseU5hbWVBdHRyaWJ1dGUpKSk7CiAgICAgICAgIHJldHVybiBTdHJpbmcgeyB2 YWx1ZS5nZXQoKSB9OwogICAgIH0pLml0ZXJhdG9yLT52YWx1ZTsKIH0K