22152 2008-11-09 18:15:13 -0800 Remove asObject() call from JSCallbackObject::getOwnPropertySlot() 2008-11-10 10:18:04 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 zwarich zwarich oldest_to_newest 98122 0 zwarich 2008-11-09 18:15:13 -0800 With the recent change to adopt asType() style cast functions with assertions instead of static_casts in many places, the assertion for the asObject() call in JSCallbackObject::getOwnPropertySlot() has been failing when using any nontrivial client of the JavaScriptCore API. The cast isn't even necessary to call slot.setCustom(), so it should be removed. 98123 1 25011 zwarich 2008-11-09 18:21:43 -0800 Created attachment 25011 Proposed patch 98147 2 25011 darin 2008-11-10 06:58:29 -0800 Comment on attachment 25011 Proposed patch r=me 98171 3 zwarich 2008-11-10 10:18:04 -0800 Landed in r38265. 25011 2008-11-09 18:21:43 -0800 2008-11-10 06:58:29 -0800 Proposed patch cast.diff text/plain 1694 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM4MjQ5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDgtMTEt MDkgIENhbWVyb24gWndhcmljaCAgPHp3YXJpY2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAyMjE1MjogUmVtb3ZlIGFzT2Jq ZWN0KCkgY2FsbCBmcm9tIEpTQ2FsbGJhY2tPYmplY3Q6OmdldE93blByb3BlcnR5U2xvdCgpCisg ICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIxNTI+CisK KyAgICAgICAgV2l0aCB0aGUgcmVjZW50IGNoYW5nZSB0byBhZG9wdCBhc1R5cGUoKSBzdHlsZSBj YXN0IGZ1bmN0aW9ucyB3aXRoCisgICAgICAgIGFzc2VydGlvbnMgaW5zdGVhZCBvZiBzdGF0aWNf Y2FzdHMgaW4gbWFueSBwbGFjZXMsIHRoZSBhc3NlcnRpb24gZm9yCisgICAgICAgIHRoZSBhc09i amVjdCgpIGNhbGwgaW4gSlNDYWxsYmFja09iamVjdDo6Z2V0T3duUHJvcGVydHlTbG90KCkgaGFz IGJlZW4KKyAgICAgICAgZmFpbGluZyB3aGVuIHVzaW5nIGFueSBub250cml2aWFsIGNsaWVudCBv ZiB0aGUgSmF2YVNjcmlwdENvcmUgQVBJLgorICAgICAgICBUaGUgY2FzdCBpc24ndCBldmVuIG5l Y2Vzc2FyeSB0byBjYWxsIHNsb3Quc2V0Q3VzdG9tKCksIHNvIGl0IHNob3VsZAorICAgICAgICBi ZSByZW1vdmVkLgorCisgICAgICAgICogQVBJL0pTQ2FsbGJhY2tPYmplY3RGdW5jdGlvbnMuaDoK KyAgICAgICAgKEpTQzo6SlNDYWxsYmFja09iamVjdDo6Z2V0T3duUHJvcGVydHlTbG90KToKKwog MjAwOC0xMS0wOSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgVGltIEhhdGNoZXIuCkluZGV4OiBBUEkvSlNDYWxsYmFja09iamVjdEZ1bmN0aW9u cy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIEFQSS9KU0NhbGxiYWNrT2JqZWN0RnVuY3Rpb25zLmgJKHJldmlz aW9uIDM4MjQwKQorKysgQVBJL0pTQ2FsbGJhY2tPYmplY3RGdW5jdGlvbnMuaAkod29ya2luZyBj b3B5KQpAQCAtMTMwLDcgKzEzMCw3IEBAIGJvb2wgSlNDYWxsYmFja09iamVjdDxCYXNlPjo6Z2V0 T3duUHJvcGUKICAgICAgICAgICAgICAgICAvLyBjYWNoZSB0aGUgdmFsdWUgc28gd2UgZG9uJ3Qg aGF2ZSB0byBjb21wdXRlIGl0IGFnYWluCiAgICAgICAgICAgICAgICAgLy8gRklYTUU6IFRoaXMg dmlvbGF0ZXMgdGhlIFByb3BlcnR5U2xvdCBkZXNpZ24gYSBsaXR0bGUgYml0LgogICAgICAgICAg ICAgICAgIC8vIFdlIHNob3VsZCBlaXRoZXIgdXNlIHRoaXMgb3B0aW1pemF0aW9uIGV2ZXJ5d2hl cmUsIG9yIG5vd2hlcmUuCi0gICAgICAgICAgICAgICAgc2xvdC5zZXRDdXN0b20oYXNPYmplY3Qo dG9KUyh2YWx1ZSkpLCBjYWNoZWRWYWx1ZUdldHRlcik7CisgICAgICAgICAgICAgICAgc2xvdC5z ZXRDdXN0b20odG9KUyh2YWx1ZSksIGNhY2hlZFZhbHVlR2V0dGVyKTsKICAgICAgICAgICAgICAg ICByZXR1cm4gdHJ1ZTsKICAgICAgICAgICAgIH0KICAgICAgICAgfQo=