221500 2021-02-05 13:38:13 -0800 [macOS] REGRESSION(r272352): missing track for videos that haven't fully loaded 2021-02-05 14:32:14 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 221360 1 hi hi eric.carlson ews-watchlist glenn hi jer.noble joepeck philipj sergio webkit-bug-importer oldest_to_newest 1726258 0 hi 2021-02-05 13:38:13 -0800 r272352 removed the `.track.fill` that was used as a "background" for the slider for videos that aren't fully loaded and are buffering, that "background" is necessary to indicate where the slider is as the `.track.secondary` only represents what's been buffered not the entire length of the video/slider 1726260 1 419457 hi 2021-02-05 13:46:38 -0800 Created attachment 419457 Patch 1726277 2 ews-feeder 2021-02-05 14:31:57 -0800 Committed r272438: <https://trac.webkit.org/changeset/272438> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419457. 1726278 3 webkit-bug-importer 2021-02-05 14:32:14 -0800 <rdar://problem/74041791> 419457 2021-02-05 13:46:38 -0800 2021-02-05 14:31:58 -0800 Patch 221500.diff text/plain 6428 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1ODcwOTJiNjhjZjkuLjMyZDI2MDBiMzAwZCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDMyIEBACisyMDIxLTAyLTA1ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNv bT4KKworICAgICAgICBbbWFjT1NdIFJFR1JFU1NJT04ocjI3MjM1Mik6IG1pc3NpbmcgdHJhY2sg Zm9yIHZpZGVvcyB0aGF0IGhhdmVuJ3QgZnVsbHkgbG9hZGVkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjE1MDAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICByMjcyMzUyIHJlbW92ZWQgdGhlIGAudHJhY2su ZmlsbGAgdGhhdCB3YXMgdXNlZCBhcyBhICJiYWNrZ3JvdW5kIiBmb3IgdGhlIHNsaWRlci4gRm9y IHZpZGVvcworICAgICAgICB0aGF0IGFyZW4ndCBmdWxseSBsb2FkZWQgYW5kIGFyZSBidWZmZXJp bmcsIHRoYXQgImJhY2tncm91bmQiIGlzIG5lY2Vzc2FyeSB0byBpbmRpY2F0ZSB3aGVyZQorICAg ICAgICB0aGUgc2xpZGVyIGlzIGFzIHRoZSBgLnRyYWNrLnNlY29uZGFyeWAgb25seSByZXByZXNl bnRzIHdoYXQncyBiZWVuIGJ1ZmZlcmVkIG5vdCB0aGUgZW50aXJlCisgICAgICAgIGxlbmd0aCBv ZiB0aGUgdmlkZW8vc2xpZGVyLgorCisgICAgICAgICogTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29u dHJvbHMvY29udHJvbHMvc2xpZGVyLmpzOgorICAgICAgICAoU2xpZGVyLnByb3RvdHlwZS5jb21t aXQpOgorICAgICAgICAqIE1vZHVsZXMvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL2NvbnRyb2xzL3Ns aWRlci5jc3M6CisgICAgICAgICguc2xpZGVyID4gLmN1c3RvbS1zbGlkZXIgPiAuZmlsbC5wcmlt YXJ5KTogQWRkZWQuCisgICAgICAgICguc2xpZGVyID4gLmN1c3RvbS1zbGlkZXIgPiAuZmlsbC50 cmFjayk6IEFkZGVkLgorICAgICAgICAoLnNsaWRlciA+IC5jdXN0b20tc2xpZGVyID4gLmZpbGwu c2Vjb25kYXJ5KTogQWRkZWQuCisgICAgICAgICguc2xpZGVyID4gLmN1c3RvbS1zbGlkZXIgPiAu cHJpbWFyeSk6IERlbGV0ZWQuCisgICAgICAgICguc2xpZGVyID4gLmN1c3RvbS1zbGlkZXIgPiAu c2Vjb25kYXJ5KTogRGVsZXRlZC4KKyAgICAgICAgQWRkIGJhY2sgdGhlIGJhY2tncm91bmQgZmls bCB0cmFjayByZW1vdmVkIGluIHIyNzIzNTIsIGJ1dCBhZGp1c3QgaXQgc28gdGhhdCBpdCBvbmx5 IGRyYXdzCisgICAgICAgIGFmdGVyIHRoZSBrbm9iIHNvIHRoYXQgb24gbWFjT1MgaXQgZG9lc24n dCBkcmF3IGluIHRoZSBzcGFjZSBhcm91bmQgdGhlIGtub2IuCisKKyAgICAgICAgKiBNb2R1bGVz L21vZGVybi1tZWRpYS1jb250cm9scy9jb250cm9scy9tYWNvcy1mdWxsc2NyZWVuLW1lZGlhLWNv bnRyb2xzLmpzOgorICAgICAgICAoTWFjT1NGdWxsc2NyZWVuTWVkaWFDb250cm9scyk6CisgICAg ICAgICogTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvY29udHJvbHMvbWFjb3MtaW5saW5l LW1lZGlhLWNvbnRyb2xzLmpzOgorICAgICAgICAoTWFjT1NJbmxpbmVNZWRpYUNvbnRyb2xzKToK KyAgICAgICAgUmVtb3ZlIHRoZSBgc2Vjb25kYXJ5VmFsdWVgIGNhbGxzIHNpbmNlIHRoZSBiYWNr Z3JvdW5kIGZpbGwgdHJhY2sgaGFzIGJlZW4gYWRkZWQgYmFjay4KKwogMjAyMS0wMi0wNSAgQW50 dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bSW50ZWdyYXRp b25dIEhpdCB0ZXN0aW5nIGJyb2tlbiBmb3IgZGVzY2VuZGFudHMgb2YgcG9pbnRlci1ldmVudHM6 bm9uZSBib3hlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tb2Rlcm4tbWVk aWEtY29udHJvbHMvY29udHJvbHMvbWFjb3MtZnVsbHNjcmVlbi1tZWRpYS1jb250cm9scy5qcyBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL2NvbnRyb2xzL21h Y29zLWZ1bGxzY3JlZW4tbWVkaWEtY29udHJvbHMuanMKaW5kZXggYWM0NzM0NWZlMjZjLi4zYjgw MjRhMDVjM2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbW9kZXJuLW1lZGlh LWNvbnRyb2xzL2NvbnRyb2xzL21hY29zLWZ1bGxzY3JlZW4tbWVkaWEtY29udHJvbHMuanMKKysr IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvY29udHJvbHMv bWFjb3MtZnVsbHNjcmVlbi1tZWRpYS1jb250cm9scy5qcwpAQCAtNDcsNyArNDcsNiBAQCBjbGFz cyBNYWNPU0Z1bGxzY3JlZW5NZWRpYUNvbnRyb2xzIGV4dGVuZHMgTWVkaWFDb250cm9scwogCiAg ICAgICAgIHRoaXMudm9sdW1lU2xpZGVyID0gbmV3IFNsaWRlcigidm9sdW1lIik7CiAgICAgICAg IHRoaXMudm9sdW1lU2xpZGVyLndpZHRoID0gNjA7Ci0gICAgICAgIHRoaXMudm9sdW1lU2xpZGVy LnNlY29uZGFyeVZhbHVlID0gMTsKIAogICAgICAgICB0aGlzLl9sZWZ0Q29udGFpbmVyID0gbmV3 IEJ1dHRvbnNDb250YWluZXIoewogICAgICAgICAgICAgY2hpbGRyZW46IHRoaXMuX3ZvbHVtZUNv bnRyb2xzRm9yQ3VycmVudERpcmVjdGlvbigpLApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvY29udHJvbHMvbWFjb3MtaW5saW5lLW1lZGlh LWNvbnRyb2xzLmpzIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJv bHMvY29udHJvbHMvbWFjb3MtaW5saW5lLW1lZGlhLWNvbnRyb2xzLmpzCmluZGV4IGNiMDgxYmNk ZmY2MC4uNmI0YjM0M2RhM2IwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21v ZGVybi1tZWRpYS1jb250cm9scy9jb250cm9scy9tYWNvcy1pbmxpbmUtbWVkaWEtY29udHJvbHMu anMKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvY29u dHJvbHMvbWFjb3MtaW5saW5lLW1lZGlhLWNvbnRyb2xzLmpzCkBAIC00MCw3ICs0MCw2IEBAIGNs YXNzIE1hY09TSW5saW5lTWVkaWFDb250cm9scyBleHRlbmRzIElubGluZU1lZGlhQ29udHJvbHMK IAogICAgICAgICB0aGlzLnZvbHVtZVNsaWRlciA9IG5ldyBTbGlkZXIoInZvbHVtZSIpOwogICAg ICAgICB0aGlzLnZvbHVtZVNsaWRlci53aWR0aCA9IDYwOwotICAgICAgICB0aGlzLnZvbHVtZVNs aWRlci5zZWNvbmRhcnlWYWx1ZSA9IDE7CiAKICAgICAgICAgdGhpcy5fdm9sdW1lU2xpZGVyQ29u dGFpbmVyID0gbmV3IExheW91dE5vZGUoYDxkaXYgY2xhc3M9InZvbHVtZS1zbGlkZXItY29udGFp bmVyIj48L2Rpdj5gKTsKICAgICAgICAgdGhpcy5fdm9sdW1lU2xpZGVyQ29udGFpbmVyLmNoaWxk cmVuID0gW25ldyBCYWNrZ3JvdW5kVGludCwgdGhpcy52b2x1bWVTbGlkZXJdOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvY29udHJvbHMv c2xpZGVyLmNzcyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbW9kZXJuLW1lZGlhLWNvbnRyb2xz L2NvbnRyb2xzL3NsaWRlci5jc3MKaW5kZXggYTJhNzc3YTQwNmEzLi41MDcwMTM1MzIzNTcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL2Nv bnRyb2xzL3NsaWRlci5jc3MKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tb2Rlcm4tbWVk aWEtY29udHJvbHMvY29udHJvbHMvc2xpZGVyLmNzcwpAQCAtNTAsMTUgKzUwLDIyIEBACiAgICAg bWl4LWJsZW5kLW1vZGU6IHBsdXMtbGlnaHRlcjsKIH0KIAotLnNsaWRlciA+IC5jdXN0b20tc2xp ZGVyID4gLnByaW1hcnkgeworLnNsaWRlciA+IC5jdXN0b20tc2xpZGVyID4gLmZpbGwucHJpbWFy eSB7CiAgICAgbGVmdDogMDsKICAgICBiYWNrZ3JvdW5kLWNvbG9yOiByZ2JhKDI1NSwgMjU1LCAy NTUsIDAuNDUpOwogICAgIGJvcmRlci10b3AtbGVmdC1yYWRpdXM6IDQuNXB4OwogICAgIGJvcmRl ci1ib3R0b20tbGVmdC1yYWRpdXM6IDQuNXB4OwogfQogCi0uc2xpZGVyID4gLmN1c3RvbS1zbGlk ZXIgPiAuc2Vjb25kYXJ5IHsKLSAgICBiYWNrZ3JvdW5kLWNvbG9yOiByZ2JhKDI1NSwgMjU1LCAy NTUsIDAuMTgpOworLnNsaWRlciA+IC5jdXN0b20tc2xpZGVyID4gLmZpbGwudHJhY2sgeworICAg IHJpZ2h0OiAwOworICAgIGJhY2tncm91bmQtY29sb3I6IHJnYmEoMjU1LCAyNTUsIDI1NSwgMC4x KTsKKyAgICBib3JkZXItdG9wLXJpZ2h0LXJhZGl1czogNC41cHg7CisgICAgYm9yZGVyLWJvdHRv bS1yaWdodC1yYWRpdXM6IDQuNXB4OworfQorCisuc2xpZGVyID4gLmN1c3RvbS1zbGlkZXIgPiAu ZmlsbC5zZWNvbmRhcnkgeworICAgIGJhY2tncm91bmQtY29sb3I6IHJnYmEoMjU1LCAyNTUsIDI1 NSwgMC4wOCk7CiAgICAgYm9yZGVyLXRvcC1yaWdodC1yYWRpdXM6IDQuNXB4OwogICAgIGJvcmRl ci1ib3R0b20tcmlnaHQtcmFkaXVzOiA0LjVweDsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL01vZHVsZXMvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL2NvbnRyb2xzL3NsaWRlci5qcyBiL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL2NvbnRyb2xzL3NsaWRl ci5qcwppbmRleCBkNmRmM2VkNjU1MzMuLmY1MmU0OGYxOTU1YyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvY29udHJvbHMvc2xpZGVyLmpz CisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL2NvbnRy b2xzL3NsaWRlci5qcwpAQCAtMzIsOSArMzIsMTAgQEAgY2xhc3MgU2xpZGVyIGV4dGVuZHMgTGF5 b3V0Tm9kZQogCiAgICAgICAgIHRoaXMuX2NvbnRhaW5lciA9IG5ldyBMYXlvdXROb2RlKGA8ZGl2 IGNsYXNzPSJjdXN0b20tc2xpZGVyIj48L2Rpdj5gKTsKICAgICAgICAgdGhpcy5fcHJpbWFyeUZp bGwgPSBuZXcgTGF5b3V0Tm9kZShgPGRpdiBjbGFzcz0icHJpbWFyeSBmaWxsIj48L2Rpdj5gKTsK KyAgICAgICAgdGhpcy5fdHJhY2tGaWxsID0gbmV3IExheW91dE5vZGUoYDxkaXYgY2xhc3M9InRy YWNrIGZpbGwiPjwvZGl2PmApOwogICAgICAgICB0aGlzLl9zZWNvbmRhcnlGaWxsID0gbmV3IExh eW91dE5vZGUoYDxkaXYgY2xhc3M9InNlY29uZGFyeSBmaWxsIj48L2Rpdj5gKTsKICAgICAgICAg dGhpcy5fa25vYiA9IG5ldyBMYXlvdXROb2RlKGA8ZGl2IGNsYXNzPSJrbm9iICR7a25vYlN0eWxl fSI+PC9kaXY+YCk7Ci0gICAgICAgIHRoaXMuX2NvbnRhaW5lci5jaGlsZHJlbiA9IFt0aGlzLl9w cmltYXJ5RmlsbCwgdGhpcy5fc2Vjb25kYXJ5RmlsbCwgdGhpcy5fa25vYl07CisgICAgICAgIHRo aXMuX2NvbnRhaW5lci5jaGlsZHJlbiA9IFt0aGlzLl9wcmltYXJ5RmlsbCwgdGhpcy5fdHJhY2tG aWxsLCB0aGlzLl9zZWNvbmRhcnlGaWxsLCB0aGlzLl9rbm9iXTsKIAogICAgICAgICB0aGlzLl9p bnB1dCA9IG5ldyBMYXlvdXROb2RlKGA8aW5wdXQgdHlwZT0icmFuZ2UiIG1pbj0iMCIgbWF4PSIx IiBzdGVwPSIwLjAwMSIgLz5gKTsKICAgICAgICAgdGhpcy5faW5wdXQuZWxlbWVudC5hZGRFdmVu dExpc3RlbmVyKCJwb2ludGVyZG93biIsIHRoaXMpOwpAQCAtMTQ2LDYgKzE0Nyw3IEBAIGNsYXNz IFNsaWRlciBleHRlbmRzIExheW91dE5vZGUKICAgICAgICAgbGV0IHNjcnViYmVyQm9yZGVyID0g dGhpcy5fa25vYlN0eWxlID09PSBTbGlkZXIuS25vYlN0eWxlLkJhciA/IDEgOiAoLTEgKiBzY3J1 YmJlcldpZHRoIC8gMik7CiAgICAgICAgIGxldCBzY3J1YmJlckNlbnRlclggPSAoc2NydWJiZXJX aWR0aCAvIDIpICsgTWF0aC5yb3VuZCgodGhpcy53aWR0aCAtIHNjcnViYmVyV2lkdGgpICogdGhp cy52YWx1ZSk7CiAgICAgICAgIHRoaXMuX3ByaW1hcnlGaWxsLmVsZW1lbnQuc3R5bGUud2lkdGgg PSBgJHtzY3J1YmJlckNlbnRlclggLSAoc2NydWJiZXJXaWR0aCAvIDIpIC0gc2NydWJiZXJCb3Jk ZXJ9cHhgOworICAgICAgICB0aGlzLl90cmFja0ZpbGwuZWxlbWVudC5zdHlsZS5sZWZ0ID0gYCR7 c2NydWJiZXJDZW50ZXJYICsgKHNjcnViYmVyV2lkdGggLyAyKSArIHNjcnViYmVyQm9yZGVyfXB4 YDsKICAgICAgICAgdGhpcy5fc2Vjb25kYXJ5RmlsbC5lbGVtZW50LnN0eWxlLmxlZnQgPSBgJHtz Y3J1YmJlckNlbnRlclggKyAoc2NydWJiZXJXaWR0aCAvIDIpICsgc2NydWJiZXJCb3JkZXJ9cHhg OwogICAgICAgICB0aGlzLl9zZWNvbmRhcnlGaWxsLmVsZW1lbnQuc3R5bGUucmlnaHQgPSBgJHso MSAtIHRoaXMuX3NlY29uZGFyeVZhbHVlKSAqIDEwMH0lYDsKICAgICAgICAgdGhpcy5fa25vYi5l bGVtZW50LnN0eWxlLmxlZnQgPSBgJHtzY3J1YmJlckNlbnRlclh9cHhgOwo=