221492 2021-02-05 11:05:33 -0800 ASSERT NOT REACHED in WebCore::Layout::LineBuilder::candidateContentForLine 2021-02-06 07:23:05 -0800 1 1 1 Unclassified WebKit Layout and Rendering Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad zalan bfulgham koivisto simon.fraser webkit-bot-watchers-bugzilla webkit-bug-importer zalan oldest_to_newest 1726197 0 ryanhaddad 2021-02-05 11:05:33 -0800 The following two tests are asserting on macOS debug WK2 bots: fast/layoutformattingcontext/float-in-inline-context-simple.html fast/layoutformattingcontext/floats-shrinking-line-simple.html https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=fast%2Flayoutformattingcontext%2Ffloat-in-inline-context-simple.html&test=fast%2Flayoutformattingcontext%2Ffloats-shrinking-line-simple.html SHOULD NEVER BE REACHED ./layout/inlineformatting/InlineLineBuilder.cpp(537) : auto WebCore::Layout::LineBuilder::candidateContentForLine(WebCore::Layout::LineCandidate &, size_t, const WebCore::Layout::LineBuilder::InlineItemRange &, size_t, WebCore::InlineLayoutUnit)::(anonymous class)::operator()() const 1 0x38ba950f9 WTFCrash 2 0x368076e2b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x36bcad701 WebCore::Layout::LineBuilder::candidateContentForLine(WebCore::Layout::LineCandidate&, unsigned long, WebCore::Layout::LineBuilder::InlineItemRange const&, unsigned long, float)::$_20::operator()() const 4 0x36bcab32b WebCore::Layout::LineBuilder::candidateContentForLine(WebCore::Layout::LineCandidate&, unsigned long, WebCore::Layout::LineBuilder::InlineItemRange const&, unsigned long, float) 5 0x36bcaa422 WebCore::Layout::LineBuilder::placeInlineContent(WebCore::Layout::LineBuilder::InlineItemRange const&, unsigned long) 6 0x36bc9d89a WebCore::Layout::LineBuilder::layoutInlineContent(WebCore::Layout::LineBuilder::InlineItemRange const&, unsigned long, WebCore::Layout::InlineRect const&, bool) 7 0x36bc9cd05 WebCore::Layout::InlineFormattingContext::lineLayout(WTF::Vector<WebCore::Layout::InlineItem, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&, WebCore::Layout::LineBuilder::InlineItemRange, WebCore::Layout::FormattingContext::ConstraintsForInFlowContent const&) 8 0x36bc9bc34 WebCore::Layout::InlineFormattingContext::layoutInFlowContent(WebCore::Layout::InvalidationState&, WebCore::Layout::FormattingContext::ConstraintsForInFlowContent const&) 9 0x36bc60858 WebCore::Layout::BlockFormattingContext::layoutInFlowContent(WebCore::Layout::InvalidationState&, WebCore::Layout::FormattingContext::ConstraintsForInFlowContent const&) 10 0x36bc416f7 WebCore::Layout::LayoutContext::layoutFormattingContextSubtree(WebCore::Layout::ContainerBox const&, WebCore::Layout::InvalidationState&) 11 0x36bc413c7 WebCore::Layout::LayoutContext::layoutWithPreparedRootGeometry(WebCore::Layout::InvalidationState&) 12 0x36bc4126b WebCore::Layout::LayoutContext::layout(WebCore::LayoutSize const&, WebCore::Layout::InvalidationState&) 13 0x36c03a4cd WebCore::FrameViewLayoutContext::layoutUsingFormattingContext() 14 0x36c01b4dd WebCore::FrameViewLayoutContext::layout() 15 0x36b0c7036 WebCore::Document::implicitClose() 16 0x36bde213b WebCore::FrameLoader::checkCallImplicitClose() 17 0x36bde1b6a WebCore::FrameLoader::checkCompleted() 18 0x36bddfc57 WebCore::FrameLoader::finishedParsing() 19 0x36b0dbd36 WebCore::Document::finishedParsing() 20 0x36b8d5f68 WebCore::HTMLConstructionSite::finishedParsing() 21 0x36b91ed97 WebCore::HTMLTreeBuilder::finished() 22 0x36b8dd418 WebCore::HTMLDocumentParser::end() 23 0x36b8db288 WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd() 24 0x36b8dafb7 WebCore::HTMLDocumentParser::prepareToStopParsing() 25 0x36b8dd482 WebCore::HTMLDocumentParser::attemptToEnd() 26 0x36b8dd559 WebCore::HTMLDocumentParser::finish() 27 0x36bdb3aa4 WebCore::DocumentWriter::end() 28 0x36bd61bb4 WebCore::DocumentLoader::finishedLoading() 29 0x36bd61551 WebCore::DocumentLoader::notifyFinished(WebCore::CachedResource&, WebCore::NetworkLoadMetrics const&) 30 0x36bf09a7a WebCore::CachedResource::checkNotify(WebCore::NetworkLoadMetrics const&) 31 0x36bf0551c WebCore::CachedResource::finishLoading(WebCore::SharedBuffer*, WebCore::NetworkLoadMetrics const&) LEAK: 1 WebPageProxy 1726198 1 ryanhaddad 2021-02-05 11:06:46 -0800 The assert was added with https://trac.webkit.org/changeset/272412/webkit 1726199 2 webkit-bug-importer 2021-02-05 11:07:00 -0800 <rdar://problem/74032439> 1726316 3 419481 zalan 2021-02-05 16:10:11 -0800 Created attachment 419481 Patch 1726388 4 ews-feeder 2021-02-06 07:23:02 -0800 Committed r272461: <https://commits.webkit.org/r272461> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419481. 419481 2021-02-05 16:10:11 -0800 2021-02-06 07:23:03 -0800 Patch bug-221492-20210205161010.patch text/plain 2165 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyNDE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGZmMGYwMzUwZDU1YmM4 Nzk2ODBlNjRmMjZmNGMyZWJmMTUwNDBlOC4uZTFlYTVmNDQ5ZWE5NTYzYzU5ZTdkYzJjMTYzZmMy YzFiOTk3M2NkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTAyLTA1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgQVNTRVJUIE5PVCBSRUFDSEVE IGluIFdlYkNvcmU6OkxheW91dDo6TGluZUJ1aWxkZXI6OmNhbmRpZGF0ZUNvbnRlbnRGb3JMaW5l CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjE0OTIK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc0MDMyNDM5PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZsb2F0cyBhcmUgbm90IHBhcnQgb2YgdGhlIGlu bGluZSBjb250ZW50IGFuZCB0aGV5IHNob3VsZCBiZSBpZ25vcmVkIHdoaWxlIGNoZWNraW5nIGlm IHRoZSBjb250aW51b3VzIGNhbmRpZGF0ZSBjb250ZW50IGVuZHMgaW4gYSB3cmFwIG9wcG9ydHVu aXR5LgorCisgICAgICAgICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUJ1aWxk ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpMaW5lQnVpbGRlcjo6Y2FuZGlkYXRl Q29udGVudEZvckxpbmUpOgorCiAyMDIxLTAyLTA1ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBs ZS5jb20+CiAKICAgICAgICAgW0xGQ11bSUZDXSBDb250aW51YXRpb24gcHJlIGFuZCBwb3N0IGJs b2NrIGlubGluZSBib3hlcyBzaG91bGQgbm90IGhhdmUgYm90aCB0aGUgc3RhcnQgYW5kIGVuZCBk ZWNvcmF0aW9ucyBvZiB0aGUgb3JpZ2luYWwgaW5saW5lIGJveApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUJ1aWxkZXIuY3BwIGIv U291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUJ1aWxkZXIu Y3BwCmluZGV4IGE1NDM1OWI5ODFlOWU2ZjJhMjQ2ZWJmYjgzYmIyYTk3ZjRkNDUxN2IuLmNmZTky ZTYyNjRkNDc4YzQzYmYwY2NiNDE5MmQ5MDI2NjY0MmJhM2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCdWlsZGVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lQnVpbGRl ci5jcHAKQEAgLTUxMCw2ICs1MTAsMTAgQEAgdm9pZCBMaW5lQnVpbGRlcjo6Y2FuZGlkYXRlQ29u dGVudEZvckxpbmUoTGluZUNhbmRpZGF0ZSYgbGluZUNhbmRpZGF0ZSwgc2l6ZV90IGMKICAgICAg ICAgICAgIC8vIFRoaXMgY2FuZGlkYXRlIGlubGluZSBjb250ZW50IGVuZHMgYmVjYXVzZSB0aGUg ZW50aXJlIGNvbnRlbnQgZW5kcyBhbmQgbm90IGJlY2F1c2UgdGhlcmUncyBhIHNvZnQgd3JhcCBv cHBvcnR1bml0eS4KICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgfQorICAgICAg ICBpZiAobV9pbmxpbmVJdGVtc1tzb2Z0V3JhcE9wcG9ydHVuaXR5SW5kZXggLSAxXS5pc0Zsb2F0 KCkpIHsKKyAgICAgICAgICAgIC8vIFdoaWxlIHdlIHN0b3AgYXQgZmxvYXRzLCB0aGV5IGFyZSBu b3QgY29uc2lkZXJlZCByZWFsIHNvZnQgd3JhcCBvcHBvcnR1bml0aWVzLiAKKyAgICAgICAgICAg IHJldHVybiBmYWxzZTsKKyAgICAgICAgfQogICAgICAgICAvLyBTZWUgaHR0cHM6Ly93d3cudzMu b3JnL1RSL2Nzcy10ZXh0LTMvI2xpbmUtYnJlYWstZGV0YWlscwogICAgICAgICBhdXRvJiB0cmFp bGluZ0lubGluZUl0ZW0gPSBtX2lubGluZUl0ZW1zW3NvZnRXcmFwT3Bwb3J0dW5pdHlJbmRleCAt IDFdOwogICAgICAgICBpZiAodHJhaWxpbmdJbmxpbmVJdGVtLmlzQm94KCkgfHwgdHJhaWxpbmdJ bmxpbmVJdGVtLmlzTGluZUJyZWFrKCkgfHwgdHJhaWxpbmdJbmxpbmVJdGVtLmlzV29yZEJyZWFr T3Bwb3J0dW5pdHkoKSB8fCB0cmFpbGluZ0lubGluZUl0ZW0uaXNJbmxpbmVCb3hFbmQoKSkgewo=