221476 2021-02-05 09:23:03 -0800 [ews] commit-queue should use commits.webkit.org url instead of trac url 2021-02-06 16:08:54 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1726113 0 aakash_jain 2021-02-05 09:23:03 -0800 commit-queue should use commits.webkit.org url instead of trac url. commits.webkit.org is a redirection service, which currently redirects to trac, but will start redirecting to github in future. When we switch commits.webkit.org to redirect to github, all old commits.webkit.org urls would redirect to github appropriately. 1726115 1 419417 aakash_jain 2021-02-05 09:24:57 -0800 Created attachment 419417 Patch 1726135 2 419417 jbedard 2021-02-05 10:10:12 -0800 Comment on attachment 419417 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419417&action=review > Tools/CISupport/ews-build/steps.py:3109 > + return 'https://commits.webkit.org/r{}'.format(revision) I think we should use identifiers here, but this is good step in the right direction, so I'm going to r+ it. 1726160 3 ews-feeder 2021-02-05 10:31:51 -0800 Committed r272423: <https://trac.webkit.org/changeset/272423> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419417. 1726164 4 webkit-bug-importer 2021-02-05 10:32:30 -0800 <rdar://problem/74030830> 1726382 5 aakash_jain 2021-02-06 06:08:44 -0800 Restarted buildbot to pick up this change. 1726428 6 aakash_jain 2021-02-06 16:08:54 -0800 Working fine, e.g.: https://bugs.webkit.org/show_bug.cgi?id=221502#c4 419417 2021-02-05 09:24:57 -0800 2021-02-05 10:31:52 -0800 Patch bug-221476-20210205122456.patch text/plain 2233 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3MjQxOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIxLTAyLTA1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBjb21taXQtcXVldWUgc2hvdWxkIHVzZSBjb21taXRzLndlYmtp dC5vcmcgdXJsIGluc3RlYWQgb2YgdHJhYyB1cmwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTQ3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weToKKyAg ICAgICAgKFB1c2hDb21taXRUb1dlYktpdFJlcG8udXJsX2Zvcl9yZXZpc2lvbik6CisgICAgICAg ICogQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weToKKwogMjAyMS0wMi0wNSAg TGF1cm8gTW91cmEgIDxsbW91cmFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbRmxhdHBhayBTREtd IFByaW50IHN0ZGVyciB3aGVuIGNvcmVkdW1wY3RsIGZhaWxzCkluZGV4OiBUb29scy9DSVN1cHBv cnQvZXdzLWJ1aWxkL3N0ZXBzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NJU3VwcG9ydC9ld3Mt YnVpbGQvc3RlcHMucHkJKHJldmlzaW9uIDI3MjQxOSkKKysrIFRvb2xzL0NJU3VwcG9ydC9ld3Mt YnVpbGQvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTMxMDYsNyArMzEwNiw3IEBAIGNsYXNz IFB1c2hDb21taXRUb1dlYktpdFJlcG8oc2hlbGwuU2hlbGwKICAgICAgICAgcmV0dXJuIHJjCiAK ICAgICBkZWYgdXJsX2Zvcl9yZXZpc2lvbihzZWxmLCByZXZpc2lvbik6Ci0gICAgICAgIHJldHVy biAnaHR0cHM6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0L3t9Jy5mb3JtYXQocmV2aXNpb24p CisgICAgICAgIHJldHVybiAnaHR0cHM6Ly9jb21taXRzLndlYmtpdC5vcmcvcnt9Jy5mb3JtYXQo cmV2aXNpb24pCiAKICAgICBkZWYgY29tbWVudF90ZXh0X2Zvcl9idWcoc2VsZiwgc3ZuX3Jldmlz aW9uPU5vbmUpOgogICAgICAgICBwYXRjaF9pZCA9IHNlbGYuZ2V0UHJvcGVydHkoJ3BhdGNoX2lk JywgJycpCkluZGV4OiBUb29scy9DSVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFRvb2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3Qu cHkJKHJldmlzaW9uIDI3MjQxOSkKKysrIFRvb2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNf dW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTM3NDksNyArMzc0OSw3IEBAIGNsYXNzIFRl c3RQdXNoQ29tbWl0VG9XZWJLaXRSZXBvKEJ1aWxkU3QKICAgICAgICAgKQogICAgICAgICBzZWxm LmV4cGVjdE91dGNvbWUocmVzdWx0PVNVQ0NFU1MsIHN0YXRlX3N0cmluZz0nQ29tbWl0dGVkIHIy NTY3MjknKQogICAgICAgICByYyA9IHNlbGYucnVuU3RlcCgpCi0gICAgICAgIHNlbGYuYXNzZXJ0 RXF1YWwoc2VsZi5nZXRQcm9wZXJ0eSgnYnVnemlsbGFfY29tbWVudF90ZXh0JyksICdDb21taXR0 ZWQgcjI1NjcyOTogPGh0dHBzOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8yNTY3Mjk+XG5c bkFsbCByZXZpZXdlZCBwYXRjaGVzIGhhdmUgYmVlbiBsYW5kZWQuIENsb3NpbmcgYnVnIGFuZCBj bGVhcmluZyBmbGFncyBvbiBhdHRhY2htZW50IDEyMzQuJykKKyAgICAgICAgc2VsZi5hc3NlcnRF cXVhbChzZWxmLmdldFByb3BlcnR5KCdidWd6aWxsYV9jb21tZW50X3RleHQnKSwgJ0NvbW1pdHRl ZCByMjU2NzI5OiA8aHR0cHM6Ly9jb21taXRzLndlYmtpdC5vcmcvcjI1NjcyOT5cblxuQWxsIHJl dmlld2VkIHBhdGNoZXMgaGF2ZSBiZWVuIGxhbmRlZC4gQ2xvc2luZyBidWcgYW5kIGNsZWFyaW5n IGZsYWdzIG9uIGF0dGFjaG1lbnQgMTIzNC4nKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHNl bGYuZ2V0UHJvcGVydHkoJ2J1aWxkX2ZpbmlzaF9zdW1tYXJ5JyksIE5vbmUpCiAgICAgICAgIHJl dHVybiByYwogCg==