221473 2021-02-05 09:20:17 -0800 [css-flexbox] Tables as flex items issues 2024-11-18 15:42:46 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 224665 224934 225343 136754 1 svillar webkit-unassigned ahmad.saleem792 bfulgham changseok esprehn+autocc ews-watchlist felipeerias glenn kondapallykalyan pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1726108 0 svillar 2021-02-05 09:20:17 -0800 Several failures in newly imported WPT tests: imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-fixed-min-width-3.html imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-flex-cross-size.html imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-percent-width-cell-001.html imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-specified-width.html imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-stretch-cross-size.html imported/w3c/web-platform-tests/css/css-flexbox/table-item-flex-percentage-width.html 1728588 1 webkit-bug-importer 2021-02-12 09:21:14 -0800 <rdar://problem/74278994> 1749658 2 felipeerias 2021-04-13 05:27:05 -0700 A few notes about the failing tests: — table-as-item-fixed-min-width-3 This test creates a flex layout with a table and a div. The table claims to have a min-width of 50px, but after layout it becomes wider as its only cell contains a div with a width of 100px. The flex algorithm uses the min-width of the table to allocate the available space. After layout, the table takes up more space than expected, causing the second flex child to overflow the container. — table-as-item-flex-cross-size The flex container (row direction) sets an overriding logical height on its table child (cross axis from the point of view of the container). However, the table does not actually grow because it ignores that overriding value. — table-as-item-percent-width-cell-001 The table ignores the overriding logical width placed by its flex container and instead takes all the available space and gives it to its first cell (which has width:100%). Furthermore, the different values of flex-basis (content, min-content, max-content) are ignored, so the outcome is the same in all cases. — table-as-item-specified-width The element has flex-basis:100px with flex-grow and flex-shrink both set to 0. This means that its width should stay at 100px and don't change. However, RenderTable::updateLogicalWidth() erroneously discards the 100px overriding width set by the flex container and uses the width value from the style instead (500px). — table-as-item-stretch-cross-size The flex container (column direction) sets an overriding logical height on its table child (main axis for the container). Like before, the table does not actually grow because it ignores that overriding value. — table-item-flex-percentage-width This test creates a series of flex containers with display:table children. Several of those do not have the expected outcome, mainly because the content's width (set as a percentage) takes precedence over its flex-basis and does not change as a result of flex-shrink or flex-grow. 1751024 3 426208 felipeerias 2021-04-16 04:51:59 -0700 Created attachment 426208 Patch 1751027 4 426208 svillar 2021-04-16 05:04:41 -0700 Comment on attachment 426208 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426208&action=review Thanks for the patch! Every patch to WebKit needs a test. If this is covered by WPT tests then you need to remove them from TestExpectations file. > Source/WebCore/rendering/RenderTable.cpp:513 > + for (unsigned i = 0; i < m_captions.size(); ++i) { You can write this like for (auto& caption : m_captions) > Source/WebCore/rendering/RenderTable.cpp:517 > + LayoutUnit contentOverridingLogicalHeight = overridingLogicalHeight() - captionLogicalHeight; Not sure why you label this as contentOverridingLogicalHeight. overridingLogicalHeight() refers to the border box, meaning that it includes border and padding so if you really want the content height you have to use overridingContentLogicalHeight() 1751082 5 426208 svillar 2021-04-16 08:14:13 -0700 Comment on attachment 426208 Patch Moved to bug 224665 2075978 6 ahmad.saleem792 2024-11-18 15:42:46 -0800 All `table-as-item` are passing on Safari Technology Preview 207 - https://wpt.fyi/results/css/css-flexbox?label=master&label=experimental&aligned&q=css-flexbox%2Ftable-as-item and this is also passing `table-item-flex-percentage-width.html` - https://wpt.fyi/results/css/css-flexbox/table-item-flex-percentage-width.html?label=master&label=experimental&aligned&q=%2Ftable-item-flex-percentage-width.html 426208 2021-04-16 04:51:59 -0700 2021-04-16 08:14:13 -0700 Patch bug-221473-20210416205158.patch text/plain 2242 felipeerias U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1ODQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmFlMzFjZDRjZTE1ODVh ZjYxNTBmYzM0MzM2ZTEzZWZhMzZkMTEzOS4uMzllMjhhY2I5Yjc1MWE1OWJiMzFmYTUzYmY0OWMx ZTdlYTZhYzc1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTA0LTE2ICBGZWxp cGUgRXJpYXMgIDxmZWxpcGVlcmlhc0BpZ2FsaWEuY29tPgorCisgICAgICAgIFRhYmxlIGxheW91 dCB0YWtlcyBvdmVycmlkaW5nIGhlaWdodCBpbnRvIGFjY291bnQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTQ3MworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbmRlclRhYmxlOjpsYXlvdXQgYXBwbGll cyB0aGUgb3ZlcnJpZGluZyBoZWlnaHQgc2V0IGJ5IHRoZSBlbGVtZW50J3MgcGFyZW50LgorCisg ICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRhYmxlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlclRhYmxlOjpsYXlvdXQpOgorCiAyMDIxLTA0LTEyICBCSiBCdXJnICA8YmJ1cmdAYXBwbGUu Y29tPgogCiAgICAgICAgIE1vZGVybml6ZSB1c2VzIG9mIENvbnNvbGVDbGllbnQKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGUuY3BwCmluZGV4IGJlODg3MzI3NmJkMDQyODMzZjkz ODFmZWFkYzM1ODQxOWEwNzI4YjQuLjBiNzI5ZWI0NTk0YTk2YWE3NTcwNWU2Zjc4YzVkM2FhMTMy NDRlOGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZS5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlLmNwcApAQCAtNTA4 LDYgKzUwOCwxNyBAQCB2b2lkIFJlbmRlclRhYmxlOjpsYXlvdXQoKQogICAgICAgICBpZiAobG9n aWNhbEhlaWdodExlbmd0aC5pc0ludHJpbnNpYygpIHx8IChsb2dpY2FsSGVpZ2h0TGVuZ3RoLmlz U3BlY2lmaWVkKCkgJiYgbG9naWNhbEhlaWdodExlbmd0aC5pc1Bvc2l0aXZlKCkpKQogICAgICAg ICAgICAgY29tcHV0ZWRMb2dpY2FsSGVpZ2h0ID0gY29udmVydFN0eWxlTG9naWNhbEhlaWdodFRv Q29tcHV0ZWRIZWlnaHQobG9naWNhbEhlaWdodExlbmd0aCk7CiAKKyAgICAgICAgaWYgKGhhc092 ZXJyaWRpbmdMb2dpY2FsSGVpZ2h0KCkpIHsKKyAgICAgICAgICAgIExheW91dFVuaXQgY2FwdGlv bkxvZ2ljYWxIZWlnaHQ7CisgICAgICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbV9j YXB0aW9ucy5zaXplKCk7ICsraSkgeworICAgICAgICAgICAgICAgIFJlbmRlclRhYmxlQ2FwdGlv biYgY2FwdGlvbiA9ICptX2NhcHRpb25zW2ldOworICAgICAgICAgICAgICAgIGNhcHRpb25Mb2dp Y2FsSGVpZ2h0ICs9IGNhcHRpb24ubG9naWNhbEhlaWdodCgpICsgY2FwdGlvbi5tYXJnaW5CZWZv cmUoKSArIGNhcHRpb24ubWFyZ2luQWZ0ZXIoKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAg IExheW91dFVuaXQgY29udGVudE92ZXJyaWRpbmdMb2dpY2FsSGVpZ2h0ID0gb3ZlcnJpZGluZ0xv Z2ljYWxIZWlnaHQoKSAtIGNhcHRpb25Mb2dpY2FsSGVpZ2h0OworICAgICAgICAgICAgaWYgKGNv bnRlbnRPdmVycmlkaW5nTG9naWNhbEhlaWdodCA+IDApCisgICAgICAgICAgICAgICAgY29tcHV0 ZWRMb2dpY2FsSGVpZ2h0ID0gc3RkOjptYXgoY29tcHV0ZWRMb2dpY2FsSGVpZ2h0LCBjb250ZW50 T3ZlcnJpZGluZ0xvZ2ljYWxIZWlnaHQpOworICAgICAgICB9CisKICAgICAgICAgTGVuZ3RoIGxv Z2ljYWxNYXhIZWlnaHRMZW5ndGggPSBzdHlsZSgpLmxvZ2ljYWxNYXhIZWlnaHQoKTsKICAgICAg ICAgaWYgKGxvZ2ljYWxNYXhIZWlnaHRMZW5ndGguaXNJbnRyaW5zaWMoKSB8fCAobG9naWNhbE1h eEhlaWdodExlbmd0aC5pc1NwZWNpZmllZCgpICYmICFsb2dpY2FsTWF4SGVpZ2h0TGVuZ3RoLmlz TmVnYXRpdmUoKSkpIHsKICAgICAgICAgICAgIExheW91dFVuaXQgY29tcHV0ZWRNYXhMb2dpY2Fs SGVpZ2h0ID0gY29udmVydFN0eWxlTG9naWNhbEhlaWdodFRvQ29tcHV0ZWRIZWlnaHQobG9naWNh bE1heEhlaWdodExlbmd0aCk7Cg==