221459 2021-02-05 05:02:00 -0800 [SOUP] Fix error handling in WebKitFormDataInputStream 2021-02-05 06:52:13 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned aperez bugs-noreply oldest_to_newest 1726012 0 cgarcia 2021-02-05 05:02:00 -0800 We are checking the error parameter passed, that can be nullptr when not provided, we should be checking the return value of g_input_stream_read() instead. 1726013 1 419390 cgarcia 2021-02-05 05:03:09 -0800 Created attachment 419390 Patch 1726020 2 419390 aperez 2021-02-05 05:21:45 -0800 Comment on attachment 419390 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419390&action=review > Source/WebCore/platform/network/soup/WebKitFormDataInputStream.cpp:92 > + if (bytesRead == -1) Good catch ^_^ 1726023 3 cgarcia 2021-02-05 05:24:03 -0800 Committed r272410: <https://trac.webkit.org/changeset/272410> 419390 2021-02-05 05:03:09 -0800 2021-02-05 06:52:13 -0800 Patch wk2-form-stream-read-error.diff text/plain 1526 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0NjU1NTk3ZjY1ZWUuLjA1ZWIwOTk1OGViNCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE2IEBACisyMDIxLTAyLTA1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KKworICAgICAgICBbU09VUF0gRml4IGVycm9yIGhhbmRsaW5nIGluIFdlYktp dEZvcm1EYXRhSW5wdXRTdHJlYW0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIyMTQ1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdlIGFyZSBjaGVja2luZyB0aGUgZXJyb3IgcGFyYW1ldGVyIHBhc3NlZCwg dGhhdCBjYW4gYmUgbnVsbHB0ciB3aGVuIG5vdCBwcm92aWRlZCwgd2Ugc2hvdWxkIGJlIGNoZWNr aW5nIHRoZQorICAgICAgICByZXR1cm4gdmFsdWUgb2YgZ19pbnB1dF9zdHJlYW1fcmVhZCgpIGlu c3RlYWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvV2ViS2l0Rm9ybURhdGFJ bnB1dFN0cmVhbS5jcHA6CisgICAgICAgICh3ZWJraXRGb3JtRGF0YUlucHV0U3RyZWFtUmVhZCk6 CisKIDIwMjEtMDItMDQgIEp1bGlhbiBHb256YWxleiAgPGp1bGlhbl9hX2dvbnphbGV6QGFwcGxl LmNvbT4KIAogICAgICAgICBOdWxsIGRlcmVmZXJlbmNlIGluIERvY3VtZW50TG9hZGVyOjpjb21t aXREYXRhKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291 cC9XZWJLaXRGb3JtRGF0YUlucHV0U3RyZWFtLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvc291cC9XZWJLaXRGb3JtRGF0YUlucHV0U3RyZWFtLmNwcAppbmRleCAxOTA5NTA1 OTg2ZjguLmIwY2JjZWMzYjJiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9zb3VwL1dlYktpdEZvcm1EYXRhSW5wdXRTdHJlYW0uY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9XZWJLaXRGb3JtRGF0YUlucHV0U3RyZWFtLmNw cApAQCAtODksNyArODksNyBAQCBzdGF0aWMgZ3NzaXplIHdlYmtpdEZvcm1EYXRhSW5wdXRTdHJl YW1SZWFkKEdJbnB1dFN0cmVhbSogaW5wdXQsIHZvaWQqIGJ1ZmZlciwgZwogICAgICAgICAgICAg Ynl0ZXNUb1JlYWQgPSBwcml2LT5jdXJyZW50U3RyZWFtUmFuZ2VMZW5ndGg7CiAKICAgICAgICAg YXV0byBieXRlc1JlYWQgPSBnX2lucHV0X3N0cmVhbV9yZWFkKHByaXYtPmN1cnJlbnRTdHJlYW0u Z2V0KCksIGJ1ZmZlciwgYnl0ZXNUb1JlYWQsIGNhbmNlbGxhYmxlLCBlcnJvcik7Ci0gICAgICAg IGlmIChlcnJvcikKKyAgICAgICAgaWYgKGJ5dGVzUmVhZCA9PSAtMSkKICAgICAgICAgICAgIHJl dHVybiBieXRlc1JlYWQ7CiAKICAgICAgICAgaWYgKGJ5dGVzUmVhZCkgewo=