221444 2021-02-04 18:52:02 -0800 [JSC] JSImmutableButterfly's toString cache should not happen for generic join 2021-02-05 00:45:44 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki mark.lam webkit-bug-importer oldest_to_newest 1725909 0 ysuzuki 2021-02-04 18:52:02 -0800 [JSC] JSImmutableButterfly's toString cache should not happen for generic join 1725910 1 419352 ysuzuki 2021-02-04 18:53:24 -0800 Created attachment 419352 Patch 1725911 2 ysuzuki 2021-02-04 18:53:27 -0800 <rdar://problem/73972862> 1725914 3 419352 mark.lam 2021-02-04 19:10:24 -0800 Comment on attachment 419352 Patch r=me 1725964 4 ews-feeder 2021-02-05 00:45:43 -0800 Committed r272406: <https://trac.webkit.org/changeset/272406> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419352. 419352 2021-02-04 18:53:24 -0800 2021-02-05 00:45:43 -0800 Patch bug-221444-20210204185324.patch text/plain 6156 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyNDAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw NGY4ZDA0YTU4OTdjNGZhYjdiOGQ4NjYyZWI2YTM2MTQ2Mjg4MzFjLi4xYTBmODg0MTJiYWI3YWU2 ZDI2NzZhM2U5NzUxN2VmZTZiMDNmY2ZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAyMS0wMi0wNCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIEpTSW1tdXRhYmxlQnV0dGVyZmx5J3MgdG9TdHJpbmcgY2FjaGUg c2hvdWxkIG5vdCBoYXBwZW4gZm9yIGdlbmVyaWMgam9pbgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIxNDQ0CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS83Mzk3Mjg2Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBXZSBzaG91bGQgbm90IGNhY2hlIEFycmF5I3RvU3RyaW5nIHJlc3VsdHMgd2l0aCBKU0lt bXV0YWJsZUJ1dHRlcmZseSBpZgorICAgICAgICBpdHMgam9pbiBvcGVyYXRpb24gYmVjb21lcyBn ZW5lcmljIGpvaW46IGluY2x1ZGluZyBvYmplY3RzIGluIGFycmF5LCBzaW5jZQorICAgICAgICB0 aGlzIGNhbiBpbnZva2Ugb2JqZWN0LnRvU3RyaW5nKCksIGFuZCBpdCBpc24ndCBzaWRlLWVmZmVj dCBmcmVlLgorCisgICAgICAgICogcnVudGltZS9BcnJheVByb3RvdHlwZS5jcHA6CisgICAgICAg IChKU0M6OmZhc3RKb2luKToKKyAgICAgICAgKEpTQzo6SlNDX0RFRklORV9IT1NUX0ZVTkNUSU9O KToKKwogMjAyMS0wMi0wNCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAg ICAgICAgIFtKU0NdIEltcGxlbWVudCBPYmplY3QuZW50cmllcyBpbiBDKysKZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0FycmF5UHJvdG90eXBlLmNwcCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0FycmF5UHJvdG90eXBlLmNwcAppbmRleCBiZmZmYzg3 YmY0YWM4OGNiNDRhNDA5MmNlNzRhOTM4M2E3NzkyOTliLi5mYmMzNmM5YjZmNTA4OTE2ZDNjMzBl MWEyYWViNTYzMTg4ODc5ZTlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9BcnJheVByb3RvdHlwZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvQXJyYXlQcm90b3R5cGUuY3BwCkBAIC00NDksNyArNDQ5LDcgQEAgaW5saW5lIGJvb2wgY29u dGFpbnNIb2xlKFQqIGRhdGEsIHVuc2lnbmVkIGxlbmd0aCkKICAgICByZXR1cm4gZmFsc2U7CiB9 CiAKLWlubGluZSBKU1ZhbHVlIGZhc3RKb2luKEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3Qs IEpTT2JqZWN0KiB0aGlzT2JqZWN0LCBTdHJpbmdWaWV3IHNlcGFyYXRvciwgdW5zaWduZWQgbGVu Z3RoLCBib29sKiBzYXdIb2xlcyA9IG51bGxwdHIpCitpbmxpbmUgSlNWYWx1ZSBmYXN0Sm9pbihK U0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBKU09iamVjdCogdGhpc09iamVjdCwgU3RyaW5n VmlldyBzZXBhcmF0b3IsIHVuc2lnbmVkIGxlbmd0aCwgYm9vbCYgc2F3SG9sZXMsIGJvb2wmIGdl bmVyaWNDYXNlKQogewogICAgIFZNJiB2bSA9IGdsb2JhbE9iamVjdC0+dm0oKTsKICAgICBhdXRv IHNjb3BlID0gREVDTEFSRV9USFJPV19TQ09QRSh2bSk7CkBAIC00NjgsOCArNDY4LDcgQEAgaW5s aW5lIEpTVmFsdWUgZmFzdEpvaW4oSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCwgSlNPYmpl Y3QqIHRoaXNPYmplY3QsIFN0cmkKICAgICAgICAgICAgIGlmIChMSUtFTFkodmFsdWUpKQogICAg ICAgICAgICAgICAgIGpvaW5lci5hcHBlbmROdW1iZXIodm0sIHZhbHVlLmFzSW50MzIoKSk7CiAg ICAgICAgICAgICBlbHNlIHsKLSAgICAgICAgICAgICAgICBpZiAoc2F3SG9sZXMpCi0gICAgICAg ICAgICAgICAgICAgICpzYXdIb2xlcyA9IHRydWU7CisgICAgICAgICAgICAgICAgc2F3SG9sZXMg PSB0cnVlOwogICAgICAgICAgICAgICAgIGlmICghaG9sZXNLbm93blRvQmVPSykgewogICAgICAg ICAgICAgICAgICAgICBpZiAoaG9sZXNNdXN0Rm9yd2FyZFRvUHJvdG90eXBlKHZtLCB0aGlzT2Jq ZWN0KSkKICAgICAgICAgICAgICAgICAgICAgICAgIGdvdG8gZ2VuZXJhbENhc2U7CkBAIC00OTQs OCArNDkzLDcgQEAgaW5saW5lIEpTVmFsdWUgZmFzdEpvaW4oSlNHbG9iYWxPYmplY3QqIGdsb2Jh bE9iamVjdCwgSlNPYmplY3QqIHRoaXNPYmplY3QsIFN0cmkKICAgICAgICAgICAgICAgICAgICAg Z290byBnZW5lcmFsQ2FzZTsKICAgICAgICAgICAgICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNj b3BlLCB7IH0pOwogICAgICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgICAgICBpZiAoc2F3 SG9sZXMpCi0gICAgICAgICAgICAgICAgICAgICpzYXdIb2xlcyA9IHRydWU7CisgICAgICAgICAg ICAgICAgc2F3SG9sZXMgPSB0cnVlOwogICAgICAgICAgICAgICAgIGlmICghaG9sZXNLbm93blRv QmVPSykgewogICAgICAgICAgICAgICAgICAgICBpZiAoaG9sZXNNdXN0Rm9yd2FyZFRvUHJvdG90 eXBlKHZtLCB0aGlzT2JqZWN0KSkKICAgICAgICAgICAgICAgICAgICAgICAgIGdvdG8gZ2VuZXJh bENhc2U7CkBAIC01MTksOCArNTE3LDcgQEAgaW5saW5lIEpTVmFsdWUgZmFzdEpvaW4oSlNHbG9i YWxPYmplY3QqIGdsb2JhbE9iamVjdCwgSlNPYmplY3QqIHRoaXNPYmplY3QsIFN0cmkKICAgICAg ICAgICAgIGlmIChMSUtFTFkoIWlzSG9sZSh2YWx1ZSkpKQogICAgICAgICAgICAgICAgIGpvaW5l ci5hcHBlbmROdW1iZXIodm0sIHZhbHVlKTsKICAgICAgICAgICAgIGVsc2UgewotICAgICAgICAg ICAgICAgIGlmIChzYXdIb2xlcykKLSAgICAgICAgICAgICAgICAgICAgKnNhd0hvbGVzID0gdHJ1 ZTsKKyAgICAgICAgICAgICAgICBzYXdIb2xlcyA9IHRydWU7CiAgICAgICAgICAgICAgICAgaWYg KCFob2xlc0tub3duVG9CZU9LKSB7CiAgICAgICAgICAgICAgICAgICAgIGlmIChob2xlc011c3RG b3J3YXJkVG9Qcm90b3R5cGUodm0sIHRoaXNPYmplY3QpKQogICAgICAgICAgICAgICAgICAgICAg ICAgZ290byBnZW5lcmFsQ2FzZTsKQEAgLTU2OCw2ICs1NjUsNyBAQCBpbmxpbmUgSlNWYWx1ZSBm YXN0Sm9pbihKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBKU09iamVjdCogdGhpc09iamVj dCwgU3RyaQogICAgIH0KIAogZ2VuZXJhbENhc2U6CisgICAgZ2VuZXJpY0Nhc2UgPSB0cnVlOwog ICAgIEpTU3RyaW5nSm9pbmVyIGpvaW5lcihnbG9iYWxPYmplY3QsIHNlcGFyYXRvciwgbGVuZ3Ro KTsKICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCB7IH0pOwogICAgIGZvciAodW5zaWdu ZWQgaSA9IDA7IGkgPCBsZW5ndGg7ICsraSkgewpAQCAtNTc5LDYgKzU3NywxMyBAQCBpbmxpbmUg SlNWYWx1ZSBmYXN0Sm9pbihKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBKU09iamVjdCog dGhpc09iamVjdCwgU3RyaQogICAgIFJFTEVBU0VfQU5EX1JFVFVSTihzY29wZSwgam9pbmVyLmpv aW4oZ2xvYmFsT2JqZWN0KSk7CiB9CiAKK0FMV0FZU19JTkxJTkUgSlNWYWx1ZSBmYXN0Sm9pbihK U0dsb2JhbE9iamVjdCogZ2xvYmFsT2JqZWN0LCBKU09iamVjdCogdGhpc09iamVjdCwgU3RyaW5n VmlldyBzZXBhcmF0b3IsIHVuc2lnbmVkIGxlbmd0aCkKK3sKKyAgICBib29sIHNhd0hvbGVzID0g ZmFsc2U7CisgICAgYm9vbCBnZW5lcmljQ2FzZSA9IGZhbHNlOworICAgIHJldHVybiBmYXN0Sm9p bihnbG9iYWxPYmplY3QsIHRoaXNPYmplY3QsIHNlcGFyYXRvciwgbGVuZ3RoLCBzYXdIb2xlcywg Z2VuZXJpY0Nhc2UpOworfQorCiBpbmxpbmUgYm9vbCBjYW5Vc2VEZWZhdWx0QXJyYXlKb2luRm9y VG9TdHJpbmcoVk0mIHZtLCBKU09iamVjdCogdGhpc09iamVjdCkKIHsKICAgICBKU0dsb2JhbE9i amVjdCogZ2xvYmFsT2JqZWN0ID0gdGhpc09iamVjdC0+Z2xvYmFsT2JqZWN0KCk7CkBAIC02NTAs MTAgKzY1NSwxMSBAQCBKU0NfREVGSU5FX0hPU1RfRlVOQ1RJT04oYXJyYXlQcm90b0Z1bmNUb1N0 cmluZywgKEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QsCiAgICAgICAgIH0KIAogICAgICAg ICBib29sIHNhd0hvbGVzID0gZmFsc2U7Ci0gICAgICAgIEpTVmFsdWUgcmVzdWx0ID0gZmFzdEpv aW4oZ2xvYmFsT2JqZWN0LCB0aGlzQXJyYXksIHsgJmNvbW1hLCAxIH0sIGxlbmd0aCwgJnNhd0hv bGVzKTsKKyAgICAgICAgYm9vbCBnZW5lcmljQ2FzZSA9IGZhbHNlOworICAgICAgICBKU1ZhbHVl IHJlc3VsdCA9IGZhc3RKb2luKGdsb2JhbE9iamVjdCwgdGhpc0FycmF5LCB7ICZjb21tYSwgMSB9 LCBsZW5ndGgsIHNhd0hvbGVzLCBnZW5lcmljQ2FzZSk7CiAgICAgICAgIFJFVFVSTl9JRl9FWENF UFRJT04oc2NvcGUsIHsgfSk7CiAKLSAgICAgICAgaWYgKCFzYXdIb2xlcyAmJiByZXN1bHQgJiYg aXNKU1N0cmluZyhyZXN1bHQpICYmIGlzQ29XKSB7CisgICAgICAgIGlmICghc2F3SG9sZXMgJiYg IWdlbmVyaWNDYXNlICYmIHJlc3VsdCAmJiBpc0pTU3RyaW5nKHJlc3VsdCkgJiYgaXNDb1cpIHsK ICAgICAgICAgICAgIEFTU0VSVChKU0ltbXV0YWJsZUJ1dHRlcmZseTo6ZnJvbUJ1dHRlcmZseSh0 aGlzQXJyYXktPmJ1dHRlcmZseSgpKSA9PSBpbW11dGFibGVCdXR0ZXJmbHkpOwogICAgICAgICAg ICAgdm0uaGVhcC5pbW11dGFibGVCdXR0ZXJmbHlUb1N0cmluZ0NhY2hlLmFkZChpbW11dGFibGVC dXR0ZXJmbHksIGpzQ2FzdDxKU1N0cmluZyo+KHJlc3VsdCkpOwogICAgICAgICB9CmRpZmYgLS1n aXQgYS9KU1Rlc3RzL0NoYW5nZUxvZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGRiZTNlOTYy OWE1NWFiMTA2MzdlOWUzYjAzZDA2OGYyNDI3OTVmZmEuLjk3N2I0MWY0ZGFmYjQ4OTg4MWU2NTRi OTBmNGI3M2NjOTUwYTkxMmEgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pT VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEtMDItMDQgIFl1c3VrZSBTdXp1 a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KKworICAgICAgICBbSlNDXSBKU0ltbXV0YWJsZUJ1dHRl cmZseSdzIHRvU3RyaW5nIGNhY2hlIHNob3VsZCBub3QgaGFwcGVuIGZvciBnZW5lcmljIGpvaW4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTQ0NAor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzM5NzI4NjI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvaW1tdXRhYmxlLWJ1dHRlcmZseS10 by1zdHJpbmctY2FjaGUtc2hvdWxkLW5vdC1oYXBwZW4tZm9yLWdlbmVyaWMtam9pbi5qczogQWRk ZWQuCisgICAgICAgIChmb28pOgorCiAyMDIxLTAyLTAzICBZdXN1a2UgU3V6dWtpICA8eXN1enVr aUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gVXBkYXRlIHRlc3QyNjIKZGlmZiAtLWdpdCBh L0pTVGVzdHMvc3RyZXNzL2ltbXV0YWJsZS1idXR0ZXJmbHktdG8tc3RyaW5nLWNhY2hlLXNob3Vs ZC1ub3QtaGFwcGVuLWZvci1nZW5lcmljLWpvaW4uanMgYi9KU1Rlc3RzL3N0cmVzcy9pbW11dGFi bGUtYnV0dGVyZmx5LXRvLXN0cmluZy1jYWNoZS1zaG91bGQtbm90LWhhcHBlbi1mb3ItZ2VuZXJp Yy1qb2luLmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAuLjkzMjIzNTZkZmNjYThiM2YxOTE1ZWM2ZGQzMzQ4YTQzY2Uw NTIwZjEKLS0tIC9kZXYvbnVsbAorKysgYi9KU1Rlc3RzL3N0cmVzcy9pbW11dGFibGUtYnV0dGVy Zmx5LXRvLXN0cmluZy1jYWNoZS1zaG91bGQtbm90LWhhcHBlbi1mb3ItZ2VuZXJpYy1qb2luLmpz CkBAIC0wLDAgKzEsMTAgQEAKK2xldCB4ID0geworICBfX3Byb3RvX186IE9iamVjdCwKK307Citm dW5jdGlvbiBmb28oKSB7CisgIE9iamVjdC5kZWZpbmVQcm9wZXJ0eShPYmplY3QsIDAsIHt9KTsK K30KK2xldCBvID0geworICB0b1N0cmluZzogZm9vCit9OworZGVsZXRlIHt9W1suLi5bb11dXTsK