22144 2008-11-08 20:15:41 -0800 REGRESSION: JS error drilling down childless node 2009-09-21 14:50:18 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED http://webkit.org/ Regression P1 Normal --- 1 dev+webkit pfeldman pfeldman timothy zwarich oldest_to_newest 98053 0 dev+webkit 2008-11-08 20:15:41 -0800 Go to <http://webkit.org/> and open the inspector and double click the <body> node then double click the <div id="icon"> node. The body will successfully become the root object of the tree, but when you do the same for the #icon div, the following JS error is thrown in the console: .../WebCore.framework/Resources/inspector/ElementsTreeOutline.js:491: JS ERROR: TypeError: Result of expression 'this.treeOutline' [null] is not an object. 148631 1 pfeldman 2009-09-21 05:32:27 -0700 The original problem is no longer repeatable. However, following is also a bug: 1) Open inspector using Inspect Element on the "Welcome" topic (important) 2) Double click on body 3) Double click on #icon div Expected: Contents of body to be displayed Actual: Contents of the welcome topic is displayed The problem is that dblclick is being dispatched twice - via explicit listener and via tree element callback. Will issue a patch shortly. 148632 2 39846 pfeldman 2009-09-21 05:41:21 -0700 Created attachment 39846 patch 148847 3 pfeldman 2009-09-21 14:50:18 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ElementsTreeOutline.js Committed r48605 39846 2009-09-21 05:41:21 -0700 2009-09-21 14:41:09 -0700 patch dblclick text/plain 1821 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTIxMzVlMS4uNDE1ZDNhZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wOS0yMSAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5 IEhhdGNoZXIuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogSlMgZXJyb3IgZHJpbGxpbmcgZG93 biBjaGlsZGxlc3Mgbm9kZS4KKyAgICAgICAgTm8gbmVlZCB0byBkaXNwYXRjaCBkb3VibGUgY2xp Y2sgdHdpY2UgLSBpdCBpcyBhbHJlYWR5IGhhbmRsZWQKKyAgICAgICAgaW4gVHJlZUVsZW1lbnQu dHJlZUVsZW1lbnREb3VibGVDbGlja2VkLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMjE0NAorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVu ZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkVsZW1lbnRz VHJlZU91dGxpbmUpOgorCiAyMDA5LTA5LTIwICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFjaWVqIFN0YWNob3dpYWsuCmRpZmYgLS1naXQg YS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcyBiL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVPdXRsaW5lLmpzCmluZGV4IDA4 YmExYzIuLmQ4YzRkODkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9F bGVtZW50c1RyZWVPdXRsaW5lLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9F bGVtZW50c1RyZWVPdXRsaW5lLmpzCkBAIC0zMSw3ICszMSw2IEBACiBXZWJJbnNwZWN0b3IuRWxl bWVudHNUcmVlT3V0bGluZSA9IGZ1bmN0aW9uKCkgewogICAgIHRoaXMuZWxlbWVudCA9IGRvY3Vt ZW50LmNyZWF0ZUVsZW1lbnQoIm9sIik7CiAgICAgdGhpcy5lbGVtZW50LmFkZEV2ZW50TGlzdGVu ZXIoIm1vdXNlZG93biIsIHRoaXMuX29ubW91c2Vkb3duLmJpbmQodGhpcyksIGZhbHNlKTsKLSAg ICB0aGlzLmVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigiZGJsY2xpY2siLCB0aGlzLl9vbmRibGNs aWNrLmJpbmQodGhpcyksIGZhbHNlKTsKICAgICB0aGlzLmVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5l cigibW91c2Vtb3ZlIiwgdGhpcy5fb25tb3VzZW1vdmUuYmluZCh0aGlzKSwgZmFsc2UpOwogICAg IHRoaXMuZWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJtb3VzZW91dCIsIHRoaXMuX29ubW91c2Vv dXQuYmluZCh0aGlzKSwgZmFsc2UpOwogCkBAIC0xODYsMTYgKzE4NSw2IEBAIFdlYkluc3BlY3Rv ci5FbGVtZW50c1RyZWVPdXRsaW5lLnByb3RvdHlwZSA9IHsKICAgICAgICAgcmV0dXJuIGVsZW1l bnQ7CiAgICAgfSwKIAotICAgIF9vbmRibGNsaWNrOiBmdW5jdGlvbihldmVudCkKLSAgICB7Ci0g ICAgICAgIHZhciBlbGVtZW50ID0gdGhpcy5fdHJlZUVsZW1lbnRGcm9tRXZlbnQoZXZlbnQpOwot Ci0gICAgICAgIGlmICghZWxlbWVudCB8fCAhZWxlbWVudC5vbmRibGNsaWNrKQotICAgICAgICAg ICAgcmV0dXJuOwotCi0gICAgICAgIGVsZW1lbnQub25kYmxjbGljayhlbGVtZW50LCBldmVudCk7 Ci0gICAgfSwKLQogICAgIF9vbm1vdXNlZG93bjogZnVuY3Rpb24oZXZlbnQpCiAgICAgewogICAg ICAgICB2YXIgZWxlbWVudCA9IHRoaXMuX3RyZWVFbGVtZW50RnJvbUV2ZW50KGV2ZW50KTsK