221433 2021-02-04 15:53:35 -0800 REGRESSION (r272382): 2 webkit.messages_unittest.GeneratedFileContentsTest tests failing after Semaphore.h rename 2021-02-04 17:12:14 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=221418 InRadar P2 Normal --- 1 ryanhaddad ross.kirsling don.olmstead ross.kirsling webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1725843 0 ryanhaddad 2021-02-04 15:53:35 -0800 [5/1961] webkit.messages_unittest.GeneratedFileContentsTest.test_message_argument_description failed: Traceback (most recent call last): File "/Volumes/Data/slave/catalina-release-tests-wk2/build/Source/WebKit/Scripts/webkit/messages_unittest.py", line 100, in test_message_argument_description self.assertGeneratedFileContentsEqual(implementation_contents, os.path.join(tests_directory, 'MessageArgumentDescriptions.cpp')) File "/Volumes/Data/slave/catalina-release-tests-wk2/build/Source/WebKit/Scripts/webkit/messages_unittest.py", line 77, in assertGeneratedFileContentsEqual self.assertEquals(actual_line, expected_line_list[index]) AssertionError: '#include "IPCSemaphore.h"' != '#include "JSIPCBinding.h"' [12/1961] webkit.messages_unittest.GeneratedFileContentsTest.test_receiver failed: Traceback (most recent call last): File "/Volumes/Data/slave/catalina-release-tests-wk2/build/Source/WebKit/Scripts/webkit/messages_unittest.py", line 89, in test_receiver self.assertGeneratedFileContentsEqual(implementation_contents, os.path.join(tests_directory, '{}MessageReceiver.cpp'.format(receiver_name))) File "/Volumes/Data/slave/catalina-release-tests-wk2/build/Source/WebKit/Scripts/webkit/messages_unittest.py", line 77, in assertGeneratedFileContentsEqual self.assertEquals(actual_line, expected_line_list[index]) AssertionError: '#include "IPCSemaphore.h"' != '#include "Semaphore.h"' 1725852 1 ross.kirsling 2021-02-04 16:05:54 -0800 Great, it's not just arcane but also fragile... 🙄 1725863 2 ross.kirsling 2021-02-04 16:17:25 -0800 Er wait, no, it looks like the changes to those two files just got dropped from the patch in the process of trying to figure out how the generator script works. 1725865 3 419335 ross.kirsling 2021-02-04 16:20:16 -0800 Created attachment 419335 Patch 1725885 4 ews-feeder 2021-02-04 17:11:31 -0800 Committed r272400: <https://trac.webkit.org/changeset/272400> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419335. 1725887 5 webkit-bug-importer 2021-02-04 17:12:14 -0800 <rdar://problem/74004365> 419335 2021-02-04 16:20:16 -0800 2021-02-04 17:11:32 -0800 Patch bug-221433-20210204162016.patch text/plain 2155 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyMzk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI4NGU2Y2UyZDNkY2FiZmVm MTA1NDk4YTRhNGVkNWQwZDFjZWM1OWIuLjVmMWQ4NDI5MjQxMjY1YmIyM2JlNTJmYzUxNGNiNzky NWZiYmRmOTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMDItMDQgIFJvc3MgS2ly c2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNvbnkuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIy NzIzODIpOiAyIHdlYmtpdC5tZXNzYWdlc191bml0dGVzdC5HZW5lcmF0ZWRGaWxlQ29udGVudHNU ZXN0IHRlc3RzIGZhaWxpbmcgYWZ0ZXIgU2VtYXBob3JlLmggcmVuYW1lCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjE0MzMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBMb29rcyBsaWtlIHNvbWUgY2hhbmdl cyB3ZXJlIGFjY2lkZW50YWxseSBkcm9wcGVkIHByaW9yIHRvIGxhbmRpbmcuCisKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdC90ZXN0cy9NZXNzYWdlQXJndW1lbnREZXNjcmlwdGlvbnMuY3BwOgor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0L3Rlc3RzL1Rlc3RXaXRoU2VtYXBob3JlTWVzc2FnZVJl Y2VpdmVyLmNwcDoKKwogMjAyMS0wMi0wNCAgS2F0ZSBDaGVuZXkgIDxrYXRoZXJpbmVfY2hlbmV5 QGFwcGxlLmNvbT4KIAogICAgICAgICBMaW5rIGxpYm5ldHdvcmtleHRlbnNpb24gYXQgY29tcGls ZSB0aW1lCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NjcmlwdHMvd2Via2l0L3Rlc3RzL01l c3NhZ2VBcmd1bWVudERlc2NyaXB0aW9ucy5jcHAgYi9Tb3VyY2UvV2ViS2l0L1NjcmlwdHMvd2Vi a2l0L3Rlc3RzL01lc3NhZ2VBcmd1bWVudERlc2NyaXB0aW9ucy5jcHAKaW5kZXggY2M2ODM2ODI4 MWNkNTkzZDQ2Y2YwYTc1ZTFhNjRkMGI3ZWYzOGM1OS4uZWQ5MzA4NTJiM2UzZGE4Yzk0NzQzMzI0 ZTQ1NDBjMjM0YTE4Y2ExOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TY3JpcHRzL3dlYmtp dC90ZXN0cy9NZXNzYWdlQXJndW1lbnREZXNjcmlwdGlvbnMuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvU2NyaXB0cy93ZWJraXQvdGVzdHMvTWVzc2FnZUFyZ3VtZW50RGVzY3JpcHRpb25zLmNwcApA QCAtMzUsMTIgKzM1LDEyIEBACiAjaWYgUExBVEZPUk0oTUFDKQogI2luY2x1ZGUgIkdlc3R1cmVU eXBlcy5oIgogI2VuZGlmCisjaW5jbHVkZSAiSVBDU2VtYXBob3JlLmgiCiAjaW5jbHVkZSAiSlNJ UENCaW5kaW5nLmgiCiAjaWYgUExBVEZPUk0oTUFDKQogI2luY2x1ZGUgIk1hY2hQb3J0LmgiCiAj ZW5kaWYKICNpbmNsdWRlICJQbHVnaW4uaCIKLSNpbmNsdWRlICJTZW1hcGhvcmUuaCIKICNpbmNs dWRlICJUZXN0Q2xhc3NOYW1lLmgiCiAjaWYgRU5BQkxFKFRFU1RfRkVBVFVSRSkKICNpbmNsdWRl ICJUZXN0VHdvU3RhdGVFbnVtLmgiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NjcmlwdHMv d2Via2l0L3Rlc3RzL1Rlc3RXaXRoU2VtYXBob3JlTWVzc2FnZVJlY2VpdmVyLmNwcCBiL1NvdXJj ZS9XZWJLaXQvU2NyaXB0cy93ZWJraXQvdGVzdHMvVGVzdFdpdGhTZW1hcGhvcmVNZXNzYWdlUmVj ZWl2ZXIuY3BwCmluZGV4IDZmNjg2OTk1MzI3ZmMyZjI0YmVhZDk1YzAzN2VlYzhkYzFkNzgwZWUu LjcyMTAzYzQ3NDQ5ZDZjYzUwNzFlMDFiMDI0YWRkNTFkZDJiNDk1NTggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvU2NyaXB0cy93ZWJraXQvdGVzdHMvVGVzdFdpdGhTZW1hcGhvcmVNZXNzYWdl UmVjZWl2ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvU2NyaXB0cy93ZWJraXQvdGVzdHMvVGVz dFdpdGhTZW1hcGhvcmVNZXNzYWdlUmVjZWl2ZXIuY3BwCkBAIC0yNyw3ICsyNyw3IEBACiAKICNp bmNsdWRlICJEZWNvZGVyLmgiCiAjaW5jbHVkZSAiSGFuZGxlTWVzc2FnZS5oIgotI2luY2x1ZGUg IlNlbWFwaG9yZS5oIgorI2luY2x1ZGUgIklQQ1NlbWFwaG9yZS5oIgogI2luY2x1ZGUgIlRlc3RX aXRoU2VtYXBob3JlTWVzc2FnZXMuaCIKIAogbmFtZXNwYWNlIFdlYktpdCB7Cg==