22141 2008-11-08 12:06:49 -0800 REGRESSION: Safari error page is not fully styled when loaded from cache 2008-11-08 21:02:08 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar, Regression P1 Major --- 1 mitz webkit-unassigned ap koivisto oldest_to_newest 98028 0 mitz 2008-11-08 12:06:49 -0800 Steps to reproduce: 1) Go to http://no-such.topleveldomain/ 2) Reload the error page 3) Close the window (and any other open error pages), open the Caches window and empty the WebCore cache 4) Go to the URL again Results: When loaded from the cache, the page is not style correctly: the error message at the top is not centered and is missing the rounded rect border. 98029 1 mitz 2008-11-08 12:07:37 -0800 <rdar://problem/6355543> 98040 2 koivisto 2008-11-08 15:22:20 -0800 TextResourceDecoder fails to skip the BOM when it is reused. 98048 3 24998 koivisto 2008-11-08 17:21:32 -0800 Created attachment 24998 patch 98050 4 24998 sam 2008-11-08 19:07:52 -0800 Comment on attachment 24998 patch r=me 98054 5 koivisto 2008-11-08 21:02:08 -0800 Sending LayoutTests/ChangeLog Adding LayoutTests/fast/encoding/css-cached-bom-expected.txt Adding LayoutTests/fast/encoding/css-cached-bom.html Adding LayoutTests/fast/encoding/resources/css-cached-bom-frame.html Adding (bin) LayoutTests/fast/encoding/resources/utf-16-little-endian.css Sending WebCore/ChangeLog Sending WebCore/loader/TextResourceDecoder.cpp Transmitting file data ....... Committed revision 38240. 24998 2008-11-08 17:21:32 -0800 2008-11-08 19:07:52 -0800 patch css-cache-bom.patch text/plain 4144 koivisto SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzODIzNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDgtMTEtMDggIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAg ICAgICAgRml4IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjE0MQor ICAgICAgICBCdWcgMjIxNDE6IFJFR1JFU1NJT046IFNhZmFyaSBlcnJvciBwYWdlIGlzIG5vdCBm dWxseSBzdHlsZWQgd2hlbiBsb2FkZWQgZnJvbSBjYWNoZQorICAgICAgICAKKyAgICAgICAgUmVz ZXQgdGV4dCBkZWNvZGVyIG9uIGZsdXNoIHNvIGl0IGRvZXMgbm90IHBhc3MgdGhyb3VnaCB0aGUg Qk9NIHdoZW4gaXQgaXMgcmV1c2VkLgorCisgICAgICAgIFRlc3Q6IGZhc3QvZW5jb2RpbmcvY3Nz LWNhY2hlZC1ib20uaHRtbAorCisgICAgICAgICogbG9hZGVyL1RleHRSZXNvdXJjZURlY29kZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6VGV4dFJlc291cmNlRGVjb2Rlcjo6Zmx1c2gpOgorCiAy MDA4LTExLTA4ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4KSW5kZXg6IFdlYkNvcmUvbG9hZGVyL1RleHRS ZXNvdXJjZURlY29kZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvbG9hZGVyL1RleHRSZXNv dXJjZURlY29kZXIuY3BwCShyZXZpc2lvbiAzODIwOSkKKysrIFdlYkNvcmUvbG9hZGVyL1RleHRS ZXNvdXJjZURlY29kZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03OTMsNiArNzkzLDcgQEAgU3Ry aW5nIFRleHRSZXNvdXJjZURlY29kZXI6OmZsdXNoKCkKIHsKICAgICBTdHJpbmcgcmVzdWx0ID0g bV9kZWNvZGVyLmRlY29kZShtX2J1ZmZlci5kYXRhKCksIG1fYnVmZmVyLnNpemUoKSwgdHJ1ZSwg bV9jb250ZW50VHlwZSA9PSBYTUwsIG1fc2F3RXJyb3IpOwogICAgIG1fYnVmZmVyLmNsZWFyKCk7 CisgICAgbV9kZWNvZGVyLnJlc2V0KG1fZGVjb2Rlci5lbmNvZGluZygpKTsKICAgICByZXR1cm4g cmVzdWx0OwogfQogCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAzODIzNykKKysrIExheW91dFRlc3RzL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDA4LTExLTA4ICBBbnR0 aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFRlc3QgZm9yIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjE0MQorICAgICAgICBCdWcgMjIxNDE6IFJFR1JFU1NJ T046IFNhZmFyaSBlcnJvciBwYWdlIGlzIG5vdCBmdWxseSBzdHlsZWQgd2hlbiBsb2FkZWQgZnJv bSBjYWNoZQorCisgICAgICAgICogZmFzdC9lbmNvZGluZy9jc3MtY2FjaGVkLWJvbS5odG1sOiBB ZGRlZC4KKyAgICAgICAgKiBmYXN0L2VuY29kaW5nL3Jlc291cmNlcy9jc3MtY2FjaGVkLWJvbS1m cmFtZS5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2VuY29kaW5nL3Jlc291cmNlcy91dGYt MTYtbGl0dGxlLWVuZGlhbi5jc3M6IEFkZGVkLgorCiAyMDA4LTExLTA4ICBTaW1vbiBGcmFzZXIg IDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJu c3RlaW4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZW5jb2RpbmcvY3NzLWNhY2hlZC1ib20uaHRt bAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2VuY29kaW5nL2Nzcy1jYWNoZWQtYm9t Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2VuY29kaW5nL2Nzcy1jYWNo ZWQtYm9tLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjAgQEAKKzxzY3JpcHQ+CitpZiAo d2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIu ZHVtcEFzVGV4dCgpOworICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsK K30KK2Z1bmN0aW9uIGZyYW1lTG9hZGVkKCkgeworICAgIGlmIChkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgnZicpLmNvbnRlbnREb2N1bWVudC5zdHlsZVNoZWV0c1swXS5jc3NSdWxlc1swXS5zZWxl Y3RvclRleHQgPT0gIiNzdWNjZXNzOjpiZWZvcmUiKQorICAgICAgICBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgncmVzdWx0JykuaW5uZXJIVE1MID0gIlNVQ0NFU1MiOworICAgIGlmICh3aW5kb3cu bGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlm eURvbmUoKTsKK30KKzwvc2NyaXB0PgorPGxpbmsgcmVsPXN0eWxlc2hlZXQgaHJlZj1yZXNvdXJj ZXMvdXRmLTE2LWxpdHRsZS1lbmRpYW4uY3NzPgorPCEtLSBUaGlzIGhhbHRzIHRoZSBwYXJzaW5n IHVudGlsIHN0eWxlc2hlZXQgaGFzIGJlZW4gbG9hZGVkIC0tPgorPHNjcmlwdCBzcmM9ZG9lc19u b3RfZXhpc3RzLmpzPjwvc2NyaXB0PgorPGRpdj5UZXN0IHRoYXQgc3R5bGVzaGVldCB3aXRoIEJP TSBpcyBjb3JyZWN0bHkgcGFyc2VkIHdoZW4gbG9hZGVkIGZyb20gY2FjaGUuIFlvdSBzaG91bGQg c2VlIHdvcmQgU1VDQ0VTUyBiZWxvdy48L2Rpdj4KKzwhLS0gTG9hZCB0aGUgc3R5bGVzaGVldCB0 byBhIGRpZmZlcmVudCBmcmFtZS4gVGhpcyB3aWxsIHVzZSBhIGNhY2hlZCBjb3B5IG9mIHRoZSBz dHlsZXNoZWV0LiAtLT4KKzxpZnJhbWUgaWQ9ZiBzcmM9cmVzb3VyY2VzL2Nzcy1jYWNoZWQtYm9t LWZyYW1lLmh0bWw+PC9pZnJhbWU+Cis8ZGl2IGlkPXJlc3VsdD5GQUlMPC9kaXY+CisKSW5kZXg6 IExheW91dFRlc3RzL2Zhc3QvZW5jb2RpbmcvcmVzb3VyY2VzL2Nzcy1jYWNoZWQtYm9tLWZyYW1l Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9lbmNvZGluZy9yZXNvdXJjZXMv Y3NzLWNhY2hlZC1ib20tZnJhbWUuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zh c3QvZW5jb2RpbmcvcmVzb3VyY2VzL2Nzcy1jYWNoZWQtYm9tLWZyYW1lLmh0bWwJKHJldmlzaW9u IDApCkBAIC0wLDAgKzEsNSBAQAorPGxpbmsgcmVsPXN0eWxlc2hlZXQgaHJlZj11dGYtMTYtbGl0 dGxlLWVuZGlhbi5jc3M+Cis8c2NyaXB0Pgord2luZG93LnBhcmVudC5mcmFtZUxvYWRlZCgpOwor PC9zY3JpcHQ+CisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZW5jb2RpbmcvcmVzb3VyY2VzL3V0 Zi0xNi1saXR0bGUtZW5kaWFuLmNzcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09CkNhbm5vdCBkaXNwbGF5OiBmaWxlIG1h cmtlZCBhcyBhIGJpbmFyeSB0eXBlLgpzdm46bWltZS10eXBlID0gYXBwbGljYXRpb24vb2N0ZXQt c3RyZWFtCgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0cy9mYXN0L2VuY29kaW5nL3Jl c291cmNlcy91dGYtMTYtbGl0dGxlLWVuZGlhbi5jc3MKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpOYW1lOiBzdm46bWlt ZS10eXBlCiAgICsgYXBwbGljYXRpb24vb2N0ZXQtc3RyZWFtCgoKLy80akFITUFkUUJqQUdNQVpR QnpBSE1BT2dCaUFHVUFaZ0J2QUhJQVpRQWdBSHNBSUFCakFHOEFiZ0IwQUdVQWJnQjBBRG9BSndC VApBRlVBUXdCREFFVUFVd0JUQUNjQUlBQjlBQTBBQ2dBTkFBb0EKCg==