221409 2021-02-04 08:40:11 -0800 REGRESSION(r272217): clang warnings in ExtensionsGLOpenGLCommon.h 2021-02-04 23:43:45 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand pnormand bugs-noreply darin dino ews-watchlist graouts kkinnunen kondapallykalyan oldest_to_newest 1725632 0 pnormand 2021-02-04 08:40:11 -0800 In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-29.cpp:3: In file included from ../../Source/WebCore/platform/graphics/cairo/GraphicsContextGLCairo.cpp:29: In file included from ../../Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h:48: ../../Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLCommon.h:59:10: warning: 'readnPixelsEXT' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] void readnPixelsEXT(int x, int y, GCGLsizei width, GCGLsizei height, GCGLenum format, GCGLenum type, GCGLsizei bufSize, void *data); ^ ../../Source/WebCore/platform/graphics/ExtensionsGL.h:304:18: note: overridden virtual function is here virtual void readnPixelsEXT(GCGLint x, GCGLint y, GCGLsizei width, GCGLsizei height, GCGLenum format, GCGLenum type, GCGLsizei bufSize, GCGLvoid* data) = 0; ^ In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-29.cpp:3: In file included from ../../Source/WebCore/platform/graphics/cairo/GraphicsContextGLCairo.cpp:29: In file included from ../../Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h:48: ../../Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLCommon.h:60:10: warning: 'getnUniformfvEXT' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] void getnUniformfvEXT(GCGLuint program, int location, GCGLsizei bufSize, float *params); ^ ../../Source/WebCore/platform/graphics/ExtensionsGL.h:305:18: note: overridden virtual function is here virtual void getnUniformfvEXT(GCGLuint program, GCGLint location, GCGLsizei bufSize, GCGLfloat* params) = 0; ^ In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-3c72abbe-29.cpp:3: In file included from ../../Source/WebCore/platform/graphics/cairo/GraphicsContextGLCairo.cpp:29: In file included from ../../Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.h:48: ../../Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLCommon.h:61:10: warning: 'getnUniformivEXT' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] void getnUniformivEXT(GCGLuint program, int location, GCGLsizei bufSize, int *params); ^ ../../Source/WebCore/platform/graphics/ExtensionsGL.h:306:18: note: overridden virtual function is here virtual void getnUniformivEXT(GCGLuint program, GCGLint location, GCGLsizei bufSize, GCGLint* params) = 0; ^ 3 warnings generated. 1725640 1 419285 pnormand 2021-02-04 09:00:40 -0800 Created attachment 419285 Patch 1725664 2 419285 darin 2021-02-04 09:37:15 -0800 Comment on attachment 419285 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419285&action=review > Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLCommon.h:61 > + void readnPixelsEXT(int x, int y, GCGLsizei width, GCGLsizei height, GCGLenum format, GCGLenum type, GCGLsizei bufSize, void *data) override; > + void getnUniformfvEXT(GCGLuint program, int location, GCGLsizei bufSize, float *params) override; > + void getnUniformivEXT(GCGLuint program, int location, GCGLsizei bufSize, int *params) override; If any of these can be final instead, that would be even better. 1725666 3 ews-feeder 2021-02-04 09:39:54 -0800 Committed r272374: <https://trac.webkit.org/changeset/272374> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419285. 1725954 4 kkinnunen 2021-02-04 23:43:45 -0800 Thanks for fixing! 419285 2021-02-04 09:00:40 -0800 2021-02-04 09:39:56 -0800 Patch bug-221409-20210204090038.patch text/plain 2066 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyMzY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDYxOThiMDIyODA1NzU5 ZGQzZTdlMGY3OGJiZGIyNmU5NTIzMGJjZS4uM2M3MGU0M2Q3OGI4ZjY4MjYzYTgxNzU3ZDhhYWNi NGUxMGZiMmM0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIxLTAyLTA0ICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9O KHIyNzIyMTcpOiBjbGFuZyB3YXJuaW5ncyBpbiBFeHRlbnNpb25zR0xPcGVuR0xDb21tb24uaAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIxNDA5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9vcGVuZ2wvRXh0ZW5zaW9uc0dMT3BlbkdMQ29tbW9uLmg6IFJlLWFkZCB0aGUg b3ZlcnJpZGUgcXVhbGlmaWVyIGZvciBhCisgICAgICAgIGZldyBtZXRob2RzLCB3aGljaCB3YXMg cmVtb3ZlZCBpbiByMjcyMjE3LgorCiAyMDIxLTAyLTA0ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5v cm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVyXSBNaXNjIFRodW5kZXIgbml0 cGlja3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5n bC9FeHRlbnNpb25zR0xPcGVuR0xDb21tb24uaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL29wZW5nbC9FeHRlbnNpb25zR0xPcGVuR0xDb21tb24uaAppbmRleCAzZWRjYWE1M2Q2 NzA4YTFjMjJmM2NlMzczZTcwZTEwY2FmOTUwNjY1Li5hZDg0MzU5ZDgzYmRhY2ZmMjNiNzNhNjU3 NDM0NjcwYzU3ZjYzNGNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9vcGVuZ2wvRXh0ZW5zaW9uc0dMT3BlbkdMQ29tbW9uLmgKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4dGVuc2lvbnNHTE9wZW5HTENvbW1vbi5oCkBA IC01Niw5ICs1Niw5IEBAIHB1YmxpYzoKICAgICBTdHJpbmcgZ2V0VHJhbnNsYXRlZFNoYWRlclNv dXJjZUFOR0xFKFBsYXRmb3JtR0xPYmplY3QpIG92ZXJyaWRlOwogCiAgICAgLy8gRVhUIFJvYnVz dG5lc3MgLSB1c2VzIGdldEdyYXBoaWNzUmVzZXRTdGF0dXNBUkIoKQotICAgIHZvaWQgcmVhZG5Q aXhlbHNFWFQoaW50IHgsIGludCB5LCBHQ0dMc2l6ZWkgd2lkdGgsIEdDR0xzaXplaSBoZWlnaHQs IEdDR0xlbnVtIGZvcm1hdCwgR0NHTGVudW0gdHlwZSwgR0NHTHNpemVpIGJ1ZlNpemUsIHZvaWQg KmRhdGEpOwotICAgIHZvaWQgZ2V0blVuaWZvcm1mdkVYVChHQ0dMdWludCBwcm9ncmFtLCBpbnQg bG9jYXRpb24sIEdDR0xzaXplaSBidWZTaXplLCBmbG9hdCAqcGFyYW1zKTsKLSAgICB2b2lkIGdl dG5Vbmlmb3JtaXZFWFQoR0NHTHVpbnQgcHJvZ3JhbSwgaW50IGxvY2F0aW9uLCBHQ0dMc2l6ZWkg YnVmU2l6ZSwgaW50ICpwYXJhbXMpOworICAgIHZvaWQgcmVhZG5QaXhlbHNFWFQoaW50IHgsIGlu dCB5LCBHQ0dMc2l6ZWkgd2lkdGgsIEdDR0xzaXplaSBoZWlnaHQsIEdDR0xlbnVtIGZvcm1hdCwg R0NHTGVudW0gdHlwZSwgR0NHTHNpemVpIGJ1ZlNpemUsIHZvaWQgKmRhdGEpIG92ZXJyaWRlOwor ICAgIHZvaWQgZ2V0blVuaWZvcm1mdkVYVChHQ0dMdWludCBwcm9ncmFtLCBpbnQgbG9jYXRpb24s IEdDR0xzaXplaSBidWZTaXplLCBmbG9hdCAqcGFyYW1zKSBvdmVycmlkZTsKKyAgICB2b2lkIGdl dG5Vbmlmb3JtaXZFWFQoR0NHTHVpbnQgcHJvZ3JhbSwgaW50IGxvY2F0aW9uLCBHQ0dMc2l6ZWkg YnVmU2l6ZSwgaW50ICpwYXJhbXMpIG92ZXJyaWRlOwogCiAgICAgYm9vbCBpc05WSURJQSgpIGNv bnN0IHsgcmV0dXJuIG1faXNOVklESUE7IH0KICAgICBib29sIGlzQU1EKCkgY29uc3QgeyByZXR1 cm4gbV9pc0FNRDsgfQo=