22137 2008-11-08 04:49:23 -0800 PLATFORM(MAC) build broken with HAVE(ACCESSIBILITY) disabled 2008-11-09 11:51:42 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer darin oldest_to_newest 98002 0 ddkilzer 2008-11-08 04:49:23 -0800 If HAVE(ACCESSIBILITY) is set to zero in JavaScriptCore/wtf/Platform.h, the PLATFORM(MAC) build will fail. I have a patch to fix this. 98003 1 24985 ddkilzer 2008-11-08 04:54:59 -0800 Created attachment 24985 Patch v1 Proposed fix. 98015 2 24985 darin 2008-11-08 09:12:59 -0800 Comment on attachment 24985 Patch v1 > +#if HAVE(ACCESSIBILITY) > bool accessibilityIgnoreAttachment() const; > +#else > + bool accessibilityIgnoreAttachment() const { return true; } > +#endif In cases like this I prefer to leave the class definition cleaner by putting the inline function definition after it. Like this: #if !HAVE(ACCESSIBILITY) inline bool AccessibilityObject::accessibilityIgnoreAttachment() const { return true; } #endif This patch seems fine as-is. r=me 98020 3 ddkilzer 2008-11-08 11:15:07 -0800 (In reply to comment #2) > (From update of attachment 24985 [edit]) > > +#if HAVE(ACCESSIBILITY) > > bool accessibilityIgnoreAttachment() const; > > +#else > > + bool accessibilityIgnoreAttachment() const { return true; } > > +#endif > > In cases like this I prefer to leave the class definition cleaner by putting > the inline function definition after it. Like this: > > #if !HAVE(ACCESSIBILITY) > inline bool AccessibilityObject::accessibilityIgnoreAttachment() const > { > return true; > } > #endif That doesn't work: /Volumes/Data/WebKit.git/WebCore/page/AccessibilityObject.h:398: error: ‘bool WebCore::AccessibilityObject::accessibilityIgnoreAttachment() const’ and ‘bool WebCore::AccessibilityObject::accessibilityIgnoreAttachment() const’ cannot be overloaded 98025 4 ddkilzer 2008-11-08 11:55:28 -0800 $ git svn dcommit Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/page/AccessibilityObject.h M WebCore/page/mac/AXObjectCacheMac.mm M WebCore/page/mac/AccessibilityObjectMac.mm M WebCore/page/mac/AccessibilityObjectWrapper.mm M WebKit/mac/ChangeLog M WebKit/mac/WebView/WebFrame.mm Committed r38235 98038 5 darin 2008-11-08 13:59:35 -0800 (In reply to comment #3) > > In cases like this I prefer to leave the class definition cleaner by putting > > the inline function definition after it. Like this: > > > > #if !HAVE(ACCESSIBILITY) > > inline bool AccessibilityObject::accessibilityIgnoreAttachment() const > > { > > return true; > > } > > #endif > > That doesn't work: > > /Volumes/Data/WebKit.git/WebCore/page/AccessibilityObject.h:398: error: ‘bool > WebCore::AccessibilityObject::accessibilityIgnoreAttachment() const’ and ‘bool > WebCore::AccessibilityObject::accessibilityIgnoreAttachment() const’ cannot be > overloaded I've done it before, so I know it works. I think there was some other small mistake that caused this. I'll try it myself later. 98039 6 ddkilzer 2008-11-08 14:15:14 -0800 (In reply to comment #5) > > That doesn't work: > > > > /Volumes/Data/WebKit.git/WebCore/page/AccessibilityObject.h:398: error: ‘bool > > WebCore::AccessibilityObject::accessibilityIgnoreAttachment() const’ and ‘bool > > WebCore::AccessibilityObject::accessibilityIgnoreAttachment() const’ cannot be > > overloaded > > I've done it before, so I know it works. I think there was some other small > mistake that caused this. I'll try it myself later. I think it would work to add the function definition to WebCore/page/AccessibilityObject.cpp instead. Was that what you meant? 98049 7 darin 2008-11-08 19:04:34 -0800 (In reply to comment #6) > I think it would work to add the function definition to > WebCore/page/AccessibilityObject.cpp instead. Was that what you meant? I agree that would also work, but the function wouldn't be inline in that case. No, it was not what I meant. 98091 8 ddkilzer 2008-11-09 11:51:42 -0800 Follow-up fix for Qt build failure: $ git svn dcommit Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/page/gtk/AccessibilityObjectAtk.cpp M WebCore/page/gtk/AccessibilityObjectWrapperAtk.cpp M WebCore/page/qt/AccessibilityObjectQt.cpp M WebCore/page/win/AccessibilityObjectWin.cpp M WebCore/page/wx/AccessibilityObjectWx.cpp Committed r38244 24985 2008-11-08 04:54:59 -0800 2008-11-08 09:12:59 -0800 Patch v1 bug-22137-v1.diff text/plain 5446 ddkilzer Y29tbWl0IGM0MjBhMWQ5ZTM1N2I5ZjQ3ZTM4YzEwYzVhN2QyYTdiMWZjNjg3YTEKQXV0aG9yOiBE YXZpZCBLaWx6ZXIgPGRka2lsemVyQGFwcGxlLmNvbT4KRGF0ZTogICBTYXQgTm92IDggMDQ6NTM6 MTcgMjAwOCAtMDgwMAoKICAgICAgICAgICAgQnVnIDIyMTM3OiBQTEFURk9STShNQUMpIGJ1aWxk IGJyb2tlbiB3aXRoIEhBVkUoQUNDRVNTSUJJTElUWSkgZGlzYWJsZWQKICAgIAogICAgICAgICAg ICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTM3PgogICAgCiAg ICAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogICAgCiAgICBXZWJDb3JlOgog ICAgCiAgICAgICAgICAgICogcGFnZS9BY2Nlc3NpYmlsaXR5T2JqZWN0Lmg6CiAgICAgICAgICAg IChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5T2JqZWN0OjphY2Nlc3NpYmlsaXR5SWdub3JlQXR0YWNo bWVudCk6CiAgICAgICAgICAgIFByb3ZpZGUgYSBkZWZhdWx0IGltcGxlbWVudGF0aW9uIHdoZW4g SEFWRShBQ0NFU1NJQklMSVRZKSBpcyBmYWxzZS4KICAgICAgICAgICAgKiBwYWdlL21hYy9BWE9i amVjdENhY2hlTWFjLm1tOiBBZGRlZCBIQVZFKEFDQ0VTU0lCSUxJVFkpIGd1YXJkLgogICAgICAg ICAgICAqIHBhZ2UvbWFjL0FjY2Vzc2liaWxpdHlPYmplY3RNYWMubW06IERpdHRvLgogICAgICAg ICAgICAqIHBhZ2UvbWFjL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyLm1tOiBEaXR0by4KICAg IAogICAgV2ViS2l0L21hYzoKICAgIAogICAgICAgICAgICAqIFdlYlZpZXcvV2ViRnJhbWUubW06 CiAgICAgICAgICAgICgtW1dlYkZyYW1lIF9hY2Nlc3NpYmlsaXR5VHJlZV0pOiBSZXR1cm4gbmls IGlmIEhBVkUoQUNDRVNTSUJJTElUWSkKICAgICAgICAgICAgaXMgZmFsc2UuCgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhYWQ0OTg1Li4w NWRhMTkyIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDA4LTExLTA4ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHpl ckBhcHBsZS5jb20+CisKKyAgICAgICAgQnVnIDIyMTM3OiBQTEFURk9STShNQUMpIGJ1aWxkIGJy b2tlbiB3aXRoIEhBVkUoQUNDRVNTSUJJTElUWSkgZGlzYWJsZWQKKworICAgICAgICA8aHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTM3PgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFnZS9BY2Nlc3NpYmlsaXR5T2Jq ZWN0Lmg6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5T2JqZWN0OjphY2Nlc3NpYmls aXR5SWdub3JlQXR0YWNobWVudCk6CisgICAgICAgIFByb3ZpZGUgYSBkZWZhdWx0IGltcGxlbWVu dGF0aW9uIHdoZW4gSEFWRShBQ0NFU1NJQklMSVRZKSBpcyBmYWxzZS4KKyAgICAgICAgKiBwYWdl L21hYy9BWE9iamVjdENhY2hlTWFjLm1tOiBBZGRlZCBIQVZFKEFDQ0VTU0lCSUxJVFkpIGd1YXJk LgorICAgICAgICAqIHBhZ2UvbWFjL0FjY2Vzc2liaWxpdHlPYmplY3RNYWMubW06IERpdHRvLgor ICAgICAgICAqIHBhZ2UvbWFjL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyLm1tOiBEaXR0by4K KwogMjAwOC0xMS0wNyAgQWxwIFRva2VyICA8YWxwQG51YW50aS5jb20+CiAKICAgICAgICAgRml4 IGJ1aWxkIHdpdGggYmxlZWRpbmcgZWRnZSBHVEsrIHZlcnNpb25zLiBHVEsrIGFuZCBvdGhlciBs aWJyYXJpZXMKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9BY2Nlc3NpYmlsaXR5T2JqZWN0Lmgg Yi9XZWJDb3JlL3BhZ2UvQWNjZXNzaWJpbGl0eU9iamVjdC5oCmluZGV4IDk0Nzc1N2EuLjMxNDU4 MWEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmgKKysrIGIv V2ViQ29yZS9wYWdlL0FjY2Vzc2liaWxpdHlPYmplY3QuaApAQCAtMzkyLDcgKzM5MiwxMSBAQCBw dWJsaWM6CiAjZW5kaWYKIAogICAgIC8vIGEgcGxhdGZvcm0tc3BlY2lmaWMgbWV0aG9kIGZvciBk ZXRlcm1pbmluZyBpZiBhbiBhdHRhY2htZW50IGlzIGlnbm9yZWQKKyNpZiBIQVZFKEFDQ0VTU0lC SUxJVFkpCiAgICAgYm9vbCBhY2Nlc3NpYmlsaXR5SWdub3JlQXR0YWNobWVudCgpIGNvbnN0Owor I2Vsc2UKKyAgICBib29sIGFjY2Vzc2liaWxpdHlJZ25vcmVBdHRhY2htZW50KCkgY29uc3QgeyBy ZXR1cm4gdHJ1ZTsgfQorI2VuZGlmCiAgICAgCiBwcm90ZWN0ZWQ6CiAgICAgdW5zaWduZWQgbV9p ZDsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9tYWMvQVhPYmplY3RDYWNoZU1hYy5tbSBiL1dl YkNvcmUvcGFnZS9tYWMvQVhPYmplY3RDYWNoZU1hYy5tbQppbmRleCAxMGFlMWNjLi5kNWNlOGYz IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvbWFjL0FYT2JqZWN0Q2FjaGVNYWMubW0KKysrIGIv V2ViQ29yZS9wYWdlL21hYy9BWE9iamVjdENhY2hlTWFjLm1tCkBAIC0yNiw2ICsyNiw4IEBACiAj aW1wb3J0ICJjb25maWcuaCIKICNpbXBvcnQgIkFYT2JqZWN0Q2FjaGUuaCIKIAorI2lmIEhBVkUo QUNDRVNTSUJJTElUWSkKKwogI2ltcG9ydCAiQWNjZXNzaWJpbGl0eU9iamVjdC5oIgogI2ltcG9y dCAiQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIuaCIKICNpbXBvcnQgIlJlbmRlck9iamVjdC5o IgpAQCAtODUsMyArODcsNSBAQCB2b2lkIEFYT2JqZWN0Q2FjaGU6OmhhbmRsZUZvY3VzZWRVSUVs ZW1lbnRDaGFuZ2VkKCkKIH0KIAogfQorCisjZW5kaWYgLy8gSEFWRShBQ0NFU1NJQklMSVRZKQpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL21hYy9BY2Nlc3NpYmlsaXR5T2JqZWN0TWFjLm1tIGIv V2ViQ29yZS9wYWdlL21hYy9BY2Nlc3NpYmlsaXR5T2JqZWN0TWFjLm1tCmluZGV4IDg3MmUxMDgu LjhmNDdhZjAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9tYWMvQWNjZXNzaWJpbGl0eU9iamVj dE1hYy5tbQorKysgYi9XZWJDb3JlL3BhZ2UvbWFjL0FjY2Vzc2liaWxpdHlPYmplY3RNYWMubW0K QEAgLTI2LDYgKzI2LDggQEAKICNpbXBvcnQgImNvbmZpZy5oIgogI2ltcG9ydCAiQWNjZXNzaWJp bGl0eU9iamVjdC5oIgogCisjaWYgSEFWRShBQ0NFU1NJQklMSVRZKQorCiAjaW1wb3J0ICJBY2Nl c3NpYmlsaXR5T2JqZWN0V3JhcHBlci5oIgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC0zNiwz ICszOCw1IEBAIGJvb2wgQWNjZXNzaWJpbGl0eU9iamVjdDo6YWNjZXNzaWJpbGl0eUlnbm9yZUF0 dGFjaG1lbnQoKSBjb25zdAogfQogICAgIAogfSAvLyBXZWJDb3JlCisKKyNlbmRpZiAvLyBIQVZF KEFDQ0VTU0lCSUxJVFkpCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvbWFjL0FjY2Vzc2liaWxp dHlPYmplY3RXcmFwcGVyLm1tIGIvV2ViQ29yZS9wYWdlL21hYy9BY2Nlc3NpYmlsaXR5T2JqZWN0 V3JhcHBlci5tbQppbmRleCAyMTA0Y2E5Li43M2NhMTllIDEwMDY0NAotLS0gYS9XZWJDb3JlL3Bh Z2UvbWFjL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyLm1tCisrKyBiL1dlYkNvcmUvcGFnZS9t YWMvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIubW0KQEAgLTI5LDYgKzI5LDggQEAKICNpbXBv cnQgImNvbmZpZy5oIgogI2ltcG9ydCAiQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIuaCIKIAor I2lmIEhBVkUoQUNDRVNTSUJJTElUWSkKKwogI2ltcG9ydCAiQVhPYmplY3RDYWNoZS5oIgogI2lt cG9ydCAiQWNjZXNzaWJpbGl0eUxpc3RCb3guaCIKICNpbXBvcnQgIkFjY2Vzc2liaWxpdHlMaXN0 LmgiCkBAIC0xOTk0LDMgKzE5OTYsNSBAQCBzdGF0aWMgUmVuZGVyT2JqZWN0KiByZW5kZXJlckZv clZpZXcoTlNWaWV3KiB2aWV3KQogfQogCiBAZW5kCisKKyNlbmRpZiAvLyBIQVZFKEFDQ0VTU0lC SUxJVFkpCmRpZmYgLS1naXQgYS9XZWJLaXQvbWFjL0NoYW5nZUxvZyBiL1dlYktpdC9tYWMvQ2hh bmdlTG9nCmluZGV4IDcwYzNlMWUuLmNhMGY1NjcgMTAwNjQ0Ci0tLSBhL1dlYktpdC9tYWMvQ2hh bmdlTG9nCisrKyBiL1dlYktpdC9tYWMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgt MTEtMDggIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBCdWcg MjIxMzc6IFBMQVRGT1JNKE1BQykgYnVpbGQgYnJva2VuIHdpdGggSEFWRShBQ0NFU1NJQklMSVRZ KSBkaXNhYmxlZAorCisgICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjIxMzc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBXZWJWaWV3L1dlYkZyYW1lLm1tOgorICAgICAgICAoLVtXZWJGcmFtZSBfYWNjZXNz aWJpbGl0eVRyZWVdKTogUmV0dXJuIG5pbCBpZiBIQVZFKEFDQ0VTU0lCSUxJVFkpCisgICAgICAg IGlzIGZhbHNlLgorCiAyMDA4LTExLTA2ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2V2aW4gRGVja2VyLgpkaWZmIC0tZ2l0IGEv V2ViS2l0L21hYy9XZWJWaWV3L1dlYkZyYW1lLm1tIGIvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkZy YW1lLm1tCmluZGV4IDEzYTZhZDQuLjVhYWU1NmIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9tYWMvV2Vi Vmlldy9XZWJGcmFtZS5tbQorKysgYi9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViRnJhbWUubW0KQEAg LTY4NCw2ICs2ODQsNyBAQCBzdGF0aWMgaW5saW5lIFdlYkRhdGFTb3VyY2UgKmRhdGFTb3VyY2Uo RG9jdW1lbnRMb2FkZXIqIGxvYWRlcikKIAogLSAoaWQpX2FjY2Vzc2liaWxpdHlUcmVlCiB7Cisj aWYgSEFWRShBQ0NFU1NJQklMSVRZKQogICAgIGlmICghQVhPYmplY3RDYWNoZTo6YWNjZXNzaWJp bGl0eUVuYWJsZWQoKSkgewogICAgICAgICBBWE9iamVjdENhY2hlOjplbmFibGVBY2Nlc3NpYmls aXR5KCk7CiAgICAgICAgIGlmIChbW05TQXBwIGFjY2Vzc2liaWxpdHlBdHRyaWJ1dGVWYWx1ZTpO U0FjY2Vzc2liaWxpdHlFbmhhbmNlZFVzZXJJbnRlcmZhY2VBdHRyaWJ1dGVdIGJvb2xWYWx1ZV0p CkBAIC02OTYsNiArNjk3LDkgQEAgc3RhdGljIGlubGluZSBXZWJEYXRhU291cmNlICpkYXRhU291 cmNlKERvY3VtZW50TG9hZGVyKiBsb2FkZXIpCiAgICAgaWYgKCFyb290KQogICAgICAgICByZXR1 cm4gbmlsOwogICAgIHJldHVybiBfcHJpdmF0ZS0+Y29yZUZyYW1lLT5kb2N1bWVudCgpLT5heE9i amVjdENhY2hlKCktPmdldChyb290KS0+d3JhcHBlcigpOworI2Vsc2UKKyAgICByZXR1cm4gbmls OworI2VuZGlmCiB9CiAKIC0gKERPTVJhbmdlICopX3JhbmdlQnlBbHRlcmluZ0N1cnJlbnRTZWxl Y3Rpb246KFNlbGVjdGlvbkNvbnRyb2xsZXI6OkVBbHRlcmF0aW9uKWFsdGVyYXRpb24gZGlyZWN0 aW9uOihTZWxlY3Rpb25Db250cm9sbGVyOjpFRGlyZWN0aW9uKWRpcmVjdGlvbiBncmFudWxhcml0 eTooVGV4dEdyYW51bGFyaXR5KWdyYW51bGFyaXR5Cg==