221356 2021-02-03 13:27:43 -0800 Supplementary code points (U+10000 - U+10FFFF) are not shaped correctly in the fast text codepath 2021-03-04 11:11:52 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=221523 https://bugs.webkit.org/show_bug.cgi?id=222753 InRadar P2 Normal --- 1 mmaxfield mmaxfield darin webkit-bug-importer zalan oldest_to_newest 1725317 0 mmaxfield 2021-02-03 13:27:43 -0800 Supplementary code points (U+10000 - U+10FFFF) are not shaped correctly in the fast text codepath 1725322 1 419182 mmaxfield 2021-02-03 13:31:06 -0800 Created attachment 419182 Needs test 1725324 2 mmaxfield 2021-02-03 13:31:41 -0800 <rdar://problem/72555297> 1725382 3 419196 mmaxfield 2021-02-03 15:42:39 -0800 Created attachment 419196 Patch 1725385 4 419198 mmaxfield 2021-02-03 15:46:05 -0800 Created attachment 419198 Patch 1725423 5 ews-feeder 2021-02-03 17:53:06 -0800 Found 18 new test failures: fast/text/complex-small-caps-non-bmp-capitalize.html, fast/text/multiple-codeunit-vertical-upright-2.html, fast/text/multiple-codeunit-vertical-upright.html, imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-bold-fraktur.html, imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-bold-italic.html, imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-bold-sans-serif.html, imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-bold-script.html, imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-fraktur.html, imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-initial.html, imported/w3c/web-platform-tests/mathml/relations/css-styling/mathvariant-looped.html ... 1725467 6 419223 mmaxfield 2021-02-03 20:19:57 -0800 Created attachment 419223 Patch for committing 1725734 7 419198 darin 2021-02-04 12:15:47 -0800 Comment on attachment 419198 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419198&action=review > Source/WebCore/platform/graphics/WidthIterator.cpp:265 > + if (character >= 0x10000) I think it would be more elegant if this used U_IS_SUPPLEMENTARY or !U_IS_BMP. Not really sure how much we want to lean into using the semantically more clear macros over the mechanically more clear numeric comparisons. 1725737 8 419198 darin 2021-02-04 12:17:36 -0800 Comment on attachment 419198 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419198&action=review >> Source/WebCore/platform/graphics/WidthIterator.cpp:265 >> + if (character >= 0x10000) > > I think it would be more elegant if this used U_IS_SUPPLEMENTARY or !U_IS_BMP. Not really sure how much we want to lean into using the semantically more clear macros over the mechanically more clear numeric comparisons. Or maybe this should be checking advanceLength or clusterLength (they are the same, why do we have both?) instead of character? 1725739 9 mmaxfield 2021-02-04 12:20:28 -0800 (In reply to Darin Adler from comment #7) > Comment on attachment 419198 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=419198&action=review > > > Source/WebCore/platform/graphics/WidthIterator.cpp:265 > > + if (character >= 0x10000) > > I think it would be more elegant if this used U_IS_SUPPLEMENTARY or > !U_IS_BMP. Not really sure how much we want to lean into using the > semantically more clear macros over the mechanically more clear numeric > comparisons. I actually already did this in the patch for committing :) 1725762 10 darin 2021-02-04 13:05:01 -0800 (In reply to Myles C. Maxfield from comment #9) > I actually already did this in the patch for committing :) Excellent! 1725771 11 ews-feeder 2021-02-04 13:28:34 -0800 Committed r272379: <https://trac.webkit.org/changeset/272379> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419223. 419182 2021-02-03 13:31:06 -0800 2021-02-03 15:42:40 -0800 Needs test bug-221356-20210203133105.patch text/plain 1919 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyMjk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2E0NDU5YTdiNjYxNjVh MDExYzI3ZGY5YTUzZjgwMjY5YWI5MGY4NC4uMzU4ZWVmOTQ2ZGJjYzlmZjUyMWI4Y2E0ZWJkYjQ1 ZThmZGFlNDA2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTAyLTAzICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgU3VwcGxlbWVu dGFyeSBjb2RlIHBvaW50cyAoVSsxMDAwMCAtIFUrMTBGRkZGKSBhcmUgbm90IHNoYXBlZCBjb3Jy ZWN0bHkgaW4gdGhlIGZhc3QgdGV4dCBjb2RlcGF0aAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIxMzU2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83 MjU1NTI5Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBTdXBwbGVtZW50YXJ5IGNvZGUgcG9pbnRzIGFyZSByZXByZXNlbnRlZCBpbiBVVEYtMTYgYXMg dHdvIGFkamFjZW50IChzdXJyb2dhdGUpIGNvZGUgdW5pdHMuIFdoZW4gd2UgbWFwIGNvZGUKKyAg ICAgICAgcG9pbnRzIHRvIGdseXBocywgd2Ugd2VyZSBvcmlnaW5hbGx5IG1hcHBpbmcgdGhlc2Ug dHdvIGNvZGUgdW5pdHMgdG8gYSBzaW5nbGUgZ2x5cGguIEhvd2V2ZXIsIHNoYXBpbmcKKyAgICAg ICAgcm91dGluZXMgcmVxdWlyZSB0aGF0IHRoZSBudW1iZXIgb2YgY29kZSBwb2ludHMgYW5kIGds eXBocyBiZSBlcXVhbCwgYnkgaW5qZWN0aW5nIGEgMCBnbHlwaCBmb3IgdGhlIHRyYWlsaW5nCisg ICAgICAgIHN1cnJvZ2F0ZS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL1dpZHRoSXRlcmF0b3IuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6V2lkdGhJdGVyYXRvcjo6YWR2YW5jZUludGVybmFsKToKKwogMjAyMS0wMi0wMiAgRGFy aW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjI3MTQz OSk6IG51bGwtZGVyZWZlcmVuY2UgaW4gdXNlU21vb3RoU2Nyb2xsaW5nCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9XaWR0aEl0ZXJhdG9yLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1dpZHRoSXRlcmF0b3IuY3BwCmluZGV4IGE4ODY2 NzVjNGI1MzQ1ODFiODBhNjM2ODBjYzBlYjQ5NTlhYzllYWEuLjA2YjI0YWZlODA4Yjk3YjIwNWIz ZjcwYzcyZjVlODFjNmY4Y2IzYWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL1dpZHRoSXRlcmF0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL1dpZHRoSXRlcmF0b3IuY3BwCkBAIC0yNjIsNiArMjYyLDggQEAgaW5saW5lIHZv aWQgV2lkdGhJdGVyYXRvcjo6YWR2YW5jZUludGVybmFsKFRleHRJdGVyYXRvciYgdGV4dEl0ZXJh dG9yLCBHbHlwaEJ1ZmYKICAgICAgICAgICAgIGdseXBoID0gMDsKIAogICAgICAgICBnbHlwaEJ1 ZmZlci5hZGQoZ2x5cGgsICpmb250LCB3aWR0aCwgY3VycmVudENoYXJhY3RlckluZGV4KTsKKyAg ICAgICAgaWYgKGNoYXJhY3RlciA+PSAweDEwMDAwKQorICAgICAgICAgICAgZ2x5cGhCdWZmZXIu YWRkKDAsICpmb250LCAwLCBjdXJyZW50Q2hhcmFjdGVySW5kZXggKyAxKTsKIAogICAgICAgICAv LyBBZHZhbmNlIHBhc3QgdGhlIGNoYXJhY3RlciB3ZSBqdXN0IGRlYWx0IHdpdGguCiAgICAgICAg IHRleHRJdGVyYXRvci5hZHZhbmNlKGFkdmFuY2VMZW5ndGgpOwo= 419196 2021-02-03 15:42:39 -0800 2021-02-03 15:46:04 -0800 Patch bug-221356-20210203154239.patch text/plain 3714 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyMjk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2E0NDU5YTdiNjYxNjVh MDExYzI3ZGY5YTUzZjgwMjY5YWI5MGY4NC4uYWU5YzI3ZDU3ZjRmYTNlYzUxMjhkOTcxZDg4NDMx YTVmNWJjYTE5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTAyLTAzICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgU3VwcGxlbWVu dGFyeSBjb2RlIHBvaW50cyAoVSsxMDAwMCAtIFUrMTBGRkZGKSBhcmUgbm90IHNoYXBlZCBjb3Jy ZWN0bHkgaW4gdGhlIGZhc3QgdGV4dCBjb2RlcGF0aAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIxMzU2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83 MjU1NTI5Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBTdXBwbGVtZW50YXJ5IGNvZGUgcG9pbnRzIGFyZSByZXByZXNlbnRlZCBpbiBVVEYtMTYgYXMg dHdvIGFkamFjZW50IChzdXJyb2dhdGUpIGNvZGUgdW5pdHMuIFdoZW4gd2UgbWFwIGNvZGUKKyAg ICAgICAgcG9pbnRzIHRvIGdseXBocywgd2Ugd2VyZSBvcmlnaW5hbGx5IG1hcHBpbmcgdGhlc2Ug dHdvIGNvZGUgdW5pdHMgdG8gYSBzaW5nbGUgZ2x5cGguIEhvd2V2ZXIsIHNoYXBpbmcKKyAgICAg ICAgcm91dGluZXMgcmVxdWlyZSB0aGF0IHRoZSBudW1iZXIgb2YgY29kZSBwb2ludHMgYW5kIGds eXBocyBiZSBlcXVhbCwgYnkgaW5qZWN0aW5nIGEgMCBnbHlwaCBmb3IgdGhlIHRyYWlsaW5nCisg ICAgICAgIHN1cnJvZ2F0ZS4KKworICAgICAgICBMdWNraWx5LCB3ZSBkb24ndCBhY3R1YWxseSBo YXZlIHRvIGRlbGV0ZSB0aGVzZSBleHRyYSAwIGdseXBocywgYmVjYXVzZSB0aGUgc2hhcGluZyBl bmdpbmUgd2lsbCBkbyB0aGF0IGZvciB1cy4KKworICAgICAgICBUZXN0OiBmYXN0L3RleHQvbXVs dGktY29kZS11bml0LXNpbXBsZS1wYXRoLmh0bWwKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL1dpZHRoSXRlcmF0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2lkdGhJdGVyYXRvcjo6 YWR2YW5jZUludGVybmFsKToKKwogMjAyMS0wMi0wMiAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBs ZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjI3MTQzOSk6IG51bGwtZGVyZWZlcmVuY2Ug aW4gdXNlU21vb3RoU2Nyb2xsaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9XaWR0aEl0ZXJhdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL1dpZHRoSXRlcmF0b3IuY3BwCmluZGV4IGE4ODY2NzVjNGI1MzQ1ODFiODBhNjM2ODBj YzBlYjQ5NTlhYzllYWEuLjA2YjI0YWZlODA4Yjk3YjIwNWIzZjcwYzcyZjVlODFjNmY4Y2IzYWQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1dpZHRoSXRlcmF0 b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1dpZHRoSXRlcmF0 b3IuY3BwCkBAIC0yNjIsNiArMjYyLDggQEAgaW5saW5lIHZvaWQgV2lkdGhJdGVyYXRvcjo6YWR2 YW5jZUludGVybmFsKFRleHRJdGVyYXRvciYgdGV4dEl0ZXJhdG9yLCBHbHlwaEJ1ZmYKICAgICAg ICAgICAgIGdseXBoID0gMDsKIAogICAgICAgICBnbHlwaEJ1ZmZlci5hZGQoZ2x5cGgsICpmb250 LCB3aWR0aCwgY3VycmVudENoYXJhY3RlckluZGV4KTsKKyAgICAgICAgaWYgKGNoYXJhY3RlciA+ PSAweDEwMDAwKQorICAgICAgICAgICAgZ2x5cGhCdWZmZXIuYWRkKDAsICpmb250LCAwLCBjdXJy ZW50Q2hhcmFjdGVySW5kZXggKyAxKTsKIAogICAgICAgICAvLyBBZHZhbmNlIHBhc3QgdGhlIGNo YXJhY3RlciB3ZSBqdXN0IGRlYWx0IHdpdGguCiAgICAgICAgIHRleHRJdGVyYXRvci5hZHZhbmNl KGFkdmFuY2VMZW5ndGgpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGY5Yjg5OWUwMzBjM2RkNDUzNTI0NDJjZjI2Y2NiNzA2 MTA2NTAzYjQuLjVhOTliOWIzYTQxZjVjMzYxMmEwY2I3YmI0OGJiZDkyN2JiNDFlZjggMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNCBAQAorMjAyMS0wMi0wMyAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4Zmll bGRAYXBwbGUuY29tPgorCisgICAgICAgIFN1cHBsZW1lbnRhcnkgY29kZSBwb2ludHMgKFUrMTAw MDAgLSBVKzEwRkZGRikgYXJlIG5vdCBzaGFwZWQgY29ycmVjdGx5IGluIHRoZSBmYXN0IHRleHQg Y29kZXBhdGgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIyMTM1NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzI1NTUyOTc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L3RleHQvbXVsdGktY29k ZS11bml0LXNpbXBsZS1wYXRoLWV4cGVjdGVkLW1pc21hdGNoLmh0bWw6IEFkZGVkLgorICAgICAg ICAqIGZhc3QvdGV4dC9tdWx0aS1jb2RlLXVuaXQtc2ltcGxlLXBhdGguaHRtbDogQWRkZWQuCisK IDIwMjEtMDItMDIgIExhdXJvIE1vdXJhICA8bG1vdXJhQGlnYWxpYS5jb20+CiAKICAgICAgICAg W0dMSUJdIEdhcmRlbmluZyBkZWJ1ZyB0aW1lb3V0cwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC90ZXh0L211bHRpLWNvZGUtdW5pdC1zaW1wbGUtcGF0aC1leHBlY3RlZC1taXNtYXRjaC5o dG1sIGIvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L211bHRpLWNvZGUtdW5pdC1zaW1wbGUtcGF0aC1l eHBlY3RlZC1taXNtYXRjaC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjI2NTVmNGU3NzhhZTlhZmEwMWRmMzVk NjBjMmQ4NzQ3M2I0ZmJjNmYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3Rl eHQvbXVsdGktY29kZS11bml0LXNpbXBsZS1wYXRoLWV4cGVjdGVkLW1pc21hdGNoLmh0bWwKQEAg LTAsMCArMSw3IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8L2hlYWQ+Cis8 Ym9keT4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvdGV4 dC9tdWx0aS1jb2RlLXVuaXQtc2ltcGxlLXBhdGguaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvdGV4 dC9tdWx0aS1jb2RlLXVuaXQtc2ltcGxlLXBhdGguaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41NWIxMjVlY2Jl YzRlY2MzM2E5ZjE1YmE4M2ZmNmNiNTM0ODcyYWQ4Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvZmFzdC90ZXh0L211bHRpLWNvZGUtdW5pdC1zaW1wbGUtcGF0aC5odG1sCkBAIC0wLDAg KzEsOCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPC9oZWFkPgorPGJvZHk+ Cis8ZGl2IHN0eWxlPSJmb250LXNpemU6IDQ4cHg7Ij4mI3gxMTMwMDs8L2Rpdj4KKzwvYm9keT4K KzwvaHRtbD4K 419198 2021-02-03 15:46:05 -0800 2021-02-03 17:53:07 -0800 Patch bug-221356-20210203154605.patch text/plain 3713 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyMjk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2E0NDU5YTdiNjYxNjVh MDExYzI3ZGY5YTUzZjgwMjY5YWI5MGY4NC4uOWViOTIyOWNhZmU1NDMyZTdjMThjMGUwODVmMjM3 ZTNlNDE0OTAwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTAyLTAzICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgU3VwcGxlbWVu dGFyeSBjb2RlIHBvaW50cyAoVSsxMDAwMCAtIFUrMTBGRkZGKSBhcmUgbm90IHNoYXBlZCBjb3Jy ZWN0bHkgaW4gdGhlIGZhc3QgdGV4dCBjb2RlcGF0aAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIxMzU2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83 MjU1NTI5Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBTdXBwbGVtZW50YXJ5IGNvZGUgcG9pbnRzIGFyZSByZXByZXNlbnRlZCBpbiBVVEYtMTYgYXMg dHdvIGFkamFjZW50IChzdXJyb2dhdGUpIGNvZGUgdW5pdHMuIFdoZW4gd2UgbWFwIGNvZGUKKyAg ICAgICAgcG9pbnRzIHRvIGdseXBocywgd2Ugd2VyZSBvcmlnaW5hbGx5IG1hcHBpbmcgdGhlc2Ug dHdvIGNvZGUgdW5pdHMgdG8gYSBzaW5nbGUgZ2x5cGguIEhvd2V2ZXIsIHNoYXBpbmcKKyAgICAg ICAgcm91dGluZXMgcmVxdWlyZSB0aGF0IHRoZSBudW1iZXIgb2YgY29kZSB1bml0cyBhbmQgZ2x5 cGhzIGJlIGVxdWFsLCBieSBpbmplY3RpbmcgYSAwIGdseXBoIGZvciB0aGUgdHJhaWxpbmcKKyAg ICAgICAgc3Vycm9nYXRlLgorCisgICAgICAgIEx1Y2tpbHksIHdlIGRvbid0IGFjdHVhbGx5IGhh dmUgdG8gZGVsZXRlIHRoZXNlIGV4dHJhIDAgZ2x5cGhzLCBiZWNhdXNlIHRoZSBzaGFwaW5nIGVu Z2luZSB3aWxsIGRvIHRoYXQgZm9yIHVzLgorCisgICAgICAgIFRlc3Q6IGZhc3QvdGV4dC9tdWx0 aS1jb2RlLXVuaXQtc2ltcGxlLXBhdGguaHRtbAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvV2lkdGhJdGVyYXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXaWR0aEl0ZXJhdG9yOjph ZHZhbmNlSW50ZXJuYWwpOgorCiAyMDIxLTAyLTAyICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxl LmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMjcxNDM5KTogbnVsbC1kZXJlZmVyZW5jZSBp biB1c2VTbW9vdGhTY3JvbGxpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL1dpZHRoSXRlcmF0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvV2lkdGhJdGVyYXRvci5jcHAKaW5kZXggYTg4NjY3NWM0YjUzNDU4MWI4MGE2MzY4MGNj MGViNDk1OWFjOWVhYS4uMDZiMjRhZmU4MDhiOTdiMjA1YjNmNzBjNzJmNWU4MWM2ZjhjYjNhZCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvV2lkdGhJdGVyYXRv ci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvV2lkdGhJdGVyYXRv ci5jcHAKQEAgLTI2Miw2ICsyNjIsOCBAQCBpbmxpbmUgdm9pZCBXaWR0aEl0ZXJhdG9yOjphZHZh bmNlSW50ZXJuYWwoVGV4dEl0ZXJhdG9yJiB0ZXh0SXRlcmF0b3IsIEdseXBoQnVmZgogICAgICAg ICAgICAgZ2x5cGggPSAwOwogCiAgICAgICAgIGdseXBoQnVmZmVyLmFkZChnbHlwaCwgKmZvbnQs IHdpZHRoLCBjdXJyZW50Q2hhcmFjdGVySW5kZXgpOworICAgICAgICBpZiAoY2hhcmFjdGVyID49 IDB4MTAwMDApCisgICAgICAgICAgICBnbHlwaEJ1ZmZlci5hZGQoMCwgKmZvbnQsIDAsIGN1cnJl bnRDaGFyYWN0ZXJJbmRleCArIDEpOwogCiAgICAgICAgIC8vIEFkdmFuY2UgcGFzdCB0aGUgY2hh cmFjdGVyIHdlIGp1c3QgZGVhbHQgd2l0aC4KICAgICAgICAgdGV4dEl0ZXJhdG9yLmFkdmFuY2Uo YWR2YW5jZUxlbmd0aCk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjliODk5ZTAzMGMzZGQ0NTM1MjQ0MmNmMjZjY2I3MDYx MDY1MDNiNC4uNWE5OWI5YjNhNDFmNWMzNjEyYTBjYjdiYjQ4YmJkOTI3YmI0MWVmOCAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE0IEBACisyMDIxLTAyLTAzICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVs ZEBhcHBsZS5jb20+CisKKyAgICAgICAgU3VwcGxlbWVudGFyeSBjb2RlIHBvaW50cyAoVSsxMDAw MCAtIFUrMTBGRkZGKSBhcmUgbm90IHNoYXBlZCBjb3JyZWN0bHkgaW4gdGhlIGZhc3QgdGV4dCBj b2RlcGF0aAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjIxMzU2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MjU1NTI5Nz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvdGV4dC9tdWx0aS1jb2Rl LXVuaXQtc2ltcGxlLXBhdGgtZXhwZWN0ZWQtbWlzbWF0Y2guaHRtbDogQWRkZWQuCisgICAgICAg ICogZmFzdC90ZXh0L211bHRpLWNvZGUtdW5pdC1zaW1wbGUtcGF0aC5odG1sOiBBZGRlZC4KKwog MjAyMS0wMi0wMiAgTGF1cm8gTW91cmEgIDxsbW91cmFAaWdhbGlhLmNvbT4KIAogICAgICAgICBb R0xJQl0gR2FyZGVuaW5nIGRlYnVnIHRpbWVvdXRzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9m YXN0L3RleHQvbXVsdGktY29kZS11bml0LXNpbXBsZS1wYXRoLWV4cGVjdGVkLW1pc21hdGNoLmh0 bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3RleHQvbXVsdGktY29kZS11bml0LXNpbXBsZS1wYXRoLWV4 cGVjdGVkLW1pc21hdGNoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMjY1NWY0ZTc3OGFlOWFmYTAxZGYzNWQ2 MGMyZDg3NDczYjRmYmM2ZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvdGV4 dC9tdWx0aS1jb2RlLXVuaXQtc2ltcGxlLXBhdGgtZXhwZWN0ZWQtbWlzbWF0Y2guaHRtbApAQCAt MCwwICsxLDcgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzwvaGVhZD4KKzxi b2R5PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC90ZXh0 L211bHRpLWNvZGUtdW5pdC1zaW1wbGUtcGF0aC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC90ZXh0 L211bHRpLWNvZGUtdW5pdC1zaW1wbGUtcGF0aC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjU1YjEyNWVjYmVj NGVjYzMzYTlmMTViYTgzZmY2Y2I1MzQ4NzJhZDgKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L3RleHQvbXVsdGktY29kZS11bml0LXNpbXBsZS1wYXRoLmh0bWwKQEAgLTAsMCAr MSw4IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8L2hlYWQ+Cis8Ym9keT4K KzxkaXYgc3R5bGU9ImZvbnQtc2l6ZTogNDhweDsiPiYjeDExMzAwOzwvZGl2PgorPC9ib2R5Pgor PC9odG1sPgo= 419223 2021-02-03 20:19:57 -0800 2021-02-04 13:28:35 -0800 Patch for committing bug-221356-20210203201956.patch text/plain 4164 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyMzUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWRjZjk5ODJjNzFkNWI5 MmNiYzZlYjFkMmI3MDkxNjU4NDNiNjdlNS4uNTg2Njc1MjYzN2FhM2U4NGExNGUzYzY3YmU3OGY3 ZWFhMGRjYmUwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTAyLTAzICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgU3VwcGxlbWVu dGFyeSBjb2RlIHBvaW50cyAoVSsxMDAwMCAtIFUrMTBGRkZGKSBhcmUgbm90IHNoYXBlZCBjb3Jy ZWN0bHkgaW4gdGhlIGZhc3QgdGV4dCBjb2RlcGF0aAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIxMzU2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83 MjU1NTI5Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBaYWxhbiBCdWp0YXMuCisKKyAgICAgICAg U3VwcGxlbWVudGFyeSBjb2RlIHBvaW50cyBhcmUgcmVwcmVzZW50ZWQgaW4gVVRGLTE2IGFzIHR3 byBhZGphY2VudCAoc3Vycm9nYXRlKSBjb2RlIHVuaXRzLiBXaGVuIHdlIG1hcCBjb2RlCisgICAg ICAgIHBvaW50cyB0byBnbHlwaHMsIHdlIHdlcmUgb3JpZ2luYWxseSBtYXBwaW5nIHRoZXNlIHR3 byBjb2RlIHVuaXRzIHRvIGEgc2luZ2xlIGdseXBoLiBIb3dldmVyLCBzaGFwaW5nCisgICAgICAg IHJvdXRpbmVzIHJlcXVpcmUgdGhhdCB0aGUgbnVtYmVyIG9mIGNvZGUgdW5pdHMgYW5kIGdseXBo cyBiZSBlcXVhbCwgYnkgaW5qZWN0aW5nIGEgMCBnbHlwaCBmb3IgdGhlIHRyYWlsaW5nCisgICAg ICAgIHN1cnJvZ2F0ZS4KKworICAgICAgICBMdWNraWx5LCB3ZSBkb24ndCBhY3R1YWxseSBoYXZl IHRvIGRlbGV0ZSB0aGVzZSBleHRyYSAwIGdseXBocywgYmVjYXVzZSB0aGUgc2hhcGluZyBlbmdp bmUgd2lsbCBkbyB0aGF0IGZvciB1cy4KKworICAgICAgICBUZXN0OiBmYXN0L3RleHQvbXVsdGkt Y29kZS11bml0LXNpbXBsZS1wYXRoLmh0bWwKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L1dpZHRoSXRlcmF0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2lkdGhJdGVyYXRvcjo6YWR2 YW5jZUludGVybmFsKToKKwogMjAyMS0wMi0wMyAgRGllZ28gUGlubyBHYXJjaWEgIDxkcGlub0Bp Z2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIEdUSyBVYnVudHUgTFRTIGJ1aWxkIGZp eCBhZnRlciByMjcyMzExLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvV2lkdGhJdGVyYXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9XaWR0aEl0ZXJhdG9yLmNwcAppbmRleCBhODg2Njc1YzRiNTM0NTgxYjgwYTYzNjgwY2MwZWI0 OTU5YWM5ZWFhLi5hNTBmZTlmNmEyNjBhMTc3MzM3Yzk4ZTAzODQzZmMxYmEwZWYwMjFlIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9XaWR0aEl0ZXJhdG9yLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9XaWR0aEl0ZXJhdG9yLmNw cApAQCAtMjYyLDYgKzI2MiwxNCBAQCBpbmxpbmUgdm9pZCBXaWR0aEl0ZXJhdG9yOjphZHZhbmNl SW50ZXJuYWwoVGV4dEl0ZXJhdG9yJiB0ZXh0SXRlcmF0b3IsIEdseXBoQnVmZgogICAgICAgICAg ICAgZ2x5cGggPSAwOwogCiAgICAgICAgIGdseXBoQnVmZmVyLmFkZChnbHlwaCwgKmZvbnQsIHdp ZHRoLCBjdXJyZW50Q2hhcmFjdGVySW5kZXgpOworI2lmICFQTEFURk9STShDT0NPQSkgfHwgVVNF KENURk9OVFNIQVBFR0xZUEhTKQorICAgICAgICAvLyBUaGVzZSAwIGdseXBocyBhcmUgbmVlZGVk IGJ5IHNoYXBlcnMgaWYgdGhlIHNvdXJjZSB0ZXh0IGhhcyBzdXJyb2dhdGUgcGFpcnMuCisgICAg ICAgIC8vIEhvd2V2ZXIsIENURm9udFRyYW5zZm9ybUdseXBocygpIGNhbid0IGRlbGV0ZSB0aGVz ZSAwIGdseXBocyBmcm9tIHRoZSBzaGFwZWQgdGV4dCwKKyAgICAgICAgLy8gc28gd2Ugc2hvdWxk bid0IGFkZCB0aGVtIGluIHRoZSBmaXJzdCBwbGFjZSBpZiB3ZSdyZSB1c2luZyB0aGF0IHNoYXBp bmcgcm91dGluZS4KKyAgICAgICAgLy8gQW55IG90aGVyIHNoYXBpbmcgcm91dGluZSBzaG91bGQg ZGVsZXRlIHRoZXNlIGdseXBocyBmcm9tIHRoZSBzaGFwZWQgdGV4dC4KKyAgICAgICAgaWYgKCFV X0lTX0JNUChjaGFyYWN0ZXIpKQorICAgICAgICAgICAgZ2x5cGhCdWZmZXIuYWRkKDAsICpmb250 LCAwLCBjdXJyZW50Q2hhcmFjdGVySW5kZXggKyAxKTsKKyNlbmRpZgogCiAgICAgICAgIC8vIEFk dmFuY2UgcGFzdCB0aGUgY2hhcmFjdGVyIHdlIGp1c3QgZGVhbHQgd2l0aC4KICAgICAgICAgdGV4 dEl0ZXJhdG9yLmFkdmFuY2UoYWR2YW5jZUxlbmd0aCk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTkxZjM2OTM0N2M0NGZk ZDQxNGVhNTI5Mzg0OWY4NTc4Nzc4NjNiMi4uNTc4MGNhNDI5YjAxZTcwMDQ2ZTk0MTI5OWE2OTJk NGFhYzY0Njc2MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91 dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTAyLTAzICBNeWxlcyBDLiBN YXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgU3VwcGxlbWVudGFyeSBj b2RlIHBvaW50cyAoVSsxMDAwMCAtIFUrMTBGRkZGKSBhcmUgbm90IHNoYXBlZCBjb3JyZWN0bHkg aW4gdGhlIGZhc3QgdGV4dCBjb2RlcGF0aAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjIxMzU2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MjU1NTI5 Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBaYWxhbiBCdWp0YXMuCisKKyAgICAgICAgKiBmYXN0 L3RleHQvbXVsdGktY29kZS11bml0LXNpbXBsZS1wYXRoLWV4cGVjdGVkLW1pc21hdGNoLmh0bWw6 IEFkZGVkLgorICAgICAgICAqIGZhc3QvdGV4dC9tdWx0aS1jb2RlLXVuaXQtc2ltcGxlLXBhdGgu aHRtbDogQWRkZWQuCisKIDIwMjEtMDItMDMgIEppZXdlbiBUYW4gIDxqaWV3ZW5fdGFuQGFwcGxl LmNvbT4KIAogICAgICAgICBbV2ViQXV0aG5dIEFsbG93IG9uZSB1c2VyIGdlc3R1cmUgZnJlZSBw cm9tcHQgZm9yIGVhY2ggbmF2aWdhdGlvbgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC90 ZXh0L211bHRpLWNvZGUtdW5pdC1zaW1wbGUtcGF0aC1leHBlY3RlZC1taXNtYXRjaC5odG1sIGIv TGF5b3V0VGVzdHMvZmFzdC90ZXh0L211bHRpLWNvZGUtdW5pdC1zaW1wbGUtcGF0aC1leHBlY3Rl ZC1taXNtYXRjaC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjI2NTVmNGU3NzhhZTlhZmEwMWRmMzVkNjBjMmQ4 NzQ3M2I0ZmJjNmYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3RleHQvbXVs dGktY29kZS11bml0LXNpbXBsZS1wYXRoLWV4cGVjdGVkLW1pc21hdGNoLmh0bWwKQEAgLTAsMCAr MSw3IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8L2hlYWQ+Cis8Ym9keT4K KzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvdGV4dC9tdWx0 aS1jb2RlLXVuaXQtc2ltcGxlLXBhdGguaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvdGV4dC9tdWx0 aS1jb2RlLXVuaXQtc2ltcGxlLXBhdGguaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41NWIxMjVlY2JlYzRlY2Mz M2E5ZjE1YmE4M2ZmNmNiNTM0ODcyYWQ4Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv ZmFzdC90ZXh0L211bHRpLWNvZGUtdW5pdC1zaW1wbGUtcGF0aC5odG1sCkBAIC0wLDAgKzEsOCBA QAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPC9oZWFkPgorPGJvZHk+Cis8ZGl2 IHN0eWxlPSJmb250LXNpemU6IDQ4cHg7Ij4mI3gxMTMwMDs8L2Rpdj4KKzwvYm9keT4KKzwvaHRt bD4K