221346 2021-02-03 11:18:10 -0800 REGRESSION (270392): Launch time regression under IOSurface::maximumSize() 2022-01-26 14:02:04 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=235526 https://bugs.webkit.org/show_bug.cgi?id=219484 InRadar P2 Normal --- 1 thorton thorton ggaren sam webkit-bug-importer oldest_to_newest 1725233 0 thorton 2021-02-03 11:18:10 -0800 REGRESSION (270392): Launch time regression under IOSurface::maximumSize() 1725234 1 419160 thorton 2021-02-03 11:21:02 -0800 Created attachment 419160 Patch 1725235 2 thorton 2021-02-03 11:21:05 -0800 <rdar://problem/73507706> 1725242 3 419160 sam 2021-02-03 11:47:11 -0800 Comment on attachment 419160 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419160&action=review > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:477 > + parameters.maximumIOSurfaceSize = WebCore::IOSurface::maximumSize(); Does it have a reasonable default value so that if something in the WebProcess (and GPU process is not enabled for DOM) tries to read this it won't be garbage? 1725243 4 thorton 2021-02-03 11:48:00 -0800 (In reply to Sam Weinig from comment #3) > Comment on attachment 419160 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=419160&action=review > > > Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:477 > > + parameters.maximumIOSurfaceSize = WebCore::IOSurface::maximumSize(); > > Does it have a reasonable default value so that if something in the > WebProcess (and GPU process is not enabled for DOM) tries to read this it > won't be garbage? The WebProcess will compute it if it's still 0x0 the first time it's read. 1725247 5 thorton 2021-02-03 11:51:08 -0800 (And, to be clear, IntSize is 0x0 by default) 1725284 6 ews-feeder 2021-02-03 12:32:27 -0800 Committed r272335: <https://trac.webkit.org/changeset/272335> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419160. 1728342 7 ryanhaddad 2021-02-11 16:15:45 -0800 There was a follow up for this change: https://trac.webkit.org/changeset/272355/webkit 419160 2021-02-03 11:21:02 -0800 2021-02-03 12:32:28 -0800 Patch bug-221346-20210203112101.patch text/plain 2108 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyMzMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZjM2U5NWNhMmQyNDU4YmM4 Y2JmMmM4ZTY3OTg3YmJjYmQ4NDI5MTAuLmYwZjdmZTFiODlhMzgyNGJhYjIzNGJmMjJmNmQ4NDFl YTUzOTAzZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDItMDMgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjI3 MDM5Mik6IExhdW5jaCB0aW1lIHJlZ3Jlc3Npb24gdW5kZXIgSU9TdXJmYWNlOjptYXhpbXVtU2l6 ZSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjEz NDYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzczNTA3NzA2PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0NvY29hL1dlYlByb2Nl c3NQb29sQ29jb2EubW06CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3NQb29sOjpwbGF0Zm9y bUluaXRpYWxpemVXZWJQcm9jZXNzKToKKyAgICAgICAgU2NvcGUgcjI3MDM5MiB0byBvbmx5IHRo ZSBjYXNlIHdoZXJlIGl0IGlzIG5lZWRlZCwgd2hlbiBET00gcmVuZGVyaW5nIGluIHRoZSBHUFUg cHJvY2VzcworICAgICAgICBpcyBlbmFibGVkIGFuZCB0aGUgV2ViIENvbnRlbnQgcHJvY2VzcyBk b2VzIG5vdCBoYXZlIGFjY2VzcyB0byBJT1N1cmZhY2UsCisgICAgICAgIGJlY2F1c2UgaXQgY2F1 c2VzIGEgc21hbGwgbGF1bmNoIHRpbWUgcmVncmVzc2lvbi4KKwogMjAyMS0wMi0wMyAgUGVyIEFy bmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW21hY09TXSBSZW1vdmUg YWNjZXNzIHRvIGNvbS5hcHBsZS5jdm1zU2VydgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvQ29jb2EvV2ViUHJvY2Vzc1Bvb2xDb2NvYS5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0NvY29hL1dlYlByb2Nlc3NQb29sQ29jb2EubW0KaW5kZXggNzVlM2MyZmY5NDIxZGRh NmViZmExYTkyYTExYTQxMjRhMGQzZGI5MS4uMGZjNzMxMDdlMWJiOTE3N2E1MTI5ZjJiN2NiYzc3 YThhMzQyODAxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2Vi UHJvY2Vzc1Bvb2xDb2NvYS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9X ZWJQcm9jZXNzUG9vbENvY29hLm1tCkBAIC00NzEsNyArNDcxLDEwIEBAIHZvaWQgV2ViUHJvY2Vz c1Bvb2w6OnBsYXRmb3JtSW5pdGlhbGl6ZVdlYlByb2Nlc3MoY29uc3QgV2ViUHJvY2Vzc1Byb3h5 JiBwcm9jZXNzCiAgICAgcGFyYW1ldGVycy5oYXNTdHlsdXNEZXZpY2UgPSBbW1dLU3R5bHVzRGV2 aWNlT2JzZXJ2ZXIgc2hhcmVkSW5zdGFuY2VdIGhhc1N0eWx1c0RldmljZV07CiAjZW5kaWYKIAot ICAgIHBhcmFtZXRlcnMubWF4aW11bUlPU3VyZmFjZVNpemUgPSBXZWJDb3JlOjpJT1N1cmZhY2U6 Om1heGltdW1TaXplKCk7CisgICAgLy8gSWYgd2UncmUgdXNpbmcgdGhlIEdQVSBwcm9jZXNzIGZv ciBET00gcmVuZGVyaW5nLCB3ZSBjYW4ndCBxdWVyeSB0aGUgbWF4aW11bSBJT1N1cmZhY2Ugc2l6 ZSBpbiB0aGUgV2ViIENvbnRlbnQgcHJvY2Vzcy4KKyAgICAvLyBIb3dldmVyLCBxdWVyeWluZyB0 aGlzIGlzIGEgbGF1bmNoIHRpbWUgcmVncmVzc2lvbiwgc28gbGltaXQgdGhpcyB0byBvbmx5IHRo ZSBuZWNlc3NhcnkgY2FzZS4KKyAgICBpZiAobV9kZWZhdWx0UGFnZUdyb3VwLT5wcmVmZXJlbmNl cygpLnVzZUdQVVByb2Nlc3NGb3JET01SZW5kZXJpbmdFbmFibGVkKCkpCisgICAgICAgIHBhcmFt ZXRlcnMubWF4aW11bUlPU3VyZmFjZVNpemUgPSBXZWJDb3JlOjpJT1N1cmZhY2U6Om1heGltdW1T aXplKCk7CiB9CiAKIHZvaWQgV2ViUHJvY2Vzc1Bvb2w6OnBsYXRmb3JtSW5pdGlhbGl6ZU5ldHdv cmtQcm9jZXNzKE5ldHdvcmtQcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzJiBwYXJhbWV0ZXJzKQo=