221338 2021-02-03 09:28:12 -0800 [LFC][IFC] Move away from using RenderStyle::preserveNewline 2021-02-03 11:49:12 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1725181 0 zalan 2021-02-03 09:28:12 -0800 RenderStyle should just be a set of setters and getters 1725183 1 419149 zalan 2021-02-03 09:30:41 -0800 Created attachment 419149 Patch 1725244 2 ews-feeder 2021-02-03 11:48:31 -0800 Committed r272332: <https://trac.webkit.org/changeset/272332> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419149. 1725245 3 webkit-bug-importer 2021-02-03 11:49:12 -0800 <rdar://problem/73942567> 419149 2021-02-03 09:30:41 -0800 2021-02-03 11:48:32 -0800 Patch bug-221338-20210203093040.patch text/plain 4991 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyMzE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmEwYzZmZjk5ZGRlNmU0 ZWJmMTI3ZDU4NjBhODYwYWExYjM2NjllMC4uZWIyNjhhZGI4ODRlOTIyMjliZDg5ZjZmMTk4Y2E1 MWUxOWJkZmEyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTAyLTAzICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBNb3ZlIGF3 YXkgZnJvbSB1c2luZyBSZW5kZXJTdHlsZTo6cHJlc2VydmVOZXdsaW5lCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjEzMzgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW5kZXJTdHlsZSBzaG91bGQganVz dCBiZSBhIGNvbGxlY3Rpb24gb2Ygc2V0dGVyIGFuZCBnZXR0ZXIgZnVuY3Rpb25zLgorCisgICAg ICAgICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lVGV4dEl0ZW0uY3BwOgorICAgICAg ICAoV2ViQ29yZTo6TGF5b3V0OjpJbmxpbmVUZXh0SXRlbTo6Y3JlYXRlQW5kQXBwZW5kVGV4dEl0 ZW1zKToKKyAgICAgICAgKiBsYXlvdXQvaW5saW5lZm9ybWF0dGluZy90ZXh0L1RleHRVdGlsLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6VGV4dFV0aWw6OnNob3VsZFByZXNlcnZlU3Bh Y2VzQW5kVGFicyk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OlRleHRVdGlsOjpzaG91bGRQ cmVzZXJ2ZU5ld2xpbmUpOgorICAgICAgICAqIGxheW91dC9pbmxpbmVmb3JtYXR0aW5nL3RleHQv VGV4dFV0aWwuaDoKKwogMjAyMS0wMi0wMyAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29t PgogCiAgICAgICAgIFtMRkNdW0lGQ10gRXZlcnkgbGVhZGluZyB3aGl0ZXNwYWNlIGNoYXJhY3Rl ciBpcyB0ZXN0ZWQgdHdpY2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxp bmVmb3JtYXR0aW5nL0lubGluZVRleHRJdGVtLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9p bmxpbmVmb3JtYXR0aW5nL0lubGluZVRleHRJdGVtLmNwcAppbmRleCBiZjQwNDZhNzQwOTdjYjNk NTE3ZjlmMjdiMDlhODhiMDU2ZDg1NjRmLi40OTAzYTJlZmY2OTM3ZWFlOWRlMTg1NDk1MmE5Y2Ez NjIzMDQ1Mjk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0 dGluZy9JbmxpbmVUZXh0SXRlbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGlu ZWZvcm1hdHRpbmcvSW5saW5lVGV4dEl0ZW0uY3BwCkBAIC03Myw2ICs3Myw3IEBAIHZvaWQgSW5s aW5lVGV4dEl0ZW06OmNyZWF0ZUFuZEFwcGVuZFRleHRJdGVtcyhJbmxpbmVJdGVtcyYgaW5saW5l Q29udGVudCwgY29uc3QKICAgICBhdXRvJiBzdHlsZSA9IGlubGluZVRleHRCb3guc3R5bGUoKTsK ICAgICBhdXRvJiBmb250ID0gc3R5bGUuZm9udENhc2NhZGUoKTsKICAgICBhdXRvIHdoaXRlc3Bh Y2VDb250ZW50SXNUcmVhdGVkQXNTaW5nbGVTcGFjZSA9ICFUZXh0VXRpbDo6c2hvdWxkUHJlc2Vy dmVTcGFjZXNBbmRUYWJzKGlubGluZVRleHRCb3gpOworICAgIGF1dG8gc2hvdWxkUHJlc2V2ZU5l d2xpbmUgPSBUZXh0VXRpbDo6c2hvdWxkUHJlc2VydmVOZXdsaW5lKGlubGluZVRleHRCb3gpOwog ICAgIExhenlMaW5lQnJlYWtJdGVyYXRvciBsaW5lQnJlYWtJdGVyYXRvcih0ZXh0KTsKICAgICB1 bnNpZ25lZCBjdXJyZW50UG9zaXRpb24gPSAwOwogCkBAIC04OCwxMyArODksMTMgQEAgdm9pZCBJ bmxpbmVUZXh0SXRlbTo6Y3JlYXRlQW5kQXBwZW5kVGV4dEl0ZW1zKElubGluZUl0ZW1zJiBpbmxp bmVDb250ZW50LCBjb25zdAogICAgICAgICB9OwogCiAgICAgICAgIC8vIFNlZ21lbnQgYnJlYWtz IHdpdGggcHJlc2VydmUgbmV3IGxpbmUgc3R5bGUgKHdoaXRlLXNwYWNlOiBwcmUsIHByZS13cmFw LCBicmVhay1zcGFjZXMgYW5kIHByZS1saW5lKSBjb21wdXRlIHRvIGZvcmNlZCBsaW5lIGJyZWFr LgotICAgICAgICBpZiAoaXNTZWdtZW50QnJlYWtDYW5kaWRhdGUodGV4dFtjdXJyZW50UG9zaXRp b25dKSAmJiBzdHlsZS5wcmVzZXJ2ZU5ld2xpbmUoKSkgeworICAgICAgICBpZiAoaXNTZWdtZW50 QnJlYWtDYW5kaWRhdGUodGV4dFtjdXJyZW50UG9zaXRpb25dKSAmJiBzaG91bGRQcmVzZXZlTmV3 bGluZSkgewogICAgICAgICAgICAgaW5saW5lQ29udGVudC5hcHBlbmQoSW5saW5lU29mdExpbmVC cmVha0l0ZW06OmNyZWF0ZVNvZnRMaW5lQnJlYWtJdGVtKGlubGluZVRleHRCb3gsIGN1cnJlbnRQ b3NpdGlvbikpOwogICAgICAgICAgICAgKytjdXJyZW50UG9zaXRpb247CiAgICAgICAgICAgICBj b250aW51ZTsKICAgICAgICAgfQogCi0gICAgICAgIGlmIChhdXRvIGxlbmd0aCA9IG1vdmVUb05l eHROb25XaGl0ZXNwYWNlUG9zaXRpb24odGV4dCwgY3VycmVudFBvc2l0aW9uLCBzdHlsZS5wcmVz ZXJ2ZU5ld2xpbmUoKSkpIHsKKyAgICAgICAgaWYgKGF1dG8gbGVuZ3RoID0gbW92ZVRvTmV4dE5v bldoaXRlc3BhY2VQb3NpdGlvbih0ZXh0LCBjdXJyZW50UG9zaXRpb24sIHNob3VsZFByZXNldmVO ZXdsaW5lKSkgewogICAgICAgICAgICAgYXV0byBhcHBlbmRXaGl0ZXNwYWNlSXRlbSA9IFsmXSAo YXV0byBzdGFydFBvc2l0aW9uLCBhdXRvIGl0ZW1MZW5ndGgpIHsKICAgICAgICAgICAgICAgICBh dXRvIHNpbXBsZVNpbmdsZVdoaXRlc3BhY2VDb250ZW50ID0gaW5saW5lVGV4dEJveC5jYW5Vc2VT aW1wbGlmaWVkQ29udGVudE1lYXN1cmluZygpICYmIChpdGVtTGVuZ3RoID09IDEgfHwgd2hpdGVz cGFjZUNvbnRlbnRJc1RyZWF0ZWRBc1NpbmdsZVNwYWNlKTsKICAgICAgICAgICAgICAgICBhdXRv IHdpZHRoID0gc2ltcGxlU2luZ2xlV2hpdGVzcGFjZUNvbnRlbnQgPyBtYWtlT3B0aW9uYWwoSW5s aW5lTGF5b3V0VW5pdCB7IGZvbnQuc3BhY2VXaWR0aCgpIH0pIDogaW5saW5lSXRlbVdpZHRoKHN0 YXJ0UG9zaXRpb24sIGl0ZW1MZW5ndGgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5 b3V0L2lubGluZWZvcm1hdHRpbmcvdGV4dC9UZXh0VXRpbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9s YXlvdXQvaW5saW5lZm9ybWF0dGluZy90ZXh0L1RleHRVdGlsLmNwcAppbmRleCA5MzIzZDQ2ZGZi YzYzOGEzNzU4NjY0ZDA1YTZjMTJkNDVkNjczNTlkLi4yYmYwYzdlMGMwYjJkNGE3NGYwZGZkYTM3 NmQ2OTYzOTE2NTczZDliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5l Zm9ybWF0dGluZy90ZXh0L1RleHRVdGlsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQv aW5saW5lZm9ybWF0dGluZy90ZXh0L1RleHRVdGlsLmNwcApAQCAtMTYwLDEwICsxNjAsMTggQEAg dW5zaWduZWQgVGV4dFV0aWw6OmZpbmROZXh0QnJlYWthYmxlUG9zaXRpb24oTGF6eUxpbmVCcmVh a0l0ZXJhdG9yJiBsaW5lQnJlYWtJdGUKIAogYm9vbCBUZXh0VXRpbDo6c2hvdWxkUHJlc2VydmVT cGFjZXNBbmRUYWJzKGNvbnN0IEJveCYgbGF5b3V0Qm94KQogeworICAgIC8vIGh0dHBzOi8vd3d3 LnczLm9yZy9UUi9jc3MtdGV4dC0zLyN3aGl0ZS1zcGFjZS1wcm9wZXJ0eQogICAgIGF1dG8gd2hp dGVzcGFjZSA9IGxheW91dEJveC5zdHlsZSgpLndoaXRlU3BhY2UoKTsKICAgICByZXR1cm4gd2hp dGVzcGFjZSA9PSBXaGl0ZVNwYWNlOjpQcmUgfHwgd2hpdGVzcGFjZSA9PSBXaGl0ZVNwYWNlOjpQ cmVXcmFwIHx8IHdoaXRlc3BhY2UgPT0gV2hpdGVTcGFjZTo6QnJlYWtTcGFjZXM7CiB9CiAKK2Jv b2wgVGV4dFV0aWw6OnNob3VsZFByZXNlcnZlTmV3bGluZShjb25zdCBCb3gmIGxheW91dEJveCkK K3sKKyAgICBhdXRvIHdoaXRlc3BhY2UgPSBsYXlvdXRCb3guc3R5bGUoKS53aGl0ZVNwYWNlKCk7 CisgICAgLy8gaHR0cHM6Ly93d3cudzMub3JnL1RSL2Nzcy10ZXh0LTMvI3doaXRlLXNwYWNlLXBy b3BlcnR5CisgICAgcmV0dXJuIHdoaXRlc3BhY2UgPT0gV2hpdGVTcGFjZTo6UHJlIHx8IHdoaXRl c3BhY2UgPT0gV2hpdGVTcGFjZTo6UHJlV3JhcCB8fCB3aGl0ZXNwYWNlID09IFdoaXRlU3BhY2U6 OkJyZWFrU3BhY2VzIHx8IHdoaXRlc3BhY2UgPT0gV2hpdGVTcGFjZTo6UHJlTGluZTsgCit9CisK IH0KIH0KICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZv cm1hdHRpbmcvdGV4dC9UZXh0VXRpbC5oIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZv cm1hdHRpbmcvdGV4dC9UZXh0VXRpbC5oCmluZGV4IGE3NzNjOGJhOTFjOTgyOTk3OTMxYTBkNTJi N2I0NmFlNDNiYWQwNzEuLjdhYmMwYjE5Y2Y4ZGVjOGYxYjg4N2QzYTJkN2JmMGZiNzBjYTczZjcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL3RleHQv VGV4dFV0aWwuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy90 ZXh0L1RleHRVdGlsLmgKQEAgLTU1LDYgKzU1LDcgQEAgcHVibGljOgogICAgIHN0YXRpYyB1bnNp Z25lZCBmaW5kTmV4dEJyZWFrYWJsZVBvc2l0aW9uKExhenlMaW5lQnJlYWtJdGVyYXRvciYsIHVu c2lnbmVkIHN0YXJ0UG9zaXRpb24sIGNvbnN0IFJlbmRlclN0eWxlJik7CiAKICAgICBzdGF0aWMg Ym9vbCBzaG91bGRQcmVzZXJ2ZVNwYWNlc0FuZFRhYnMoY29uc3QgQm94Jik7CisgICAgc3RhdGlj IGJvb2wgc2hvdWxkUHJlc2VydmVOZXdsaW5lKGNvbnN0IEJveCYpOwogCiBwcml2YXRlOgogICAg IHN0YXRpYyBJbmxpbmVMYXlvdXRVbml0IGZpeGVkUGl0Y2hXaWR0aChjb25zdCBTdHJpbmdWaWV3 JiwgY29uc3QgUmVuZGVyU3R5bGUmLCB1bnNpZ25lZCBmcm9tLCB1bnNpZ25lZCB0bywgSW5saW5l TGF5b3V0VW5pdCBjb250ZW50TG9naWNhbExlZnQpOwo=