<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>221336</bug_id>
          
          <creation_ts>2021-02-03 09:12:03 -0800</creation_ts>
          <short_desc>[macOS] Remove access to com.apple.cvmsServ</short_desc>
          <delta_ts>2021-02-03 10:39:08 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Per Arne Vollan">pvollan</reporter>
          <assigned_to name="Per Arne Vollan">pvollan</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1725166</commentid>
    <comment_count>0</comment_count>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2021-02-03 09:12:03 -0800</bug_when>
    <thetext>Remove access to com.apple.cvmsServ in the WebContent process when the GPU Process is enabled.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1725174</commentid>
    <comment_count>1</comment_count>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2021-02-03 09:15:53 -0800</bug_when>
    <thetext>&lt;rdar://problem/70495789&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1725176</commentid>
    <comment_count>2</comment_count>
      <attachid>419148</attachid>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2021-02-03 09:17:26 -0800</bug_when>
    <thetext>Created attachment 419148
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1725204</commentid>
    <comment_count>3</comment_count>
      <attachid>419148</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2021-02-03 10:28:34 -0800</bug_when>
    <thetext>Comment on attachment 419148
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419148&amp;action=review

&gt; Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:118
&gt; +    (deny mach-lookup

Is this safe to do on older OS? Should we move the precompile checks around this so we deny on 11+, but allow on older systems?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1725206</commentid>
    <comment_count>4</comment_count>
      <attachid>419148</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2021-02-03 10:30:13 -0800</bug_when>
    <thetext>Comment on attachment 419148
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419148&amp;action=review

r=me

&gt;&gt; Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:118
&gt;&gt; +    (deny mach-lookup
&gt; 
&gt; Is this safe to do on older OS? Should we move the precompile checks around this so we deny on 11+, but allow on older systems?

Oh! never mind. I see that this is only when the service is not extended.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1725213</commentid>
    <comment_count>5</comment_count>
      <attachid>419148</attachid>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2021-02-03 10:34:20 -0800</bug_when>
    <thetext>Comment on attachment 419148
Patch

Thanks for reviewing!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1725219</commentid>
    <comment_count>6</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-02-03 10:39:07 -0800</bug_when>
    <thetext>Committed r272329: &lt;https://trac.webkit.org/changeset/272329&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419148.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>419148</attachid>
            <date>2021-02-03 09:17:26 -0800</date>
            <delta_ts>2021-02-03 10:39:08 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-221336-20210203091725.patch</filename>
            <type>text/plain</type>
            <size>1290</size>
            <attacher name="Per Arne Vollan">pvollan</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL
aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNzIzMTcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv
Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDIxLTAyLTAzICBQZXIgQXJuZSBW
b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbbWFjT1NdIFJlbW92ZSBhY2Nl
c3MgdG8gY29tLmFwcGxlLmN2bXNTZXJ2CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD0yMjEzMzYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzcwNDk1Nzg5
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92
ZSBhY2Nlc3MgdG8gY29tLmFwcGxlLmN2bXNTZXJ2IGluIHRoZSBXZWJDb250ZW50IHByb2Nlc3Mg
d2hlbiB0aGUgR1BVIFByb2Nlc3MgaXMgZW5hYmxlZC4KKworICAgICAgICAqIFdlYlByb2Nlc3Mv
Y29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW46CisKIDIwMjEtMDItMDMgIEFudG9pbmUgUXVpbnQg
IDxncmFvdXRzQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIGEgbG9hZGVyIGZvciA8bW9kZWw+
IHJlc291cmNlcwpJbmRleDogU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQ
cm9jZXNzLnNiLmluCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20u
YXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgkocmV2aXNpb24gMjcyMjA5KQorKysgU291cmNlL1dlYktp
dC9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluCSh3b3JraW5nIGNvcHkpCkBA
IC0xMTUsOCArMTE1LDcgQEAKICAgICAgICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmN2
bXNTZXJ2IikKICAgICAgICAgKQogICAgICkKLSAgICA7OyBUaGlzIGlzIGp1c3QgZm9yIGxvZ2dp
bmcuIFJlbW92ZSB3aGVuIHRoZSBHUFUgcHJvY2VzcyBpcyBlbmFibGVkIGJ5IGRlZmF1bHQuCi0g
ICAgKGFsbG93IG1hY2gtbG9va3VwICh3aXRoIHJlcG9ydCkKKyAgICAoZGVueSBtYWNoLWxvb2t1
cAogI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTEwMDAwCiAgICAgICAg
ICh3aXRoIHRlbGVtZXRyeS1iYWNrdHJhY2UpCiAjZW5kaWYK
</data>

          </attachment>
      

    </bug>

</bugzilla>