221328 2021-02-03 06:09:22 -0800 Make shouldComputeLogicalWidthFromAspectRatioAndInsets writing mode aware 2021-02-04 01:12:14 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 47738 1 rbuis rbuis changseok esprehn+autocc ews-watchlist glenn kondapallykalyan pdr rego webkit-bug-importer oldest_to_newest 1725104 0 rbuis 2021-02-03 06:09:22 -0800 Commit r271061 added support for aspect-ratio on positioned elements, taking into account insets, but it failed to take writing-mode into account when checking insets. This change fixes that by asking logical values. 1725106 1 419128 rbuis 2021-02-03 06:11:49 -0800 Created attachment 419128 Patch 1725550 2 419128 rego 2021-02-04 00:57:01 -0800 Comment on attachment 419128 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419128&action=review r=me, with a nit comment inline. > Source/WebCore/rendering/RenderBox.cpp:5100 > + if (style().width().isAuto() && style().height().isAuto() && !style().logicalTop().isAuto() && !style().logicalBottom().isAuto() && (style().logicalLeft().isAuto() || style().logicalRight().isAuto())) What about logicalWidth() instead of width()? I guess it doesn't really matter as we have an and for width and height, but maybe it'd be worth changing for consistency dunno. 1725551 3 419128 rbuis 2021-02-04 01:00:06 -0800 Comment on attachment 419128 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419128&action=review >> Source/WebCore/rendering/RenderBox.cpp:5100 >> + if (style().width().isAuto() && style().height().isAuto() && !style().logicalTop().isAuto() && !style().logicalBottom().isAuto() && (style().logicalLeft().isAuto() || style().logicalRight().isAuto())) > > What about logicalWidth() instead of width()? I guess it doesn't really matter as we have an and for width and height, but maybe it'd be worth changing for consistency dunno. Interesting idea, but ultimately we need to check both dimensions and using the logical variants is a bit slower. So I'll keep as-is. 1725554 4 ews-feeder 2021-02-04 01:11:34 -0800 Committed r272363: <https://trac.webkit.org/changeset/272363> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419128. 1725555 5 webkit-bug-importer 2021-02-04 01:12:14 -0800 <rdar://problem/73970893> 419128 2021-02-03 06:11:49 -0800 2021-02-04 01:11:35 -0800 Patch bug-221328-20210203151147.patch text/plain 4062 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyMzA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTNhZmE5MTE3MDA3OWFl NjQ3OThmZGRkZGUzNmY0NTMyZTU5Nzk5Zi4uYTczOTcxYjhjOTNjZDE4NmNhNjE4NTFhYjU4Mjc3 NmRhZDkxNjY0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAyLTAzICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgTWFrZSBzaG91bGRDb21wdXRlTG9n aWNhbFdpZHRoRnJvbUFzcGVjdFJhdGlvQW5kSW5zZXRzIHdyaXRpbmcgbW9kZSBhd2FyZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIxMzI4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29tbWl0IHIyNzEw NjEgYWRkZWQgc3VwcG9ydCBmb3IgYXNwZWN0LXJhdGlvIG9uIHBvc2l0aW9uZWQgZWxlbWVudHMs IHRha2luZyBpbnRvIGFjY291bnQKKyAgICAgICAgaW5zZXRzLCBidXQgaXQgZmFpbGVkIHRvIHRh a2Ugd3JpdGluZy1tb2RlIGludG8gYWNjb3VudCB3aGVuIGNoZWNraW5nIGluc2V0cy4gVGhpcyBj aGFuZ2UgZml4ZXMKKyAgICAgICAgdGhhdCBieSBhc2tpbmcgbG9naWNhbCB2YWx1ZXMuCisKKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl ckJveDo6c2hvdWxkQ29tcHV0ZUxvZ2ljYWxXaWR0aEZyb21Bc3BlY3RSYXRpb0FuZEluc2V0cyBj b25zdCk6CisKIDIwMjEtMDItMDMgIFJvYiBCdWlzICA8cmJ1aXNAaWdhbGlhLmNvbT4KIAogICAg ICAgICBTdXBwb3J0IGFzcGVjdC1yYXRpbyBvbiBncmlkIGl0ZW1zCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJCb3guY3BwCmluZGV4IDJmZWVmOWUzMjdmNTBiNTkwZmE4OWExNTJiMTE2M2Nj ZDk1MjJkYTEuLmQ0ZGZmYzVjNTRiOTllODIwYTgxNjNlNzAwNjBiNzc5N2VjNjhkOGMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCkBAIC01MDk3LDcgKzUwOTcsNyBAQCBi b29sIFJlbmRlckJveDo6c2hvdWxkQ29tcHV0ZUxvZ2ljYWxXaWR0aEZyb21Bc3BlY3RSYXRpb0Fu ZEluc2V0cygpIGNvbnN0CiAgICAgaWYgKCFpc091dE9mRmxvd1Bvc2l0aW9uZWQoKSkKICAgICAg ICAgcmV0dXJuIGZhbHNlOwogICAgIC8vIEZJWE1FOiBzZWUgaWYgdGhpcyBjYW4gYmVjb21lIGEg aGVscGVyIG9uIFJlbmRlclN0eWxlLgotICAgIGlmIChzdHlsZSgpLndpZHRoKCkuaXNBdXRvKCkg JiYgc3R5bGUoKS5oZWlnaHQoKS5pc0F1dG8oKSAmJiAhc3R5bGUoKS50b3AoKS5pc0F1dG8oKSAm JiAhc3R5bGUoKS5ib3R0b20oKS5pc0F1dG8oKSAmJiAoc3R5bGUoKS5sZWZ0KCkuaXNBdXRvKCkg fHwgc3R5bGUoKS5yaWdodCgpLmlzQXV0bygpKSkKKyAgICBpZiAoc3R5bGUoKS53aWR0aCgpLmlz QXV0bygpICYmIHN0eWxlKCkuaGVpZ2h0KCkuaXNBdXRvKCkgJiYgIXN0eWxlKCkubG9naWNhbFRv cCgpLmlzQXV0bygpICYmICFzdHlsZSgpLmxvZ2ljYWxCb3R0b20oKS5pc0F1dG8oKSAmJiAoc3R5 bGUoKS5sb2dpY2FsTGVmdCgpLmlzQXV0bygpIHx8IHN0eWxlKCkubG9naWNhbFJpZ2h0KCkuaXNB dXRvKCkpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICByZXR1cm4gZmFsc2U7CiB9CmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5k ZXggMTMzM2MyNWMzMjFiMjQxYWNlZTM3OTc0ZjVlY2ZlNmVhOWU1YTdlYS4uYzI2NzJiMmFiMWVk MGIzOGRhMWE2MzBlOGM4MzkxODIxMzE1ZTI5MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIx LTAyLTAzICBSb2IgQnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgTWFrZSBzaG91 bGRDb21wdXRlTG9naWNhbFdpZHRoRnJvbUFzcGVjdFJhdGlvQW5kSW5zZXRzIHdyaXRpbmcgbW9k ZSBhd2FyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjIxMzI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg RW5hYmxlIHNvbWUgdGVzdHMgdGhhdCBwYXNzIG5vdy4KKworICAgICAgICAqIFRlc3RFeHBlY3Rh dGlvbnM6CisKIDIwMjEtMDItMDMgIFJvYiBCdWlzICA8cmJ1aXNAaWdhbGlhLmNvbT4KIAogICAg ICAgICBTdXBwb3J0IGFzcGVjdC1yYXRpbyBvbiBncmlkIGl0ZW1zCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwpp bmRleCAxZmQ0NDlkMzdiMzgwNDg0ZWY2MmRmNDIzOGFiOWIzMDM4OGY3NjBkLi4wNWNmNzFiMjU4 MzQ0OGYzMWMyMzdlNDJjYmM2ODU0YTg1OTI4ODI2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9U ZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTQ0 MDksMTEgKzQ0MDksOSBAQCB3ZWJraXQub3JnL2IvMjE0NDYyIGltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvY3NzL2Nzcy1zY29waW5nL3NoYWRvdy1kaXJlYwogd2Via2l0Lm9yZy9iLzIx NDQ2MiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3Mtc2NvcGluZy9zaGFk b3ctZGlyZWN0aW9uYWxpdHktMDAyLnRlbnRhdGl2ZS5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBd CiB3ZWJraXQub3JnL2IvMjE0NDYyIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3Nz L2Nzcy1zY29waW5nL3Nsb3R0ZWQtcGxhY2Vob2xkZXIuaHRtbCBbIEltYWdlT25seUZhaWx1cmUg XQogCi13ZWJraXQub3JnL2IvMjE0NDYzIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMv Y3NzL2Nzcy1zaXppbmcvYXNwZWN0LXJhdGlvL2Fic3Bvcy0wMDQuaHRtbCBbIEltYWdlT25seUZh aWx1cmUgXQogd2Via2l0Lm9yZy9iLzIxNDQ2MyBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL2Nzcy9jc3Mtc2l6aW5nL2FzcGVjdC1yYXRpby9hYnNwb3MtMDEyLmh0bWwgWyBJbWFnZU9u bHlGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8yMTQ0NjMgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9y bS10ZXN0cy9jc3MvY3NzLXNpemluZy9hc3BlY3QtcmF0aW8vYWJzcG9zLTAxMy5odG1sIFsgSW1h Z2VPbmx5RmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMjE0NDYzIGltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvY3NzL2Nzcy1zaXppbmcvYXNwZWN0LXJhdGlvL2Fic3Bvcy0wMTQuaHRtbCBb IEltYWdlT25seUZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzIxNDQ2MyBpbXBvcnRlZC93M2Mvd2Vi LXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3Mtc2l6aW5nL2FzcGVjdC1yYXRpby9hYnNwb3MtMDE1Lmh0 bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8yMTQ0NjMgaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLXNpemluZy9hc3BlY3QtcmF0aW8vYmxvY2stYXNw ZWN0LXJhdGlvLTAwNC5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMjE0 NDYzIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1zaXppbmcvYXNwZWN0 LXJhdGlvL2Jsb2NrLWFzcGVjdC1yYXRpby0wMDYuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQog d2Via2l0Lm9yZy9iLzIxNDQ2MyBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9j c3Mtc2l6aW5nL2FzcGVjdC1yYXRpby9ibG9jay1hc3BlY3QtcmF0aW8tMDA5Lmh0bWwgWyBJbWFn ZU9ubHlGYWlsdXJlIF0K