221318 2021-02-02 21:48:08 -0800 Avoid a virtual function call in HTMLInputElement::value() 2021-02-03 18:22:08 -0800 1 1 1 Unclassified WebKit Forms WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser cdumez changseok darin esprehn+autocc ews-watchlist gyuyoung.kim mifenton simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1725014 0 simon.fraser 2021-02-02 21:48:08 -0800 Avoid a virtual function call in HTMLInputElement::value() 1725015 1 419104 simon.fraser 2021-02-02 21:49:25 -0800 Created attachment 419104 Patch 1725042 2 ews-feeder 2021-02-02 23:08:49 -0800 Committed r272298: <https://trac.webkit.org/changeset/272298> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419104. 1725043 3 webkit-bug-importer 2021-02-02 23:09:28 -0800 <rdar://problem/73917640> 1725432 4 419104 darin 2021-02-03 18:22:08 -0800 Comment on attachment 419104 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=419104&action=review > Source/WebCore/html/InputType.h:193 > + bool canHaveTypeSpecificValue() const { return isFileUpload(); } I know this already landed, but I’d instead suggest changing getTypeSpecificValue to do this optimization so callers don’t need to make a separate call. Make it non-virtual and have it call a virtual function. It’s not great that caller has to be careful to call in a certain way. Better if there’s no way to do it wrong. 419104 2021-02-02 21:49:25 -0800 2021-02-02 23:08:51 -0800 Patch bug-221318-20210202214924.patch text/plain 2305 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyMjE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTRiOWUxYzFjNmEzZmVl Y2YyNTJlZTJlNWQ5MGJmN2M4MDY0N2U4MC4uNjFiZjU2Yjk3ODYzYzAxMTFkOGYwYjA1OTliMzYw ZWNiMjcxZTQwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTAyLTAyICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEF2b2lkIGEgdmly dHVhbCBmdW5jdGlvbiBjYWxsIGluIEhUTUxJbnB1dEVsZW1lbnQ6OnZhbHVlKCkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTMxOAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9ubHkgZmlsZSB1cGxvYWQg Y29udHJvbHMgb3ZlcnJpZGUgZ2V0VHlwZVNwZWNpZmljVmFsdWUoKSwgc28gdG8gYXZvaWQgYSB2 aXJ0dWFsCisgICAgICAgIGZ1bmN0aW9uIGNhbGwsIGNoZWNrIHRoZSB0eXBlIGZpcnN0IHZpYSBj YW5IYXZlVHlwZVNwZWNpZmljVmFsdWUoKS4KKworICAgICAgICAqIGh0bWwvSFRNTElucHV0RWxl bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50Ojp2YWx1ZSBjb25z dCk6CisgICAgICAgICogaHRtbC9JbnB1dFR5cGUuaDoKKyAgICAgICAgKFdlYkNvcmU6OklucHV0 VHlwZTo6Y2FuSGF2ZVR5cGVTcGVjaWZpY1ZhbHVlIGNvbnN0KToKKwogMjAyMS0wMi0wMiAgU2lt b24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5hbWUgSFRN TEZvcm1Db250cm9sRWxlbWVudDo6c2V0TmVlZHNXaWxsVmFsaWRhdGVDaGVjaygpIHRvIHVwZGF0 ZVdpbGxWYWxpZGF0ZUFuZFZhbGlkaXR5KCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTElucHV0RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVs ZW1lbnQuY3BwCmluZGV4IDlkMGM1MDJkM2UyY2U0NmI2OGNhOWE1NDZmOTY4ZDhhMzYwZDA2M2Eu LjA0M2U0MmU1ODZmMDNiNmQwN2VhNmViOGIwYmJjODc1Y2M3ZWU4MTIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcApAQCAtMTAxNyw3ICsxMDE3LDcgQEAgdm9pZCBI VE1MSW5wdXRFbGVtZW50Ojpjb3B5Tm9uQXR0cmlidXRlUHJvcGVydGllc0Zyb21FbGVtZW50KGNv bnN0IEVsZW1lbnQmIHNvdXIKIFN0cmluZyBIVE1MSW5wdXRFbGVtZW50Ojp2YWx1ZSgpIGNvbnN0 CiB7CiAgICAgU3RyaW5nIHZhbHVlOwotICAgIGlmIChtX2lucHV0VHlwZS0+Z2V0VHlwZVNwZWNp ZmljVmFsdWUodmFsdWUpKQorICAgIGlmIChtX2lucHV0VHlwZS0+Y2FuSGF2ZVR5cGVTcGVjaWZp Y1ZhbHVlKCkgJiYgbV9pbnB1dFR5cGUtPmdldFR5cGVTcGVjaWZpY1ZhbHVlKHZhbHVlKSkKICAg ICAgICAgcmV0dXJuIHZhbHVlOwogCiAgICAgdmFsdWUgPSBtX3ZhbHVlSWZEaXJ0eTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW5wdXRUeXBlLmggYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL0lucHV0VHlwZS5oCmluZGV4IDRmNmNjMzIyNTZkODVhOGRkOTg1MWY3MzY2MTYxZTFhMWFk YjE3YjEuLjliOGRmNDkzMDMxNGU1YjQwNTY5MTM4NDRlNzkyMTQ2ZmUxZTZmYzQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSW5wdXRUeXBlLmgKKysrIGIvU291cmNlL1dlYkNvcmUv aHRtbC9JbnB1dFR5cGUuaApAQCAtMTkwLDYgKzE5MCw3IEBAIHB1YmxpYzoKICAgICBib29sIGlz Q2hlY2thYmxlKCkgY29uc3QgeyByZXR1cm4gY2hlY2thYmxlVHlwZXMuY29udGFpbnMobV90eXBl KTsgfQogICAgIGJvb2wgaXNTdGVwcGFibGUoKSBjb25zdCB7IHJldHVybiBzdGVwcGFibGVUeXBl cy5jb250YWlucyhtX3R5cGUpOyB9CiAgICAgYm9vbCBzdXBwb3J0c1ZhbGlkYXRpb24oKSBjb25z dCB7IHJldHVybiAhbm9uVmFsaWRhdGluZ1R5cGVzLmNvbnRhaW5zKG1fdHlwZSk7IH0KKyAgICBi b29sIGNhbkhhdmVUeXBlU3BlY2lmaWNWYWx1ZSgpIGNvbnN0IHsgcmV0dXJuIGlzRmlsZVVwbG9h ZCgpOyB9CiAKICAgICBib29sIGlzSW50ZXJhY3RpdmVDb250ZW50KCkgY29uc3Q7CiAgICAgYm9v bCBzdXBwb3J0TGFiZWxzKCkgY29uc3Q7Cg==