221297 2021-02-02 14:34:10 -0800 Rename HTMLFormControlElement::setNeedsWillValidateCheck() to updateWillValidateAndValidity() 2021-02-02 17:34:14 -0800 1 1 1 Unclassified WebKit Forms WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser cdumez changseok esprehn+autocc ews-watchlist gyuyoung.kim mifenton simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1724896 0 simon.fraser 2021-02-02 14:34:10 -0800 Rename HTMLFormControlElement::setNeedsWillValidateCheck() to updateWillValidateAndValidity() 1724897 1 419068 simon.fraser 2021-02-02 14:34:49 -0800 Created attachment 419068 Patch 1724971 2 ews-feeder 2021-02-02 17:33:02 -0800 Committed r272247: <https://trac.webkit.org/changeset/272247> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419068. 1724972 3 webkit-bug-importer 2021-02-02 17:34:14 -0800 <rdar://problem/73907673> 419068 2021-02-02 14:34:49 -0800 2021-02-02 17:33:04 -0800 Patch bug-221297-20210202143448.patch text/plain 6978 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyMjE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2M3ZDM3MmQ1YmY4YjJh ZTQ4MjcwNTQ0MTQxNTQ1YzQ1ZmFiNjQ3Ny4uODBiYTQ4ZTJkMjc1N2I1OTY5NGMxYjQyZDRjZjM5 ODliNjBjMWJhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDIxLTAyLTAyICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJlbmFtZSBIVE1M Rm9ybUNvbnRyb2xFbGVtZW50OjpzZXROZWVkc1dpbGxWYWxpZGF0ZUNoZWNrKCkgdG8gdXBkYXRl V2lsbFZhbGlkYXRlQW5kVmFsaWRpdHkoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjIxMjk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgU2ltcGxlIHJlbmFtZTogc2V0TmVlZHNXaWxsVmFsaWRhdGVDaGVj aygpIGVhZ2VybHkgdXBkYXRlZCBib3RoICd3aWxsVmFsaWQnIGFuZCAnaXNWYWxpZCcKKyAgICAg ICAgc28gY2FsbCBpdCB3aGF0IGl0IGlzLgorCisgICAgICAgICogaHRtbC9IVE1MQnV0dG9uRWxl bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MQnV0dG9uRWxlbWVudDo6cGFyc2VBdHRy aWJ1dGUpOgorICAgICAgICAqIGh0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpIVE1MRm9ybUNvbnRyb2xFbGVtZW50OjpkaXNhYmxlZFN0YXRlQ2hhbmdl ZCk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRm9ybUNvbnRyb2xFbGVtZW50OjpyZWFkT25seVN0 YXRlQ2hhbmdlZCk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRm9ybUNvbnRyb2xFbGVtZW50Ojpp bnNlcnRlZEludG9BbmNlc3Rvcik6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRm9ybUNvbnRyb2xF bGVtZW50OjpyZW1vdmVkRnJvbUFuY2VzdG9yKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxGb3Jt Q29udHJvbEVsZW1lbnQ6OndpbGxWYWxpZGF0ZSBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpI VE1MRm9ybUNvbnRyb2xFbGVtZW50Ojp1cGRhdGVXaWxsVmFsaWRhdGVBbmRWYWxpZGl0eSk6Cisg ICAgICAgIChXZWJDb3JlOjpIVE1MRm9ybUNvbnRyb2xFbGVtZW50OjpzZXROZWVkc1dpbGxWYWxp ZGF0ZUNoZWNrKTogRGVsZXRlZC4KKyAgICAgICAgKiBodG1sL0hUTUxGb3JtQ29udHJvbEVsZW1l bnQuaDoKKyAgICAgICAgKiBodG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6SFRNTElucHV0RWxlbWVudDo6dXBkYXRlVHlwZSk6CisgICAgICAgIChXZWJDb3JlOjpI VE1MSW5wdXRFbGVtZW50Ojppbml0aWFsaXplSW5wdXRUeXBlKToKKwogMjAyMS0wMi0wMiAgQ2hy aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFByb21vdGUgZGVidWcgYXNz ZXJ0aW9uIHRvIHJlbGVhc2UgYXNzZXJ0aW9uIGluIGNvb2tpZXNGb3JVUkwoKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQnV0dG9uRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxCdXR0b25FbGVtZW50LmNwcAppbmRleCAzNjRhNzI3ODdkNjQ4ZjczMDVh NTJhMDM4ZDBlODc1OTQ5M2JhZTI3Li43NDkzODQ5ZTc5MGI3NmRhYTM4YTE4NWM0MGIzOTJlMjFl NjllMDQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxCdXR0b25FbGVtZW50 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxCdXR0b25FbGVtZW50LmNwcApAQCAt MTE3LDcgKzExNyw3IEBAIHZvaWQgSFRNTEJ1dHRvbkVsZW1lbnQ6OnBhcnNlQXR0cmlidXRlKGNv bnN0IFF1YWxpZmllZE5hbWUmIG5hbWUsIGNvbnN0IEF0b21TdHJpCiAgICAgICAgIGVsc2UKICAg ICAgICAgICAgIG1fdHlwZSA9IFNVQk1JVDsKICAgICAgICAgaWYgKG9sZFR5cGUgIT0gbV90eXBl KSB7Ci0gICAgICAgICAgICBzZXROZWVkc1dpbGxWYWxpZGF0ZUNoZWNrKCk7CisgICAgICAgICAg ICB1cGRhdGVXaWxsVmFsaWRhdGVBbmRWYWxpZGl0eSgpOwogICAgICAgICAgICAgaWYgKGZvcm0o KSAmJiAob2xkVHlwZSA9PSBTVUJNSVQgfHwgbV90eXBlID09IFNVQk1JVCkpCiAgICAgICAgICAg ICAgICAgZm9ybSgpLT5yZXNldERlZmF1bHRCdXR0b24oKTsKICAgICAgICAgfQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5jcHAKaW5kZXggODZiNjVjMDVi NTJmNmVkOTI1OGE0ODYyMzVlMDkyMTI0NWU1MGE1Zi4uMTlkZDk3NmIxOWJmNjNlMThjMWM0MzBj YjRmMmI5ZjIyYTE0YjM2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9y bUNvbnRyb2xFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29u dHJvbEVsZW1lbnQuY3BwCkBAIC0xODAsNyArMTgwLDcgQEAgdm9pZCBIVE1MRm9ybUNvbnRyb2xF bGVtZW50OjpkaXNhYmxlZEF0dHJpYnV0ZUNoYW5nZWQoKQogCiB2b2lkIEhUTUxGb3JtQ29udHJv bEVsZW1lbnQ6OmRpc2FibGVkU3RhdGVDaGFuZ2VkKCkKIHsKLSAgICBzZXROZWVkc1dpbGxWYWxp ZGF0ZUNoZWNrKCk7CisgICAgdXBkYXRlV2lsbFZhbGlkYXRlQW5kVmFsaWRpdHkoKTsKICAgICBp bnZhbGlkYXRlU3R5bGVGb3JTdWJ0cmVlKCk7CiAgICAgaWYgKHJlbmRlcmVyKCkgJiYgcmVuZGVy ZXIoKS0+c3R5bGUoKS5oYXNBcHBlYXJhbmNlKCkpCiAgICAgICAgIHJlbmRlcmVyKCktPnRoZW1l KCkuc3RhdGVDaGFuZ2VkKCpyZW5kZXJlcigpLCBDb250cm9sU3RhdGVzOjpFbmFibGVkU3RhdGUp OwpAQCAtMTg4LDcgKzE4OCw3IEBAIHZvaWQgSFRNTEZvcm1Db250cm9sRWxlbWVudDo6ZGlzYWJs ZWRTdGF0ZUNoYW5nZWQoKQogCiB2b2lkIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OnJlYWRPbmx5 U3RhdGVDaGFuZ2VkKCkKIHsKLSAgICBzZXROZWVkc1dpbGxWYWxpZGF0ZUNoZWNrKCk7CisgICAg dXBkYXRlV2lsbFZhbGlkYXRlQW5kVmFsaWRpdHkoKTsKICAgICBpbnZhbGlkYXRlU3R5bGVGb3JT dWJ0cmVlKCk7CiB9CiAKQEAgLTI5Myw3ICsyOTMsNyBAQCBOb2RlOjpJbnNlcnRlZEludG9BbmNl c3RvclJlc3VsdCBIVE1MRm9ybUNvbnRyb2xFbGVtZW50OjppbnNlcnRlZEludG9BbmNlc3RvcihJ bgogICAgIGlmIChtX2RhdGFMaXN0QW5jZXN0b3JTdGF0ZSA9PSBOb3RJbnNpZGVEYXRhTGlzdCkK ICAgICAgICAgbV9kYXRhTGlzdEFuY2VzdG9yU3RhdGUgPSBVbmtub3duOwogCi0gICAgc2V0TmVl ZHNXaWxsVmFsaWRhdGVDaGVjaygpOworICAgIHVwZGF0ZVdpbGxWYWxpZGF0ZUFuZFZhbGlkaXR5 KCk7CiAgICAgaWYgKHdpbGxWYWxpZGF0ZSgpICYmICFpc1ZhbGlkRm9ybUNvbnRyb2xFbGVtZW50 KCkpCiAgICAgICAgIGFkZEludmFsaWRFbGVtZW50VG9BbmNlc3RvckZyb21JbnNlcnRpb25Qb2lu dCgqdGhpcywgJnBhcmVudE9mSW5zZXJ0ZWRUcmVlKTsKICAgICBpZiAoZG9jdW1lbnQoKS5oYXNE aXNhYmxlZEZpZWxkc2V0RWxlbWVudCgpKQpAQCAtMzI5LDcgKzMyOSw3IEBAIHZvaWQgSFRNTEZv cm1Db250cm9sRWxlbWVudDo6cmVtb3ZlZEZyb21BbmNlc3RvcihSZW1vdmFsVHlwZSByZW1vdmFs VHlwZSwgQ29udGFpCiAgICAgICAgIHJlbW92ZUludmFsaWRFbGVtZW50VG9BbmNlc3RvckZyb21J bnNlcnRpb25Qb2ludCgqdGhpcywgJm9sZFBhcmVudE9mUmVtb3ZlZFRyZWUpOwogCiAgICAgaWYg KHdhc0luc2lkZURhdGFMaXN0KQotICAgICAgICBzZXROZWVkc1dpbGxWYWxpZGF0ZUNoZWNrKCk7 CisgICAgICAgIHVwZGF0ZVdpbGxWYWxpZGF0ZUFuZFZhbGlkaXR5KCk7CiB9CiAKIHZvaWQgSFRN TEZvcm1Db250cm9sRWxlbWVudDo6c2V0Q2hhbmdlZFNpbmNlTGFzdEZvcm1Db250cm9sQ2hhbmdl RXZlbnQoYm9vbCBjaGFuZ2VkKQpAQCAtNDMxLDcgKzQzMSw3IEBAIGJvb2wgSFRNTEZvcm1Db250 cm9sRWxlbWVudDo6d2lsbFZhbGlkYXRlKCkgY29uc3QKICAgICAgICAgaWYgKG1fd2lsbFZhbGlk YXRlICE9IG5ld1dpbGxWYWxpZGF0ZSkKICAgICAgICAgICAgIG1fd2lsbFZhbGlkYXRlID0gbmV3 V2lsbFZhbGlkYXRlOwogICAgIH0gZWxzZSB7Ci0gICAgICAgIC8vIElmIHRoZSBmb2xsb3dpbmcg YXNzZXJ0aW9uIGZhaWxzLCBzZXROZWVkc1dpbGxWYWxpZGF0ZUNoZWNrKCkgaXMgbm90CisgICAg ICAgIC8vIElmIHRoZSBmb2xsb3dpbmcgYXNzZXJ0aW9uIGZhaWxzLCB1cGRhdGVXaWxsVmFsaWRh dGVBbmRWYWxpZGl0eSgpIGlzIG5vdAogICAgICAgICAvLyBjYWxsZWQgY29ycmVjdGx5IHdoZW4g c29tZXRoaW5nIHdoaWNoIGNoYW5nZXMgY29tcHV0ZVdpbGxWYWxpZGF0ZSgpIHJlc3VsdAogICAg ICAgICAvLyBpcyB1cGRhdGVkLgogICAgICAgICBBU1NFUlQobV93aWxsVmFsaWRhdGUgPT0gY29t cHV0ZVdpbGxWYWxpZGF0ZSgpKTsKQEAgLTQzOSw3ICs0MzksNyBAQCBib29sIEhUTUxGb3JtQ29u dHJvbEVsZW1lbnQ6OndpbGxWYWxpZGF0ZSgpIGNvbnN0CiAgICAgcmV0dXJuIG1fd2lsbFZhbGlk YXRlOwogfQogCi12b2lkIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OnNldE5lZWRzV2lsbFZhbGlk YXRlQ2hlY2soKQordm9pZCBIVE1MRm9ybUNvbnRyb2xFbGVtZW50Ojp1cGRhdGVXaWxsVmFsaWRh dGVBbmRWYWxpZGl0eSgpCiB7CiAgICAgLy8gV2UgbmVlZCB0byByZWNhbGN1bGF0ZSB3aWxsVmFs aWRhdGUgaW1tZWRpYXRlbHkgYmVjYXVzZSB3aWxsVmFsaWRhdGUgY2hhbmdlIGNhbiBjYXVzZXMg c3R5bGUgY2hhbmdlLgogICAgIGJvb2wgbmV3V2lsbFZhbGlkYXRlID0gY29tcHV0ZVdpbGxWYWxp ZGF0ZSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xF bGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuaApp bmRleCBiOTcxODRiZmY2NDMwNGE2MTJkMWU3NzY1ZTVmZWZkMzgzODA5ZDMxLi4zOThkZjBhOTBm M2NkNmU2YzNhNDQxYzhhMTg1MjhiNjdjZDg3MGE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxGb3JtQ29udHJvbEVsZW1lbnQuaApAQCAtMTUzLDcgKzE1Myw3IEBAIHByb3RlY3RlZDoK ICAgICB2b2lkIGRpc3BhdGNoQmx1ckV2ZW50KFJlZlB0cjxFbGVtZW50PiYmIG5ld0ZvY3VzZWRF bGVtZW50KSBvdmVycmlkZTsKIAogICAgIC8vIFRoaXMgbXVzdCBiZSBjYWxsZWQgYW55IHRpbWUg dGhlIHJlc3VsdCBvZiB3aWxsVmFsaWRhdGUoKSBoYXMgY2hhbmdlZC4KLSAgICB2b2lkIHNldE5l ZWRzV2lsbFZhbGlkYXRlQ2hlY2soKTsKKyAgICB2b2lkIHVwZGF0ZVdpbGxWYWxpZGF0ZUFuZFZh bGlkaXR5KCk7CiAgICAgdmlydHVhbCBib29sIGNvbXB1dGVXaWxsVmFsaWRhdGUoKSBjb25zdDsK IAogICAgIGJvb2wgdmFsaWRhdGlvbk1lc3NhZ2VTaGFkb3dUcmVlQ29udGFpbnMoY29uc3QgTm9k ZSYpIGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVt ZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKaW5kZXgg ZjVkNDkxYjZjNWQ3NGMwNDAwMmUyNTllMWQ1ZDc3NDIxYTg2MDA1Yy4uOWQwYzUwMmQzZTJjZTQ2 YjY4Y2E5YTU0NmY5NjhkOGEzNjBkMDYzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MSW5wdXRFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxJbnB1 dEVsZW1lbnQuY3BwCkBAIC01NjMsNyArNTYzLDcgQEAgdm9pZCBIVE1MSW5wdXRFbGVtZW50Ojp1 cGRhdGVUeXBlKCkKICAgICBtX2lucHV0VHlwZSA9IFdURk1vdmUobmV3VHlwZSk7CiAgICAgbV9p bnB1dFR5cGUtPmNyZWF0ZVNoYWRvd1N1YnRyZWVBbmRVcGRhdGVJbm5lclRleHRFbGVtZW50RWRp dGFiaWxpdHkobV9wYXJzaW5nSW5Qcm9ncmVzcyA/IENoaWxkQ2hhbmdlOjpTb3VyY2U6OlBhcnNl ciA6IENoaWxkQ2hhbmdlOjpTb3VyY2U6OkFQSSwgaXNJbm5lclRleHRFbGVtZW50RWRpdGFibGUo KSk7CiAKLSAgICBzZXROZWVkc1dpbGxWYWxpZGF0ZUNoZWNrKCk7CisgICAgdXBkYXRlV2lsbFZh bGlkYXRlQW5kVmFsaWRpdHkoKTsKIAogICAgIGlmICghZGlkU3RvcmVWYWx1ZSAmJiB3aWxsU3Rv cmVWYWx1ZSkKICAgICAgICAgbV92YWx1ZUlmRGlydHkgPSBzYW5pdGl6ZVZhbHVlKGF0dHJpYnV0 ZVdpdGhvdXRTeW5jaHJvbml6YXRpb24odmFsdWVBdHRyKSk7CkBAIC03MTEsMTQgKzcxMSwxNCBA QCBpbmxpbmUgdm9pZCBIVE1MSW5wdXRFbGVtZW50Ojppbml0aWFsaXplSW5wdXRUeXBlKCkKICAg ICBpZiAodHlwZS5pc051bGwoKSkgewogICAgICAgICBtX2lucHV0VHlwZSA9IElucHV0VHlwZTo6 Y3JlYXRlVGV4dCgqdGhpcyk7CiAgICAgICAgIGVuc3VyZVVzZXJBZ2VudFNoYWRvd1Jvb3QoKTsK LSAgICAgICAgc2V0TmVlZHNXaWxsVmFsaWRhdGVDaGVjaygpOworICAgICAgICB1cGRhdGVXaWxs VmFsaWRhdGVBbmRWYWxpZGl0eSgpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCiAgICAgbV9o YXNUeXBlID0gdHJ1ZTsKICAgICBtX2lucHV0VHlwZSA9IElucHV0VHlwZTo6Y3JlYXRlKCp0aGlz LCB0eXBlKTsKICAgICBlbnN1cmVVc2VyQWdlbnRTaGFkb3dSb290KCk7Ci0gICAgc2V0TmVlZHNX aWxsVmFsaWRhdGVDaGVjaygpOworICAgIHVwZGF0ZVdpbGxWYWxpZGF0ZUFuZFZhbGlkaXR5KCk7 CiAgICAgcmVnaXN0ZXJGb3JTdXNwZW5zaW9uQ2FsbGJhY2tJZk5lZWRlZCgpOwogICAgIHJ1blBv c3RUeXBlVXBkYXRlVGFza3MoKTsKIH0K