22129 2008-11-07 12:33:22 -0800 Move CTI::isConstant() to CodeBlock 2008-11-07 12:43:25 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 zwarich zwarich oldest_to_newest 97955 0 zwarich 2008-11-07 12:33:22 -0800 We should move CTI::isConstant() to CodeBlock in preparation for fixing bug 21801. 97956 1 24970 zwarich 2008-11-07 12:36:15 -0800 Created attachment 24970 Proposed patch 97957 2 24970 ggaren 2008-11-07 12:37:40 -0800 Comment on attachment 24970 Proposed patch r=me 97958 3 zwarich 2008-11-07 12:43:25 -0800 Landed in r38229. 24970 2008-11-07 12:36:15 -0800 2008-11-07 12:37:40 -0800 Proposed patch isconstant.diff text/plain 4514 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM4MjI4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDgtMTEt MDcgIENhbWVyb24gWndhcmljaCAgPHp3YXJpY2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAyMjEyOTogTW92ZSBDVEk6Omlz Q29uc3RhbnQoKSB0byBDb2RlQmxvY2sKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMjEyOT4KKworICAgICAgICAqIFZNL0NUSS5jcHA6CisgICAgICAg IChKU0M6OkNUSTo6ZW1pdEdldEFyZyk6CisgICAgICAgIChKU0M6OkNUSTo6ZW1pdEdldFB1dEFy Zyk6CisgICAgICAgIChKU0M6OkNUSTo6Z2V0Q29uc3RhbnRJbW1lZGlhdGVOdW1lcmljQXJnKToK KyAgICAgICAgKEpTQzo6Q1RJOjpwcmludE9wY29kZU9wZXJhbmRUeXBlcyk6CisgICAgICAgIChK U0M6OkNUSTo6cHJpdmF0ZUNvbXBpbGVNYWluUGFzcyk6CisgICAgICAgICogVk0vQ1RJLmg6Cisg ICAgICAgICogVk0vQ29kZUJsb2NrLmg6CisgICAgICAgIChKU0M6OkNvZGVCbG9jazo6aXNDb25z dGFudCk6CisKIDIwMDgtMTEtMDcgIEFscCBUb2tlciAgPGFscEBudWFudGkuY29tPgogCiAgICAg ICAgIGF1dG90b29scyBmaXguIEFsd2F5cyB1c2UgdGhlIGNvbmZpZ3VyZWQgcGVybCBiaW5hcnkg KHdoaWNoIG1heSBiZQpJbmRleDogVk0vQ1RJLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBWTS9DVEkuY3Bw CShyZXZpc2lvbiAzODIyOCkKKysrIFZNL0NUSS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE2OCwx MSArMTY4LDYgQEAgZXh0ZXJuICJDIiB7CiAKICNlbmRpZgogCi1BTFdBWVNfSU5MSU5FIGJvb2wg Q1RJOjppc0NvbnN0YW50KGludCBzcmMpCi17Ci0gICAgcmV0dXJuIHNyYyA+PSBtX2NvZGVCbG9j ay0+bnVtVmFycyAmJiBzcmMgPCBtX2NvZGVCbG9jay0+bnVtVmFycyArIG1fY29kZUJsb2NrLT5u dW1Db25zdGFudHM7Ci19Ci0KIEFMV0FZU19JTkxJTkUgSlNWYWx1ZSogQ1RJOjpnZXRDb25zdGFu dChDYWxsRnJhbWUqIGNhbGxGcmFtZSwgaW50IHNyYykKIHsKICAgICByZXR1cm4gbV9jb2RlQmxv Y2stPmNvbnN0YW50UmVnaXN0ZXJzW3NyYyAtIG1fY29kZUJsb2NrLT5udW1WYXJzXS5qc1ZhbHVl KGNhbGxGcmFtZSk7CkBAIC0xODcsNyArMTgyLDcgQEAgaW5saW5lIHVpbnRwdHJfdCBDVEk6OmFz SW50ZWdlcihKU1ZhbHVlKgogQUxXQVlTX0lOTElORSB2b2lkIENUSTo6ZW1pdEdldEFyZyhpbnQg c3JjLCBYODZBc3NlbWJsZXI6OlJlZ2lzdGVySUQgZHN0KQogewogICAgIC8vIFRPRE86IHdlIHdh bnQgdG8gcmV1c2UgdmFsdWVzIHRoYXQgYXJlIGFscmVhZHkgaW4gcmVnaXN0ZXJzIGlmIHdlIGNh biAtIGFkZCBhIHJlZ2lzdGVyIGFsbG9jYXRvciEKLSAgICBpZiAoaXNDb25zdGFudChzcmMpKSB7 CisgICAgaWYgKG1fY29kZUJsb2NrLT5pc0NvbnN0YW50KHNyYykpIHsKICAgICAgICAgSlNWYWx1 ZSoganMgPSBnZXRDb25zdGFudChtX2NhbGxGcmFtZSwgc3JjKTsKICAgICAgICAgbV9qaXQubW92 bF9pMzJyKGFzSW50ZWdlcihqcyksIGRzdCk7CiAgICAgfSBlbHNlCkBAIC0xOTcsNyArMTkyLDcg QEAgQUxXQVlTX0lOTElORSB2b2lkIENUSTo6ZW1pdEdldEFyZyhpbnQgcwogLy8gZ2V0IGFyZyBw dXRzIGFuIGFyZyBmcm9tIHRoZSBTRiByZWdpc3RlciBhcnJheSBvbnRvIHRoZSBzdGFjaywgYXMg YW4gYXJnIHRvIGEgY29udGV4dCB0aHJlYWRlZCBmdW5jdGlvbi4KIEFMV0FZU19JTkxJTkUgdm9p ZCBDVEk6OmVtaXRHZXRQdXRBcmcodW5zaWduZWQgc3JjLCB1bnNpZ25lZCBvZmZzZXQsIFg4NkFz c2VtYmxlcjo6UmVnaXN0ZXJJRCBzY3JhdGNoKQogewotICAgIGlmIChpc0NvbnN0YW50KHNyYykp IHsKKyAgICBpZiAobV9jb2RlQmxvY2stPmlzQ29uc3RhbnQoc3JjKSkgewogICAgICAgICBKU1Zh bHVlKiBqcyA9IGdldENvbnN0YW50KG1fY2FsbEZyYW1lLCBzcmMpOwogICAgICAgICBtX2ppdC5t b3ZsX2kzMm0oYXNJbnRlZ2VyKGpzKSwgb2Zmc2V0ICsgc2l6ZW9mKHZvaWQqKSwgWDg2Ojplc3Ap OwogICAgIH0gZWxzZSB7CkBAIC0yMTksNyArMjE0LDcgQEAgQUxXQVlTX0lOTElORSB2b2lkIENU STo6ZW1pdFB1dEFyZ0NvbnN0YQogCiBBTFdBWVNfSU5MSU5FIEpTVmFsdWUqIENUSTo6Z2V0Q29u c3RhbnRJbW1lZGlhdGVOdW1lcmljQXJnKHVuc2lnbmVkIHNyYykKIHsKLSAgICBpZiAoaXNDb25z dGFudChzcmMpKSB7CisgICAgaWYgKG1fY29kZUJsb2NrLT5pc0NvbnN0YW50KHNyYykpIHsKICAg ICAgICAgSlNWYWx1ZSoganMgPSBnZXRDb25zdGFudChtX2NhbGxGcmFtZSwgc3JjKTsKICAgICAg ICAgcmV0dXJuIEpTSW1tZWRpYXRlOjppc051bWJlcihqcykgPyBqcyA6IG5vVmFsdWUoKTsKICAg ICB9CkBAIC0yNzgsNyArMjczLDcgQEAgdm9pZCBjdGlSZXBhdGNoQ2FsbEJ5UmV0dXJuQWRkcmVz cyh2b2lkKgogdm9pZCBDVEk6OnByaW50T3Bjb2RlT3BlcmFuZFR5cGVzKHVuc2lnbmVkIHNyYzEs IHVuc2lnbmVkIHNyYzIpCiB7CiAgICAgY2hhciB3aGljaDEgPSAnKic7Ci0gICAgaWYgKGlzQ29u c3RhbnQoc3JjMSkpIHsKKyAgICBpZiAobV9jb2RlQmxvY2stPmlzQ29uc3RhbnQoc3JjMSkpIHsK ICAgICAgICAgSlNWYWx1ZSoganMgPSBnZXRDb25zdGFudChtX2NhbGxGcmFtZSwgc3JjMSk7CiAg ICAgICAgIHdoaWNoMSA9IAogICAgICAgICAgICAgSlNJbW1lZGlhdGU6OmlzSW1tZWRpYXRlKGpz KSA/CkBAIC0yOTIsNyArMjg3LDcgQEAgdm9pZCBDVEk6OnByaW50T3Bjb2RlT3BlcmFuZFR5cGVz KHVuc2lnbgogICAgICAgICAgICAgJ2snKTsKICAgICB9CiAgICAgY2hhciB3aGljaDIgPSAnKic7 Ci0gICAgaWYgKGlzQ29uc3RhbnQoc3JjMikpIHsKKyAgICBpZiAobV9jb2RlQmxvY2stPmlzQ29u c3RhbnQoc3JjMikpIHsKICAgICAgICAgSlNWYWx1ZSoganMgPSBnZXRDb25zdGFudChtX2NhbGxG cmFtZSwgc3JjMik7CiAgICAgICAgIHdoaWNoMiA9IAogICAgICAgICAgICAgSlNJbW1lZGlhdGU6 OmlzSW1tZWRpYXRlKGpzKSA/CkBAIC0xMDA2LDcgKzEwMDEsNyBAQCB2b2lkIENUSTo6cHJpdmF0 ZUNvbXBpbGVNYWluUGFzcygpCiAgICAgICAgIHN3aXRjaCAob3Bjb2RlSUQpIHsKICAgICAgICAg Y2FzZSBvcF9tb3Y6IHsKICAgICAgICAgICAgIHVuc2lnbmVkIHNyYyA9IGluc3RydWN0aW9uW2kg KyAyXS51Lm9wZXJhbmQ7Ci0gICAgICAgICAgICBpZiAoaXNDb25zdGFudChzcmMpKQorICAgICAg ICAgICAgaWYgKG1fY29kZUJsb2NrLT5pc0NvbnN0YW50KHNyYykpCiAgICAgICAgICAgICAgICAg bV9qaXQubW92bF9pMzJyKGFzSW50ZWdlcihnZXRDb25zdGFudChtX2NhbGxGcmFtZSwgc3JjKSks IFg4Njo6ZWF4KTsKICAgICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICBlbWl0R2V0QXJn KHNyYywgWDg2OjplYXgpOwpJbmRleDogVk0vQ1RJLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVk0vQ1RJLmgJ KHJldmlzaW9uIDM4MjI4KQorKysgVk0vQ1RJLmgJKHdvcmtpbmcgY29weSkKQEAgLTM1Nyw3ICsz NTcsNiBAQCBuYW1lc3BhY2UgSlNDIHsKIAogICAgICAgICBzdGF0aWMgdWludHB0cl90IGFzSW50 ZWdlcihKU1ZhbHVlKik7CiAKLSAgICAgICAgYm9vbCBpc0NvbnN0YW50KGludCBzcmMpOwogICAg ICAgICBKU1ZhbHVlKiBnZXRDb25zdGFudChDYWxsRnJhbWUqLCBpbnQgc3JjKTsKIAogICAgICAg ICB2b2lkIHByaXZhdGVDb21waWxlTWFpblBhc3MoKTsKSW5kZXg6IFZNL0NvZGVCbG9jay5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFZNL0NvZGVCbG9jay5oCShyZXZpc2lvbiAzODIyOCkKKysrIFZNL0NvZGVC bG9jay5oCSh3b3JraW5nIGNvcHkpCkBAIC0yODksNiArMjg5LDExIEBAIG5hbWVzcGFjZSBKU0Mg ewogICAgICAgICAgICAgbGlua2VkQ2FsbGVyTGlzdC5zaHJpbmsobGFzdFBvcyk7CiAgICAgICAg IH0KIAorICAgICAgICBBTFdBWVNfSU5MSU5FIGJvb2wgaXNDb25zdGFudChpbnQgaW5kZXgpCisg ICAgICAgIHsKKyAgICAgICAgICAgIHJldHVybiBpbmRleCA+PSBudW1WYXJzICYmIGluZGV4IDwg bnVtVmFycyArIG51bUNvbnN0YW50czsKKyAgICAgICAgfQorCiAjaWYgIWRlZmluZWQoTkRFQlVH KSB8fCBFTkFCTEVfT1BDT0RFX1NBTVBMSU5HCiAgICAgICAgIHZvaWQgZHVtcChFeGVjU3RhdGUq KSBjb25zdDsKICAgICAgICAgdm9pZCBwcmludFN0cnVjdHVyZUlEcyhjb25zdCBJbnN0cnVjdGlv biopIGNvbnN0Owo=