221269 2021-02-02 10:18:45 -0800 [ews] Commit queue failure message should indicate that cq+ flag can be set again 2021-02-03 08:10:29 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1724732 0 aakash_jain 2021-02-02 10:18:45 -0800 Commit queue failure message should indicate that cq+ flag can be set again. Recently after moving to github, we have seen increase in intermittent issues on commit-queue. The failure message which commit-queue post on bugs is very generic. Many people might not know that they can set cq+ flag again to have commit-queue try again. Commit-queue failure message should be updated to indicate that. Separately, we should fix the root-cause of the intermittent issues. 1724734 1 419023 aakash_jain 2021-02-02 10:19:56 -0800 Created attachment 419023 Patch 1724815 2 ews-feeder 2021-02-02 12:34:39 -0800 commit-queue failed to commit attachment 419023 to WebKit repository. 1724901 3 ews-feeder 2021-02-02 14:38:31 -0800 Committed r272238: <https://trac.webkit.org/changeset/272238> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419023. 1724902 4 webkit-bug-importer 2021-02-02 14:39:23 -0800 <rdar://problem/73899548> 1725144 5 aakash_jain 2021-02-03 08:10:29 -0800 Working fine, e.g.: https://bugs.webkit.org/show_bug.cgi?id=221301#c4 419023 2021-02-02 10:19:56 -0800 2021-02-02 14:38:31 -0800 Patch bug-221269-20210202131955.patch text/plain 3650 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3MjIxOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIxLTAyLTAyICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBDb21taXQgcXVldWUgZmFpbHVyZSBtZXNzYWdlIHNob3VsZCBp bmRpY2F0ZSB0aGF0IGNxKyBmbGFnIGNhbiBiZSBzZXQgYWdhaW4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTI2OQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVw cy5weToKKyAgICAgICAgKFB1c2hDb21taXRUb1dlYktpdFJlcG8uY29tbWVudF90ZXh0X2Zvcl9i dWcpOgorICAgICAgICAqIENJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHk6CisK IDIwMjEtMDItMDIgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAg ICAgIGV3cyBpc24ndCByZXRyeWluZyBidWlsZHMgd2hlbiBraWxsLW9sZC1wcm9jZXNzZXMgZmFp bHMKSW5kZXg6IFRvb2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gVG9vbHMvQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkocmV2aXNpb24gMjcyMjE4KQor KysgVG9vbHMvQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkod29ya2luZyBjb3B5KQpAQCAt MzExMSw3ICszMTExLDkgQEAgY2xhc3MgUHVzaENvbW1pdFRvV2ViS2l0UmVwbyhzaGVsbC5TaGVs bAogICAgIGRlZiBjb21tZW50X3RleHRfZm9yX2J1ZyhzZWxmLCBzdm5fcmV2aXNpb249Tm9uZSk6 CiAgICAgICAgIHBhdGNoX2lkID0gc2VsZi5nZXRQcm9wZXJ0eSgncGF0Y2hfaWQnLCAnJykKICAg ICAgICAgaWYgbm90IHN2bl9yZXZpc2lvbjoKLSAgICAgICAgICAgIHJldHVybiAnY29tbWl0LXF1 ZXVlIGZhaWxlZCB0byBjb21taXQgYXR0YWNobWVudCB7fSB0byBXZWJLaXQgcmVwb3NpdG9yeS4n LmZvcm1hdChwYXRjaF9pZCkKKyAgICAgICAgICAgIGNvbW1lbnQgPSAnY29tbWl0LXF1ZXVlIGZh aWxlZCB0byBjb21taXQgYXR0YWNobWVudCB7fSB0byBXZWJLaXQgcmVwb3NpdG9yeS4nLmZvcm1h dChwYXRjaF9pZCkKKyAgICAgICAgICAgIGNvbW1lbnQgKz0gJyBUbyByZXRyeSwgcGxlYXNlIHNl dCBjcSsgZmxhZyBhZ2Fpbi4nCisgICAgICAgICAgICByZXR1cm4gY29tbWVudAogICAgICAgICBj b21tZW50ID0gJ0NvbW1pdHRlZCBye306IDx7fT4nLmZvcm1hdChzdm5fcmV2aXNpb24sIHNlbGYu dXJsX2Zvcl9yZXZpc2lvbihzdm5fcmV2aXNpb24pKQogICAgICAgICBjb21tZW50ICs9ICdcblxu QWxsIHJldmlld2VkIHBhdGNoZXMgaGF2ZSBiZWVuIGxhbmRlZC4gQ2xvc2luZyBidWcgYW5kIGNs ZWFyaW5nIGZsYWdzIG9uIGF0dGFjaG1lbnQge30uJy5mb3JtYXQocGF0Y2hfaWQpCiAgICAgICAg IHJldHVybiBjb21tZW50CkluZGV4OiBUb29scy9DSVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3Vu aXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNf dW5pdHRlc3QucHkJKHJldmlzaW9uIDI3MjIxOCkKKysrIFRvb2xzL0NJU3VwcG9ydC9ld3MtYnVp bGQvc3RlcHNfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTM3MzgsNiArMzczOCw3IEBA IGNsYXNzIFRlc3RQdXNoQ29tbWl0VG9XZWJLaXRSZXBvKEJ1aWxkU3QKIAogICAgIGRlZiB0ZXN0 X3N1Y2Nlc3Moc2VsZik6CiAgICAgICAgIHNlbGYuc2V0dXBTdGVwKFB1c2hDb21taXRUb1dlYktp dFJlcG8oKSkKKyAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgncGF0Y2hfaWQnLCAnMTIzNCcpCiAg ICAgICAgIHNlbGYuZXhwZWN0UmVtb3RlQ29tbWFuZHMoCiAgICAgICAgICAgICBFeHBlY3RTaGVs bCh3b3JrZGlyPSd3a2RpcicsCiAgICAgICAgICAgICAgICAgICAgICAgICB0aW1lb3V0PTMwMCwK QEAgLTM3NDcsMTAgKzM3NDgsMTQgQEAgY2xhc3MgVGVzdFB1c2hDb21taXRUb1dlYktpdFJlcG8o QnVpbGRTdAogICAgICAgICAgICAgMCwKICAgICAgICAgKQogICAgICAgICBzZWxmLmV4cGVjdE91 dGNvbWUocmVzdWx0PVNVQ0NFU1MsIHN0YXRlX3N0cmluZz0nQ29tbWl0dGVkIHIyNTY3MjknKQot ICAgICAgICByZXR1cm4gc2VsZi5ydW5TdGVwKCkKKyAgICAgICAgcmMgPSBzZWxmLnJ1blN0ZXAo KQorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHNlbGYuZ2V0UHJvcGVydHkoJ2J1Z3ppbGxhX2Nv bW1lbnRfdGV4dCcpLCAnQ29tbWl0dGVkIHIyNTY3Mjk6IDxodHRwczovL3RyYWMud2Via2l0Lm9y Zy9jaGFuZ2VzZXQvMjU2NzI5PlxuXG5BbGwgcmV2aWV3ZWQgcGF0Y2hlcyBoYXZlIGJlZW4gbGFu ZGVkLiBDbG9zaW5nIGJ1ZyBhbmQgY2xlYXJpbmcgZmxhZ3Mgb24gYXR0YWNobWVudCAxMjM0Licp CisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoc2VsZi5nZXRQcm9wZXJ0eSgnYnVpbGRfZmluaXNo X3N1bW1hcnknKSwgTm9uZSkKKyAgICAgICAgcmV0dXJuIHJjCiAKICAgICBkZWYgdGVzdF9mYWls dXJlKHNlbGYpOgogICAgICAgICBzZWxmLnNldHVwU3RlcChQdXNoQ29tbWl0VG9XZWJLaXRSZXBv KCkpCisgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ3BhdGNoX2lkJywgJzIzNDUnKQogICAgICAg ICBzZWxmLmV4cGVjdFJlbW90ZUNvbW1hbmRzKAogICAgICAgICAgICAgRXhwZWN0U2hlbGwod29y a2Rpcj0nd2tkaXInLAogICAgICAgICAgICAgICAgICAgICAgICAgdGltZW91dD0zMDAsCkBAIC0z NzYwLDcgKzM3NjUsMTAgQEAgY2xhc3MgVGVzdFB1c2hDb21taXRUb1dlYktpdFJlcG8oQnVpbGRT dAogICAgICAgICAgICAgMiwKICAgICAgICAgKQogICAgICAgICBzZWxmLmV4cGVjdE91dGNvbWUo cmVzdWx0PUZBSUxVUkUsIHN0YXRlX3N0cmluZz0nRmFpbGVkIHRvIHB1c2ggY29tbWl0IHRvIFdl YmtpdCByZXBvc2l0b3J5JykKLSAgICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCisgICAgICAg IHJjID0gc2VsZi5ydW5TdGVwKCkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChzZWxmLmdldFBy b3BlcnR5KCdidWlsZF9maW5pc2hfc3VtbWFyeScpLCAnRmFpbGVkIHRvIGNvbW1pdCB0byBXZWJL aXQgcmVwb3NpdG9yeScpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoc2VsZi5nZXRQcm9wZXJ0 eSgnYnVnemlsbGFfY29tbWVudF90ZXh0JyksICdjb21taXQtcXVldWUgZmFpbGVkIHRvIGNvbW1p dCBhdHRhY2htZW50IDIzNDUgdG8gV2ViS2l0IHJlcG9zaXRvcnkuIFRvIHJldHJ5LCBwbGVhc2Ug c2V0IGNxKyBmbGFnIGFnYWluLicpCisgICAgICAgIHJldHVybiByYwogCiAKIGNsYXNzIFRlc3RT aG93SWRlbnRpZmllcihCdWlsZFN0ZXBNaXhpbkFkZGl0aW9ucywgdW5pdHRlc3QuVGVzdENhc2Up Ogo=