221266 2021-02-02 09:24:05 -0800 [webkitcorepy] Autoinstaller can fail on packages containing write protected files 2021-02-02 15:11:14 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 don.olmstead don.olmstead jbedard webkit-bug-importer oldest_to_newest 1724693 0 don.olmstead 2021-02-02 09:24:05 -0800 This is kind of a fringe issue that I've had happen to me a few times. One of the packages, logilab.common, contains a write-protected file. Looks like if an autoinstall of a package fails the temp directory the tar is extracted to is still present. When the install is run again the tar can't be extracted because the write protected file is present and its being written to. Traceback (most recent call last): File "C:\webkit\Tools\Scripts\webkitpy\test\main.py", line 321, in <module> sys.exit(main()) File "C:\webkit\Tools\Scripts\webkitpy\test\main.py", line 76, in main return not tester.run() File "C:\webkit\Tools\Scripts\webkitpy\test\main.py", line 149, in run return self._run_tests(names) File "C:\webkit\Tools\Scripts\webkitpy\test\main.py", line 156, in _run_tests AutoInstall.install_everything() File "C:\webkit\Tools\Scripts\libraries\webkitcorepy\webkitcorepy\autoinstall.py", line 512, in install_everything package.install() File "C:\webkit\Tools\Scripts\libraries\webkitcorepy\webkitcorepy\autoinstall.py", line 241, in install archive.unpack(temp_location) File "C:\webkit\Tools\Scripts\libraries\webkitcorepy\webkitcorepy\autoinstall.py", line 90, in unpack file.extractall(target) File "C:\Users\eolmstead\Documents\webkit-trunk\tools\python3\lib\tarfile.py", line 2034, in extractall self.extract(tarinfo, path, set_attrs=not tarinfo.isdir(), File "C:\Users\eolmstead\Documents\webkit-trunk\tools\python3\lib\tarfile.py", line 2075, in extract self._extract_member(tarinfo, os.path.join(path, tarinfo.name), File "C:\Users\eolmstead\Documents\webkit-trunk\tools\python3\lib\tarfile.py", line 2147, in _extract_member self.makefile(tarinfo, targetpath) File "C:\Users\eolmstead\Documents\webkit-trunk\tools\python3\lib\tarfile.py", line 2188, in makefile with bltn_open(targetpath, "wb") as target: PermissionError: [Errno 13] Permission denied: 'C:\\Users\\EOLMST~1\\AppData\\Local\\Temp\\2\\logilab.common\\logilab-common-1.8.1\\test\\data\\write_protected_file.txt' 1724802 1 419044 don.olmstead 2021-02-02 12:04:41 -0800 Created attachment 419044 Patch 1724914 2 ews-feeder 2021-02-02 15:10:56 -0800 Committed r272240: <https://trac.webkit.org/changeset/272240> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419044. 1724915 3 webkit-bug-importer 2021-02-02 15:11:14 -0800 <rdar://problem/73901124> 419044 2021-02-02 12:04:41 -0800 2021-02-02 15:10:56 -0800 Patch bug-221266.diff text/plain 2026 don.olmstead ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3Mzlm NTQ3NzhhNWEuLjJkOTQ2M2MzYzkxMSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTAyLTAyICBEb24gT2xtc3Rl YWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CisKKyAgICAgICAgW3dlYmtpdGNvcmVweV0gQXV0 b2luc3RhbGxlciBjYW4gZmFpbCBvbiBwYWNrYWdlcyBjb250YWluaW5nIHdyaXRlIHByb3RlY3Rl ZCBmaWxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjIxMjY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhlIGF1dG9pbnN0YWxsZXIgZXh0cmFjdHMgYW4gYXJjaGl2ZSBjb250YWluaW5nIHRoZSBwYWNr YWdlIHRvIGEgdGVtcG9yYXJ5IGRpcmVjdG9yeSBhbmQKKyAgICAgICAgdGhlbiBpbnN0YWxscyBp dCBmcm9tIHRoZXJlLiBJZiB0aGUgYXV0b2luc3RhbGxlciBhdHRlbXB0cyB0byBleHRyYWN0IHRo ZSBhcmNoaXZlIGFnYWluIGludG8KKyAgICAgICAgdGhlIHNhbWUgdGVtcG9yYXJ5IGRpcmVjdG9y eSBpdCBjYW4gZmFpbCBpZiB0aGVyZSB3YXMgYSB3cml0ZSBwcm90ZWN0ZWQgZmlsZS4gVGhlIGV4 dHJhY3Rpb24KKyAgICAgICAgd2lsbCBmYWlsIGFuZCB0aGUgaW5zdGFsbGVyIGNhbm5vdCBjb250 aW51ZSB1bnRpbCB0aGUgdGVtcG9yYXJ5IGRpcmVjdG9yeSBpcyBjbGVhcmVkLgorCisgICAgICAg IFRvIHByZXZlbnQgdGhpcyB0aGUgcGVybWlzc2lvbnMgZm9yIGVhY2ggZmlsZS9kaXJlY3Rvcnkg aW4gdGhlIHRhcmJhbGwgaXMgbWFudWFsbHkgc2V0LgorCisgICAgICAgIFRoaXMgd2FzIG9yaWdp bmFsbHkgb2JzZXJ2ZWQgd2l0aCB0aGUgbG9naWxhYi1jb21tb24gcGFja2FnZSB3aGljaCBzaGlw cyB3aXRoIGEgdGVzdCBjb250YWluaW5nCisgICAgICAgIGEgd3JpdGUgcHJvdGVjdGVkIGZpbGUu CisKKyAgICAgICAgKiBTY3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkvd2Via2l0Y29yZXB5 L2F1dG9pbnN0YWxsLnB5OgorICAgICAgICAoUGFja2FnZS5BcmNoaXZlLnVucGFjayk6CisKIDIw MjEtMDItMDIgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAg IGV3cyBpc24ndCByZXRyeWluZyBidWlsZHMgd2hlbiBraWxsLW9sZC1wcm9jZXNzZXMgZmFpbHMK ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdGNvcmVweS93ZWJraXRj b3JlcHkvYXV0b2luc3RhbGwucHkgYi9Ub29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3Jl cHkvd2Via2l0Y29yZXB5L2F1dG9pbnN0YWxsLnB5CmluZGV4IDM2YTAxZGYwMjU2ZS4uMDNhZWM3 ZWJmNzNkIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkv d2Via2l0Y29yZXB5L2F1dG9pbnN0YWxsLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVz L3dlYmtpdGNvcmVweS93ZWJraXRjb3JlcHkvYXV0b2luc3RhbGwucHkKQEAgLTExNiw2ICsxMTYs OSBAQCBjbGFzcyBQYWNrYWdlKG9iamVjdCk6CiAKICAgICAgICAgICAgIGlmIHNlbGYuZXh0ZW5z aW9uID09ICd0YXIuZ3onOgogICAgICAgICAgICAgICAgIGZpbGUgPSB0YXJmaWxlLm9wZW4oc2Vs Zi5wYXRoKQorICAgICAgICAgICAgICAgICMgUHJldmVudCB3cml0ZS1wcm90ZWN0ZWQgZmlsZXMg d2hpY2ggY2FuJ3QgYmUgb3ZlcndyaXR0ZW4gYnkgbWFudWFsbHkgc2V0dGluZyBwZXJtaXNzaW9u cworICAgICAgICAgICAgICAgIGZvciB0YXJyZWQgaW4gZmlsZToKKyAgICAgICAgICAgICAgICAg ICAgdGFycmVkLm1vZGUgPSAwbzc3NyBpZiB0YXJyZWQuaXNkaXIoKSBlbHNlIDBvNjQ0CiAgICAg ICAgICAgICAgICAgdHJ5OgogICAgICAgICAgICAgICAgICAgICBmaWxlLmV4dHJhY3RhbGwodGFy Z2V0KQogICAgICAgICAgICAgICAgIGZpbmFsbHk6Cg==