221259 2021-02-02 07:25:46 -0800 [JSC] Small cleanup in StackVisitor::readNonInlinedFrame 2021-02-02 10:21:13 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 xan.lopez webkit-unassigned ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer xan.lopez ysuzuki oldest_to_newest 1724655 0 xan.lopez 2021-02-02 07:25:46 -0800 Patch coming. 1724656 1 418997 xan.lopez 2021-02-02 07:28:37 -0800 Created attachment 418997 Small cleanup, v1 v1 1724726 2 418997 ysuzuki 2021-02-02 10:10:59 -0800 Comment on attachment 418997 Small cleanup, v1 r=me 1724735 3 ews-feeder 2021-02-02 10:20:26 -0800 Committed r272219: <https://trac.webkit.org/changeset/272219> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418997. 1724738 4 webkit-bug-importer 2021-02-02 10:21:13 -0800 <rdar://problem/73886146> 418997 2021-02-02 07:28:37 -0800 2021-02-02 10:20:28 -0800 Small cleanup, v1 0001-JSC-Small-cleanup-in-StackVisitor-readNonInlinedFram.patch text/plain 3695 xan.lopez RnJvbSA2YTJmYWU0YTYyNmM1YWEyMjg5Yzk0YWYyM2E0ZTdiZDE0YzU3NTJlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/WGFuPTIwTD1DMz1CM3Blej89IDx4YW5AaWdh bGlhLmNvbT4KRGF0ZTogVHVlLCAyIEZlYiAyMDIxIDE2OjI3OjU1ICswMTAwClN1YmplY3Q6IFtQ QVRDSF0gW0pTQ10gU21hbGwgY2xlYW51cCBpbiBTdGFja1Zpc2l0b3I6OnJlYWROb25JbmxpbmVk RnJhbWUKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjEyNTkKClJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKaXNBbnlXYXNtQ2FsbGVlKCkgd2lsbCBuZXZlciBi ZSB0cnVlIGlmIFdlYkFzc2VtYmx5IGlzIGRpc2FibGVkIGF0CmNvbXBpbGUgdGltZSwgc28gd2Ug Y2FuIG1vdmUgYSBnb29kIGNodW5rIG9mIGNvZGUgaW5zaWRlIHRoZQpVU0UoV0VCQVNTRU1CTFkp IGNoZWNrLiBBbHNvIG1vdmUgYWxsIGNvbnN0YW50IGluaXRpYWxpemF0aW9ucyBhdAp0aGUgYmVn aW5uaW5nIG9mIHRoZSBtZXRob2QsIGFuZCByZW1vdmUgYW4gdW5uZWNlc3NhcnkgZXh0cmEKdmFy aWFibGUuCgoqIGludGVycHJldGVyL1N0YWNrVmlzaXRvci5jcHA6CihKU0M6OlN0YWNrVmlzaXRv cjo6cmVhZE5vbklubGluZWRGcmFtZSk6Ci0tLQogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5n ZUxvZyAgICAgICAgICAgICAgIHwgMTYgKysrKysrKysrKwogLi4uL2ludGVycHJldGVyL1N0YWNr VmlzaXRvci5jcHAgICAgICAgICAgICAgIHwgMzAgKysrKysrKysrLS0tLS0tLS0tLQogMiBmaWxl cyBjaGFuZ2VkLCAzMCBpbnNlcnRpb25zKCspLCAxNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L0NoYW5nZUxvZwppbmRleCA3ZWZkYzg3ZTk1OTkuLmU0ODA0Yzc0ZGJkZCAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMDItMDIgIFhhbiBMb3BleiAgPHhh bkBpZ2FsaWEuY29tPgorCisgICAgICAgIFtKU0NdIFNtYWxsIGNsZWFudXAgaW4gU3RhY2tWaXNp dG9yOjpyZWFkTm9uSW5saW5lZEZyYW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMjEyNTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBpc0FueVdhc21DYWxsZWUoKSB3aWxsIG5ldmVyIGJlIHRydWUgaWYg V2ViQXNzZW1ibHkgaXMgZGlzYWJsZWQgYXQKKyAgICAgICAgY29tcGlsZSB0aW1lLCBzbyB3ZSBj YW4gbW92ZSBhIGdvb2QgY2h1bmsgb2YgY29kZSBpbnNpZGUgdGhlCisgICAgICAgIFVTRShXRUJB U1NFTUJMWSkgY2hlY2suIEFsc28gbW92ZSBhbGwgY29uc3RhbnQgaW5pdGlhbGl6YXRpb25zIGF0 CisgICAgICAgIHRoZSBiZWdpbm5pbmcgb2YgdGhlIG1ldGhvZCwgYW5kIHJlbW92ZSBhbiB1bm5l Y2Vzc2FyeSBleHRyYQorICAgICAgICB2YXJpYWJsZS4KKworICAgICAgICAqIGludGVycHJldGVy L1N0YWNrVmlzaXRvci5jcHA6CisgICAgICAgIChKU0M6OlN0YWNrVmlzaXRvcjo6cmVhZE5vbklu bGluZWRGcmFtZSk6CisKIDIwMjEtMDItMDIgIEJKIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+CiAK ICAgICAgICAgV2ViIEluc3BlY3RvcjogaW1wbGVtZW50IHRoZSBiYXNpY3MgZm9yIHNob3dpbmcv aGlkaW5nIGdyaWQgb3ZlcmxheXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9p bnRlcnByZXRlci9TdGFja1Zpc2l0b3IuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVy cHJldGVyL1N0YWNrVmlzaXRvci5jcHAKaW5kZXggOWJhMDk5MGJhYjY0Li5iZDNhNDE5NjhhZTQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9TdGFja1Zpc2l0 b3IuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9TdGFja1Zpc2l0 b3IuY3BwCkBAIC0xNjEsMzAgKzE2MSwyOCBAQCB2b2lkIFN0YWNrVmlzaXRvcjo6cmVhZE5vbklu bGluZWRGcmFtZShDYWxsRnJhbWUqIGNhbGxGcmFtZSwgQ29kZU9yaWdpbiogY29kZU9yaQogICAg IG1fZnJhbWUubV9jYWxsZXJGcmFtZSA9IGNhbGxGcmFtZS0+Y2FsbGVyRnJhbWUobV9mcmFtZS5t X2NhbGxlckVudHJ5RnJhbWUpOwogICAgIG1fZnJhbWUubV9jYWxsZXJJc0VudHJ5RnJhbWUgPSBt X2ZyYW1lLm1fY2FsbGVyRW50cnlGcmFtZSAhPSBtX2ZyYW1lLm1fZW50cnlGcmFtZTsKICAgICBt X2ZyYW1lLm1faXNXYXNtRnJhbWUgPSBmYWxzZTsKKyAgICBtX2ZyYW1lLm1fY2FsbGVlID0gY2Fs bEZyYW1lLT5jYWxsZWUoKTsKKyNpZiBFTkFCTEUoREZHX0pJVCkKKyAgICBtX2ZyYW1lLm1faW5s aW5lQ2FsbEZyYW1lID0gbnVsbHB0cjsKKyNlbmRpZgogCi0gICAgQ2FsbGVlQml0cyBjYWxsZWUg PSBjYWxsRnJhbWUtPmNhbGxlZSgpOwotICAgIG1fZnJhbWUubV9jYWxsZWUgPSBjYWxsZWU7Ci0K KyNpZiBFTkFCTEUoV0VCQVNTRU1CTFkpCiAgICAgaWYgKGNhbGxGcmFtZS0+aXNBbnlXYXNtQ2Fs bGVlKCkpIHsKICAgICAgICAgbV9mcmFtZS5tX2lzV2FzbUZyYW1lID0gdHJ1ZTsKICAgICAgICAg bV9mcmFtZS5tX2NvZGVCbG9jayA9IG51bGxwdHI7CiAgICAgICAgIG1fZnJhbWUubV9ieXRlY29k ZUluZGV4ID0gQnl0ZWNvZGVJbmRleCgpOwotI2lmIEVOQUJMRShXRUJBU1NFTUJMWSkKLSAgICAg ICAgQ2FsbGVlQml0cyBiaXRzID0gY2FsbEZyYW1lLT5jYWxsZWUoKTsKLSAgICAgICAgaWYgKGJp dHMuaXNXYXNtKCkpCi0gICAgICAgICAgICBtX2ZyYW1lLm1fd2FzbUZ1bmN0aW9uSW5kZXhPck5h bWUgPSBiaXRzLmFzV2FzbUNhbGxlZSgpLT5pbmRleE9yTmFtZSgpOwotI2VuZGlmCi0gICAgfSBl bHNlIHsKLSAgICAgICAgbV9mcmFtZS5tX2NvZGVCbG9jayA9IGNhbGxGcmFtZS0+Y29kZUJsb2Nr KCk7Ci0gICAgICAgIG1fZnJhbWUubV9ieXRlY29kZUluZGV4ID0gIW1fZnJhbWUuY29kZUJsb2Nr KCkgPyBCeXRlY29kZUluZGV4KDApCi0gICAgICAgICAgICA6IGNvZGVPcmlnaW4gPyBjb2RlT3Jp Z2luLT5ieXRlY29kZUluZGV4KCkKLSAgICAgICAgICAgIDogY2FsbEZyYW1lLT5ieXRlY29kZUlu ZGV4KCk7CiAKLSAgICB9CisgICAgICAgIGlmIChtX2ZyYW1lLm1fY2FsbGVlLmlzV2FzbSgpKQor ICAgICAgICAgICAgbV9mcmFtZS5tX3dhc21GdW5jdGlvbkluZGV4T3JOYW1lID0gbV9mcmFtZS5t X2NhbGxlZS5hc1dhc21DYWxsZWUoKS0+aW5kZXhPck5hbWUoKTsKIAotI2lmIEVOQUJMRShERkdf SklUKQotICAgIG1fZnJhbWUubV9pbmxpbmVDYWxsRnJhbWUgPSBudWxscHRyOworICAgICAgICBy ZXR1cm47CisgICAgfQogI2VuZGlmCisgICAgbV9mcmFtZS5tX2NvZGVCbG9jayA9IGNhbGxGcmFt ZS0+Y29kZUJsb2NrKCk7CisgICAgbV9mcmFtZS5tX2J5dGVjb2RlSW5kZXggPSAhbV9mcmFtZS5j b2RlQmxvY2soKSA/IEJ5dGVjb2RlSW5kZXgoMCkKKyAgICAgICAgOiBjb2RlT3JpZ2luID8gY29k ZU9yaWdpbi0+Ynl0ZWNvZGVJbmRleCgpCisgICAgICAgIDogY2FsbEZyYW1lLT5ieXRlY29kZUlu ZGV4KCk7CisKIH0KIAogI2lmIEVOQUJMRShERkdfSklUKQotLSAKMi4yOS4yCgo=