221254 2021-02-02 05:28:39 -0800 [WPE] Some more dependencies mising in Tools/wpe/install-dependencies 2021-02-04 03:59:37 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build PC Linux RESOLVED FIXED InRadar P2 Minor --- 1 estea estea aperez clopez estea ews-watchlist webkit-bug-importer oldest_to_newest 1724621 0 estea 2021-02-02 05:28:39 -0800 Overview: python-psutil is missing from Debian and Tools installation stops. Missing libegl-mesa0 aborts installation of required libegl1-mesa-dev. Reproduce: Try a fresh install in a recent Debian or Ubuntu system (because they lack python2 packages) where libegl-mesa0 and libegl1-mesa-dev are not installed. Run: Tools/wpe/install-dependencies Result: Errors about missing packages will be generated. Expected result: The installation to succeed without errors. Proposed solution: In Tools/wpe/install-dependencies script: python-psutil could be replaced with python3-psutil. libegl-mesa0 could be added before libegl1-mesa-dev. 1724623 1 418985 estea 2021-02-02 05:30:19 -0800 Created attachment 418985 proposed patch for Tools dependencies python-psutil is replaced with python3-psutil that is present in Diebian/Ubuntu/Raspbian. libegl-mesa0 is added in the dependencies list as it's required for libegl1-mesa-dev to be installed. 1725083 2 418985 aperez 2021-02-03 04:52:38 -0800 Comment on attachment 418985 proposed patch for Tools dependencies Patch looks fine, but you need to edit the ChangeLog before we can accept it. The “webkit-patch” script (or “prepare-ChangeLog”) can check your local changes and generate a skeleton of the edits in the ChangeLog that then you can fill in. There is a walkthrough here: https://trac.webkit.org/wiki/CommitterTips#Walkingyouthroughyourfirstcommit Feel free to ask if you get stuck :) 1725105 3 419127 estea 2021-02-03 06:10:32 -0800 Created attachment 419127 modified the patch and updated the Changelog Thank you for the review and the guidelines! I've updated my patch and the Changelog. 1725562 4 ews-feeder 2021-02-04 02:31:25 -0800 Adrian Perez found in /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). 1725563 5 aperez 2021-02-04 02:31:39 -0800 (In reply to Eleni Maria Stea from comment #3) > Created attachment 419127 [details] > modified the patch and updated the Changelog > > Thank you for the review and the guidelines! > I've updated my patch and the Changelog. Approved, thanks! 1725564 6 aperez 2021-02-04 02:37:13 -0800 (In reply to EWS from comment #4) > Adrian Perez found in > /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog does not appear to > be a valid reviewer according to contributors.json. > /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog neither lists a > valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case > insensitive). Gah! The commit-queue failed because the line: “Reviewed by Adrian Perez.” …should have been instead: “Reviewed by Adrian Perez de Castro.” (Reviewer names are checked against the contents of the “Tools/Scripts/webkitpy/common/config/contributors.json” file.) Another option is to leave the line as: ”Reviewed by OOOPS.” …and then when a reviewer sets the “r+” flag in Bugzilla, the commit queue will edit the ChangeLog and replace “OOOPS” with the name of the reviewer. 1725565 7 419262 aperez 2021-02-04 02:38:02 -0800 Created attachment 419262 Patch for landing 1725566 8 aperez 2021-02-04 02:40:01 -0800 I have posted a version with the “Reviewed by” line edited to contain the correct name, to let the commit queue handle the landing. 1725569 9 estea 2021-02-04 03:00:22 -0800 (In reply to Adrian Perez from comment #8) > I have posted a version with the “Reviewed by” line edited to > contain the correct name, to let the commit queue handle the > landing. Thanks! And apologies I mistyped your name! 1725570 10 ews-feeder 2021-02-04 03:02:55 -0800 Committed r272365: <https://trac.webkit.org/changeset/272365> All reviewed patches have been landed. Closing bug and clearing flags on attachment 419262. 1725571 11 webkit-bug-importer 2021-02-04 03:03:12 -0800 <rdar://problem/73973784> 1725578 12 aperez 2021-02-04 03:59:37 -0800 (In reply to Eleni Maria Stea from comment #9) > (In reply to Adrian Perez from comment #8) > > I have posted a version with the “Reviewed by” line edited to > > contain the correct name, to let the commit queue handle the > > landing. > > Thanks! And apologies I mistyped your name! No problem at all =] 418985 2021-02-02 05:30:19 -0800 2021-02-03 07:27:37 -0800 proposed patch for Tools dependencies 0001-Some-dependencies-are-missing-from-Tools-wpe-install.patch text/plain 1245 estea RnJvbSA4OWRlNjhlODJjYjY1NGM5ZmU2ODRkZTU5ZjJhMzg2ZDAyZmJhY2M0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFbGVuaSBNYXJpYSBTdGVhIDxlc3RlYUBpZ2FsaWEuY29tPgpE YXRlOiBUdWUsIDIgRmViIDIwMjEgMTU6MDg6MTEgKzAyMDAKU3ViamVjdDogW1BBVENIXSBTb21l IGRlcGVuZGVuY2llcyBhcmUgbWlzc2luZyBmcm9tCiBUb29scy93cGUvaW5zdGFsbC1kZXBlbmRl bmNpZXMKCnB5dGhvbi1wc3V0aWwgaXMgcmVwbGFjZWQgd2l0aCBweXRob24zLXBzdXRpbCB0aGF0 IGlzIHByZXNlbnQgaW4KRGllYmlhbi9VYnVudHUvUmFzcGJpYW4uIGxpYmVnbC1tZXNhMCBpcyBh ZGRlZCBpbiB0aGUgZGVwZW5kZW5jaWVzCmxpc3QgYXMgaXQncyByZXF1aXJlZCBmb3IgbGliZWds MS1tZXNhLWRldiB0byBiZSBpbnN0YWxsZWQuCgpGaXg6IGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMjEyNTQKLS0tCiBUb29scy93cGUvaW5zdGFsbC1kZXBlbmRlbmNp ZXMgfCAzICsrLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigt KQoKZGlmZiAtLWdpdCBhL1Rvb2xzL3dwZS9pbnN0YWxsLWRlcGVuZGVuY2llcyBiL1Rvb2xzL3dw ZS9pbnN0YWxsLWRlcGVuZGVuY2llcwppbmRleCBkYTRjN2ZmYzk1MTIuLmIzMWI3MWQ4NjI4NiAx MDA3NTUKLS0tIGEvVG9vbHMvd3BlL2luc3RhbGwtZGVwZW5kZW5jaWVzCisrKyBiL1Rvb2xzL3dw ZS9pbnN0YWxsLWRlcGVuZGVuY2llcwpAQCAtMTA2LDcgKzEwNiw3IEBAIGZ1bmN0aW9uIGluc3Rh bGxEZXBlbmRlbmNpZXNXaXRoQXB0IHsKICAgICAgICAgcHNtaXNjIFwKICAgICAgICAgcHVsc2Vh dWRpby11dGlscyBcCiAgICAgICAgIHB5dGhvbi1naSBcCi0gICAgICAgIHB5dGhvbi1wc3V0aWwg XAorICAgICAgICBweXRob24zLXBzdXRpbCBcCiAgICAgICAgIHJ1YnkgXAogICAgICAgICBydWJ5 LWhpZ2hsaW5lIFwKICAgICAgICAgcnVieS1qc29uIgpAQCAtMTIwLDYgKzEyMCw3IEBAIGZ1bmN0 aW9uIGluc3RhbGxEZXBlbmRlbmNpZXNXaXRoQXB0IHsKICAgICAgICAgZ2l0IFwKICAgICAgICAg Z3NldHRpbmdzLWRlc2t0b3Atc2NoZW1hcy1kZXYgXAogICAgICAgICBneXAgXAorICAgICAgICBs aWJlZ2wtbWVzYTAgXAogICAgICAgICBsaWJlZ2wxLW1lc2EtZGV2IFwKICAgICAgICAgbGliZXhw YXQxLWRldiBcCiAgICAgICAgIGxpYmZkay1hYWMtZGV2IFwKLS0gCjIuMzAuMAoK 419127 2021-02-03 06:10:32 -0800 2021-02-04 02:37:57 -0800 modified the patch and updated the Changelog 0001-Modifications-to-Tools-wpe-install-dependencies.patch text/plain 2061 estea RnJvbSAxNTkwMmU2YzAzNWRiNjJkNTM1MDYwYzAxNjBmNDkwNDRhMWQwNzM3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFbGVuaSBNYXJpYSBTdGVhIDxlc3RlYUBpZ2FsaWEuY29tPgpE YXRlOiBXZWQsIDMgRmViIDIwMjEgMTY6MDY6MDYgKzAyMDAKU3ViamVjdDogW1BBVENIXSBNb2Rp ZmljYXRpb25zIHRvIFRvb2xzL3dwZS9pbnN0YWxsLWRlcGVuZGVuY2llcwogaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTI1NAoKUmV2aWV3ZWQgYnkgIEFkcmlhbiBQ ZXJlei4KCiogd3BlL2luc3RhbGwtZGVwZW5kZW5jaWVzOiBweXRob24tcHN1dGlsIGlzIHJlcGxh Y2VkIHdpdGgKcHl0aG9uMy1wc3V0aWwgdGhhdCBpcyBwcmVzZW50IGluIERlYmlhbi9VYnVudHUv UmFzcGJpYW4uIGxpYmVnbC1tZXNhMAppcyBhZGRlZCBpbiB0aGUgZGVwZW5kZW5jaWVzIGxpc3Qg YXMgaXQncyByZXF1aXJlZCBmb3IgbGliZWdsMS1tZXNhLWRldgp0byBiZSBpbnN0YWxsZWQuCi0t LQogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgIHwgMTMgKysrKysrKysrKysrKwogVG9v bHMvd3BlL2luc3RhbGwtZGVwZW5kZW5jaWVzIHwgIDMgKystCiAyIGZpbGVzIGNoYW5nZWQsIDE1 IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VM b2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2MzYTUwMzZiNzhkLi4xNTY3YzI2ZmQwZDQgMTAw NjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNiBAQAorMjAyMS0wMi0wMyAgRWxlbmkgTWFyaWEgU3RlYSAgPGVzdGVhQGlnYWxpYS5jb20+ CisKKyAgICAgICAgTW9kaWZpY2F0aW9ucyB0byBUb29scy93cGUvaW5zdGFsbC1kZXBlbmRlbmNp ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTI1 NAorCisgICAgICAgIFJldmlld2VkIGJ5ICBBZHJpYW4gUGVyZXouCisKKyAgICAgICAgKiB3cGUv aW5zdGFsbC1kZXBlbmRlbmNpZXM6IHB5dGhvbi1wc3V0aWwgaXMgcmVwbGFjZWQgd2l0aAorICAg ICAgICBweXRob24zLXBzdXRpbCB0aGF0IGlzIHByZXNlbnQgaW4gRGViaWFuL1VidW50dS9SYXNw Ymlhbi4gbGliZWdsLW1lc2EwCisgICAgICAgIGlzIGFkZGVkIGluIHRoZSBkZXBlbmRlbmNpZXMg bGlzdCBhcyBpdCdzIHJlcXVpcmVkIGZvciBsaWJlZ2wxLW1lc2EtZGV2CisgICAgICAgIHRvIGJl IGluc3RhbGxlZC4KKworCiAyMDIxLTAyLTAzICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBw bGUuY29tPgogCiAgICAgICAgIEJpZyBTdXIgdGVzdDI2MiBxdWV1ZXMgZmFpbGluZyBkb3dubG9h ZC1idWlsdC1wcm9kdWN0IHN0ZXAKZGlmZiAtLWdpdCBhL1Rvb2xzL3dwZS9pbnN0YWxsLWRlcGVu ZGVuY2llcyBiL1Rvb2xzL3dwZS9pbnN0YWxsLWRlcGVuZGVuY2llcwppbmRleCBkYTRjN2ZmYzk1 MTIuLmIzMWI3MWQ4NjI4NiAxMDA3NTUKLS0tIGEvVG9vbHMvd3BlL2luc3RhbGwtZGVwZW5kZW5j aWVzCisrKyBiL1Rvb2xzL3dwZS9pbnN0YWxsLWRlcGVuZGVuY2llcwpAQCAtMTA2LDcgKzEwNiw3 IEBAIGZ1bmN0aW9uIGluc3RhbGxEZXBlbmRlbmNpZXNXaXRoQXB0IHsKICAgICAgICAgcHNtaXNj IFwKICAgICAgICAgcHVsc2VhdWRpby11dGlscyBcCiAgICAgICAgIHB5dGhvbi1naSBcCi0gICAg ICAgIHB5dGhvbi1wc3V0aWwgXAorICAgICAgICBweXRob24zLXBzdXRpbCBcCiAgICAgICAgIHJ1 YnkgXAogICAgICAgICBydWJ5LWhpZ2hsaW5lIFwKICAgICAgICAgcnVieS1qc29uIgpAQCAtMTIw LDYgKzEyMCw3IEBAIGZ1bmN0aW9uIGluc3RhbGxEZXBlbmRlbmNpZXNXaXRoQXB0IHsKICAgICAg ICAgZ2l0IFwKICAgICAgICAgZ3NldHRpbmdzLWRlc2t0b3Atc2NoZW1hcy1kZXYgXAogICAgICAg ICBneXAgXAorICAgICAgICBsaWJlZ2wtbWVzYTAgXAogICAgICAgICBsaWJlZ2wxLW1lc2EtZGV2 IFwKICAgICAgICAgbGliZXhwYXQxLWRldiBcCiAgICAgICAgIGxpYmZkay1hYWMtZGV2IFwKLS0g CjIuMzAuMAoK 419262 2021-02-04 02:38:02 -0800 2021-02-04 03:02:56 -0800 Patch for landing bug-221254-20210204123801.patch text/plain 1546 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyMzYzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOGQ2M2YwOWNhZWVhZGY4ZjA4YjFjOWNlYjhjYzk2NDkw NTg0YzQ4MS4uNjYxMWE3MTg4MzQwNDgxNGNhMWU4YTBmMjhlNzNlN2UxZDJlY2RiMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIxLTAyLTA0ICBFbGVuaSBNYXJpYSBTdGVhICA8ZXN0ZWFAaWdhbGlhLmNvbT4KKwor ICAgICAgICBNb2RpZmljYXRpb25zIHRvIFRvb2xzL3dwZS9pbnN0YWxsLWRlcGVuZGVuY2llcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIxMjU0CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgQWRyaWFuIFBlcmV6IGRlIENhc3Ryby4KKworICAgICAgICAq IHdwZS9pbnN0YWxsLWRlcGVuZGVuY2llczogcHl0aG9uLXBzdXRpbCBpcyByZXBsYWNlZCB3aXRo CisgICAgICAgIHB5dGhvbjMtcHN1dGlsIHRoYXQgaXMgcHJlc2VudCBpbiBEZWJpYW4vVWJ1bnR1 L1Jhc3BiaWFuLiBsaWJlZ2wtbWVzYTAKKyAgICAgICAgaXMgYWRkZWQgaW4gdGhlIGRlcGVuZGVu Y2llcyBsaXN0IGFzIGl0J3MgcmVxdWlyZWQgZm9yIGxpYmVnbDEtbWVzYS1kZXYKKyAgICAgICAg dG8gYmUgaW5zdGFsbGVkLgorCisKIDIwMjEtMDItMDMgIEppZXdlbiBUYW4gIDxqaWV3ZW5fdGFu QGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViQXV0aG5dIEFsbG93IG9uZSB1c2VyIGdlc3R1cmUg ZnJlZSBwcm9tcHQgZm9yIGVhY2ggbmF2aWdhdGlvbgpkaWZmIC0tZ2l0IGEvVG9vbHMvd3BlL2lu c3RhbGwtZGVwZW5kZW5jaWVzIGIvVG9vbHMvd3BlL2luc3RhbGwtZGVwZW5kZW5jaWVzCmluZGV4 IGRhNGM3ZmZjOTUxMjRlY2NmNDc2MWI4Zjk5ZGYyZTA1OGE1YTc3MzUuLmIzMWI3MWQ4NjI4NjJh Y2VjOTY2YTY2ODRiZjFlMmRmM2MxY2M1MDYgMTAwNzU1Ci0tLSBhL1Rvb2xzL3dwZS9pbnN0YWxs LWRlcGVuZGVuY2llcworKysgYi9Ub29scy93cGUvaW5zdGFsbC1kZXBlbmRlbmNpZXMKQEAgLTEw Niw3ICsxMDYsNyBAQCBmdW5jdGlvbiBpbnN0YWxsRGVwZW5kZW5jaWVzV2l0aEFwdCB7CiAgICAg ICAgIHBzbWlzYyBcCiAgICAgICAgIHB1bHNlYXVkaW8tdXRpbHMgXAogICAgICAgICBweXRob24t Z2kgXAotICAgICAgICBweXRob24tcHN1dGlsIFwKKyAgICAgICAgcHl0aG9uMy1wc3V0aWwgXAog ICAgICAgICBydWJ5IFwKICAgICAgICAgcnVieS1oaWdobGluZSBcCiAgICAgICAgIHJ1YnktanNv biIKQEAgLTEyMCw2ICsxMjAsNyBAQCBmdW5jdGlvbiBpbnN0YWxsRGVwZW5kZW5jaWVzV2l0aEFw dCB7CiAgICAgICAgIGdpdCBcCiAgICAgICAgIGdzZXR0aW5ncy1kZXNrdG9wLXNjaGVtYXMtZGV2 IFwKICAgICAgICAgZ3lwIFwKKyAgICAgICAgbGliZWdsLW1lc2EwIFwKICAgICAgICAgbGliZWds MS1tZXNhLWRldiBcCiAgICAgICAgIGxpYmV4cGF0MS1kZXYgXAogICAgICAgICBsaWJmZGstYWFj LWRldiBcCg==