221250 2021-02-02 01:02:40 -0800 WKASCAuthorizationPresenterDelegate needs to import RunLoop.h and BlockPtr.h 2021-02-02 10:15:44 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts dino ews-watchlist jiewen_tan koivisto webkit-bug-importer oldest_to_newest 1724562 0 graouts 2021-02-02 01:02:40 -0800 WKASCAuthorizationPresenterDelegate needs to import RunLoop.h and BlockPtr.h 1724563 1 418971 graouts 2021-02-02 01:03:13 -0800 Created attachment 418971 Patch 1724582 2 418971 koivisto 2021-02-02 02:22:27 -0800 Comment on attachment 418971 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418971&action=review > Source/WebKit/UIProcess/WebAuthentication/Cocoa/WKASCAuthorizationPresenterDelegate.mm:35 > +#import <wtf/BlockPtr.h> > +#import <wtf/RunLoop.h> > #import "AuthenticationServicesCoreSoftLink.h" Don't we usually sort wtf includes last? Wonder why style bot is not complaining. 1724583 3 graouts 2021-02-02 02:24:31 -0800 (In reply to Antti Koivisto from comment #2) > Comment on attachment 418971 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=418971&action=review > > > Source/WebKit/UIProcess/WebAuthentication/Cocoa/WKASCAuthorizationPresenterDelegate.mm:35 > > +#import <wtf/BlockPtr.h> > > +#import <wtf/RunLoop.h> > > #import "AuthenticationServicesCoreSoftLink.h" > > Don't we usually sort wtf includes last? Wonder why style bot is not > complaining. Actually, the style checker complained the other way around that soft-linking headers should appear last. 1724587 4 418971 dino 2021-02-02 02:27:44 -0800 Comment on attachment 418971 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418971&action=review >>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/WKASCAuthorizationPresenterDelegate.mm:35 >>> #import "AuthenticationServicesCoreSoftLink.h" >> >> Don't we usually sort wtf includes last? Wonder why style bot is not complaining. > > Actually, the style checker complained the other way around that soft-linking headers should appear last. Huh!? If that's the case, I think there should be a blank line separating them. 1724591 5 graouts 2021-02-02 02:48:05 -0800 (In reply to Dean Jackson from comment #4) > Comment on attachment 418971 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=418971&action=review > > >>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/WKASCAuthorizationPresenterDelegate.mm:35 > >>> #import "AuthenticationServicesCoreSoftLink.h" > >> > >> Don't we usually sort wtf includes last? Wonder why style bot is not complaining. > > > > Actually, the style checker complained the other way around that soft-linking headers should appear last. > > Huh!? Yeah! > If that's the case, I think there should be a blank line separating them. Sure, will do that. 1724600 6 graouts 2021-02-02 03:07:35 -0800 Committed r272203: <https://trac.webkit.org/changeset/272203> 1724601 7 webkit-bug-importer 2021-02-02 03:08:13 -0800 <rdar://problem/73872818> 1724730 8 jiewen_tan 2021-02-02 10:15:44 -0800 Thanks for fixing this issue. Sorry for causing it. 418971 2021-02-02 01:03:13 -0800 2021-02-02 02:21:24 -0800 Patch bug-221250-20210202100312.patch text/plain 1368 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyMTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY4ZjQ1YTNkYWZlNWJhMGQx ZjQ4ZDlkNmY2OWQ5NWRlZTFiOTQwYzYuLmZkMmI5YTI2ODdjZjJlODdkOGFjZjQ0NDkwZmU4ZmIz ZGRkYjdmMTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjEtMDItMDIgIEFudG9pbmUg UXVpbnQgIDxncmFvdXRzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgV0tBU0NBdXRob3JpemF0aW9u UHJlc2VudGVyRGVsZWdhdGUgbmVlZHMgdG8gaW1wb3J0IFJ1bkxvb3AuaCBhbmQgQmxvY2tQdHIu aAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIxMjUw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvV2ViQXV0aGVudGljYXRpb24vQ29jb2EvV0tBU0NBdXRob3JpemF0aW9uUHJlc2VudGVy RGVsZWdhdGUubW06CisKIDIwMjEtMDEtMjkgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgogCiAgICAgICAgIENoZWNrIGFjdGl2ZURvY3VtZW50TG9hZGVyKCkgZm9yIG51bGwgY29uc2lz dGVudGx5IGV2ZXJ5d2hlcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dl YkF1dGhlbnRpY2F0aW9uL0NvY29hL1dLQVNDQXV0aG9yaXphdGlvblByZXNlbnRlckRlbGVnYXRl Lm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vQ29jb2EvV0tB U0NBdXRob3JpemF0aW9uUHJlc2VudGVyRGVsZWdhdGUubW0KaW5kZXggN2NjMTcwNzQ0YThlNGI1 ZDA1MDcxZWViZGEwZjRlYjBlMDJkZjRiYi4uN2MyMDhmZjBhZDU3MDBlYzE3ZGI0NDM4YjY4MzQ5 YTQzY2QyNmE5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVu dGljYXRpb24vQ29jb2EvV0tBU0NBdXRob3JpemF0aW9uUHJlc2VudGVyRGVsZWdhdGUubW0KKysr IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vQ29jb2EvV0tBU0NB dXRob3JpemF0aW9uUHJlc2VudGVyRGVsZWdhdGUubW0KQEAgLTMwLDYgKzMwLDggQEAKIAogI2lt cG9ydCAiQXV0aGVudGljYXRvclByZXNlbnRlckNvb3JkaW5hdG9yLmgiCiAKKyNpbXBvcnQgPHd0 Zi9CbG9ja1B0ci5oPgorI2ltcG9ydCA8d3RmL1J1bkxvb3AuaD4KICNpbXBvcnQgIkF1dGhlbnRp Y2F0aW9uU2VydmljZXNDb3JlU29mdExpbmsuaCIKIAogTlNfQVNTVU1FX05PTk5VTExfQkVHSU4K