221241 2021-02-01 19:53:24 -0800 ConcurrentPtrHashSet::contains() should be const. 2021-02-01 23:57:14 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam benjamin cdumez cmarcelo ews-watchlist webkit-bug-importer ysuzuki oldest_to_newest 1724511 0 mark.lam 2021-02-01 19:53:24 -0800 There's no reason why it needs to be non-const. 1724512 1 418954 mark.lam 2021-02-01 19:59:43 -0800 Created attachment 418954 proposed patch. 1724513 2 418954 ysuzuki 2021-02-01 20:01:10 -0800 Comment on attachment 418954 proposed patch. r=me 1724543 3 mark.lam 2021-02-01 23:56:03 -0800 Thanks for the review. Landed in r272192: <http://trac.webkit.org/r272192>. 1724544 4 webkit-bug-importer 2021-02-01 23:57:14 -0800 <rdar://problem/73867230> 418954 2021-02-01 19:59:43 -0800 2021-02-01 20:01:10 -0800 proposed patch. bug-221241.patch text/plain 1520 mark.lam SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNzIxODgpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDIxLTAyLTAxICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KKworICAgICAgICBDb25jdXJyZW50UHRySGFzaFNldDo6Y29udGFpbnMoKSBz aG91bGQgYmUgY29uc3QuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMjEyNDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHd0Zi9Db25jdXJyZW50UHRySGFzaFNldC5oOgorCiAyMDIxLTAyLTAxICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gRGlzYWJsZSBp bnRlcnN0aXRpYWwgZXZlbnRzIG9uIEFWUGxheWVySXRlbS4KSW5kZXg6IFNvdXJjZS9XVEYvd3Rm L0NvbmN1cnJlbnRQdHJIYXNoU2V0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvQ29u Y3VycmVudFB0ckhhc2hTZXQuaAkocmV2aXNpb24gMjcyMTg4KQorKysgU291cmNlL1dURi93dGYv Q29uY3VycmVudFB0ckhhc2hTZXQuaAkod29ya2luZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAKIC8q Ci0gKiBDb3B5cmlnaHQgKEMpIDIwMTcgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgor ICogQ29weXJpZ2h0IChDKSAyMDE3LTIwMjEgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVk LgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9y bXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3Zp ZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC02MSw3ICs2MSw3IEBAIHB1Ymxp YzoKICAgICBXVEZfRVhQT1JUX1BSSVZBVEUgfkNvbmN1cnJlbnRQdHJIYXNoU2V0KCk7CiAgICAg CiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4KLSAgICBib29sIGNvbnRhaW5zKFQgdmFsdWUpCisg ICAgYm9vbCBjb250YWlucyhUIHZhbHVlKSBjb25zdAogICAgIHsKICAgICAgICAgcmV0dXJuIGNv bnRhaW5zSW1wbChjYXN0KHZhbHVlKSk7CiAgICAgfQpAQCAtMTA3LDcgKzEwNyw3IEBAIHByaXZh dGU6CiAgICAgdm9pZCBpbml0aWFsaXplKCk7CiAgICAgCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUg VD4KLSAgICB2b2lkKiBjYXN0KFQgdmFsdWUpCisgICAgc3RhdGljIHZvaWQqIGNhc3QoVCB2YWx1 ZSkKICAgICB7CiAgICAgICAgIHN0YXRpY19hc3NlcnQoc2l6ZW9mKFQpIDw9IHNpemVvZih2b2lk KiksICJ0eXBlIHRvbyBiaWciKTsKICAgICAgICAgdW5pb24gewo=