221235 2021-02-01 17:28:40 -0800 ews isn't retrying builds when kill-old-processes fails 2021-02-22 07:23:52 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain jbedard jlewis3 ryanhaddad webkit-bug-importer oldest_to_newest 1724480 0 aakash_jain 2021-02-01 17:28:40 -0800 ews isn't retrying builds when kill old process fails. e.g.: https://ews-build.webkit.org/#/builders/56/builds/196 didn't resulted in retry. Retry on kill-old-process failure was added in https://trac.webkit.org/changeset/252324/webkit which was working fine. But seems like https://trac.webkit.org/r257654 broke it. 1724481 1 418944 aakash_jain 2021-02-01 17:31:52 -0800 Created attachment 418944 Patch 1724588 2 aakash_jain 2021-02-02 02:37:13 -0800 Sample run: https://ews-build.webkit-uat.org/#/builders/13/builds/3883 1724604 3 ews-feeder 2021-02-02 03:12:21 -0800 Committed r272204: <https://trac.webkit.org/changeset/272204> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418944. 1724605 4 webkit-bug-importer 2021-02-02 03:13:13 -0800 <rdar://problem/73872929> 1732123 5 aakash_jain 2021-02-22 07:23:52 -0800 This seems to work fine. For e.g: https://ews-build.webkit.org/#/builders/58/builds/2278 was retried when kill-old-processes failed (as bot was in bad state). 418944 2021-02-01 17:31:52 -0800 2021-02-02 03:12:21 -0800 Patch bug-221235-20210201203151.patch text/plain 3408 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3MjE4MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDIxLTAyLTAxICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBld3MgaXNuJ3QgcmV0cnlpbmcgYnVpbGRzIHdoZW4ga2lsbC1vbGQtcHJv Y2Vzc2VzIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjEyMzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIENJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6CisgICAgICAgIChLaWxsT2xkUHJv Y2Vzc2VzLl9faW5pdF9fKTogSW5jcmVhc2VkIHRpbWVvdXQgdG8gMiBtaW51dGVzLgorICAgICAg ICAoS2lsbE9sZFByb2Nlc3Nlcy5ldmFsdWF0ZUNvbW1hbmQpOiBVc2VkIHJjIHNpbmNlIHNlbGYu cmVzdWx0cyBpcyBOb25lIGF0IHRoaXMgc3RlcC4KKyAgICAgICAgKiBDSVN1cHBvcnQvZXdzLWJ1 aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5OiBVcGRhdGVkIHVuaXQtdGVzdHMuCisKIDIwMjEtMDItMDEg IERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KIAogICAgICAgICBbd2Via2l0 c2NtcHldIFVzZSBzaHV0aWwgdG8gZmluZCBzY20gZXhlY3V0YWJsZSBwYXRocwpJbmRleDogVG9v bHMvQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DSVN1 cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CShyZXZpc2lvbiAyNzIxODEpCisrKyBUb29scy9DSVN1 cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsNCBAQAot IyBDb3B5cmlnaHQgKEMpIDIwMTgtMjAyMCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQu CisjIENvcHlyaWdodCAoQykgMjAxOC0yMDIxIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZl ZC4KICMKICMgUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jt cywgd2l0aCBvciB3aXRob3V0CiAjIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRl ZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtMTkyMSwxMiArMTkyMSwxMyBAQCBj bGFzcyBLaWxsT2xkUHJvY2Vzc2VzKHNoZWxsLkNvbXBpbGUpOgogICAgIGNvbW1hbmQgPSBbJ3B5 dGhvbicsICdUb29scy9DSVN1cHBvcnQva2lsbC1vbGQtcHJvY2Vzc2VzJywgJ2J1aWxkYm90J10K IAogICAgIGRlZiBfX2luaXRfXyhzZWxmLCAqKmt3YXJncyk6Ci0gICAgICAgIHN1cGVyKEtpbGxP bGRQcm9jZXNzZXMsIHNlbGYpLl9faW5pdF9fKHRpbWVvdXQ9NjAsIGxvZ0Vudmlyb249RmFsc2Us ICoqa3dhcmdzKQorICAgICAgICBzdXBlcihLaWxsT2xkUHJvY2Vzc2VzLCBzZWxmKS5fX2luaXRf Xyh0aW1lb3V0PTIgKiA2MCwgbG9nRW52aXJvbj1GYWxzZSwgKiprd2FyZ3MpCiAKICAgICBkZWYg ZXZhbHVhdGVDb21tYW5kKHNlbGYsIGNtZCk6Ci0gICAgICAgIGlmIHNlbGYucmVzdWx0cyBpbiBb RkFJTFVSRSwgRVhDRVBUSU9OXToKKyAgICAgICAgcmMgPSBzaGVsbC5Db21waWxlLmV2YWx1YXRl Q29tbWFuZChzZWxmLCBjbWQpCisgICAgICAgIGlmIHJjIGluIFtGQUlMVVJFLCBFWENFUFRJT05d OgogICAgICAgICAgICAgc2VsZi5idWlsZC5idWlsZEZpbmlzaGVkKFsnRmFpbGVkIHRvIGtpbGwg b2xkIHByb2Nlc3NlcywgcmV0cnlpbmcgYnVpbGQnXSwgUkVUUlkpCi0gICAgICAgIHJldHVybiBz aGVsbC5Db21waWxlLmV2YWx1YXRlQ29tbWFuZChzZWxmLCBjbWQpCisgICAgICAgIHJldHVybiBy YwogCiAgICAgZGVmIGdldFJlc3VsdFN1bW1hcnkoc2VsZik6CiAgICAgICAgIGlmIHNlbGYucmVz dWx0cyBpbiBbRkFJTFVSRSwgRVhDRVBUSU9OXToKSW5kZXg6IFRvb2xzL0NJU3VwcG9ydC9ld3Mt YnVpbGQvc3RlcHNfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ0lTdXBwb3J0L2V3 cy1idWlsZC9zdGVwc191bml0dGVzdC5weQkocmV2aXNpb24gMjcyMTgxKQorKysgVG9vbHMvQ0lT dXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMSw0 ICsxLDQgQEAKLSMgQ29weXJpZ2h0IChDKSAyMDE4LTIwMjAgQXBwbGUgSW5jLiBBbGwgcmlnaHRz IHJlc2VydmVkLgorIyBDb3B5cmlnaHQgKEMpIDIwMTgtMjAyMSBBcHBsZSBJbmMuIEFsbCByaWdo dHMgcmVzZXJ2ZWQuCiAjCiAjIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBi aW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogIyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0 ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTc3Myw3ICs3NzMs NyBAQCBjbGFzcyBUZXN0S2lsbE9sZFByb2Nlc3NlcyhCdWlsZFN0ZXBNaXhpCiAgICAgICAgICAg ICBFeHBlY3RTaGVsbCh3b3JrZGlyPSd3a2RpcicsCiAgICAgICAgICAgICAgICAgICAgICAgICBj b21tYW5kPVsncHl0aG9uJywgJ1Rvb2xzL0NJU3VwcG9ydC9raWxsLW9sZC1wcm9jZXNzZXMnLCAn YnVpbGRib3QnXSwKICAgICAgICAgICAgICAgICAgICAgICAgIGxvZ0Vudmlyb249RmFsc2UsCi0g ICAgICAgICAgICAgICAgICAgICAgICB0aW1lb3V0PTYwLAorICAgICAgICAgICAgICAgICAgICAg ICAgdGltZW91dD0xMjAsCiAgICAgICAgICAgICAgICAgICAgICAgICApCiAgICAgICAgICAgICAr IDAsCiAgICAgICAgICkKQEAgLTc4Niw3ICs3ODYsNyBAQCBjbGFzcyBUZXN0S2lsbE9sZFByb2Nl c3NlcyhCdWlsZFN0ZXBNaXhpCiAgICAgICAgICAgICBFeHBlY3RTaGVsbCh3b3JrZGlyPSd3a2Rp cicsCiAgICAgICAgICAgICAgICAgICAgICAgICBjb21tYW5kPVsncHl0aG9uJywgJ1Rvb2xzL0NJ U3VwcG9ydC9raWxsLW9sZC1wcm9jZXNzZXMnLCAnYnVpbGRib3QnXSwKICAgICAgICAgICAgICAg ICAgICAgICAgIGxvZ0Vudmlyb249RmFsc2UsCi0gICAgICAgICAgICAgICAgICAgICAgICB0aW1l b3V0PTYwLAorICAgICAgICAgICAgICAgICAgICAgICAgdGltZW91dD0xMjAsCiAgICAgICAgICAg ICAgICAgICAgICAgICApCiAgICAgICAgICAgICArIEV4cGVjdFNoZWxsLmxvZygnc3RkaW8nLCBz dGRvdXQ9J1VuZXhwZWN0ZWQgZXJyb3IuJykKICAgICAgICAgICAgICsgMiwK