221208 2021-02-01 07:40:53 -0800 [build.webkit.org] is_test_mode_enabled should default to True 2021-02-08 07:37:49 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=196248 InRadar P2 Normal --- 175056 1 aakash_jain aakash_jain aakash_jain jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1724238 0 aakash_jain 2021-02-01 07:40:53 -0800 Similar to https://bugs.webkit.org/show_bug.cgi?id=196248, is_test_mode_enabled variable should default to True in order to avoid accidentally running production settings on a local/test instance. Currently we need to explicitly add an environment variable BUILDBOT_TESTING in order to indicate test instance. If someone forgets to set this environment variable on a local instance, he/she would run with production settings. Currently it's very easy to make this mistake. We should reverse the logic to make it harder to do such mistake. We should instead require to set an environment variable BUILDBOT_PRODUCTION on production server. It will be a one time configuration on the production server (by configuring environment variable in a manner that persist across reboots and various shell sessions). 1724240 1 418872 aakash_jain 2021-02-01 07:41:43 -0800 Created attachment 418872 Patch 1724244 2 webkit-bug-importer 2021-02-01 08:05:34 -0800 <rdar://problem/73829462> 1724273 3 ews-feeder 2021-02-01 09:07:51 -0800 Committed r272144: <https://trac.webkit.org/changeset/272144> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418872. 418872 2021-02-01 07:41:43 -0800 2021-02-01 09:07:52 -0800 Patch bug-221208-20210201104142.patch text/plain 1082 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3MjE0MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDIxLTAyLTAxICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbYnVpbGQud2Via2l0Lm9yZ10gaXNfdGVzdF9tb2RlX2VuYWJsZWQgc2hv dWxkIGRlZmF1bHQgdG8gVHJ1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjIxMjA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBDSVN1cHBvcnQvYnVpbGQtd2Via2l0LW9yZy9tYXN0ZXJfYnVpbGRib3Qy LmNmZzoKKwogMjAyMS0wMi0wMSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgog CiAgICAgICAgIFtKU0NdIEFkZCBAIGluIEVycm9yLnN0YWNrIGlmIFVSTCBleGlzdHMKSW5kZXg6 IFRvb2xzL0NJU3VwcG9ydC9idWlsZC13ZWJraXQtb3JnL21hc3Rlcl9idWlsZGJvdDIuY2ZnCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL0NJU3VwcG9ydC9idWlsZC13ZWJraXQtb3JnL21hc3Rlcl9idWls ZGJvdDIuY2ZnCShyZXZpc2lvbiAyNzIxNDIpCisrKyBUb29scy9DSVN1cHBvcnQvYnVpbGQtd2Vi a2l0LW9yZy9tYXN0ZXJfYnVpbGRib3QyLmNmZwkod29ya2luZyBjb3B5KQpAQCAtOCw3ICs4LDcg QEAgZnJvbSBkYXRldGltZSBpbXBvcnQgdGltZWRlbHRhCiBmcm9tIGxvYWRDb25maWcgaW1wb3J0 ICoKIAogCi1pc190ZXN0X21vZGVfZW5hYmxlZCA9IG9zLmdldGVudignQlVJTERCT1RfVEVTVElO RycpIGlzIG5vdCBOb25lCitpc190ZXN0X21vZGVfZW5hYmxlZCA9IG9zLmdldGVudignQlVJTERC T1RfUFJPRFVDVElPTicpIGlzIE5vbmUKIAogYyA9IEJ1aWxkbWFzdGVyQ29uZmlnID0ge30KIAo=