221200 2021-02-01 05:17:24 -0800 Only update IPC connection of RemoteCaptureSampleManager for audio sources 2021-02-02 04:13:13 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer youennf oldest_to_newest 1724200 0 youennf 2021-02-01 05:17:24 -0800 Only update IPC connection of RemoteCaptureSampleManager for audio sources 1724201 1 418861 youennf 2021-02-01 05:18:49 -0800 Created attachment 418861 Patch 1724274 2 418861 eric.carlson 2021-02-01 09:13:08 -0800 Comment on attachment 418861 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418861&action=review > Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:201 > void UserMediaCaptureManager::didUpdateSourceConnection(RemoteRealtimeMediaSource& source) > { > - m_remoteCaptureSampleManager.didUpdateSourceConnection(source); > + if (source.type() == RealtimeMediaSource::Type::Audio) > + m_remoteCaptureSampleManager.didUpdateSourceConnection(source); > } It isn't clear why this should be for audio only. Should the method be renamed, or at least add a comment explaining why this is? 1724572 3 418861 youennf 2021-02-02 02:03:33 -0800 Comment on attachment 418861 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418861&action=review >> Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:201 >> } > > It isn't clear why this should be for audio only. Should the method be renamed, or at least add a comment explaining why this is? Right, let's rename m_remoteCaptureSampleManager to m_remoteAudioCaptureSampleManager. 1724573 4 418974 youennf 2021-02-02 02:06:01 -0800 Created attachment 418974 Patch for landing 1724594 5 ews-feeder 2021-02-02 02:56:23 -0800 commit-queue failed to commit attachment 418974 to WebKit repository. 1724603 6 ews-feeder 2021-02-02 03:12:02 -0800 commit-queue failed to commit attachment 418974 to WebKit repository. 1724613 7 ews-feeder 2021-02-02 04:12:10 -0800 Committed r272205: <https://trac.webkit.org/changeset/272205> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418974. 1724614 8 webkit-bug-importer 2021-02-02 04:13:13 -0800 <rdar://problem/73874360> 418861 2021-02-01 05:18:49 -0800 2021-02-02 02:05:57 -0800 Patch bug-221200-20210201141847.patch text/plain 1627 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyMTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY4ZjQ1YTNkYWZlNWJhMGQx ZjQ4ZDlkNmY2OWQ5NWRlZTFiOTQwYzYuLmE4NjYzMmU5YmYwNGMyZThlYWNmNDU2NDQ2MjE3Mjk1 NGI5NzQ3NTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMDItMDEgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIE9ubHkgdXBkYXRlIElQQyBjb25u ZWN0aW9uIG9mIFJlbW90ZUNhcHR1cmVTYW1wbGVNYW5hZ2VyIGZvciBhdWRpbyBzb3VyY2VzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjEyMDAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSBpcyBu byBuZWVkIHRvIHVwZGF0ZSB0aGUgY29ubmVjdGlvbiBmb3Igc291cmNlcyB0aGF0IGFyZSBub3Qg YWRkZWQgdG8gdGhlIFJlbW90ZUNhcHR1cmVTYW1wbGVNYW5hZ2VyLgorCisgICAgICAgICogV2Vi UHJvY2Vzcy9jb2NvYS9Vc2VyTWVkaWFDYXB0dXJlTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJL aXQ6OlVzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyOjpkaWRVcGRhdGVTb3VyY2VDb25uZWN0aW9uKToK KwogMjAyMS0wMS0yOSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAg Q2hlY2sgYWN0aXZlRG9jdW1lbnRMb2FkZXIoKSBmb3IgbnVsbCBjb25zaXN0ZW50bHkgZXZlcnl3 aGVyZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1VzZXJNZWRp YUNhcHR1cmVNYW5hZ2VyLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9Vc2Vy TWVkaWFDYXB0dXJlTWFuYWdlci5jcHAKaW5kZXggYmY4ZDkyYzQyZTg4NTUzMzkyMTdjMjM4NDBk MmZhZWEzZTNlNWQ0ZS4uZWM0ZmQ2ZWI5M2NjMGRlZjQ4ZTExZDhhYjlmNTU3YzQ0MWNmMzZiNiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1VzZXJNZWRpYUNhcHR1 cmVNYW5hZ2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvVXNlck1l ZGlhQ2FwdHVyZU1hbmFnZXIuY3BwCkBAIC0xOTYsNyArMTk2LDggQEAgQ2FwdHVyZVNvdXJjZU9y RXJyb3IgVXNlck1lZGlhQ2FwdHVyZU1hbmFnZXI6OkRpc3BsYXlGYWN0b3J5OjpjcmVhdGVEaXNw bGF5Q2FwdHUKIAogdm9pZCBVc2VyTWVkaWFDYXB0dXJlTWFuYWdlcjo6ZGlkVXBkYXRlU291cmNl Q29ubmVjdGlvbihSZW1vdGVSZWFsdGltZU1lZGlhU291cmNlJiBzb3VyY2UpCiB7Ci0gICAgbV9y ZW1vdGVDYXB0dXJlU2FtcGxlTWFuYWdlci5kaWRVcGRhdGVTb3VyY2VDb25uZWN0aW9uKHNvdXJj ZSk7CisgICAgaWYgKHNvdXJjZS50eXBlKCkgPT0gUmVhbHRpbWVNZWRpYVNvdXJjZTo6VHlwZTo6 QXVkaW8pCisgICAgICAgIG1fcmVtb3RlQ2FwdHVyZVNhbXBsZU1hbmFnZXIuZGlkVXBkYXRlU291 cmNlQ29ubmVjdGlvbihzb3VyY2UpOwogfQogCiB9Cg== 418974 2021-02-02 02:06:01 -0800 2021-02-02 04:12:11 -0800 Patch for landing bug-221200-20210202110600.patch text/plain 2861 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyMTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY4ZjQ1YTNkYWZlNWJhMGQx ZjQ4ZDlkNmY2OWQ5NWRlZTFiOTQwYzYuLmU3YTI2NDUzZDYyYTBjOTUzYjY1YjU3YmZhMWU2NDJh ODU0Y2Q3ZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDItMDEgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIE9ubHkgdXBkYXRlIElQQyBjb25u ZWN0aW9uIG9mIFJlbW90ZUNhcHR1cmVTYW1wbGVNYW5hZ2VyIGZvciBhdWRpbyBzb3VyY2VzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjEyMDAKKwor ICAgICAgICBSZXZpZXdlZCBieSBFcmljIENhcmxzb24uCisKKyAgICAgICAgVGhlcmUgaXMgbm8g bmVlZCB0byB1cGRhdGUgdGhlIGNvbm5lY3Rpb24gZm9yIHNvdXJjZXMgdGhhdCBhcmUgbm90IGFk ZGVkIHRvIHRoZSBSZW1vdGVDYXB0dXJlU2FtcGxlTWFuYWdlci4KKworICAgICAgICAqIFdlYlBy b2Nlc3MvY29jb2EvVXNlck1lZGlhQ2FwdHVyZU1hbmFnZXIuY3BwOgorICAgICAgICAoV2ViS2l0 OjpVc2VyTWVkaWFDYXB0dXJlTWFuYWdlcjo6YWRkU291cmNlKToKKyAgICAgICAgKFdlYktpdDo6 VXNlck1lZGlhQ2FwdHVyZU1hbmFnZXI6OmRpZFVwZGF0ZVNvdXJjZUNvbm5lY3Rpb24pOgorICAg ICAgICAqIFdlYlByb2Nlc3MvY29jb2EvVXNlck1lZGlhQ2FwdHVyZU1hbmFnZXIuaDoKKwogMjAy MS0wMS0yOSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgQ2hlY2sg YWN0aXZlRG9jdW1lbnRMb2FkZXIoKSBmb3IgbnVsbCBjb25zaXN0ZW50bHkgZXZlcnl3aGVyZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1VzZXJNZWRpYUNhcHR1 cmVNYW5hZ2VyLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9Vc2VyTWVkaWFD YXB0dXJlTWFuYWdlci5jcHAKaW5kZXggYmY4ZDkyYzQyZTg4NTUzMzkyMTdjMjM4NDBkMmZhZWEz ZTNlNWQ0ZS4uYzFmZjRlNTNlOTJmYjAxNGZjNjg4MGFkZGMyNjYwYTI3YTlkOGI0MSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1VzZXJNZWRpYUNhcHR1cmVNYW5h Z2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvVXNlck1lZGlhQ2Fw dHVyZU1hbmFnZXIuY3BwCkBAIC04OCw3ICs4OCw3IEBAIHZvaWQgVXNlck1lZGlhQ2FwdHVyZU1h bmFnZXI6OnNldHVwQ2FwdHVyZVByb2Nlc3Nlcyhib29sIHNob3VsZENhcHR1cmVBdWRpb0luVUlQ CiB2b2lkIFVzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyOjphZGRTb3VyY2UoUmVmPFJlbW90ZVJlYWx0 aW1lTWVkaWFTb3VyY2U+JiYgc291cmNlKQogewogICAgIGlmIChzb3VyY2UtPnR5cGUoKSA9PSBS ZWFsdGltZU1lZGlhU291cmNlOjpUeXBlOjpBdWRpbykKLSAgICAgICAgbV9yZW1vdGVDYXB0dXJl U2FtcGxlTWFuYWdlci5hZGRTb3VyY2Uoc291cmNlLmNvcHlSZWYoKSk7CisgICAgICAgIG1fcmVt b3RlQXVkaW9DYXB0dXJlU2FtcGxlTWFuYWdlci5hZGRTb3VyY2Uoc291cmNlLmNvcHlSZWYoKSk7 CiAKICAgICBhdXRvIGlkZW50aWZpZXIgPSBzb3VyY2UtPmlkZW50aWZpZXIoKTsKICAgICBBU1NF UlQoIW1fc291cmNlcy5jb250YWlucyhpZGVudGlmaWVyKSk7CkBAIC0xOTYsNyArMTk2LDggQEAg Q2FwdHVyZVNvdXJjZU9yRXJyb3IgVXNlck1lZGlhQ2FwdHVyZU1hbmFnZXI6OkRpc3BsYXlGYWN0 b3J5OjpjcmVhdGVEaXNwbGF5Q2FwdHUKIAogdm9pZCBVc2VyTWVkaWFDYXB0dXJlTWFuYWdlcjo6 ZGlkVXBkYXRlU291cmNlQ29ubmVjdGlvbihSZW1vdGVSZWFsdGltZU1lZGlhU291cmNlJiBzb3Vy Y2UpCiB7Ci0gICAgbV9yZW1vdGVDYXB0dXJlU2FtcGxlTWFuYWdlci5kaWRVcGRhdGVTb3VyY2VD b25uZWN0aW9uKHNvdXJjZSk7CisgICAgaWYgKHNvdXJjZS50eXBlKCkgPT0gUmVhbHRpbWVNZWRp YVNvdXJjZTo6VHlwZTo6QXVkaW8pCisgICAgICAgIG1fcmVtb3RlQXVkaW9DYXB0dXJlU2FtcGxl TWFuYWdlci5kaWRVcGRhdGVTb3VyY2VDb25uZWN0aW9uKHNvdXJjZSk7CiB9CiAKIH0KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9Vc2VyTWVkaWFDYXB0dXJlTWFu YWdlci5oIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1VzZXJNZWRpYUNhcHR1cmVN YW5hZ2VyLmgKaW5kZXggOWUwMmFhYmNiY2Q1ZGM0YTEwNTQ2YmZiMGIxMWYxNDE0MDMyMjhmNS4u MWFmMWYxOGI5NTBiODhjODUzMGZjYjI5N2E0ZmQ4ODM1ZTgzNWQ4MCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1VzZXJNZWRpYUNhcHR1cmVNYW5hZ2VyLmgKKysr IGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1VzZXJNZWRpYUNhcHR1cmVNYW5hZ2Vy LmgKQEAgLTEzNyw3ICsxMzcsNyBAQCBwcml2YXRlOgogICAgIEF1ZGlvRmFjdG9yeSBtX2F1ZGlv RmFjdG9yeTsKICAgICBWaWRlb0ZhY3RvcnkgbV92aWRlb0ZhY3Rvcnk7CiAgICAgRGlzcGxheUZh Y3RvcnkgbV9kaXNwbGF5RmFjdG9yeTsKLSAgICBSZW1vdGVDYXB0dXJlU2FtcGxlTWFuYWdlciBt X3JlbW90ZUNhcHR1cmVTYW1wbGVNYW5hZ2VyOworICAgIFJlbW90ZUNhcHR1cmVTYW1wbGVNYW5h Z2VyIG1fcmVtb3RlQXVkaW9DYXB0dXJlU2FtcGxlTWFuYWdlcjsKIH07CiAKIH0gLy8gbmFtZXNw YWNlIFdlYktpdAo=