221198 2021-02-01 02:26:46 -0800 CeilingOnPageSize too low for Loongson CPUs 2022-02-15 07:47:51 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 berto webkit-unassigned angelos benjamin berto cdumez chengzhpchn cmarcelo ews-watchlist mcatanzaro webkit-bug-importer xan.lopez oldest_to_newest 1724157 0 berto 2021-02-01 02:26:46 -0800 CeilingOnPageSize is set to 4KB for MIPS on Linux, but that value is not permitted on Loongson CPUs which have a 16KB page size: https://sources.debian.org/src/linux/5.10.9-1/arch/mips/Kconfig/#L2213-L2215 1724169 1 xan.lopez 2021-02-01 02:56:04 -0800 Our guess is that we are crashing in WTF::pageSize(): RELEASE_ASSERT_WITH_MESSAGE(s_pageSize <= CeilingOnPageSize, "CeilingOnPageSize is too low, raise it in PageBlock.h!"); For Loongson CPUs that will be 16 <= 4, which won't work. We can change the general ceiling value for MIPS to something else, at least 16KB, or try to detect Loongson CPUs and change it just for those. 1724170 2 berto 2021-02-01 02:59:32 -0800 (In reply to Xan Lopez from comment #1) > We can change the general ceiling value for MIPS to something else, > at least 16KB, or try to detect Loongson CPUs and change it just for > those. For distributions I don't think the latter is an option, because there's no guarantee that the machine where the package is built is the same where it is installed and run. But I can patch that downstream if there's no good general solution. 1726575 3 webkit-bug-importer 2021-02-08 02:27:13 -0800 <rdar://problem/74089683> 1760472 4 berto 2021-05-15 14:13:58 -0700 This was fixed for 32-bit MIPS in r276583 (bug 225030), I think we should also do it for MIPS64. 1760485 5 mcatanzaro 2021-05-15 15:46:19 -0700 (In reply to Alberto Garcia from comment #4) > This was fixed for 32-bit MIPS in r276583 (bug 225030), I think we should > also do it for MIPS64. Do it! 1760489 6 428747 berto 2021-05-15 15:57:25 -0700 Created attachment 428747 Patch 1760496 7 ews-feeder 2021-05-15 16:55:01 -0700 Committed r277551 (237779@main): <https://commits.webkit.org/237779@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428747. 1841714 8 mcatanzaro 2022-02-15 07:47:51 -0800 *** Bug 223721 has been marked as a duplicate of this bug. *** 428747 2021-05-15 15:57:25 -0700 2021-05-15 16:55:03 -0700 Patch 221198.diff text/plain 1513 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggMGZhMWM3N2FiNDljLi5kODdkNTFmZGFmOWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIw MjEtMDUtMTUgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlhLmNvbT4KKworICAgICAgICBD ZWlsaW5nT25QYWdlU2l6ZSB0b28gbG93IGZvciBMb29uZ3NvbiBDUFVzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjExOTgKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzc0MDg5NjgzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEluY3JlYXNlIHRoZSBwYWdlIHNpemUgdG8gMTZLQiBpbiBNSVBTNjQuCisK KyAgICAgICAgKiB3dGYvUGFnZUJsb2NrLmg6CisKIDIwMjEtMDUtMTQgIENocmlzIER1bWV6ICA8 Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBEcm9wIEZpbGVTeXN0ZW06OmZpbGVNZXRhZGF0 YSgpIC8gZmlsZU1ldGFkYXRhRm9sbG93aW5nU3ltbGlua3MoKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dURi93dGYvUGFnZUJsb2NrLmggYi9Tb3VyY2UvV1RGL3d0Zi9QYWdlQmxvY2suaAppbmRleCA0 MzQzMDAzNWExNTguLjYwODJmMmQ2MmJiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvUGFn ZUJsb2NrLmgKKysrIGIvU291cmNlL1dURi93dGYvUGFnZUJsb2NrLmgKQEAgLTQ3LDExICs0Nywx MSBAQCBuYW1lc3BhY2UgV1RGIHsKIC8vIDY0IEtpQi4gKEFwcGxlIHVzZXMgMTYgS2lCLikKIC8v CiAvLyBVc2UgNjQgS2lCIGZvciBhbnkgdW5rbm93biBDUFVzIHRvIGJlIGNvbnNlcnZhdGl2ZS4K LSNpZiBPUyhEQVJXSU4pIHx8IFBMQVRGT1JNKFBMQVlTVEFUSU9OKSB8fCBDUFUoTUlQUykKKyNp ZiBPUyhEQVJXSU4pIHx8IFBMQVRGT1JNKFBMQVlTVEFUSU9OKSB8fCBDUFUoTUlQUykgfHwgQ1BV KE1JUFM2NCkKIGNvbnN0ZXhwciBzaXplX3QgQ2VpbGluZ09uUGFnZVNpemUgPSAxNiAqIEtCOwog I2VsaWYgVVNFKDY0S0JfUEFHRV9CTE9DSykgfHwgQ1BVKFBQQykgfHwgQ1BVKFBQQzY0KSB8fCBD UFUoUFBDNjRMRSkgfHwgQ1BVKFVOS05PV04pCiBjb25zdGV4cHIgc2l6ZV90IENlaWxpbmdPblBh Z2VTaXplID0gNjQgKiBLQjsKLSNlbGlmIE9TKFdJTkRPV1MpIHx8IENQVShNSVBTNjQpIHx8IENQ VShYODYpIHx8IENQVShYODZfNjQpIHx8IENQVShBUk0pIHx8IENQVShBUk02NCkKKyNlbGlmIE9T KFdJTkRPV1MpIHx8IENQVShYODYpIHx8IENQVShYODZfNjQpIHx8IENQVShBUk0pIHx8IENQVShB Uk02NCkKIGNvbnN0ZXhwciBzaXplX3QgQ2VpbGluZ09uUGFnZVNpemUgPSA0ICogS0I7CiAjZWxz ZQogI2Vycm9yIE11c3Qgc2V0IENlaWxpbmdPblBhZ2VTaXplIGluIFBhZ2VCbG9jay5oIHdoZW4g YWRkaW5nIGEgbmV3IENQVSBhcmNoaXRlY3R1cmUhCg==