221196 2021-02-01 01:24:59 -0800 [LFC][Integration] RenderInline::offsetLeft needs to call ensureLineBoxes 2021-02-01 07:12:13 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned bfulgham changseok esprehn+autocc ews-watchlist glenn kondapallykalyan pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1724136 0 koivisto 2021-02-01 01:24:59 -0800 Use ensureLineBoxes for rare API calls before we implement them fully in LFC integration. 1724143 1 418847 koivisto 2021-02-01 01:56:17 -0800 Created attachment 418847 patch 1724229 2 ews-feeder 2021-02-01 07:11:14 -0800 Committed r272142: <https://trac.webkit.org/changeset/272142> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418847. 1724230 3 webkit-bug-importer 2021-02-01 07:12:13 -0800 <rdar://problem/73828261> 418847 2021-02-01 01:56:17 -0800 2021-02-01 07:11:15 -0800 patch lfc-renderinline-ensure.patch text/plain 3255 koivisto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzOTk2MjNhMDU5YzUuLjk1OTk1OWUzYTQxYSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE5IEBACisyMDIxLTAyLTAxICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNv bT4KKworICAgICAgICBbTEZDXVtJbnRlZ3JhdGlvbl0gUmVuZGVySW5saW5lOjpvZmZzZXRMZWZ0 IG5lZWRzIHRvIGNhbGwgZW5zdXJlTGluZUJveGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjExOTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgZW5zdXJlTGluZUJveGVzIGZvciByYXJlIEFQSSBj YWxscyBiZWZvcmUgd2UgaW1wbGVtZW50IHRoZW0gZnVsbHkgaW4gTEZDIGludGVncmF0aW9uLgor CisgICAgICAgICogbGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uQ292ZXJhZ2Uu Y3BwOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJJbmxpbmUuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVySW5saW5lOjphYnNvbHV0ZVF1YWRzRm9yU2VsZWN0aW9uIGNvbnN0KToKKyAg ICAgICAgKFdlYkNvcmU6OlJlbmRlcklubGluZTo6b2Zmc2V0TGVmdCBjb25zdCk6CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJJbmxpbmU6Om9mZnNldFRvcCBjb25zdCk6CisgICAgICAgIChXZWJD b3JlOjpSZW5kZXJJbmxpbmU6Om5vZGVBdFBvaW50KToKKwogMjAyMS0wMS0zMSAgWGFiaWVyIFJv ZHJpZ3VleiBDYWx2YXIgIDxjYWx2YXJpc0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHU3RyZWFt ZXJdW0VNRV0gQWRkIGJhc2ljIGNiY3Mgc3VwcG9ydApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlcklubGluZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVySW5saW5lLmNwcAppbmRleCA3NWRjNWIzNjk2MjMuLmU0YTlkNzI4NzE1ZSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcklubGluZS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcklubGluZS5jcHAKQEAgLTQyNyw2ICs0MjcsMTAg QEAgdm9pZCBSZW5kZXJJbmxpbmU6OmFic29sdXRlUXVhZHNJZ25vcmluZ0NvbnRpbnVhdGlvbihj b25zdCBGbG9hdFJlY3QmLCBWZWN0b3I8RmwKICNpZiBQTEFURk9STShJT1NfRkFNSUxZKQogdm9p ZCBSZW5kZXJJbmxpbmU6OmFic29sdXRlUXVhZHNGb3JTZWxlY3Rpb24oVmVjdG9yPEZsb2F0UXVh ZD4mIHF1YWRzKSBjb25zdAogeworI2lmIEVOQUJMRShMQVlPVVRfRk9STUFUVElOR19DT05URVhU KQorICAgIGlmIChhdXRvKiBsaW5lTGF5b3V0ID0gTGF5b3V0SW50ZWdyYXRpb246OkxpbmVMYXlv dXQ6OmNvbnRhaW5pbmcoY29uc3RfY2FzdDxSZW5kZXJJbmxpbmUmPigqdGhpcykpKQorICAgICAg ICBsaW5lTGF5b3V0LT5mbG93KCkuZW5zdXJlTGluZUJveGVzKCk7CisjZW5kaWYKICAgICBBYnNv bHV0ZVF1YWRzR2VuZXJhdG9yQ29udGV4dCBjb250ZXh0KHRoaXMsIHF1YWRzKTsKICAgICBnZW5l cmF0ZUxpbmVCb3hSZWN0cyhjb250ZXh0KTsKIH0KQEAgLTQzNCw2ICs0MzgsMTAgQEAgdm9pZCBS ZW5kZXJJbmxpbmU6OmFic29sdXRlUXVhZHNGb3JTZWxlY3Rpb24oVmVjdG9yPEZsb2F0UXVhZD4m IHF1YWRzKSBjb25zdAogCiBMYXlvdXRVbml0IFJlbmRlcklubGluZTo6b2Zmc2V0TGVmdCgpIGNv bnN0CiB7CisjaWYgRU5BQkxFKExBWU9VVF9GT1JNQVRUSU5HX0NPTlRFWFQpCisgICAgaWYgKGF1 dG8qIGxpbmVMYXlvdXQgPSBMYXlvdXRJbnRlZ3JhdGlvbjo6TGluZUxheW91dDo6Y29udGFpbmlu Zyhjb25zdF9jYXN0PFJlbmRlcklubGluZSY+KCp0aGlzKSkpCisgICAgICAgIGxpbmVMYXlvdXQt PmZsb3coKS5lbnN1cmVMaW5lQm94ZXMoKTsKKyNlbmRpZgogICAgIExheW91dFBvaW50IHRvcExl ZnQ7CiAgICAgaWYgKElubGluZUJveCogZmlyc3RCb3ggPSBmaXJzdExpbmVCb3hJbmNsdWRpbmdD dWxsaW5nKCkpCiAgICAgICAgIHRvcExlZnQgPSBmbG9vcmVkTGF5b3V0UG9pbnQoZmlyc3RCb3gt PnRvcExlZnQoKSk7CkBAIC00NDIsNiArNDUwLDEwIEBAIExheW91dFVuaXQgUmVuZGVySW5saW5l OjpvZmZzZXRMZWZ0KCkgY29uc3QKIAogTGF5b3V0VW5pdCBSZW5kZXJJbmxpbmU6Om9mZnNldFRv cCgpIGNvbnN0CiB7CisjaWYgRU5BQkxFKExBWU9VVF9GT1JNQVRUSU5HX0NPTlRFWFQpCisgICAg aWYgKGF1dG8qIGxpbmVMYXlvdXQgPSBMYXlvdXRJbnRlZ3JhdGlvbjo6TGluZUxheW91dDo6Y29u dGFpbmluZyhjb25zdF9jYXN0PFJlbmRlcklubGluZSY+KCp0aGlzKSkpCisgICAgICAgIGxpbmVM YXlvdXQtPmZsb3coKS5lbnN1cmVMaW5lQm94ZXMoKTsKKyNlbmRpZgogICAgIExheW91dFBvaW50 IHRvcExlZnQ7CiAgICAgaWYgKElubGluZUJveCogZmlyc3RCb3ggPSBmaXJzdExpbmVCb3hJbmNs dWRpbmdDdWxsaW5nKCkpCiAgICAgICAgIHRvcExlZnQgPSBmbG9vcmVkTGF5b3V0UG9pbnQoZmly c3RCb3gtPnRvcExlZnQoKSk7CkBAIC01MTYsNiArNTI4LDEwIEBAIGNvbnN0IGNoYXIqIFJlbmRl cklubGluZTo6cmVuZGVyTmFtZSgpIGNvbnN0CiBib29sIFJlbmRlcklubGluZTo6bm9kZUF0UG9p bnQoY29uc3QgSGl0VGVzdFJlcXVlc3QmIHJlcXVlc3QsIEhpdFRlc3RSZXN1bHQmIHJlc3VsdCwK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgSGl0VGVzdExvY2F0aW9uJiBs b2NhdGlvbkluQ29udGFpbmVyLCBjb25zdCBMYXlvdXRQb2ludCYgYWNjdW11bGF0ZWRPZmZzZXQs IEhpdFRlc3RBY3Rpb24gaGl0VGVzdEFjdGlvbikKIHsKKyNpZiBFTkFCTEUoTEFZT1VUX0ZPUk1B VFRJTkdfQ09OVEVYVCkKKyAgICBpZiAoYXV0byogbGluZUxheW91dCA9IExheW91dEludGVncmF0 aW9uOjpMaW5lTGF5b3V0Ojpjb250YWluaW5nKGNvbnN0X2Nhc3Q8UmVuZGVySW5saW5lJj4oKnRo aXMpKSkKKyAgICAgICAgbGluZUxheW91dC0+ZmxvdygpLmVuc3VyZUxpbmVCb3hlcygpOworI2Vu ZGlmCiAgICAgcmV0dXJuIG1fbGluZUJveGVzLmhpdFRlc3QodGhpcywgcmVxdWVzdCwgcmVzdWx0 LCBsb2NhdGlvbkluQ29udGFpbmVyLCBhY2N1bXVsYXRlZE9mZnNldCwgaGl0VGVzdEFjdGlvbik7 CiB9CiAK