221189 2021-01-31 10:29:41 -0800 [LFC][IFC] InlineContentBreaker::processOverflowingTextContent should find breaking positions even after the overflowing run 2021-01-31 16:47:13 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1724089 0 zalan 2021-01-31 10:29:41 -0800 <span>unbreakable_and_overflow<span style="word-break: break-all">breakable</span> should be able to break at "breakable" 1724090 1 418828 zalan 2021-01-31 10:57:21 -0800 Created attachment 418828 Patch 1724116 2 ews-feeder 2021-01-31 16:46:03 -0800 Committed r272128: <https://trac.webkit.org/changeset/272128> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418828. 1724117 3 webkit-bug-importer 2021-01-31 16:47:13 -0800 <rdar://problem/73811630> 418828 2021-01-31 10:57:21 -0800 2021-01-31 16:46:05 -0800 Patch bug-221189-20210131105720.patch text/plain 5409 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyMDk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGRlYjYyMjBhM2ExZGZk ZDJkOGVjZDUwNTY0MGM5ZDNiZDdiMzgyZC4uMTU0YTgzYjQwZjcwOWY4NzFlNDdlYmQ0M2Y5NGVh MGFlOGEwOGI4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTAxLTMxICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBJbmxpbmVD b250ZW50QnJlYWtlcjo6cHJvY2Vzc092ZXJmbG93aW5nVGV4dENvbnRlbnQgc2hvdWxkIGZpbmQg YnJlYWtpbmcgcG9zaXRpb25zIGV2ZW4gYWZ0ZXIgdGhlIG92ZXJmbG93aW5nIHJ1bgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIxMTg5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiB0aGUgY29udGVu dCBoYXMgbXVsdGlwbGUgKGNvbnRpbm91cylydW5zLCBhbmQgd2UgZmluZCB0aGUgb3ZlcmZsb3dp bmcgb25lCisgICAgICAgIDEuIGZpcnN0IHN0YXJ0IHNlYXJjaGluZyBiYWNrd2FyZHMgdG8gc2Vl IGlmIHdlIGNhbiBmaW5kIHNvbWV0aGluZyB0aGF0J3MgYnJlYWthYmxlICh0aGlzIGlzIGFscmVh ZHkgaW1wbGVtZW50ZWQpCisgICAgICAgIDIuIHN0YXJ0IHNlYXJjaGluZyBmb3J3YXJkIHRvIHNl ZSBpZiB3ZSBjYW4gZmluZCBzb21ldGhpbmcgdGhhdCdzIGJyZWFrYWJsZSAtdGhvdWdoIGluIHRo aXMgY2FzZSBpdCdzIHN1cmVseSBvdmVyZmxvd2luZy4KKworICAgICAgICBUaGlzIHBhdGNoIGlt cGxlbWVudHMgIzIuCisKKyAgICAgICAgKiBsYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVD b250ZW50QnJlYWtlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OklubGluZUNvbnRl bnRCcmVha2VyOjpwcm9jZXNzT3ZlcmZsb3dpbmdUZXh0Q29udGVudCBjb25zdCk6CisKIDIwMjEt MDEtMzEgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtJ RkNdIERvIG5vdCB1c2UgYSBtYXggdmFsdWUgdG8gaW5kaWNhdGUgaW5maW5pdGUgYXZhaWxhYmxl IHNwYWNlIGluIElubGluZUNvbnRlbnRCcmVha2VyOjp0cnlCcmVha2luZ1RleHRSdW4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUNvbnRl bnRCcmVha2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lu bGluZUNvbnRlbnRCcmVha2VyLmNwcAppbmRleCA4YmNkMDZjMjlhM2Q4Nzk4NDc2MzAwMTc2ZDEy ZTlhNWRiNTQzMjE2Li40OWJhM2FmMmFjNWQ2Y2QzNTZkZGQxZjEyYzIxZjZmMWI0NDA1NDYyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVD b250ZW50QnJlYWtlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1h dHRpbmcvSW5saW5lQ29udGVudEJyZWFrZXIuY3BwCkBAIC0zMTIsMTYgKzMxMiw0NyBAQCBPcHRp b25hbDxUcmFpbGluZ1RleHRDb250ZW50PiBJbmxpbmVDb250ZW50QnJlYWtlcjo6cHJvY2Vzc092 ZXJmbG93aW5nVGV4dENvbnRlbgogICAgICAgICArK2luZGV4OwogICAgIH0KICAgICAvLyBXZSBk aWQgbm90IG1hbmFnZSB0byBicmVhayB0aGUgcnVuIHRoYXQgYWN0dWFsbHkgb3ZlcmZsb3dzIHRo ZSBsaW5lLgotICAgIC8vIExldCdzIHRyeSB0byBmaW5kIHRoZSBsYXN0IGJyZWFrYWJsZSBwb3Np dGlvbiBzdGFydGluZyBmcm9tIHRoZSBvdmVyZmxvd2luZyBydW4gYW5kIHdyYXAgaXQgYXQgdGhl IGNvbnRlbnQgYm91bmRhcnkgKGFzIGl0IHN1cmVseSBmaXRzKS4KLSAgICB3aGlsZSAoaW5kZXgt LSkgewotICAgICAgICBhdXRvJiBydW4gPSBydW5zW2luZGV4XTsKLSAgICAgICAgYWNjdW11bGF0 ZWRSdW5XaWR0aCAtPSBydW4ubG9naWNhbFdpZHRoOworICAgIC8vIExldCdzIHRyeSB0byBmaW5k IHRoZSBhIHByZXZpb3VzIGJyZWFraW5nIHBvc2l0aW9uIHN0YXJ0aW5nIGZyb20gdGhlIG92ZXJm bG93aW5nIHJ1bi4gSXQgc3VyZWx5IGZpdHMuCisgICAgYXV0byBwcmV2aW91c1J1bkluZGV4ID0g aW5kZXg7CisgICAgYXV0byBwcmV2aW91c0FjY3VtdWxhdGVkQ29udGVudFdpZHRoID0gYWNjdW11 bGF0ZWRSdW5XaWR0aDsKKyAgICB3aGlsZSAocHJldmlvdXNSdW5JbmRleC0tKSB7CisgICAgICAg IGF1dG8mIHJ1biA9IHJ1bnNbcHJldmlvdXNSdW5JbmRleF07CisgICAgICAgIHByZXZpb3VzQWNj dW11bGF0ZWRDb250ZW50V2lkdGggLT0gcnVuLmxvZ2ljYWxXaWR0aDsKKyAgICAgICAgaWYgKGlz QnJlYWthYmxlUnVuKHJ1bikpIHsKKyAgICAgICAgICAgIEFTU0VSVChydW4uaW5saW5lSXRlbS5p c1RleHQoKSk7CisgICAgICAgICAgICBpZiAoYXV0byBwYXJ0aWFsUnVuID0gdHJ5QnJlYWtpbmdU ZXh0UnVuKHJ1biwgbGluZVN0YXR1cy5jb250ZW50TG9naWNhbFJpZ2h0ICsgcHJldmlvdXNBY2N1 bXVsYXRlZENvbnRlbnRXaWR0aCwgeyB9KSkgeworICAgICAgICAgICAgICAgIC8vIFdlIGtub3cg dGhpcyBydW4gZml0cywgc28gaWYgYnJlYWtpbmcgaXMgYWxsb3dlZCBvbiB0aGUgcnVuLCBpdCBz aG91bGQgcmV0dXJuIGEgbm9uLWVtcHR5IGxlZnQtc2lkZQorICAgICAgICAgICAgICAgIC8vIHNp bmNlIGl0J3MgZWl0aGVyIGF0IGh5cGVuIHBvc2l0aW9uIG9yIHRoZSBlbnRpcmUgcnVuIGlzIHJl dHVybmVkLgorICAgICAgICAgICAgICAgIEFTU0VSVChwYXJ0aWFsUnVuLT5sZW5ndGgpOworICAg ICAgICAgICAgICAgIGF1dG8gcnVuSXNGdWxseUFjY29tbW9kYXRlZCA9IHBhcnRpYWxSdW4tPmxl bmd0aCA9PSBkb3duY2FzdDxJbmxpbmVUZXh0SXRlbT4ocnVuLmlubGluZUl0ZW0pLmxlbmd0aCgp OworICAgICAgICAgICAgICAgIHJldHVybiBUcmFpbGluZ1RleHRDb250ZW50IHsgcHJldmlvdXNS dW5JbmRleCwgZmFsc2UsIHJ1bklzRnVsbHlBY2NvbW1vZGF0ZWQgPyBXVEY6Om51bGxvcHQgOiBw YXJ0aWFsUnVuIH07CisgICAgICAgICAgICB9CisgICAgICAgIH0KKyAgICB9CisgICAgLy8gQXQg dGhpcyBwb2ludCB3ZSBrbm93IHRoYXQgdGhlcmUncyBubyBicmVha2FibGUgcnVuIGFsbCB0aGUg d2F5IHRvIHRoZSBvdmVyZmxvd2luZyBydW4uCisgICAgLy8gTm93IHdlIG5lZWQgdG8gY2hlY2sg aWYgYW55IHJ1biBhZnRlciB0aGUgb3ZlcmZsb3dpbmcgY29udGVudCBjYW4gYnJlYWsuCisgICAg Ly8gZS5nLiA8c3Bhbj50aGlzX2NvbnRlbnRfb3ZlcmZsb3dzX2J1dF9ub3RfYnJlYWthYmxlPHNw YW4+PHNwYW4gc3R5bGU9IndvcmQtYnJlYWs6IGJyZWFrLWFsbCI+YnV0X3RoaXNfaXNfYnJlYWth YmxlPC9zcGFuPgorICAgIGF1dG8gbmV4dFJ1bkluZGV4ID0gaW5kZXg7CisgICAgYXV0byBuZXh0 QWNjdW11bGF0ZWRDb250ZW50V2lkdGggPSBhY2N1bXVsYXRlZFJ1bldpZHRoOworICAgIHdoaWxl ICgrK25leHRSdW5JbmRleCA8IHJ1bnMuc2l6ZSgpKSB7CisgICAgICAgIGF1dG8mIHJ1biA9IHJ1 bnNbbmV4dFJ1bkluZGV4XTsKKyAgICAgICAgbmV4dEFjY3VtdWxhdGVkQ29udGVudFdpZHRoICs9 IHJ1bi5sb2dpY2FsV2lkdGg7CiAgICAgICAgIGlmIChpc0JyZWFrYWJsZVJ1bihydW4pKSB7CiAg ICAgICAgICAgICBBU1NFUlQocnVuLmlubGluZUl0ZW0uaXNUZXh0KCkpOwotICAgICAgICAgICAg aWYgKGF1dG8gcGFydGlhbFJ1biA9IHRyeUJyZWFraW5nVGV4dFJ1bihydW4sIGxpbmVTdGF0dXMu Y29udGVudExvZ2ljYWxSaWdodCArIGFjY3VtdWxhdGVkUnVuV2lkdGgsIHsgfSkpIHsKLSAgICAg ICAgICAgICAgICAvLyBXZSBrbm93IHRoaXMgcnVuIGZpdHMsIHNvIGlmIHdyYXBwaW5nIGlzIGFs bG93ZWQgb24gdGhlIHJ1biwgaXQgc2hvdWxkIHJldHVybiBhIG5vbi1lbXB0eSBsZWZ0LXNpZGUu CisgICAgICAgICAgICAvLyBXZSBrbm93IHRoYXQgdGhpcyBydW4gZG9lcyBub3QgZml0IHRoZSBh dmFpbGFibGUgc3BhY2UuIElmIHdlIGNhbiBicmVhayBhdCBhbnkgcG9zaXRpb24sIGxldCdzIGp1 c3QgdXNlIHRoZSBzdGFydCBvZiB0aGUgcnVuLgorICAgICAgICAgICAgaWYgKHdvcmRCcmVha0Jl aGF2aW9yKHJ1bi5pbmxpbmVJdGVtLnN0eWxlKCkpID09IFdvcmRCcmVha1J1bGU6OkF0QXJiaXRy YXJ5UG9zaXRpb24pIHsKKyAgICAgICAgICAgICAgICAvLyBXZSBtdXN0IGJlIG9uIGFuIGlubGlu ZSBib3ggYm91bmRhcnkuIExldCdzIGdvIGJhY2sgdG8gdGhlIHJ1biBpbiBmcm9udCBvZiB0aGUg aW5saW5lIGJveCBzdGFydCBydW4uCisgICAgICAgICAgICAgICAgLy8gZS5nLiA8c3Bhbj51bmJy ZWFrYWJsZV9hbmRfb3ZlcmZsb3c8c3BhbiBzdHlsZT0id29yZC1icmVhazogYnJlYWstYWxsIj5i cmVha2FibGU8L3NwYW4+CisgICAgICAgICAgICAgICAgLy8gV2UgYXJlIGF0ICJicmVha2FibGUi LCA8c3Bhbj4gaXMgYXQgbmV4dFJ1bkluZGV4IC0gMSBhbmQgdGhlIHRyYWlsaW5nIHJ1biBpcyBh dCBuZXh0UnVuSW5kZXggLSAyLgorICAgICAgICAgICAgICAgIEFTU0VSVChydW5zW25leHRSdW5J bmRleCAtIDFdLmlubGluZUl0ZW0uaXNJbmxpbmVCb3hTdGFydCgpKTsKKyAgICAgICAgICAgICAg ICAvLyBBdCB3b3JzdCB3ZSBhcmUgYmFjayB0byB0aGUgb3ZlcmZsb3dpbmcgcnVuLCBsaWtlIGlu IHRoZSBleGFtcGxlIGFib3ZlLgorICAgICAgICAgICAgICAgIEFTU0VSVChuZXh0UnVuSW5kZXgg LSAyID49IGluZGV4KTsKKyAgICAgICAgICAgICAgICByZXR1cm4gVHJhaWxpbmdUZXh0Q29udGVu dCB7IG5leHRSdW5JbmRleCAtIDIsIHRydWUsIHsgfSB9OworICAgICAgICAgICAgfQorICAgICAg ICAgICAgaWYgKGF1dG8gcGFydGlhbFJ1biA9IHRyeUJyZWFraW5nVGV4dFJ1bihydW4sIGxpbmVT dGF0dXMuY29udGVudExvZ2ljYWxSaWdodCArIG5leHRBY2N1bXVsYXRlZENvbnRlbnRXaWR0aCwg eyB9KSkgewogICAgICAgICAgICAgICAgIEFTU0VSVChwYXJ0aWFsUnVuLT5sZW5ndGgpOwotICAg ICAgICAgICAgICAgIHJldHVybiBUcmFpbGluZ1RleHRDb250ZW50IHsgaW5kZXgsIGZhbHNlLCBw YXJ0aWFsUnVuIH07CisgICAgICAgICAgICAgICAgLy8gV2UgbWFuYWdlZCB0byBicmVhayB0aGlz IHRleHQgcnVuIG1pZCBjb250ZW50LiBJdCBoYXMgdG8gYmUgYSBoeXBoZW4gYnJlYWsuCisgICAg ICAgICAgICAgICAgcmV0dXJuIFRyYWlsaW5nVGV4dENvbnRlbnQgeyBuZXh0UnVuSW5kZXgsIHRy dWUsIHBhcnRpYWxSdW4gfTsKICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0K