221179 2021-01-30 10:09:50 -0800 [LFC][IFC] Line gap metric should apply to all inline boxes 2021-01-30 11:35:14 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1724040 0 zalan 2021-01-30 10:09:50 -0800 "If line-height computes to normal and either text-edge is leading or this is the root inline box, the font’s line gap metric may also be incorporated into A and D by adding half to each side as half-leading." https://www.w3.org/TR/css-inline-3/#inline-height since we don't have text-edge support yet, it applies to all inline boxes. 1724041 1 418817 zalan 2021-01-30 10:16:16 -0800 Created attachment 418817 Patch 1724052 2 ews-feeder 2021-01-30 11:34:53 -0800 Committed r272118: <https://trac.webkit.org/changeset/272118> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418817. 1724053 3 webkit-bug-importer 2021-01-30 11:35:14 -0800 <rdar://problem/73794661> 418817 2021-01-30 10:16:16 -0800 2021-01-30 11:34:54 -0800 Patch bug-221179-20210130101615.patch text/plain 2805 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyMTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTUzNTJjMWE2MWIwZjVh ZjQyNDU5YmZhNTFhODcwNDhhNjg0Y2ZjZi4uNWRkMDExZTYxMzNhMTIwYWFhMTlhNTQ5OGQxNWQ3 MjBhNjMxOWU0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTAxLTMwICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBMaW5lIGdh cCBtZXRyaWMgc2hvdWxkIGFwcGx5IHRvIGFsbCBpbmxpbmUgYm94ZXMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTE3OQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFjY29yZGluZyB0byB0aGUgQ1NTIHNw ZWMgKGh0dHBzOi8vd3d3LnczLm9yZy9UUi9jc3MtaW5saW5lLTMvI2lubGluZS1oZWlnaHQpCisg ICAgICAgIHdoZW4gdGhlIGxpbmUtaGVpZ2h0IGNvbXB1dGVzIHRvIG5vcm1hbCAoUmVuZGVyU3R5 bGU6OmxpbmVIZWlnaHQoKS5pc05lZ2F0aXZlKCkpIGFuZAorICAgICAgICBlaXRoZXIgdGV4dC1l ZGdlIGlzIGxlYWRpbmcgKHByb3BlcnR5IGlzIG5vdCBzdXBwb3J0ZWQgeWV0LCBpbml0aWFsIHZh bHVlIGlzIGxlYWRpbmcpIG9yCisgICAgICAgIHRoaXMgaXMgdGhlIHJvb3QgaW5saW5lIGJveCwg dGhlIGZvbnTigJlzIGxpbmUgZ2FwIHNob3VsZCBiZSB0YWtlbiBpbnRvIGFjY291bnQgd2hlbiBj b21wdXRpbmcgCisgICAgICAgIGxheW91dCBib3VuZHMuCisKKyAgICAgICAgKiBsYXlvdXQvaW5s aW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4dEdlb21ldHJ5LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkxheW91dDo6TGluZUJveEJ1aWxkZXI6OnNldFZlcnRpY2FsR2VvbWV0cnlG b3JJbmxpbmVCb3ggY29uc3QpOgorCiAyMDIxLTAxLTMwICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBh cHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bSUZDXSBBZGp1c3QgdGhlIGxpbmUgYm94IHN0cmV0 Y2hpbmcgKHF1aXJreSkgPGJyPiBiZWhhdmlvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv bGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHRHZW9tZXRyeS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0 aW5nQ29udGV4dEdlb21ldHJ5LmNwcAppbmRleCA0ZTY2MDI4ZjNiNGJlOWQ1ZmFmNzQ5YzE1ZjUz NDhjM2E1MTdlYzRhLi45NmE1OTM4OWE4ZWVjNzBkMGJhMWIyMzcyMGJiOWUwNTcyMGI4MjAyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVG b3JtYXR0aW5nQ29udGV4dEdlb21ldHJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQv aW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4dEdlb21ldHJ5LmNwcApAQCAt MTg1LDEyICsxODUsMTIgQEAgdm9pZCBMaW5lQm94QnVpbGRlcjo6c2V0VmVydGljYWxHZW9tZXRy eUZvcklubGluZUJveChMaW5lQm94OjpJbmxpbmVMZXZlbEJveCYgaW4KICAgICBpZiAobGluZUhl aWdodC5pc05lZ2F0aXZlKCkpIHsKICAgICAgICAgLy8gSWYgbGluZS1oZWlnaHQgY29tcHV0ZXMg dG8gbm9ybWFsIGFuZCBlaXRoZXIgdGV4dC1lZGdlIGlzIGxlYWRpbmcgb3IgdGhpcyBpcyB0aGUg cm9vdCBpbmxpbmUgYm94LAogICAgICAgICAvLyB0aGUgZm9udOKAmXMgbGluZSBnYXAgbWV0cmlj IG1heSBhbHNvIGJlIGluY29ycG9yYXRlZCBpbnRvIEEgYW5kIEQgYnkgYWRkaW5nIGhhbGYgdG8g ZWFjaCBzaWRlIGFzIGhhbGYtbGVhZGluZy4KLSAgICAgICAgYXV0byBzaG91bGRMaW5lR2FwU3Ry ZXRjaElubGluZUxldmVsQm94ID0gaW5saW5lTGV2ZWxCb3guaXNSb290SW5saW5lQm94KCkgfHwg aW5saW5lTGV2ZWxCb3guaXNMaW5lQnJlYWtCb3goKTsKLSAgICAgICAgaWYgKHNob3VsZExpbmVH YXBTdHJldGNoSW5saW5lTGV2ZWxCb3gpIHsKLSAgICAgICAgICAgIGF1dG8gaGFsZkxpbmVHYXAg PSAoZm9udE1ldHJpY3MubGluZVNwYWNpbmcoKSAtIGxvZ2ljYWxIZWlnaHQpIC8gMjsKLSAgICAg ICAgICAgIGFzY2VudCArPSBoYWxmTGluZUdhcDsKLSAgICAgICAgICAgIGRlc2NlbnQgKz0gaGFs ZkxpbmVHYXA7Ci0gICAgICAgIH0KKyAgICAgICAgLy8gaHR0cHM6Ly93d3cudzMub3JnL1RSL2Nz cy1pbmxpbmUtMy8jaW5saW5lLWhlaWdodAorICAgICAgICAvLyBTaW5jZSB0ZXh0LWVkZ2UgaXMg bm90IHN1cHBvcnRlZCB5ZXQgYW5kIHRoZSBpbml0aWFsIHZhbHVlIGlzIGxlYWRpbmcsIHdlIHNo b3VsZCBqdXN0IGFwcGx5IGl0IHRvCisgICAgICAgIC8vIGFsbCBpbmxpbmUgYm94ZXMuCisgICAg ICAgIGF1dG8gaGFsZkxpbmVHYXAgPSAoZm9udE1ldHJpY3MubGluZVNwYWNpbmcoKSAtIGxvZ2lj YWxIZWlnaHQpIC8gMjsKKyAgICAgICAgYXNjZW50ICs9IGhhbGZMaW5lR2FwOworICAgICAgICBk ZXNjZW50ICs9IGhhbGZMaW5lR2FwOwogICAgIH0gZWxzZSB7CiAgICAgICAgIElubGluZUxheW91 dFVuaXQgbGluZUhlaWdodCA9IHN0eWxlLmNvbXB1dGVkTGluZUhlaWdodCgpOwogICAgICAgICBJ bmxpbmVMYXlvdXRVbml0IGhhbGZMZWFkaW5nID0gKGxpbmVIZWlnaHQgLSAoYXNjZW50ICsgZGVz Y2VudCkpIC8gMjsK