221177 2021-01-30 06:00:58 -0800 Attempting to [[Set]] JSArray's read-only "length" should throw even with current [[Value]] 2022-02-05 16:16:28 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Minor --- 1 nisl_grammarly1 ashvayka ashvayka ews-watchlist fpizlo keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1724031 0 nisl_grammarly1 2021-01-30 06:00:58 -0800 #version: d940b47 #Testcase var a=[1,2]; Object.freeze(a); var b=a.push(); print(b); #Command: ./webkit/WebKitBuild/Release/bin/jsc testcase.js #Output: 2 #Expected output: TypeError: "length" is read-only # Description When executing this test case, a is frozen in the second line, so an error should be thrown when executing Array.prototype.push, but JavaScriptCore outputs normally. 1724056 1 ysuzuki 2021-01-30 12:17:46 -0800 setLength should throw an error even if it is setting the same length if length is readonly. This bug does not break the invariant of freezing (error will not happen only when the setting length equals to the existing length.) But it is strictly speaking not aligned to the spec. var a=[1,2]; Object.freeze(a); a.push(2); // Throwing an error correctly since it is pushing a value and changing length actually. 1726381 2 webkit-bug-importer 2021-02-06 06:01:13 -0800 <rdar://problem/74059121> 1837784 3 450997 ashvayka 2022-02-05 13:16:52 -0800 Created attachment 450997 Patch 1837787 4 450997 saam 2022-02-05 13:22:04 -0800 Comment on attachment 450997 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450997&action=review r=me > Source/JavaScriptCore/ChangeLog:13 > + a) it's the only callee of setLengthWithArrayStorage() that performs [[DefineOwnProperty]], callee -> caller 1837791 5 450997 ashvayka 2022-02-05 13:42:48 -0800 Comment on attachment 450997 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450997&action=review > JSTests/stress/array-prototype-methods-set-length.js:98 > + Array.defineProperty(testObject, "length", { writable: false }); Oops, of course it throws, will fix. I will tighten expected error messages in a follow-up, which will make read-only "length" error messages consistent. 1837810 6 ashvayka 2022-02-05 16:14:56 -0800 Committed r289164 (246860@trunk): <https://commits.webkit.org/246860@trunk> 1837811 7 ashvayka 2022-02-05 16:16:28 -0800 (In reply to Saam Barati from comment #4) > Comment on attachment 450997 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=450997&action=review > > r=me > > > Source/JavaScriptCore/ChangeLog:13 > > + a) it's the only callee of setLengthWithArrayStorage() that performs [[DefineOwnProperty]], > > callee -> caller Fixed, and the tests too. Also, exporting some of them to test262 so the V8 team would fix the bug as well: https://github.com/tc39/test262/pull/3400. Thanks Saam! 450997 2022-02-05 13:16:52 -0800 2022-02-05 13:22:04 -0800 Patch bug-221177-20220205211650.patch text/plain 9004 ashvayka SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyODkxNjApCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEyIEBACisyMDIyLTAyLTA1ICBBbGV4ZXkgU2h2YXlrYSAgPGFzaHZheWthQGFw cGxlLmNvbT4KKworICAgICAgICBBdHRlbXB0aW5nIHRvIFtbU2V0XV0gSlNBcnJheSdzIHJlYWQt b25seSAibGVuZ3RoIiBzaG91bGQgdGhyb3cgZXZlbiB3aXRoIGN1cnJlbnQgW1tWYWx1ZV1dCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjExNzcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9h cnJheS1wcm90b3R5cGUtbWV0aG9kcy1zZXQtbGVuZ3RoLmpzOiBBZGRlZC4KKwogMjAyMi0wMi0w NCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYWtSZWYg ZGVyZWYgY2FuIHJldHVybiBudWxsIGluc3RlYWQgb2YgdW5kZWZpbmVkCkluZGV4OiBKU1Rlc3Rz L3N0cmVzcy9hcnJheS1wcm90b3R5cGUtbWV0aG9kcy1zZXQtbGVuZ3RoLmpzCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIEpTVGVzdHMvc3RyZXNzL2FycmF5LXByb3RvdHlwZS1tZXRob2RzLXNldC1sZW5ndGguanMJ KG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9zdHJlc3MvYXJyYXktcHJvdG90eXBlLW1ldGhvZHMt c2V0LWxlbmd0aC5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDE0MCBAQAorZnVuY3Rpb24g c2hvdWxkQmUoYWN0dWFsLCBleHBlY3RlZCkgeworICAgIGlmIChhY3R1YWwgIT09IGV4cGVjdGVk KQorICAgICAgICB0aHJvdyBuZXcgRXJyb3IoYEJhZCB2YWx1ZTogJHthY3R1YWx9IWApOworfTsK KworZnVuY3Rpb24gc2hvdWxkVGhyb3coZnVuYywgcmVFeHBlY3RlZEVycm9yKSB7CisgICAgbGV0 IGVycm9yVGhyb3duID0gZmFsc2U7CisgICAgdHJ5IHsKKyAgICAgICAgZnVuYygpOworICAgIH0g Y2F0Y2ggKGVycm9yKSB7CisgICAgICAgIGVycm9yVGhyb3duID0gdHJ1ZTsKKyAgICAgICAgaWYg KCFyZUV4cGVjdGVkRXJyb3IudGVzdChlcnJvci50b1N0cmluZygpKSkKKyAgICAgICAgICAgIHRo cm93IG5ldyBFcnJvcihgQmFkIGVycm9yOiAke2Vycm9yfSFcbmNyZWF0ZVRlc3RPYmplY3Q6XG4k e2NyZWF0ZVRlc3RPYmplY3R9XG5tYWtlTGVuZ3RoUmVhZE9ubHk6ICR7bWFrZUxlbmd0aFJlYWRP bmx5fWApOworICAgIH0KKyAgICBpZiAoIWVycm9yVGhyb3duKQorICAgICAgICB0aHJvdyBuZXcg RXJyb3IoYERpZG4ndCB0aHJvdyFcbmNyZWF0ZVRlc3RPYmplY3Q6ICR7Y3JlYXRlVGVzdE9iamVj dH1cbm1ha2VMZW5ndGhSZWFkT25seTogJHttYWtlTGVuZ3RoUmVhZE9ubHl9YCk7Cit9OworCit2 YXIgY3JlYXRlVGVzdE9iamVjdDsKK2NvbnN0IGNyZWF0ZVRlc3RPYmplY3RGdW5jdGlvbnMgPSBb CisgICAgbGVuID0+IG5ldyBBcnJheShsZW4pLAorICAgIGxlbiA9PiBuZXcgUHJveHkobmV3IEFy cmF5KGxlbiksIHt9KSwKKyAgICBsZW4gPT4geyBjb25zdCBvYmogPSBPYmplY3QuY3JlYXRlKEFy cmF5LnByb3RvdHlwZSk7IG9iai5sZW5ndGggPSBsZW47IHJldHVybiBvYmo7IH0sCitdOworCit2 YXIgbWFrZUxlbmd0aFJlYWRPbmx5OworY29uc3QgbWFrZUxlbmd0aFJlYWRPbmx5RnVuY3Rpb25z ID0gWworICAgIGFyciA9PiB7IE9iamVjdC5mcmVlemUoYXJyKTsgfSwKKyAgICBhcnIgPT4geyBP YmplY3QuZGVmaW5lUHJvcGVydHkoYXJyLCAibGVuZ3RoIiwgeyB3cml0YWJsZTogZmFsc2UgfSk7 IH0sCitdOworCit2YXIgdGVzdE9iamVjdDsKK2NvbnN0IGV4cGVjdGVkVHlwZUVycm9yID0gL15U eXBlRXJyb3I6LisvOworCitmb3IgKGNyZWF0ZVRlc3RPYmplY3Qgb2YgY3JlYXRlVGVzdE9iamVj dEZ1bmN0aW9ucykgeworZm9yIChtYWtlTGVuZ3RoUmVhZE9ubHkgb2YgbWFrZUxlbmd0aFJlYWRP bmx5RnVuY3Rpb25zKSB7CisKKyAgICB0ZXN0T2JqZWN0ID0gY3JlYXRlVGVzdE9iamVjdCgwKTsK KyAgICBtYWtlTGVuZ3RoUmVhZE9ubHkodGVzdE9iamVjdCk7CisgICAgc2hvdWxkVGhyb3coKCkg PT4geyAidXNlIHN0cmljdCI7IHRlc3RPYmplY3QubGVuZ3RoID0gMDsgfSwgZXhwZWN0ZWRUeXBl RXJyb3IpOworICAgIHNob3VsZEJlKHRlc3RPYmplY3QubGVuZ3RoLCAwKTsKKworICAgIHRlc3RP YmplY3QgPSBjcmVhdGVUZXN0T2JqZWN0KDApOworICAgIG1ha2VMZW5ndGhSZWFkT25seSh0ZXN0 T2JqZWN0KTsKKyAgICBzaG91bGRUaHJvdygoKSA9PiB7IHRlc3RPYmplY3QucG9wKCk7IH0sIGV4 cGVjdGVkVHlwZUVycm9yKTsKKyAgICBzaG91bGRCZSh0ZXN0T2JqZWN0Lmxlbmd0aCwgMCk7CisK KyAgICB0ZXN0T2JqZWN0ID0gY3JlYXRlVGVzdE9iamVjdCgxKTsKKyAgICB0ZXN0T2JqZWN0WzBd ID0gMTsKKyAgICBtYWtlTGVuZ3RoUmVhZE9ubHkodGVzdE9iamVjdCk7CisgICAgc2hvdWxkVGhy b3coKCkgPT4geyB0ZXN0T2JqZWN0LnBvcCgpOyB9LCBleHBlY3RlZFR5cGVFcnJvcik7CisgICAg c2hvdWxkQmUodGVzdE9iamVjdC5sZW5ndGgsIDEpOworCisgICAgdGVzdE9iamVjdCA9IGNyZWF0 ZVRlc3RPYmplY3QoMCk7CisgICAgbWFrZUxlbmd0aFJlYWRPbmx5KHRlc3RPYmplY3QpOworICAg IHNob3VsZFRocm93KCgpID0+IHsgdGVzdE9iamVjdC5wdXNoKCk7IH0sIGV4cGVjdGVkVHlwZUVy cm9yKTsKKyAgICBzaG91bGRCZSh0ZXN0T2JqZWN0Lmxlbmd0aCwgMCk7CisKKyAgICB0ZXN0T2Jq ZWN0ID0gY3JlYXRlVGVzdE9iamVjdCgwKTsKKyAgICBtYWtlTGVuZ3RoUmVhZE9ubHkodGVzdE9i amVjdCk7CisgICAgc2hvdWxkVGhyb3coKCkgPT4geyB0ZXN0T2JqZWN0LnB1c2goMSk7IH0sIGV4 cGVjdGVkVHlwZUVycm9yKTsKKyAgICBzaG91bGRCZSh0ZXN0T2JqZWN0Lmxlbmd0aCwgMCk7CisK KyAgICB0ZXN0T2JqZWN0ID0gY3JlYXRlVGVzdE9iamVjdCgwKTsKKyAgICBtYWtlTGVuZ3RoUmVh ZE9ubHkodGVzdE9iamVjdCk7CisgICAgc2hvdWxkVGhyb3coKCkgPT4geyB0ZXN0T2JqZWN0LnNo aWZ0KCk7IH0sIGV4cGVjdGVkVHlwZUVycm9yKTsKKyAgICBzaG91bGRCZSh0ZXN0T2JqZWN0Lmxl bmd0aCwgMCk7CisKKyAgICB0ZXN0T2JqZWN0ID0gY3JlYXRlVGVzdE9iamVjdCgxKTsKKyAgICB0 ZXN0T2JqZWN0WzBdID0gMTsKKyAgICBtYWtlTGVuZ3RoUmVhZE9ubHkodGVzdE9iamVjdCk7Cisg ICAgc2hvdWxkVGhyb3coKCkgPT4geyB0ZXN0T2JqZWN0LnNoaWZ0KCk7IH0sIGV4cGVjdGVkVHlw ZUVycm9yKTsKKyAgICBzaG91bGRCZSh0ZXN0T2JqZWN0Lmxlbmd0aCwgMSk7CisKKyAgICB0ZXN0 T2JqZWN0ID0gY3JlYXRlVGVzdE9iamVjdCgwKTsKKyAgICBtYWtlTGVuZ3RoUmVhZE9ubHkodGVz dE9iamVjdCk7CisgICAgc2hvdWxkVGhyb3coKCkgPT4geyB0ZXN0T2JqZWN0LnVuc2hpZnQoKTsg fSwgZXhwZWN0ZWRUeXBlRXJyb3IpOworICAgIHNob3VsZEJlKHRlc3RPYmplY3QubGVuZ3RoLCAw KTsKKworICAgIHRlc3RPYmplY3QgPSBjcmVhdGVUZXN0T2JqZWN0KDApOworICAgIG1ha2VMZW5n dGhSZWFkT25seSh0ZXN0T2JqZWN0KTsKKyAgICBzaG91bGRUaHJvdygoKSA9PiB7IHRlc3RPYmpl Y3QudW5zaGlmdCgxKTsgfSwgZXhwZWN0ZWRUeXBlRXJyb3IpOworICAgIHNob3VsZEJlKHRlc3RP YmplY3QubGVuZ3RoLCAwKTsKKworfX0KKworLy8gbGV0J3MgaGF2ZSBhIGJhZCB0aW1lPworCitm b3IgKGNyZWF0ZVRlc3RPYmplY3Qgb2YgY3JlYXRlVGVzdE9iamVjdEZ1bmN0aW9ucykgeworZm9y IChtYWtlTGVuZ3RoUmVhZE9ubHkgb2YgbWFrZUxlbmd0aFJlYWRPbmx5RnVuY3Rpb25zKSB7CisK KyAgICBsZXQgYXJyYXlQcm90b3R5cGVHZXQwQ2FsbHMgPSAwOworICAgIGxldCBhcnJheVByb3Rv dHlwZVNldDBDYWxscyA9IDA7CisKKyAgICBPYmplY3QuZGVmaW5lUHJvcGVydHkoQXJyYXkucHJv dG90eXBlLCAiMCIsIHsKKyAgICAgICAgZ2V0KCkgeworICAgICAgICAgICAgYXJyYXlQcm90b3R5 cGVHZXQwQ2FsbHMrKzsKKyAgICAgICAgICAgIEFycmF5LmRlZmluZVByb3BlcnR5KHRlc3RPYmpl Y3QsICJsZW5ndGgiLCB7IHdyaXRhYmxlOiBmYWxzZSB9KTsKKyAgICAgICAgfSwKKyAgICAgICAg c2V0KF92YWwpIHsKKyAgICAgICAgICAgIGFycmF5UHJvdG90eXBlU2V0MENhbGxzKys7CisgICAg ICAgICAgICBBcnJheS5kZWZpbmVQcm9wZXJ0eSh0ZXN0T2JqZWN0LCAibGVuZ3RoIiwgeyB3cml0 YWJsZTogZmFsc2UgfSk7CisgICAgICAgIH0sCisgICAgICAgIGNvbmZpZ3VyYWJsZTogdHJ1ZSwK KyAgICB9KTsKKworICAgIHRlc3RPYmplY3QgPSBjcmVhdGVUZXN0T2JqZWN0KDEpOworICAgIHNo b3VsZFRocm93KCgpID0+IHsgdGVzdE9iamVjdC5wb3AoKTsgfSwgZXhwZWN0ZWRUeXBlRXJyb3Ip OworICAgIHNob3VsZEJlKGFycmF5UHJvdG90eXBlR2V0MENhbGxzLCAxKTsKKyAgICBzaG91bGRC ZSh0ZXN0T2JqZWN0Lmxlbmd0aCwgMSk7CisKKyAgICB0ZXN0T2JqZWN0ID0gY3JlYXRlVGVzdE9i amVjdCgxKTsKKyAgICBzaG91bGRUaHJvdygoKSA9PiB7IHRlc3RPYmplY3Quc2hpZnQoMSk7IH0s IGV4cGVjdGVkVHlwZUVycm9yKTsKKyAgICBzaG91bGRCZShhcnJheVByb3RvdHlwZUdldDBDYWxs cywgMik7CisgICAgc2hvdWxkQmUodGVzdE9iamVjdC5sZW5ndGgsIDEpOworCisgICAgdGVzdE9i amVjdCA9IGNyZWF0ZVRlc3RPYmplY3QoMCk7CisgICAgc2hvdWxkVGhyb3coKCkgPT4geyB0ZXN0 T2JqZWN0LnB1c2goMSk7IH0sIGV4cGVjdGVkVHlwZUVycm9yKTsKKyAgICBzaG91bGRCZShhcnJh eVByb3RvdHlwZVNldDBDYWxscywgMSk7CisgICAgc2hvdWxkQmUodGVzdE9iamVjdC5sZW5ndGgs IDApOworCisgICAgdGVzdE9iamVjdCA9IGNyZWF0ZVRlc3RPYmplY3QoMCk7CisgICAgc2hvdWxk VGhyb3coKCkgPT4geyB0ZXN0T2JqZWN0LnVuc2hpZnQoMSk7IH0sIGV4cGVjdGVkVHlwZUVycm9y KTsKKyAgICBzaG91bGRCZShhcnJheVByb3RvdHlwZVNldDBDYWxscywgMik7CisgICAgc2hvdWxk QmUodGVzdE9iamVjdC5sZW5ndGgsIDApOworCit9fQorCisvLyBbW0RlZmluZU93blByb3BlcnR5 XV0gc2hvdWxkbid0IGZhaWwKKworZm9yIChjcmVhdGVUZXN0T2JqZWN0IG9mIGNyZWF0ZVRlc3RP YmplY3RGdW5jdGlvbnMpIHsKK2ZvciAobWFrZUxlbmd0aFJlYWRPbmx5IG9mIG1ha2VMZW5ndGhS ZWFkT25seUZ1bmN0aW9ucykgeworCisgICAgdGVzdE9iamVjdCA9IGNyZWF0ZVRlc3RPYmplY3Qo NDIpOworICAgIG1ha2VMZW5ndGhSZWFkT25seSh0ZXN0T2JqZWN0KTsKKyAgICBPYmplY3QuZGVm aW5lUHJvcGVydHkodGVzdE9iamVjdCwgImxlbmd0aCIsIHsgdmFsdWU6IDQyIH0pOyAvLyBkb2Vz bid0IHRocm93CisgICAgc2hvdWxkQmUoUmVmbGVjdC5kZWZpbmVQcm9wZXJ0eSh0ZXN0T2JqZWN0 LCAibGVuZ3RoIiwgeyB2YWx1ZTogNDIgfSksIHRydWUpOworICAgIHNob3VsZEJlKHRlc3RPYmpl Y3QubGVuZ3RoLCA0Mik7CisKK319CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlz aW9uIDI4OTE1NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcg Y29weSkKQEAgLTEsMyArMSwzNiBAQAorMjAyMi0wMi0wNSAgQWxleGV5IFNodmF5a2EgIDxhc2h2 YXlrYUBhcHBsZS5jb20+CisKKyAgICAgICAgQXR0ZW1wdGluZyB0byBbW1NldF1dIEpTQXJyYXkn cyByZWFkLW9ubHkgImxlbmd0aCIgc2hvdWxkIHRocm93IGV2ZW4gd2l0aCBjdXJyZW50IFtbVmFs dWVdXQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIx MTc3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXMg cGVyIE9yZGluYXJ5U2V0IGFsZ29yaXRobSBbMV0uIFRvIGFjaGlldmUgdGhhdCwgd2hpbGUgZW5z dXJpbmcgbm8gZXJyb3IgaXMgdGhyb3duCisgICAgICAgIGlmIHJlYWQtb25seSAibGVuZ3RoIiBp c24ndCBhY3R1YWxseSBjaGFuZ2VkIHZpYSBbW0RlZmluZU93blByb3BlcnR5XV0gWzJdLCB0aGlz IHBhdGNoCisgICAgICAgIG1vdmVzIGBuZXdMZW5ndGggPT0gb2xkTGVuZ3RoYCBjaGVjayB0byBK U0FycmF5OjpkZWZpbmVPd25Qcm9wZXJ0eSgpLgorCisgICAgICAgIFRoYXQgaXMgZ3VhcmFudGVl ZCB0byBiZSBjb3JyZWN0IGJlY2F1c2U6CisgICAgICAgICAgYSkgaXQncyB0aGUgb25seSBjYWxs ZWUgb2Ygc2V0TGVuZ3RoV2l0aEFycmF5U3RvcmFnZSgpIHRoYXQgcGVyZm9ybXMgW1tEZWZpbmVP d25Qcm9wZXJ0eV1dLAorICAgICAgICAgICAgIHdoaWxlIG90aGVycyBpbXBsZW1lbnQgW1tTZXRd XTsKKyAgICAgICAgICBiKSB0aGVyZSBjYW4ndCBwb3NzaWJseSBiZSBhcnJheSBpbmRpY2VzIHRo YXQgSlNBcnJheTo6ZGVmaW5lT3duUHJvcGVydHkoKSBoYXMgdG8gcmVtb3ZlLAorICAgICAgICAg ICAgIGFuZCBldmVuIHRoZSBzcGVjIGEgc2hvcnRjdXQgaGVyZSBbM10uCisKKyAgICAgICAgQWxs IGNvZGUgcGF0aHMgaW4gcG9wKCkgLyBzaGlmdCgpIC8gcHVzaCgpIC8gdW5zaGlmdCgpIGFyZSBj b3ZlcmVkIGJ5IHRoZSBuZXdseSBhZGRlZCB0ZXN0LAorICAgICAgICBhcyB3ZWxsIGFzIEpTQXJy YXkncyBbW0RlZmluZU93blByb3BlcnR5XV0sIHdoaWxlIHNsaWNlKCkgLyBzcGxpY2UoKSAvIGV0 YyB3ZXJlIHZldHRlZCB0bworICAgICAgICBbW1NldF1dICJsZW5ndGgiIGFjY29yZGluZyB0byB0 aGUgc3BlYy4KKworICAgICAgICBBbGlnbnMgSlNDIHdpdGggU3BpZGVyTW9ua2V5IGFuZCBwYXJ0 bHkgd2l0aCBWOCwgd2hpY2ggaXMgY29ycmVjdCBmb3IgT2JqZWN0LmZyZWV6ZSgpCisgICAgICAg IGJ1dCBub3QgZm9yIGBPYmplY3QuZGVmaW5lUHJvcGVydHkoYXJyYXksICJsZW5ndGgiLCB7IHdy aXRhYmxlOiBmYWxzZSB9KWAuCisKKyAgICAgICAgWzFdOiBodHRwczovL3RjMzkuZXMvZWNtYTI2 Mi8jc2VjLW9yZGluYXJ5c2V0d2l0aG93bmRlc2NyaXB0b3IgKHN0ZXAgMi5hKQorICAgICAgICBb Ml06IGh0dHBzOi8vdGMzOS5lcy9lY21hMjYyLyNzZWMtdmFsaWRhdGVhbmRhcHBseXByb3BlcnR5 ZGVzY3JpcHRvciAoc3RlcCA1IGFuZCA3KQorICAgICAgICBbM106IGh0dHBzOi8vdGMzOS5lcy9l Y21hMjYyLyNzZWMtYXJyYXlzZXRsZW5ndGggKHN0ZXAgMTEpCisKKworICAgICAgICAqIHJ1bnRp bWUvSlNBcnJheS5jcHA6CisgICAgICAgIChKU0M6OkpTQXJyYXk6OmRlZmluZU93blByb3BlcnR5 KToKKyAgICAgICAgKEpTQzo6SlNBcnJheTo6c2V0TGVuZ3RoV2l0aEFycmF5U3RvcmFnZSk6CisK IDIwMjItMDItMDQgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAg ICBXZWFrUmVmIGRlcmVmIGNhbiByZXR1cm4gbnVsbCBpbnN0ZWFkIG9mIHVuZGVmaW5lZApJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNBcnJheS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNBcnJheS5jcHAJKHJldmlzaW9uIDI4 OTE1NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xOTEsOCArMTkxLDExIEBAIGJvb2wgSlNBcnJheTo6ZGVmaW5lT3duUHJv cGVydHkoSlNPYmplY3QKICAgICAgICAgfQogCiAgICAgICAgIC8vIHNldExlbmd0aCgpIGNsZWFy cyBpbmRpY2VzID49IG5ld0xlbmd0aCBhbmQgc2V0cyBjb3JyZWN0ICJsZW5ndGgiIHZhbHVlIGlm IFtbRGVsZXRlXV0gZmFpbHMgKHN0ZXAgMTcuYi5pKQotICAgICAgICBib29sIHN1Y2Nlc3MgPSBh cnJheS0+c2V0TGVuZ3RoKGdsb2JhbE9iamVjdCwgbmV3TGVuZ3RoLCB0aHJvd0V4Y2VwdGlvbik7 Ci0gICAgICAgIEVYQ0VQVElPTl9BU1NFUlQoIXNjb3BlLmV4Y2VwdGlvbigpIHx8ICFzdWNjZXNz KTsKKyAgICAgICAgYm9vbCBzdWNjZXNzID0gdHJ1ZTsKKyAgICAgICAgaWYgKG5ld0xlbmd0aCAh PSBhcnJheS0+bGVuZ3RoKCkpIHsKKyAgICAgICAgICAgIHN1Y2Nlc3MgPSBhcnJheS0+c2V0TGVu Z3RoKGdsb2JhbE9iamVjdCwgbmV3TGVuZ3RoLCB0aHJvd0V4Y2VwdGlvbik7CisgICAgICAgICAg ICBFWENFUFRJT05fQVNTRVJUKCFzY29wZS5leGNlcHRpb24oKSB8fCAhc3VjY2Vzcyk7CisgICAg ICAgIH0KICAgICAgICAgaWYgKGRlc2NyaXB0b3Iud3JpdGFibGVQcmVzZW50KCkpCiAgICAgICAg ICAgICBhcnJheS0+c2V0TGVuZ3RoV3JpdGFibGUoZ2xvYmFsT2JqZWN0LCBkZXNjcmlwdG9yLndy aXRhYmxlKCkpOwogICAgICAgICByZXR1cm4gc3VjY2VzczsKQEAgLTQxNSw4ICs0MTgsNiBAQCBi b29sIEpTQXJyYXk6OnNldExlbmd0aFdpdGhBcnJheVN0b3JhZ2UoCiAgICAgYXV0byBzY29wZSA9 IERFQ0xBUkVfVEhST1dfU0NPUEUodm0pOwogCiAgICAgdW5zaWduZWQgbGVuZ3RoID0gc3RvcmFn ZS0+bGVuZ3RoKCk7Ci0gICAgaWYgKG5ld0xlbmd0aCA9PSBsZW5ndGgpCi0gICAgICAgIHJldHVy biB0cnVlOwogICAgIAogICAgIC8vIElmIHRoZSBsZW5ndGggaXMgcmVhZCBvbmx5IHRoZW4gd2Ug ZW50ZXIgc3BhcnNlIG1vZGUsIHNvIHNob3VsZCBlbnRlciB0aGUgZm9sbG93aW5nICdpZicuCiAg ICAgQVNTRVJUKGlzTGVuZ3RoV3JpdGFibGUoKSB8fCBzdG9yYWdlLT5tX3NwYXJzZU1hcCk7Cg==