221170 2021-01-29 19:35:09 -0800 [LFC][IFC] Remove redundant LineBoxBuilder::isRootLayoutBox function 2021-01-30 04:45:16 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1723996 0 zalan 2021-01-29 19:35:09 -0800 call InlineLevelBox::isRootInlineBox instead 1723997 1 418802 zalan 2021-01-29 19:37:03 -0800 Created attachment 418802 Patch 1724026 2 ews-feeder 2021-01-30 04:44:12 -0800 Committed r272115: <https://trac.webkit.org/changeset/272115> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418802. 1724027 3 webkit-bug-importer 2021-01-30 04:45:16 -0800 <rdar://problem/73790980> 418802 2021-01-29 19:37:03 -0800 2021-01-30 04:44:13 -0800 Patch bug-221170-20210129193702.patch text/plain 3888 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyMDk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmI2ZDU1MTEyZmU1NjQ1 MDEzNjJhNzZiNzlkNTkzZmVmMDQ4ODY0ZS4uNWI5YWUzOGQ5NDdmYjhjYzFlNzJmYTA0MmE0NmRj YjE2Yjg1N2JiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAxLTI5ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBSZW1vdmUg cmVkdW5kYW50IExpbmVCb3hCdWlsZGVyOjppc1Jvb3RMYXlvdXRCb3ggZnVuY3Rpb24KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTE3MAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogbGF5b3V0L2lubGlu ZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHRHZW9tZXRyeS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpMYXlvdXQ6OkxpbmVCb3hCdWlsZGVyOjppc1Jvb3RMYXlvdXRCb3ggY29uc3Qp OiBDaGFuZ2UgdGhlIG5hbWUgdG8gaW5jbHVkZSAibGF5b3V0Qm94IiB0byBub3QgY29uZnVzZSBp dCB3aXRoIGlubGluZSBib3hlcy4KKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6TGluZUJveEJ1 aWxkZXI6OnNldFZlcnRpY2FsR2VvbWV0cnlGb3JJbmxpbmVCb3ggY29uc3QpOgorICAgICAgICAo V2ViQ29yZTo6TGF5b3V0OjpMaW5lQm94QnVpbGRlcjo6Y29uc3RydWN0SW5saW5lTGV2ZWxCb3hl cyk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkxpbmVCb3hCdWlsZGVyOjppc1Jvb3RJbmxp bmVCb3ggY29uc3QpOiBEZWxldGVkLgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpMaW5lQm94 QnVpbGRlcjo6aXNSb290Qm94IGNvbnN0KTogRGVsZXRlZC4KKwogMjAyMS0wMS0yOSAgU2FtIFdl aW5pZyAgPHdlaW5pZ0BhcHBsZS5jb20+CiAKICAgICAgICAgVXBkYXRlIGNvbnN1bWVOdW1iZXJS YXcoKSB0byByZXR1cm4gYW4gT3B0aW9uYWw8ZG91YmxlPiByYXRoZXIgdGhhbiB1c2luZyBhIGJv b2wvb3V0IHBhcmFtZXRlciBwYXR0ZXJuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlv dXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4dEdlb21ldHJ5LmNwcCBi L1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdD b250ZXh0R2VvbWV0cnkuY3BwCmluZGV4IDE4NjJlOWFkZmVkYTJkZmY1OGQ5MjNhYTZjMmUyMWIz NDExNzc4YTEuLjRlNjYwMjhmM2I0YmU5ZDVmYWY3NDljMTVmNTM0OGMzYTUxN2VjNGEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1h dHRpbmdDb250ZXh0R2VvbWV0cnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxp bmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0R2VvbWV0cnkuY3BwCkBAIC01Myw4 ICs1Myw3IEBAIHByaXZhdGU6CiAgICAgY29uc3QgQm94JiByb290Qm94KCkgY29uc3QgeyByZXR1 cm4gZm9ybWF0dGluZ0NvbnRleHQoKS5yb290KCk7IH0KICAgICBMYXlvdXRTdGF0ZSYgbGF5b3V0 U3RhdGUoKSBjb25zdCB7IHJldHVybiBmb3JtYXR0aW5nQ29udGV4dCgpLmxheW91dFN0YXRlKCk7 IH0KIAotICAgIGJvb2wgaXNSb290SW5saW5lQm94KGNvbnN0IExpbmVCb3g6OklubGluZUxldmVs Qm94JiBpbmxpbmVMZXZlbEJveCkgY29uc3QgeyByZXR1cm4gJmlubGluZUxldmVsQm94LmxheW91 dEJveCgpID09ICZyb290Qm94KCk7IH0KLSAgICBib29sIGlzUm9vdEJveChjb25zdCBDb250YWlu ZXJCb3gmIGNvbnRhaW5lckJveCkgY29uc3QgeyByZXR1cm4gJmNvbnRhaW5lckJveCA9PSAmcm9v dEJveCgpOyB9CisgICAgYm9vbCBpc1Jvb3RMYXlvdXRCb3goY29uc3QgQ29udGFpbmVyQm94JiBj b250YWluZXJCb3gpIGNvbnN0IHsgcmV0dXJuICZjb250YWluZXJCb3ggPT0gJnJvb3RCb3goKTsg fQogCiBwcml2YXRlOgogICAgIGNvbnN0IElubGluZUZvcm1hdHRpbmdDb250ZXh0JiBtX2lubGlu ZUZvcm1hdHRpbmdDb250ZXh0OwpAQCAtMTg2LDcgKzE4NSw3IEBAIHZvaWQgTGluZUJveEJ1aWxk ZXI6OnNldFZlcnRpY2FsR2VvbWV0cnlGb3JJbmxpbmVCb3goTGluZUJveDo6SW5saW5lTGV2ZWxC b3gmIGluCiAgICAgaWYgKGxpbmVIZWlnaHQuaXNOZWdhdGl2ZSgpKSB7CiAgICAgICAgIC8vIElm IGxpbmUtaGVpZ2h0IGNvbXB1dGVzIHRvIG5vcm1hbCBhbmQgZWl0aGVyIHRleHQtZWRnZSBpcyBs ZWFkaW5nIG9yIHRoaXMgaXMgdGhlIHJvb3QgaW5saW5lIGJveCwKICAgICAgICAgLy8gdGhlIGZv bnTigJlzIGxpbmUgZ2FwIG1ldHJpYyBtYXkgYWxzbyBiZSBpbmNvcnBvcmF0ZWQgaW50byBBIGFu ZCBEIGJ5IGFkZGluZyBoYWxmIHRvIGVhY2ggc2lkZSBhcyBoYWxmLWxlYWRpbmcuCi0gICAgICAg IGF1dG8gc2hvdWxkTGluZUdhcFN0cmV0Y2hJbmxpbmVMZXZlbEJveCA9IGlzUm9vdElubGluZUJv eChpbmxpbmVMZXZlbEJveCkgfHwgaW5saW5lTGV2ZWxCb3guaXNMaW5lQnJlYWtCb3goKTsKKyAg ICAgICAgYXV0byBzaG91bGRMaW5lR2FwU3RyZXRjaElubGluZUxldmVsQm94ID0gaW5saW5lTGV2 ZWxCb3guaXNSb290SW5saW5lQm94KCkgfHwgaW5saW5lTGV2ZWxCb3guaXNMaW5lQnJlYWtCb3go KTsKICAgICAgICAgaWYgKHNob3VsZExpbmVHYXBTdHJldGNoSW5saW5lTGV2ZWxCb3gpIHsKICAg ICAgICAgICAgIGF1dG8gaGFsZkxpbmVHYXAgPSAoZm9udE1ldHJpY3MubGluZVNwYWNpbmcoKSAt IGxvZ2ljYWxIZWlnaHQpIC8gMjsKICAgICAgICAgICAgIGFzY2VudCArPSBoYWxmTGluZUdhcDsK QEAgLTIzNywxMyArMjM2LDEzIEBAIHZvaWQgTGluZUJveEJ1aWxkZXI6OmNvbnN0cnVjdElubGlu ZUxldmVsQm94ZXMoTGluZUJveCYgbGluZUJveCwgY29uc3QgTGluZTo6UnVuCiAgICAgICAgIC8v IDxzcGFuPm5vcm1hbGx5IHRoZSBpbmxpbmUgYm94IGNsb3NpbmcgZm9ybXMgYSBjb250aW51b3Vz IGNvbnRlbnQ8L3NwYW4+CiAgICAgICAgIC8vIDxzcGFuPnVubGVzcyBpdCdzIGZvcmNlZCB0byB0 aGUgbmV4dCBsaW5lPGJyPjwvc3Bhbj4KICAgICAgICAgYXV0byBmaXJzdFJ1bk5lZWRzSW5saW5l Qm94ID0gZmlyc3RSdW4uaXNJbmxpbmVCb3hFbmQoKTsKLSAgICAgICAgaWYgKCFmaXJzdFJ1bk5l ZWRzSW5saW5lQm94ICYmIGlzUm9vdEJveChmaXJzdFJ1blBhcmVudExheW91dEJveCkpCisgICAg ICAgIGlmICghZmlyc3RSdW5OZWVkc0lubGluZUJveCAmJiBpc1Jvb3RMYXlvdXRCb3goZmlyc3RS dW5QYXJlbnRMYXlvdXRCb3gpKQogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICBWZWN0b3I8 Y29uc3QgQm94Kj4gbGF5b3V0Qm94ZXNXaXRob3V0SW5saW5lQm94ZXM7CiAgICAgICAgIGlmIChm aXJzdFJ1bk5lZWRzSW5saW5lQm94KQogICAgICAgICAgICAgbGF5b3V0Qm94ZXNXaXRob3V0SW5s aW5lQm94ZXMuYXBwZW5kKCZmaXJzdFJ1bi5sYXlvdXRCb3goKSk7CiAgICAgICAgIGF1dG8qIGFu Y2VzdG9yID0gJmZpcnN0UnVuUGFyZW50TGF5b3V0Qm94OwotICAgICAgICB3aGlsZSAoIWlzUm9v dEJveCgqYW5jZXN0b3IpKSB7CisgICAgICAgIHdoaWxlICghaXNSb290TGF5b3V0Qm94KCphbmNl c3RvcikpIHsKICAgICAgICAgICAgIGxheW91dEJveGVzV2l0aG91dElubGluZUJveGVzLmFwcGVu ZChhbmNlc3Rvcik7CiAgICAgICAgICAgICBhbmNlc3RvciA9ICZhbmNlc3Rvci0+cGFyZW50KCk7 CiAgICAgICAgIH0K