221127 2021-01-29 02:26:00 -0800 [SOUP] Add support for data URLs in the network process 2021-02-01 02:29:47 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=220509 Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned aperez bugs-noreply oldest_to_newest 1723670 0 cgarcia 2021-01-29 02:26:00 -0800 In r271879 I removed the support for data URLs in the network process for soup, assuming data URLs were always loaded from the web process, but that's not the case for downloads. I think we should not go to the network process for downloads either, but for now it's easier to fix this regression by supporting data URLs in the network process again. This was caught by http/tests/security/anchor-download-allow-data.html 1723671 1 418714 cgarcia 2021-01-29 02:30:16 -0800 Created attachment 418714 Patch 1724162 2 cgarcia 2021-02-01 02:29:47 -0800 Committed r272138: <https://trac.webkit.org/changeset/272138> 418714 2021-01-29 02:30:16 -0800 2021-02-01 01:55:29 -0800 Patch wk2-soup-data-url.diff text/plain 5719 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYWEzNmNjZGU1MTI3Li4zNDVjNGE0MzFmNmIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMjMgQEAKKzIwMjEtMDEtMjkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtTT1VQXSBBZGQgc3VwcG9ydCBmb3IgZGF0YSBVUkxzIGluIHRo ZSBuZXR3b3JrIHByb2Nlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIyMTEyNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEluIHIyNzE4NzkgSSByZW1vdmVkIHRoZSBzdXBwb3J0IGZvciBkYXRhIFVSTHMg aW4gdGhlIG5ldHdvcmsgcHJvY2VzcyBmb3Igc291cCwgYXNzdW1pbmcgZGF0YSBVUkxzIHdlcmUg YWx3YXlzCisgICAgICAgIGxvYWRlZCBmcm9tIHRoZSB3ZWIgcHJvY2VzcywgYnV0IHRoYXQncyBu b3QgdGhlIGNhc2UgZm9yIGRvd25sb2Fkcy4gSSB0aGluayB3ZSBzaG91bGQgbm90IGdvIHRvIHRo ZSBuZXR3b3JrCisgICAgICAgIHByb2Nlc3MgZm9yIGRvd25sb2FkcyBlaXRoZXIsIGJ1dCBmb3Ig bm93IGl0J3MgZWFzaWVyIHRvIGZpeCB0aGlzIHJlZ3Jlc3Npb24gYnkgc3VwcG9ydGluZyBkYXRh IFVSTHMgaW4gdGhlCisgICAgICAgIG5ldHdvcmsgcHJvY2VzcyBhZ2Fpbi4gRml4ZXMgaHR0cC90 ZXN0cy9zZWN1cml0eS9hbmNob3ItZG93bmxvYWQtYWxsb3ctZGF0YS5odG1sLgorCisgICAgICAg ICogTmV0d29ya1Byb2Nlc3Mvc291cC9OZXR3b3JrRGF0YVRhc2tTb3VwLmNwcDoKKyAgICAgICAg KFdlYktpdDo6TmV0d29ya0RhdGFUYXNrU291cDo6Y3JlYXRlUmVxdWVzdCk6IFJldHVybiBlYXJs eSBpZiBpdCdzIGEgZGF0YSBVUkwuCisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtEYXRhVGFza1Nv dXA6OmNsZWFyUmVxdWVzdCk6IENsZWFyIHRoZSBwZW5kaW5nIGRhdGEgVVJMIHJlc3VsdC4KKyAg ICAgICAgKFdlYktpdDo6TmV0d29ya0RhdGFUYXNrU291cDo6cmVzdW1lKTogU3RhcnQgYSBkYXRh IFVSTCBkZWNvZGUgdGFzayBpZiBpdCdzIGEgbmV3IGRhdGEgVVJMIHJlcXVlc3QsIG9yIGNvbXBs ZXRlCisgICAgICAgIHRoZSBwZW5kaW5nIG9uZS4KKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0Rh dGFUYXNrU291cDo6ZGlkUmVhZERhdGFVUkwpOiBDb21wbGV0ZSB0aGUgZGF0YSBVUkwgcmVxdWVz dC4KKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9zb3VwL05ldHdvcmtEYXRhVGFza1NvdXAuaDoK KwogMjAyMS0wMS0yOSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAg ICAgUmVjb3ZlciBhdWRpbyBhbmQgdmlkZW8gY2FwdHVyZSBmcm9tIEdQVVByb2Nlc3MgY3Jhc2gK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mvc291cC9OZXR3b3JrRGF0 YVRhc2tTb3VwLmNwcCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mvc291cC9OZXR3b3Jr RGF0YVRhc2tTb3VwLmNwcAppbmRleCAzN2FmNDliZjU1YjUuLjM5MDE1ZjkwMGIyZCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9zb3VwL05ldHdvcmtEYXRhVGFza1Nv dXAuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mvc291cC9OZXR3b3JrRGF0 YVRhc2tTb3VwLmNwcApAQCAtMTEzLDYgKzExMyw5IEBAIHZvaWQgTmV0d29ya0RhdGFUYXNrU291 cDo6Y3JlYXRlUmVxdWVzdChSZXNvdXJjZVJlcXVlc3QmJiByZXF1ZXN0LCBXYXNCbG9ja2luZ0Nv CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKKyAgICBpZiAobV9jdXJyZW50UmVxdWVzdC51cmwo KS5wcm90b2NvbElzRGF0YSgpKQorICAgICAgICByZXR1cm47CisKICAgICBpZiAoIW1fY3VycmVu dFJlcXVlc3QudXJsKCkucHJvdG9jb2xJc0luSFRUUEZhbWlseSgpKSB7CiAgICAgICAgIHNjaGVk dWxlRmFpbHVyZShJbnZhbGlkVVJMRmFpbHVyZSk7CiAgICAgICAgIHJldHVybjsKQEAgLTE5MSw2 ICsxOTQsNyBAQCB2b2lkIE5ldHdvcmtEYXRhVGFza1NvdXA6OmNsZWFyUmVxdWVzdCgpCiAKICAg ICBzdG9wVGltZW91dCgpOwogICAgIG1fcGVuZGluZ1Jlc3VsdCA9IG51bGxwdHI7CisgICAgbV9w ZW5kaW5nRGF0YVVSTFJlc3VsdCA9IFdURjo6bnVsbG9wdDsKICAgICBtX2ZpbGUgPSBudWxscHRy OwogICAgIG1faW5wdXRTdHJlYW0gPSBudWxscHRyOwogICAgIG1fbXVsdGlwYXJ0SW5wdXRTdHJl YW0gPSBudWxscHRyOwpAQCAtMjQxLDYgKzI0NSwyNCBAQCB2b2lkIE5ldHdvcmtEYXRhVGFza1Nv dXA6OnJlc3VtZSgpCiAgICAgICAgIHJldHVybjsKICAgICB9CiAKKyAgICBpZiAobV9jdXJyZW50 UmVxdWVzdC51cmwoKS5wcm90b2NvbElzRGF0YSgpICYmICFtX2NhbmNlbGxhYmxlKSB7CisgICAg ICAgIG1fY2FuY2VsbGFibGUgPSBhZG9wdEdSZWYoZ19jYW5jZWxsYWJsZV9uZXcoKSk7CisgICAg ICAgIERhdGFVUkxEZWNvZGVyOjpkZWNvZGUobV9jdXJyZW50UmVxdWVzdC51cmwoKSwgeyB9LCBE YXRhVVJMRGVjb2Rlcjo6TW9kZTo6TGVnYWN5LCBbdGhpcywgcHJvdGVjdGVkVGhpcyA9IFdURk1v dmUocHJvdGVjdGVkVGhpcyldKGF1dG8gZGVjb2RlUmVzdWx0KSBtdXRhYmxlIHsKKyAgICAgICAg ICAgIGlmIChtX3N0YXRlID09IFN0YXRlOjpDYW5jZWxpbmcgfHwgbV9zdGF0ZSA9PSBTdGF0ZTo6 Q29tcGxldGVkIHx8ICFtX2NsaWVudCkgeworICAgICAgICAgICAgICAgIGNsZWFyUmVxdWVzdCgp OworICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIH0KKworICAgICAgICAgICAg aWYgKG1fc3RhdGUgPT0gU3RhdGU6OlN1c3BlbmRlZCkgeworICAgICAgICAgICAgICAgIG1fcGVu ZGluZ0RhdGFVUkxSZXN1bHQgPSBXVEZNb3ZlKGRlY29kZVJlc3VsdCk7CisgICAgICAgICAgICAg ICAgcmV0dXJuOworICAgICAgICAgICAgfQorCisgICAgICAgICAgICBkaWRSZWFkRGF0YVVSTChX VEZNb3ZlKGRlY29kZVJlc3VsdCkpOworICAgICAgICB9KTsKKyAgICAgICAgcmV0dXJuOworICAg IH0KKwogICAgIGlmIChtX3BlbmRpbmdSZXN1bHQpIHsKICAgICAgICAgR1JlZlB0cjxHQXN5bmNS ZXN1bHQ+IHBlbmRpbmdSZXN1bHQgPSBXVEZNb3ZlKG1fcGVuZGluZ1Jlc3VsdCk7CiAgICAgICAg IGlmIChtX2lucHV0U3RyZWFtKQpAQCAtMjU3LDcgKzI3OSw4IEBAIHZvaWQgTmV0d29ya0RhdGFU YXNrU291cDo6cmVzdW1lKCkKICAgICAgICAgICAgICAgICByZWFkRmlsZUNhbGxiYWNrKG1fZmls ZS5nZXQoKSwgcGVuZGluZ1Jlc3VsdC5nZXQoKSwgcHJvdGVjdGVkVGhpcy5sZWFrUmVmKCkpOwog ICAgICAgICB9IGVsc2UKICAgICAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwotICAgIH0K KyAgICB9IGVsc2UgaWYgKG1fY3VycmVudFJlcXVlc3QudXJsKCkucHJvdG9jb2xJc0RhdGEoKSkK KyAgICAgICAgZGlkUmVhZERhdGFVUkwoV1RGTW92ZShtX3BlbmRpbmdEYXRhVVJMUmVzdWx0KSk7 CiB9CiAKIHZvaWQgTmV0d29ya0RhdGFUYXNrU291cDo6Y2FuY2VsKCkKQEAgLTEyOTcsNSArMTMy MCwyMyBAQCB2b2lkIE5ldHdvcmtEYXRhVGFza1NvdXA6OmRpZFJlYWRGaWxlKEdSZWZQdHI8R0lu cHV0U3RyZWFtPiYmIGlucHV0U3RyZWFtKQogICAgIGRpc3BhdGNoRGlkUmVjZWl2ZVJlc3BvbnNl KCk7CiB9CiAKK3ZvaWQgTmV0d29ya0RhdGFUYXNrU291cDo6ZGlkUmVhZERhdGFVUkwoT3B0aW9u YWw8RGF0YVVSTERlY29kZXI6OlJlc3VsdD4mJiByZXN1bHQpCit7CisgICAgaWYgKGdfY2FuY2Vs bGFibGVfaXNfY2FuY2VsbGVkKG1fY2FuY2VsbGFibGUuZ2V0KCkpKSB7CisgICAgICAgIGRpZEZh aWwoY2FuY2VsbGVkRXJyb3IobV9jdXJyZW50UmVxdWVzdCkpOworICAgICAgICByZXR1cm47Cisg ICAgfQorCisgICAgaWYgKCFyZXN1bHQpIHsKKyAgICAgICAgZGlkRmFpbChpbnRlcm5hbEVycm9y KG1fY3VycmVudFJlcXVlc3QudXJsKCkpKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKworICAg IG1fcmVzcG9uc2UgPSBSZXNvdXJjZVJlc3BvbnNlOjpkYXRhVVJMUmVzcG9uc2UobV9jdXJyZW50 UmVxdWVzdC51cmwoKSwgcmVzdWx0LnZhbHVlKCkpOworICAgIGF1dG8gYnl0ZXMgPSBTaGFyZWRC dWZmZXI6OmNyZWF0ZShXVEZNb3ZlKHJlc3VsdC0+ZGF0YSkpLT5jcmVhdGVHQnl0ZXMoKTsKKyAg ICBtX2lucHV0U3RyZWFtID0gYWRvcHRHUmVmKGdfbWVtb3J5X2lucHV0X3N0cmVhbV9uZXdfZnJv bV9ieXRlcyhieXRlcy5nZXQoKSkpOworICAgIGRpc3BhdGNoRGlkUmVjZWl2ZVJlc3BvbnNlKCk7 Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L05ldHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya0RhdGFUYXNrU291cC5oIGIvU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9zb3VwL05ldHdvcmtEYXRhVGFza1NvdXAuaAppbmRleCBjZmZhMTIz MjA4MDEuLjE2ZTAxNDgwNGEzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJv Y2Vzcy9zb3VwL05ldHdvcmtEYXRhVGFza1NvdXAuaAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdv cmtQcm9jZXNzL3NvdXAvTmV0d29ya0RhdGFUYXNrU291cC5oCkBAIC0yNiw2ICsyNiw3IEBACiAj cHJhZ21hIG9uY2UKIAogI2luY2x1ZGUgIk5ldHdvcmtEYXRhVGFzay5oIgorI2luY2x1ZGUgPFdl YkNvcmUvRGF0YVVSTERlY29kZXIuaD4KICNpbmNsdWRlIDxXZWJDb3JlL0ZyYW1lSWRlbnRpZmll ci5oPgogI2luY2x1ZGUgPFdlYkNvcmUvTmV0d29ya0xvYWRNZXRyaWNzLmg+CiAjaW5jbHVkZSA8 V2ViQ29yZS9QYWdlSWRlbnRpZmllci5oPgpAQCAtMTQyLDYgKzE0Myw4IEBAIHByaXZhdGU6CiAg ICAgc3RhdGljIHZvaWQgZW51bWVyYXRlRmlsZUNoaWxkcmVuQ2FsbGJhY2soR0ZpbGUqLCBHQXN5 bmNSZXN1bHQqLCBOZXR3b3JrRGF0YVRhc2tTb3VwKik7CiAgICAgdm9pZCBkaWRSZWFkRmlsZShH UmVmUHRyPEdJbnB1dFN0cmVhbT4mJik7CiAKKyAgICB2b2lkIGRpZFJlYWREYXRhVVJMKE9wdGlv bmFsPFdlYkNvcmU6OkRhdGFVUkxEZWNvZGVyOjpSZXN1bHQ+JiYpOworCiAgICAgV2ViQ29yZTo6 RnJhbWVJZGVudGlmaWVyIG1fZnJhbWVJRDsKICAgICBXZWJDb3JlOjpQYWdlSWRlbnRpZmllciBt X3BhZ2VJRDsKICAgICBTdGF0ZSBtX3N0YXRlIHsgU3RhdGU6OlN1c3BlbmRlZCB9OwpAQCAtMTUy LDYgKzE1NSw3IEBAIHByaXZhdGU6CiAgICAgR1JlZlB0cjxTb3VwTXVsdGlwYXJ0SW5wdXRTdHJl YW0+IG1fbXVsdGlwYXJ0SW5wdXRTdHJlYW07CiAgICAgR1JlZlB0cjxHQ2FuY2VsbGFibGU+IG1f Y2FuY2VsbGFibGU7CiAgICAgR1JlZlB0cjxHQXN5bmNSZXN1bHQ+IG1fcGVuZGluZ1Jlc3VsdDsK KyAgICBPcHRpb25hbDxXZWJDb3JlOjpEYXRhVVJMRGVjb2Rlcjo6UmVzdWx0PiBtX3BlbmRpbmdE YXRhVVJMUmVzdWx0OwogICAgIFdlYkNvcmU6OlByb3RlY3Rpb25TcGFjZSBtX3Byb3RlY3Rpb25T cGFjZUZvclBlcnNpc3RlbnRTdG9yYWdlOwogICAgIFdlYkNvcmU6OkNyZWRlbnRpYWwgbV9jcmVk ZW50aWFsRm9yUGVyc2lzdGVudFN0b3JhZ2U7CiAgICAgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0 IG1fY3VycmVudFJlcXVlc3Q7Cg==