221088 2021-01-28 08:19:07 -0800 [macOS] Crash when updating color preferences 2021-01-28 10:01:31 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham webkit-bug-importer oldest_to_newest 1723367 0 pvollan 2021-01-28 08:19:07 -0800 After <https://trac.webkit.org/changeset/271965/webkit>, the WebContent process is no longer allowed to connect to the Launch Services daemon. This introduced a crash in the WebContent process when changing color preferences, since AppKit will then attempt to set application information with Launch Services, which causes a crash when that fails. 1723368 1 webkit-bug-importer 2021-01-28 08:19:26 -0800 <rdar://problem/73709142> 1723372 2 418644 pvollan 2021-01-28 08:35:16 -0800 Created attachment 418644 Patch 1723384 3 418644 bfulgham 2021-01-28 09:17:05 -0800 Comment on attachment 418644 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418644&action=review r=me, though I think a comment or changed function name might be helpful. > Source/WebKit/ChangeLog:12 > + WebContent process. Do you mean UIProcess here? I think the preference updates are expected in UIProcess, and we should never attempt to make such updates in the WCP. > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:188 > +static void updateCanQuitQuietlyAndSafely(NSApplication*, SEL) Perhaps this would be clearer with a better name, rather than a comment like I suggested below: static void preventAppKitFromContactingLaunchServicesFromWebContentProcess(NSApplication*, SEL) ... or maybe you can think of a better name. > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:189 > +{ Perhaps a comment here would be useful: // WebKit prohibits communication with Launch Services after entering the sandbox. This method override prevents AppKit // in the WebContent process from attempting to set color preferences. Color preferences are instead handled in the UIProcess. 1723391 4 418651 pvollan 2021-01-28 09:32:20 -0800 Created attachment 418651 Patch 1723392 5 pvollan 2021-01-28 09:39:07 -0800 (In reply to Brent Fulgham from comment #3) > Comment on attachment 418644 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=418644&action=review > > r=me, though I think a comment or changed function name might be helpful. > > > Source/WebKit/ChangeLog:12 > > + WebContent process. > > Do you mean UIProcess here? I think the preference updates are expected in > UIProcess, and we should never attempt to make such updates in the WCP. > This happened when updating color preferences from System Preferences. I updated the change log. > > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:188 > > +static void updateCanQuitQuietlyAndSafely(NSApplication*, SEL) > > Perhaps this would be clearer with a better name, rather than a comment like > I suggested below: > > static void > preventAppKitFromContactingLaunchServicesFromWebContentProcess(NSApplication* > , SEL) > > ... or maybe you can think of a better name. > Fixed! > > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:189 > > +{ > > Perhaps a comment here would be useful: > > // WebKit prohibits communication with Launch Services after entering the > sandbox. This method override prevents AppKit > // in the WebContent process from attempting to set color preferences. Color > preferences are instead handled in the UIProcess. Done, with a minor modification. Thanks for reviewing! 1723401 6 ews-feeder 2021-01-28 10:01:30 -0800 Committed r272017: <https://trac.webkit.org/changeset/272017> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418651. 418644 2021-01-28 08:35:16 -0800 2021-01-28 09:17:05 -0800 Patch bug-221088-20210128083516.patch text/plain 5130 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3MTk4MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAxLTI4ICBQZXIgQXJu ZSAgPHB2b2xsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFttYWNPU10gQ3Jhc2ggd2hlbiB1cGRh dGluZyBjb2xvciBwcmVmZXJlbmNlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjIxMDg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUmVtb3ZlIHByZXZpb3VzIHdvcmthcm91bmQgaW4gcjI3MTk2NSBmb3Ig cHJldmVudGluZyBMYXVuY2ggU2VydmljZXMgY29ubmVjdGlvbnMsIHNpbmNlIHRoaXMgaXMgY292 ZXJlZAorICAgICAgICBieSB0aGUgbmV3IGFwcHJvYWNoIGluIHRoaXMgcGF0Y2guCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9tYWMvVGhlbWVNYWMubW06CisgICAgICAgICgtW1dlYkNvcmVUaGVtZVdp bmRvdyBpc0tleVdpbmRvd10pOgorICAgICAgICAoLVtXZWJDb3JlVGhlbWVXaW5kb3cgaW52YWxp ZGF0ZVJlc3RvcmFibGVTdGF0ZV0pOiBEZWxldGVkLgorCiAyMDIxLTAxLTI3ICBKZXIgTm9ibGUg IDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgTWVkaWFSZW1vdGVTb2Z0TGlu ayBhbiBPYmplY3RpdmUtQysrIGZpbGUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VM b2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZwkocmV2aXNpb24g MjcyMDEzKQorKysgU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDIxLTAxLTI4ICBQZXIgQXJuZSAgPHB2b2xsYW5AYXBwbGUuY29t PgorCisgICAgICAgIFttYWNPU10gQ3Jhc2ggd2hlbiB1cGRhdGluZyBjb2xvciBwcmVmZXJlbmNl cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIxMDg4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRGVjbGFy ZSBOU0FwcGxpY2F0aW9uIFNQSSBmb3IgdXBkYXRpbmcgYXBwbGljYXRpb24gaW5mb3JtYXRpb24g d2l0aCBMYXVuY2ggU2VydmljZXMuCisKKyAgICAgICAgKiBwYWwvc3BpL21hYy9OU0FwcGxpY2F0 aW9uU1BJLmg6CisKIDIwMjEtMDEtMjEgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5A d2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgZXhwZXJpbWVudGFsIGZlYXR1cmUgdG8gdXNlIG5l dHdvcmsgbG9hZGVyCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9tYWMvTlNBcHBs aWNhdGlvblNQSS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL21h Yy9OU0FwcGxpY2F0aW9uU1BJLmgJKHJldmlzaW9uIDI3MTk4MykKKysrIFNvdXJjZS9XZWJDb3Jl L1BBTC9wYWwvc3BpL21hYy9OU0FwcGxpY2F0aW9uU1BJLmgJKHdvcmtpbmcgY29weSkKQEAgLTM1 LDYgKzM1LDggQEAgQGludGVyZmFjZSBOU0FwcGxpY2F0aW9uICgpCiAtICh2b2lkKWFjY2Vzc2li aWxpdHlTZXRFbmhhbmNlZFVzZXJJbnRlcmZhY2VBdHRyaWJ1dGU6KGlkKXZhbHVlOwogLSAoaWQp YWNjZXNzaWJpbGl0eUVuaGFuY2VkVXNlckludGVyZmFjZUF0dHJpYnV0ZTsKIAorLSAodm9pZClf dXBkYXRlQ2FuUXVpdFF1aWV0bHlBbmRTYWZlbHk7CisKIC8vIENvbmRpdGlvbmFsbHkgZGVmaW5l IHRoaXMgb25seSBmb3IgIVVTRV9BUFBMRV9JTlRFUk5BTF9TREsgd2hlbiA8cmRhcjovL3Byb2Js ZW0vNjM4NjQ3MTE+IGlzIGZpeGVkLgogQHByb3BlcnR5IChjb3B5LCBzZXR0ZXI9X3NldEFjY2Vu dENvbG9yOikgTlNDb2xvciAqX2FjY2VudENvbG9yOwogQHByb3BlcnR5IChyZWFkb25seSwgY29w eSkgTlNDb2xvciAqX2VmZmVjdGl2ZUFjY2VudENvbG9yOwpJbmRleDogU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbWFjL1RoZW1lTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL21hYy9UaGVtZU1hYy5tbQkocmV2aXNpb24gMjcxOTgzKQorKysgU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbWFjL1RoZW1lTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC02NiwxMCArNjYs NiBAQCAtIChCT09MKWlzS2V5V2luZG93CiB7CiAgICAgcmV0dXJuIHRoZW1lV2luZG93SGFzS2V5 QXBwZWFyYW5jZTsKIH0KLQotLSAodm9pZClpbnZhbGlkYXRlUmVzdG9yYWJsZVN0YXRlCi17Ci19 CiBAZW5kCiAKIEBpbXBsZW1lbnRhdGlvbiBXZWJDb3JlVGhlbWVWaWV3CkluZGV4OiBTb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gMjcxOTg3KQorKysgU291cmNlL1dlYktpdC9DaGFuZ2VMb2cJKHdvcmtpbmcgY29w eSkKQEAgLTEsMyArMSwyMCBAQAorMjAyMS0wMS0yOCAgUGVyIEFybmUgIDxwdm9sbGFuQGFwcGxl LmNvbT4KKworICAgICAgICBbbWFjT1NdIENyYXNoIHdoZW4gdXBkYXRpbmcgY29sb3IgcHJlZmVy ZW5jZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIy MTA4OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFm dGVyIHIyNzE5NjUsIHRoZSBXZWJDb250ZW50IHByb2Nlc3MgaXMgbm8gbG9uZ2VyIGFsbG93ZWQg dG8gY29ubmVjdCB0byB0aGUgTGF1bmNoIFNlcnZpY2VzIGRhZW1vbi4gVGhpcyBpbnRyb2R1Y2Vk IGEgY3Jhc2gKKyAgICAgICAgaW4gdGhlIFdlYkNvbnRlbnQgcHJvY2VzcyB3aGVuIGNoYW5naW5n IGNvbG9yIHByZWZlcmVuY2VzLCBzaW5jZSBBcHBLaXQgd2lsbCB0aGVuIGF0dGVtcHQgdG8gc2V0 IGFwcGxpY2F0aW9uIGluZm9ybWF0aW9uIHdpdGgKKyAgICAgICAgTGF1bmNoIFNlcnZpY2VzLCB3 aGljaCBjYXVzZXMgYSBjcmFzaCB3aGVuIHRoYXQgZmFpbHMuIFRoaXMgcGF0Y2ggYWRkcmVzc2Vz IHRoaXMgaXNzdWUgYnkgb3ZlcnJpZGluZyB0aGUgQXBwS2l0IG1ldGhvZCB0aGF0CisgICAgICAg IHVwZGF0ZXMgdGhlIHNwZWNpZmljIGFwcGxpY2F0aW9uIGluZm9ybWF0aW9uIHdpdGggTGF1bmNo IFNlcnZpY2VzLCBzaW5jZSB1cGRhdGluZyB0aGlzIGluZm9ybWF0aW9uIHNob3VsZCBiZSByZXF1 aXJlZCBpbiB0aGUKKyAgICAgICAgV2ViQ29udGVudCBwcm9jZXNzLgorCisgICAgICAgICogV2Vi UHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW06CisgICAgICAgIChXZWJLaXQ6OnVwZGF0 ZUNhblF1aXRRdWlldGx5QW5kU2FmZWx5KToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6 cGxhdGZvcm1Jbml0aWFsaXplV2ViUHJvY2Vzcyk6CisKIDIwMjEtMDEtMjcgIEJyZW50IEZ1bGdo YW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gQ29uZGl0aW9uYWxpemUg ZGVidWdnaW5nIHN1cHBvcnQgb24gaW50ZXJuYWwgYnVpbGRzCkluZGV4OiBTb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0JKHJldmlzaW9uIDI3 MTk4MykKKysrIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2Eu bW0JKHdvcmtpbmcgY29weSkKQEAgLTE4Myw2ICsxODMsMTIgQEAgc3RhdGljIGlkIE5TQXBwbGlj YXRpb25BY2Nlc3NpYmlsaXR5Rm9jdQogCiAgICAgcmV0dXJuIFtwYWdlLT5hY2Nlc3NpYmlsaXR5 UmVtb3RlT2JqZWN0KCkgYWNjZXNzaWJpbGl0eUZvY3VzZWRVSUVsZW1lbnRdOwogfQorCisjaWYg RU5BQkxFKFNFVF9XRUJDT05URU5UX1BST0NFU1NfSU5GT1JNQVRJT05fSU5fTkVUV09SS19QUk9D RVNTKQorc3RhdGljIHZvaWQgdXBkYXRlQ2FuUXVpdFF1aWV0bHlBbmRTYWZlbHkoTlNBcHBsaWNh dGlvbiosIFNFTCkKK3sKK30KKyNlbmRpZgogI2VuZGlmCiAKIApAQCAtMzIwLDYgKzMyNiw5IEBA IHZvaWQgV2ViUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplV2ViUHIKICAgICB1cGRhdGVQcm9j ZXNzTmFtZSgpOwogCiAjaWYgRU5BQkxFKFNFVF9XRUJDT05URU5UX1BST0NFU1NfSU5GT1JNQVRJ T05fSU5fTkVUV09SS19QUk9DRVNTKQorICAgIGF1dG8gbWV0aG9kID0gY2xhc3NfZ2V0SW5zdGFu Y2VNZXRob2QoW05TQXBwbGljYXRpb24gY2xhc3NdLCBAc2VsZWN0b3IoX3VwZGF0ZUNhblF1aXRR dWlldGx5QW5kU2FmZWx5KSk7CisgICAgbWV0aG9kX3NldEltcGxlbWVudGF0aW9uKG1ldGhvZCwg KElNUCl1cGRhdGVDYW5RdWl0UXVpZXRseUFuZFNhZmVseSk7CisKICAgICAvLyBGSVhNRTogUmVw bGFjZSB0aGUgY29uc3RhbnQgNCB3aXRoIGtMU1NlcnZlckNvbm5lY3Rpb25TdGF0dXNSZWxlYXNl Tm90aWZpY2F0aW9uc01hc2sgd2hlbiBhdmFpbGFibGUgaW4gdGhlIFNESywgc2VlIDxodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIwOTg4Pi4KICAgICBfTFNTZXRBcHBs aWNhdGlvbkxhdW5jaFNlcnZpY2VzU2VydmVyQ29ubmVjdGlvblN0YXR1cyhrTFNTZXJ2ZXJDb25u ZWN0aW9uU3RhdHVzRG9Ob3RDb25uZWN0VG9TZXJ2ZXJNYXNrIHwgLyprTFNTZXJ2ZXJDb25uZWN0 aW9uU3RhdHVzUmVsZWFzZU5vdGlmaWNhdGlvbnNNYXNrKi8gNCwgbnVsbHB0cik7CiAjZW5kaWYK 418651 2021-01-28 09:32:20 -0800 2021-01-28 10:01:31 -0800 Patch bug-221088-20210128093220.patch text/plain 5592 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3MjAxNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDIxLTAxLTI4ICBQZXIgQXJu ZSAgPHB2b2xsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFttYWNPU10gQ3Jhc2ggd2hlbiB1cGRh dGluZyBjb2xvciBwcmVmZXJlbmNlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjIxMDg4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MzcwOTE0Mj4K KworICAgICAgICBSZXZpZXdlZCBieSBCcmVudCBGdWxnaGFtLgorCisgICAgICAgIFJlbW92ZSBw cmV2aW91cyB3b3JrYXJvdW5kIGluIHIyNzE5NjUgZm9yIHByZXZlbnRpbmcgTGF1bmNoIFNlcnZp Y2VzIGNvbm5lY3Rpb25zLCBzaW5jZSB0aGlzIGlzIGNvdmVyZWQKKyAgICAgICAgYnkgdGhlIG5l dyBhcHByb2FjaCBpbiB0aGlzIHBhdGNoLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1RoZW1l TWFjLm1tOgorICAgICAgICAoLVtXZWJDb3JlVGhlbWVXaW5kb3cgaXNLZXlXaW5kb3ddKToKKyAg ICAgICAgKC1bV2ViQ29yZVRoZW1lV2luZG93IGludmFsaWRhdGVSZXN0b3JhYmxlU3RhdGVdKTog RGVsZXRlZC4KKwogMjAyMS0wMS0yOCAgQWRhIENoYW4gIDxhZGEuY2hhbkBhcHBsZS5jb20+CiAK ICAgICAgICAgUkVHUkVTU0lPTiAocjI3MTk4OCk6IFhSU2Vzc2lvbi5lbmQoKSBwcm9taXNlIGlz IG5vdCByZXNvbHZlZCBpZiBQbGF0Zm9ybVhSOjpEZXZpY2U6OnN1cHBvcnRzU2Vzc2lvblNodXRk b3duTm90aWZpY2F0aW9uKCkgcmV0dXJucyBmYWxzZQpJbmRleDogU291cmNlL1dlYkNvcmUvUEFM L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdlTG9nCShy ZXZpc2lvbiAyNzIwMTUpCisrKyBTb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMDEtMjggIFBlciBBcm5lICA8cHZvbGxhbkBh cHBsZS5jb20+CisKKyAgICAgICAgW21hY09TXSBDcmFzaCB3aGVuIHVwZGF0aW5nIGNvbG9yIHBy ZWZlcmVuY2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMjEwODgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzczNzA5MTQyPgorCisgICAgICAgIFJl dmlld2VkIGJ5IEJyZW50IEZ1bGdoYW0uCisKKyAgICAgICAgRGVjbGFyZSBOU0FwcGxpY2F0aW9u IFNQSSBmb3IgdXBkYXRpbmcgYXBwbGljYXRpb24gaW5mb3JtYXRpb24gd2l0aCBMYXVuY2ggU2Vy dmljZXMuCisKKyAgICAgICAgKiBwYWwvc3BpL21hYy9OU0FwcGxpY2F0aW9uU1BJLmg6CisKIDIw MjEtMDEtMjEgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAog ICAgICAgICBBZGQgZXhwZXJpbWVudGFsIGZlYXR1cmUgdG8gdXNlIG5ldHdvcmsgbG9hZGVyCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9tYWMvTlNBcHBsaWNhdGlvblNQSS5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL21hYy9OU0FwcGxpY2F0aW9u U1BJLmgJKHJldmlzaW9uIDI3MjAxNSkKKysrIFNvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL21h Yy9OU0FwcGxpY2F0aW9uU1BJLmgJKHdvcmtpbmcgY29weSkKQEAgLTM1LDYgKzM1LDggQEAgQGlu dGVyZmFjZSBOU0FwcGxpY2F0aW9uICgpCiAtICh2b2lkKWFjY2Vzc2liaWxpdHlTZXRFbmhhbmNl ZFVzZXJJbnRlcmZhY2VBdHRyaWJ1dGU6KGlkKXZhbHVlOwogLSAoaWQpYWNjZXNzaWJpbGl0eUVu aGFuY2VkVXNlckludGVyZmFjZUF0dHJpYnV0ZTsKIAorLSAodm9pZClfdXBkYXRlQ2FuUXVpdFF1 aWV0bHlBbmRTYWZlbHk7CisKIC8vIENvbmRpdGlvbmFsbHkgZGVmaW5lIHRoaXMgb25seSBmb3Ig IVVTRV9BUFBMRV9JTlRFUk5BTF9TREsgd2hlbiA8cmRhcjovL3Byb2JsZW0vNjM4NjQ3MTE+IGlz IGZpeGVkLgogQHByb3BlcnR5IChjb3B5LCBzZXR0ZXI9X3NldEFjY2VudENvbG9yOikgTlNDb2xv ciAqX2FjY2VudENvbG9yOwogQHByb3BlcnR5IChyZWFkb25seSwgY29weSkgTlNDb2xvciAqX2Vm ZmVjdGl2ZUFjY2VudENvbG9yOwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Ro ZW1lTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9UaGVt ZU1hYy5tbQkocmV2aXNpb24gMjcyMDE1KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFj L1RoZW1lTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC02NiwxMCArNjYsNiBAQCAtIChCT09MKWlz S2V5V2luZG93CiB7CiAgICAgcmV0dXJuIHRoZW1lV2luZG93SGFzS2V5QXBwZWFyYW5jZTsKIH0K LQotLSAodm9pZClpbnZhbGlkYXRlUmVzdG9yYWJsZVN0YXRlCi17Ci19CiBAZW5kCiAKIEBpbXBs ZW1lbnRhdGlvbiBXZWJDb3JlVGhlbWVWaWV3CkluZGV4OiBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwkocmV2aXNpb24gMjcyMDE1 KQorKysgU291cmNlL1dlYktpdC9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwy MSBAQAorMjAyMS0wMS0yOCAgUGVyIEFybmUgIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAg ICBbbWFjT1NdIENyYXNoIHdoZW4gdXBkYXRpbmcgY29sb3IgcHJlZmVyZW5jZXMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTA4OAorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vNzM3MDkxNDI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQnJlbnQgRnVs Z2hhbS4KKworICAgICAgICBBZnRlciByMjcxOTY1LCB0aGUgV2ViQ29udGVudCBwcm9jZXNzIGlz IG5vIGxvbmdlciBhbGxvd2VkIHRvIGNvbm5lY3QgdG8gdGhlIExhdW5jaCBTZXJ2aWNlcyBkYWVt b24uIFRoaXMgaW50cm9kdWNlZCBhIGNyYXNoCisgICAgICAgIGluIHRoZSBXZWJDb250ZW50IHBy b2Nlc3Mgd2hlbiBjb2xvciBwcmVmZXJlbmNlcyB3ZXJlIGNoYW5nZWQgaW4gU3lzdGVtIFByZWZl cmVuY2VzLCBzaW5jZSBBcHBLaXQgd2lsbCB0aGVuIGF0dGVtcHQgdG8gc2V0CisgICAgICAgIGFw cGxpY2F0aW9uIGluZm9ybWF0aW9uIHdpdGggTGF1bmNoIFNlcnZpY2VzLCB3aGljaCBjYXVzZXMg YSBjcmFzaCB3aGVuIHRoYXQgZmFpbHMuIFRoaXMgcGF0Y2ggYWRkcmVzc2VzIHRoaXMgaXNzdWUg YnkKKyAgICAgICAgb3ZlcnJpZGluZyB0aGUgQXBwS2l0IG1ldGhvZCB0aGF0IHVwZGF0ZXMgdGhl IHNwZWNpZmljIGFwcGxpY2F0aW9uIGluZm9ybWF0aW9uIHdpdGggTGF1bmNoIFNlcnZpY2VzLCBz aW5jZSB1cGRhdGluZyB0aGlzCisgICAgICAgIGluZm9ybWF0aW9uIHNob3VsZCBiZSByZXF1aXJl ZCBpbiB0aGUgV2ViQ29udGVudCBwcm9jZXNzLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9jb2Nv YS9XZWJQcm9jZXNzQ29jb2EubW06CisgICAgICAgIChXZWJLaXQ6OnVwZGF0ZUNhblF1aXRRdWll dGx5QW5kU2FmZWx5KToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6cGxhdGZvcm1Jbml0 aWFsaXplV2ViUHJvY2Vzcyk6CisKIDIwMjEtMDEtMjggIFBlciBBcm5lICA8cHZvbGxhbkBhcHBs ZS5jb20+CiAKICAgICAgICAgW21hY09TXSBSZW1vdmUgYWNjZXNzIHRvIGNvbS5hcHBsZS5CbHVl dG9vdGhTZXJ2aWNlcwpJbmRleDogU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1dlYlBy b2Nlc3NDb2NvYS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29j b2EvV2ViUHJvY2Vzc0NvY29hLm1tCShyZXZpc2lvbiAyNzIwMTUpCisrKyBTb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0x ODMsNiArMTgzLDE0IEBAIHN0YXRpYyBpZCBOU0FwcGxpY2F0aW9uQWNjZXNzaWJpbGl0eUZvY3UK IAogICAgIHJldHVybiBbcGFnZS0+YWNjZXNzaWJpbGl0eVJlbW90ZU9iamVjdCgpIGFjY2Vzc2li aWxpdHlGb2N1c2VkVUlFbGVtZW50XTsKIH0KKworI2lmIEVOQUJMRShTRVRfV0VCQ09OVEVOVF9Q Uk9DRVNTX0lORk9STUFUSU9OX0lOX05FVFdPUktfUFJPQ0VTUykKK3N0YXRpYyB2b2lkIHByZXZl bnRBcHBLaXRGcm9tQ29udGFjdGluZ0xhdW5jaFNlcnZpY2VzKE5TQXBwbGljYXRpb24qLCBTRUwp Cit7CisgICAgLy8gV2ViS2l0IHByb2hpYml0cyBjb21tdW5pY2F0aW9uIHdpdGggTGF1bmNoIFNl cnZpY2VzIGFmdGVyIGVudGVyaW5nIHRoZSBzYW5kYm94LiBUaGlzIG1ldGhvZCBvdmVycmlkZQor ICAgIC8vIHByZXZlbnRzIEFwcEtpdCBmcm9tIGF0dGVtcHRpbmcgdG8gdXBkYXRlIGFwcGxpY2F0 aW9uIGluZm9ybWF0aW9uIHdpdGggTGF1bmNoIFNlcnZpY2VzIGZyb20gdGhlIFdlYkNvbnRlbnQg cHJvY2Vzcy4KK30KKyNlbmRpZgogI2VuZGlmCiAKIApAQCAtMzIwLDYgKzMyOCw5IEBAIHZvaWQg V2ViUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplV2ViUHIKICAgICB1cGRhdGVQcm9jZXNzTmFt ZSgpOwogCiAjaWYgRU5BQkxFKFNFVF9XRUJDT05URU5UX1BST0NFU1NfSU5GT1JNQVRJT05fSU5f TkVUV09SS19QUk9DRVNTKQorICAgIGF1dG8gbWV0aG9kID0gY2xhc3NfZ2V0SW5zdGFuY2VNZXRo b2QoW05TQXBwbGljYXRpb24gY2xhc3NdLCBAc2VsZWN0b3IoX3VwZGF0ZUNhblF1aXRRdWlldGx5 QW5kU2FmZWx5KSk7CisgICAgbWV0aG9kX3NldEltcGxlbWVudGF0aW9uKG1ldGhvZCwgKElNUClw cmV2ZW50QXBwS2l0RnJvbUNvbnRhY3RpbmdMYXVuY2hTZXJ2aWNlcyk7CisKICAgICAvLyBGSVhN RTogUmVwbGFjZSB0aGUgY29uc3RhbnQgNCB3aXRoIGtMU1NlcnZlckNvbm5lY3Rpb25TdGF0dXNS ZWxlYXNlTm90aWZpY2F0aW9uc01hc2sgd2hlbiBhdmFpbGFibGUgaW4gdGhlIFNESywgc2VlIDxo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIwOTg4Pi4KICAgICBfTFNT ZXRBcHBsaWNhdGlvbkxhdW5jaFNlcnZpY2VzU2VydmVyQ29ubmVjdGlvblN0YXR1cyhrTFNTZXJ2 ZXJDb25uZWN0aW9uU3RhdHVzRG9Ob3RDb25uZWN0VG9TZXJ2ZXJNYXNrIHwgLyprTFNTZXJ2ZXJD b25uZWN0aW9uU3RhdHVzUmVsZWFzZU5vdGlmaWNhdGlvbnNNYXNrKi8gNCwgbnVsbHB0cik7CiAj ZW5kaWYK