221080 2021-01-27 21:53:07 -0800 REGRESSION (r271988): XRSession.end() promise is not resolved if PlatformXR::Device::supportsSessionShutdownNotification() returns false 2021-01-28 08:33:14 -0800 1 1 1 Unclassified WebKit WebXR WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 adachan adachan cdumez dino svillar webkit-bug-importer oldest_to_newest 1723291 0 adachan 2021-01-27 21:53:07 -0800 This is a regression from https://bugs.webkit.org/show_bug.cgi?id=220835. In that change, m_endPromise was saved after the call to WebXRSession::shutdown(InitiatedBySystem::No), but that call could result in WebXRSession::didCompleteShutdown() if the device returns false for supportsSessionShutdownNotification() and m_endPromise would still be null then. Not sure why xrSession_end.https.html did not time out like I've seen with xrSession_requestAnimationFrame_callback_calls.https.html. 1723293 1 adachan 2021-01-27 21:58:42 -0800 Regression point is https://trac.webkit.org/changeset/271988/webkit 1723295 2 418619 adachan 2021-01-27 22:10:20 -0800 Created attachment 418619 Patch 1723370 3 ews-feeder 2021-01-28 08:32:55 -0800 Committed r272014: <https://trac.webkit.org/changeset/272014> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418619. 1723371 4 webkit-bug-importer 2021-01-28 08:33:14 -0800 <rdar://problem/73709519> 418619 2021-01-27 22:10:20 -0800 2021-01-28 08:32:56 -0800 Patch bug-221080-20210127221018.patch text/plain 3682 adachan U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxOTg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzcyMzA5YjM2ZmYyZjhh YjE4YzM2MWFlNmE1MGIyOThlNmZjYzM0YS4uYTc4ZTRiNjQxODM0ZWU2MTc1NTU4NWI3NDE0MTBj ZjY1ZTIyODQwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTAxLTI3ICBBZGEg Q2hhbiAgPGFkYS5jaGFuQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjcxOTg4 KTogWFJTZXNzaW9uLmVuZCgpIHByb21pc2UgaXMgbm90IHJlc29sdmVkIGlmIFBsYXRmb3JtWFI6 OkRldmljZTo6c3VwcG9ydHNTZXNzaW9uU2h1dGRvd25Ob3RpZmljYXRpb24oKSByZXR1cm5zIGZh bHNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjEw ODAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBtX2Vu ZFByb21pc2UgbmVlZHMgdG8gYmUgc2V0IGJlZm9yZSBXZWJYUlNlc3Npb246OnNodXRkb3duKCkg aXMgY2FsbGVkCisgICAgICAgIHNpbmNlIHRoYXQgY2FuIGNhbGwgV2ViWFJTZXNzaW9uOjpkaWRD b21wbGV0ZVNodXRkb3duKCkgd2hpY2ggd2lsbAorICAgICAgICByZXNvbHZlIG1fZW5kUHJvbWlz ZS4KKworICAgICAgICBUaGlzIGlzc3VlIGNhdXNlZCBhIHRpbWVvdXQgaW4gdGhlIGNsZWFudXAg c3RlcCBmb3IgYSB0ZXN0IGxpa2UKKyAgICAgICAgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10 ZXN0cy93ZWJ4ci94clNlc3Npb25fcmVxdWVzdEFuaW1hdGlvbkZyYW1lX2NhbGxiYWNrX2NhbGxz Lmh0dHBzLmh0bWwuCisKKyAgICAgICAgKiBNb2R1bGVzL3dlYnhyL1dlYlhSU2Vzc2lvbi5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpXZWJYUlNlc3Npb246OmVuZCk6CisKIDIwMjEtMDEtMjcgIEFk YSBDaGFuICA8YWRhLmNoYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFNlbmQgdGhlIGVuZCBYUlNl c3Npb25FdmVudCBhZnRlciB0aGUgcGxhdGZvcm0tc3BlY2lmaWMgc3RlcHMgZm9yIHNlc3Npb24g c2h1dGRvd24gaGF2ZSBjb21wbGV0ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVs ZXMvd2VieHIvV2ViWFJTZXNzaW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2VieHIv V2ViWFJTZXNzaW9uLmNwcAppbmRleCAwNTBiZDg1MWI3OWYzZjgyNTZjZGU0NmE4NzBjOGFjYWRi M2JiMTRlLi5kOGUyZjgxMWMyNDViMGNlYjBhY2VmZWEzZGZlZGE1NGU1MjhiMDA1IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnhyL1dlYlhSU2Vzc2lvbi5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJ4ci9XZWJYUlNlc3Npb24uY3BwCkBAIC0zOTAsNiAr MzkwLDkgQEAgRXhjZXB0aW9uT3I8dm9pZD4gV2ViWFJTZXNzaW9uOjplbmQoRW5kUHJvbWlzZSYm IHByb21pc2UpCiAgICAgaWYgKG1fZW5kZWQpCiAgICAgICAgIHJldHVybiBFeGNlcHRpb24geyBJ bnZhbGlkU3RhdGVFcnJvciwgIkNhbm5vdCBlbmQgYSBzZXNzaW9uIG1vcmUgdGhhbiBvbmNlIl9z IH07CiAKKyAgICBBU1NFUlQoIW1fZW5kUHJvbWlzZSk7CisgICAgbV9lbmRQcm9taXNlID0gV1RG TW92ZShwcm9taXNlKTsKKwogICAgIC8vIDEuIExldCBwcm9taXNlIGJlIGEgbmV3IFByb21pc2Uu CiAgICAgLy8gMi4gU2h1dCBkb3duIHRoZSB0YXJnZXQgWFJTZXNzaW9uIG9iamVjdC4KICAgICBz aHV0ZG93bihJbml0aWF0ZWRCeVN5c3RlbTo6Tm8pOwpAQCAtMzk3LDkgKzQwMCw2IEBAIEV4Y2Vw dGlvbk9yPHZvaWQ+IFdlYlhSU2Vzc2lvbjo6ZW5kKEVuZFByb21pc2UmJiBwcm9taXNlKQogICAg IC8vIDMuIFF1ZXVlIGEgdGFzayB0byBwZXJmb3JtIHRoZSBmb2xsb3dpbmcgc3RlcHM6CiAgICAg Ly8gMy4xIFdhaXQgdW50aWwgYW55IHBsYXRmb3JtLXNwZWNpZmljIHN0ZXBzIHJlbGF0ZWQgdG8g c2h1dHRpbmcgZG93biB0aGUgc2Vzc2lvbiBoYXZlIGNvbXBsZXRlZC4KICAgICAvLyAzLjIgUmVz b2x2ZSBwcm9taXNlLgotICAgIEFTU0VSVCghbV9lbmRQcm9taXNlKTsKLSAgICBtX2VuZFByb21p c2UgPSBXVEZNb3ZlKHByb21pc2UpOwotCiAgICAgLy8gNC4gUmV0dXJuIHByb21pc2UuCiAgICAg cmV0dXJuIHsgfTsKIH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91 dFRlc3RzL0NoYW5nZUxvZwppbmRleCAyMTFkMGNmNzE3MWI3ZDY3YmNhOWE5MDZmOGEwYzkwMjY0 NmI4MjZhLi4wMzA4MDU5OTU2N2Y1M2E4MDc4NWM0ZjYzMGM0Y2EyOGJiZTA1MWQ5IDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTQgQEAKKzIwMjEtMDEtMjcgIEFkYSBDaGFuICA8YWRhLmNoYW5AYXBwbGUuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNzE5ODgpOiBYUlNlc3Npb24uZW5kKCkgcHJvbWlz ZSBpcyBub3QgcmVzb2x2ZWQgaWYgUGxhdGZvcm1YUjo6RGV2aWNlOjpzdXBwb3J0c1Nlc3Npb25T aHV0ZG93bk5vdGlmaWNhdGlvbigpIHJldHVybnMgZmFsc2UKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMTA4MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVuYWJsZSBhIHRlc3QgdGhhdCB3YXMgdGltaW5n IG91dCwgYnV0IG5vdyBwYXNzZXMgd2l0aCB0aGUgYnVnIGZpeC4KKworICAgICAgICAqIHBsYXRm b3JtL21hYy9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDIxLTAxLTI3ICBBZGEgQ2hhbiAgPGFkYS5j aGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBTZW5kIHRoZSBlbmQgWFJTZXNzaW9uRXZlbnQgYWZ0 ZXIgdGhlIHBsYXRmb3JtLXNwZWNpZmljIHN0ZXBzIGZvciBzZXNzaW9uIHNodXRkb3duIGhhdmUg Y29tcGxldGVkCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVj dGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCmluZGV4 IDU5ZWJhNmIwMGRiNjUwM2RhMjlmODliZGUxNTIzNTcyNDJjNDA3OTUuLjQ0NmRhOWM4MzI3MDVj Y2ViNmU2YTQ3ODhiMDZlNzBjNjYzMjJhY2YgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRm b3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9U ZXN0RXhwZWN0YXRpb25zCkBAIC0yMjYwLDQgKzIyNjAsNSBAQCB3ZWJraXQub3JnL2IvMjIwNTUy IFsgQmlnU3VyKyBdIG1lZGlhL21lZGlhLXNvdXJjZS9tZWRpYS1zb3VyY2Utd2VibS1pbml0LWlu c2lkZQogCiAjIFdlYlhSIHRlc3RzCiBbIEJpZ1N1cisgXSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRm b3JtLXRlc3RzL3dlYnhyL3hyU2Vzc2lvbl9lbmQuaHR0cHMuaHRtbCBbIFBhc3MgXQorWyBCaWdT dXIrIF0gaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy93ZWJ4ci94clNlc3Npb25fcmVx dWVzdEFuaW1hdGlvbkZyYW1lX2NhbGxiYWNrX2NhbGxzLmh0dHBzLmh0bWwgWyBQYXNzIF0KIFsg QmlnU3VyKyBdIGh0dHAvd3B0L3dlYnhyIFsgUGFzcyBdCg==