221070 2021-01-27 17:22:37 -0800 [Flatpak SDK] Flatpak environment JSON is prematurely deleted with flatpak-spawn calls 2021-02-10 12:42:33 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=220781 https://bugs.webkit.org/show_bug.cgi?id=221711 InRadar P2 Normal --- 1 lmoura lmoura bugs-noreply pnormand webkit-bug-importer oldest_to_newest 1723226 0 lmoura 2021-01-27 17:22:37 -0800 r271938 added a flatpak_env.json file to forward some variables to webkit-bwrap after flatpak 1.10 changes. This is working fine most of the time, but if flatpak-spawn is used to invoke a command from the host into the flatpak again (e.g. calling coredumpctl when a layout test fails), the new webkit-flatpak invocation may overwrite the file and delete it when exiting. This could cause the finally block in the first flatpak process to fail with: Traceback (most recent call last): File "./Tools/Scripts/run-webkit-tests", line 42, in <module> flatpakutils.run_in_sandbox_if_available(sys.argv) File "./Tools/flatpak/flatpakutils.py", line 1124, in run_in_sandbox_if_available sys.exit(flatpak_runner.run_in_sandbox(*app_args)) File "./Tools/flatpak/flatpakutils.py", line 877, in run_in_sandbox os.remove(env_file) OSError: [Errno 2] No such file or directory: '/home/lauro/dev/WebKit/WebKitBuild/flatpak-env.json' 1723232 1 418603 lmoura 2021-01-27 17:39:10 -0800 Created attachment 418603 Initial patch 1723410 2 ews-feeder 2021-01-28 10:26:58 -0800 Committed r272018: <https://trac.webkit.org/changeset/272018> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418603. 1723411 3 webkit-bug-importer 2021-01-28 10:27:19 -0800 <rdar://problem/73714133> 418603 2021-01-27 17:39:10 -0800 2021-01-28 10:26:59 -0800 Initial patch bug-221070-20210127223908.patch text/plain 2051 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxOTkwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDQ5ZjM0N2VkZTE4Zjk2NDliNjc1ODUyYzk0YzQxYzVl NjNmNWRjZi4uNTI1OThkOTM4YjdkZWM4ZTQ1ZjNiZDE5YWUzZjA4Y2JmZGUwM2Y1ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDIxLTAxLTI3ICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAg ICAgIFtGbGF0cGFrIFNES10gRmxhdHBhayBlbnZpcm9ubWVudCBKU09OIGlzIHByZW1hdHVyZWx5 IGRlbGV0ZWQgd2l0aCBmbGF0cGFrLXNwYXduIGNhbGxzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjEwNzAKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUbyBhdm9pZCBuZXN0ZWQgd2Via2l0LWZsYXRwYWsg Y2FsbHMgb3ZlcndyaXRpbmcvZGVsZXRpbmcgd2hlCisgICAgICAgIGVudmlyb25tZW50IGZpbGUs IG9ubHkgY3JlYXRlIGlmIHRoZXJlIGlzIG5vIHN1Y2ggZmlsZSBhbmQgb25seSBkZWxldGUKKyAg ICAgICAgaW4gdGhlIHNhbWUgcHJvY2VzcyB0aGF0IGNyZWF0ZWQgaXQuCisKKyAgICAgICAgVGhp cyBhcHByb2FjaCBoYXMgdGhlIGRyYXdiYWNrIG9mIGxpbWl0aW5nIG5lc3RlZCBjYWxscyBjaGFu Z2luZyB0aGUKKyAgICAgICAgdmFyaWFibGUgdmFsdWVzIGFuZCBhIGZpbGUgdW5kZWxldGVkIGFm dGVyIGEgY3Jhc2ggbWlnaHQgYXZvaWQgdGhlCisgICAgICAgIG5leHQgbm9ybWFsIGludm9jYXRp b24gY3JlYXRpbmcgaXQuCisKKyAgICAgICAgKiBmbGF0cGFrL2ZsYXRwYWt1dGlscy5weToKKyAg ICAgICAgKFdlYmtpdEZsYXRwYWsucnVuX2luX3NhbmRib3gpOgorCiAyMDIxLTAxLTI3ICBBYWth c2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbYnVpbGQud2Via2l0 Lm9yZ10gQWRkIGJhc2ljIGF1dGhlbnRpY2F0aW9uCmRpZmYgLS1naXQgYS9Ub29scy9mbGF0cGFr L2ZsYXRwYWt1dGlscy5weSBiL1Rvb2xzL2ZsYXRwYWsvZmxhdHBha3V0aWxzLnB5CmluZGV4IDQ1 MDllODhmYmI0Mjc3OWJlZTYzNDUzOGFiNmM1YmNhMzFmODI4MWQuLmU0ZmRkMDk4ZGEwYzNkZjk5 MDc1ZDVjYTZkYmRiNjIwMWE5MWYyM2IgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2ZsYXRwYWsvZmxhdHBh a3V0aWxzLnB5CisrKyBiL1Rvb2xzL2ZsYXRwYWsvZmxhdHBha3V0aWxzLnB5CkBAIC04NjYsMTUg Kzg2NiwxOSBAQCBjbGFzcyBXZWJraXRGbGF0cGFrOgogICAgICAgICB9KQogCiAgICAgICAgIGVu dl9maWxlID0gb3MucGF0aC5qb2luKHNlbGYuYnVpbGRfcm9vdCwgJ2ZsYXRwYWstZW52Lmpzb24n KQotICAgICAgICB3aXRoIG9wZW4oZW52X2ZpbGUsICd3JykgYXMgZjoKLSAgICAgICAgICAgIGpz b24uZHVtcChkaWN0KGZsYXRwYWtfZW52KSwgZiwgaW5kZW50PTIpCisgICAgICAgIGlmIG5vdCBv cy5wYXRoLmV4aXN0cyhlbnZfZmlsZSk6CisgICAgICAgICAgICB3aXRoIG9wZW4oZW52X2ZpbGUs ICd3JykgYXMgZjoKKyAgICAgICAgICAgICAgICBqc29uLmR1bXAoZGljdChmbGF0cGFrX2Vudiks IGYsIGluZGVudD0yKQorICAgICAgICBlbHNlOgorICAgICAgICAgICAgZW52X2ZpbGUgPSBOb25l CiAKICAgICAgICAgdHJ5OgogICAgICAgICAgICAgcmV0dXJuIHNlbGYuZXhlY3V0ZV9jb21tYW5k KGZsYXRwYWtfY29tbWFuZCwgc3Rkb3V0PXN0ZG91dCwgZW52PWZsYXRwYWtfZW52KQogICAgICAg ICBleGNlcHQgS2V5Ym9hcmRJbnRlcnJ1cHQ6CiAgICAgICAgICAgICByZXR1cm4gMAogICAgICAg ICBmaW5hbGx5OgotICAgICAgICAgICAgb3MucmVtb3ZlKGVudl9maWxlKQorICAgICAgICAgICAg aWYgZW52X2ZpbGUgaXMgbm90IE5vbmUgYW5kIG9zLnBhdGguZXhpc3RzKGVudl9maWxlKToKKyAg ICAgICAgICAgICAgICBvcy5yZW1vdmUoZW52X2ZpbGUpCiAKICAgICAgICAgcmV0dXJuIDAKIAo=