22107 2008-11-06 10:56:56 -0800 Fix compilation of WTF::AVLTree 2008-11-06 11:31:17 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 hausmann webkit-unassigned oldest_to_newest 97842 0 hausmann 2008-11-06 10:56:56 -0800 Some functions in AVLTree call get_lt and get_gt with a second argument that does not exist. 97843 1 24948 hausmann 2008-11-06 10:57:24 -0800 Created attachment 24948 Patch to fix compilation 97846 2 24948 darin 2008-11-06 11:19:42 -0800 Comment on attachment 24948 Patch to fix compilation > + * wtf/AVLTree.h: > + (JSC::::remove): > + (JSC::::subst): This ChangeLog entry looks strange. I know it was produced by prepare-ChangeLog, but we shouldn't check in strange log entries just because the script made them. r=me 97850 3 hausmann 2008-11-06 11:30:57 -0800 Thanks, landed with corrected changelog in r38190 97851 4 24948 hausmann 2008-11-06 11:31:17 -0800 Comment on attachment 24948 Patch to fix compilation (clearing review after landing) 24948 2008-11-06 10:57:24 -0800 2008-11-06 11:31:17 -0800 Patch to fix compilation patch.txt text/plain 2427 hausmann Y29tbWl0IGM5YjdhOTA2N2RkMDhiMzg0NmI0YjlhNGE0NmYyYzk0ODAwOGZjZTcKQXV0aG9yOiBM YXN6bG8gR29tYm9zIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgpEYXRlOiAgIFRodSBPY3Qg MjMgMjE6NDE6NDcgMjAwOCArMDMwMAoKICAgIDAwOC0xMS0wNiAgTGFzemxvIEdvbWJvcyAgPGxh c3psby4xLmdvbWJvc0Bub2tpYS5jb20+CiAgICAKICAgICAgICAgICAgUmV2aWV3ZWQgYnkgU2lt b24gSGF1c21hbm4uCiAgICAKICAgICAgICAgICAgQnVnIHVuY292ZXJlZCBkdXJpbmcgUlZDVCBw b3J0IGluIGZ1bmN0aW9ucyBub3QgdXNlZC4gZ2V0X2x0KCkgYW5kCiAgICAgICAgICAgIGdldF9n dCgpIHRha2VzIG9ubHkgb25lIGFyZ3VtZW50IC0gcmVtb3ZlIHNlY29uZCBhcmd1bWVudCB3aGVy ZQogICAgICAgICAgICBhcHBsaWNhYmxlLgoKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBjMzIxNDk3Li4xYTBjZjU0 IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgtMTEtMDYgIExhc3psbyBHb21ib3Mg IDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IFNpbW9u IEhhdXNtYW5uLgorCisgICAgICAgIEJ1ZyB1bmNvdmVyZWQgZHVyaW5nIFJWQ1QgcG9ydCBpbiBm dW5jdGlvbnMgbm90IHVzZWQuIGdldF9sdCgpIGFuZAorICAgICAgICBnZXRfZ3QoKSB0YWtlcyBv bmx5IG9uZSBhcmd1bWVudCAtIHJlbW92ZSBzZWNvbmQgYXJndW1lbnQgd2hlcmUKKyAgICAgICAg YXBwbGljYWJsZS4KKworICAgICAgICAqIHd0Zi9BVkxUcmVlLmg6CisgICAgICAgIChKU0M6Ojo6 cmVtb3ZlKToKKyAgICAgICAgKEpTQzo6OjpzdWJzdCk6CisKIDIwMDgtMTEtMDYgIEFscCBUb2tl ciAgPGFscEBudWFudGkuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IENhbWVyb24gWndhcmlj aC4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3d0Zi9BVkxUcmVlLmggYi9KYXZhU2NyaXB0 Q29yZS93dGYvQVZMVHJlZS5oCmluZGV4IGNkMTUxMWYuLjk3ZjI4YWIgMTAwNjQ0Ci0tLSBhL0ph dmFTY3JpcHRDb3JlL3d0Zi9BVkxUcmVlLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvd3RmL0FWTFRy ZWUuaApAQCAtODIyLDcgKzgyMiw3IEBAIEFWTFRyZWU8QWJzdHJhY3RvciwgbWF4RGVwdGgsIEJT ZXQ+OjpyZW1vdmUoa2V5IGspCiAgICAgICAgICAgICBjbXBfc2hvcnRlbmVkX3N1Yl93aXRoX3Bh dGggPSBjbXA7CiAKICAgICAgICAgLy8gR2V0IHRoZSBoYW5kbGUgb2YgdGhlIG9wcG9zaXRlIGNo aWxkLCB3aGljaCBtYXkgbm90IGJlIG51bGwuCi0gICAgICAgIGNoaWxkID0gY21wID4gMCA/IGdl dF9sdChoLCBmYWxzZSkgOiBnZXRfZ3QoaCwgZmFsc2UpOworICAgICAgICBjaGlsZCA9IGNtcCA+ IDAgPyBnZXRfbHQoaCkgOiBnZXRfZ3QoaCk7CiAgICAgfQogCiAgICAgaWYgKHBhcmVudCA9PSBu dWxsKCkpCkBAIC04NDEsOCArODQxLDggQEAgQVZMVHJlZTxBYnN0cmFjdG9yLCBtYXhEZXB0aCwg QlNldD46OnJlbW92ZShrZXkgaykKIAogICAgIGlmIChoICE9IHJtKSB7CiAgICAgICAgIC8vIFBv a2UgaW4gdGhlIHJlcGxhY2VtZW50IGZvciB0aGUgbm9kZSB0byBiZSByZW1vdmVkLgotICAgICAg ICBzZXRfbHQoaCwgZ2V0X2x0KHJtLCBmYWxzZSkpOwotICAgICAgICBzZXRfZ3QoaCwgZ2V0X2d0 KHJtLCBmYWxzZSkpOworICAgICAgICBzZXRfbHQoaCwgZ2V0X2x0KHJtKSk7CisgICAgICAgIHNl dF9ndChoLCBnZXRfZ3Qocm0pKTsKICAgICAgICAgc2V0X2JmKGgsIGdldF9iZihybSkpOwogICAg ICAgICBpZiAocGFyZW50X3JtID09IG51bGwoKSkKICAgICAgICAgICAgIGFicy5yb290ID0gaDsK QEAgLTkzNCw4ICs5MzQsOCBAQCBBVkxUcmVlPEFic3RyYWN0b3IsIG1heERlcHRoLCBCU2V0Pjo6 c3Vic3QoaGFuZGxlIG5ld19ub2RlKQogICAgIH0KIAogICAgIC8qIENvcHkgdHJlZSBob3VzZWtl ZXBpbmcgZmllbGRzIGZyb20gbm9kZSBpbiB0cmVlIHRvIG5ldyBub2RlLiAqLwotICAgIHNldF9s dChuZXdfbm9kZSwgZ2V0X2x0KGgsIGZhbHNlKSk7Ci0gICAgc2V0X2d0KG5ld19ub2RlLCBnZXRf Z3QoaCwgZmFsc2UpKTsKKyAgICBzZXRfbHQobmV3X25vZGUsIGdldF9sdChoKSk7CisgICAgc2V0 X2d0KG5ld19ub2RlLCBnZXRfZ3QoaCkpOwogICAgIHNldF9iZihuZXdfbm9kZSwgZ2V0X2JmKGgp KTsKIAogICAgIGlmIChwYXJlbnQgPT0gbnVsbCgpKQpAQCAtOTUyLDcgKzk1Miw2IEBAIEFWTFRy ZWU8QWJzdHJhY3RvciwgbWF4RGVwdGgsIEJTZXQ+OjpzdWJzdChoYW5kbGUgbmV3X25vZGUpCiAg ICAgcmV0dXJuIGg7CiB9CiAKLQogfQogCiAjZW5kaWYK