221068 2021-01-27 16:38:56 -0800 [Flatpak SDK] Avoid "Invalid byte sequence in conversion input" errors and other encoding issues 2021-01-28 04:49:14 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=220781 InRadar P2 Normal --- 1 lmoura lmoura aboya aperez bugs-noreply pnormand webkit-bug-importer oldest_to_newest 1723206 0 lmoura 2021-01-27 16:38:56 -0800 After r271938, sometimes the flatpak invocation could raise the following error without more information: Error: Invalid byte sequence in conversion input This seems to happen due to LANG being deleted in flatpakutils.py before being set in webkit-bwrap. Also, the webkit-flatpak script may fail with encoding issues when printing the messages "Running..." and "Command.... exited with non-zero status" with the non-ascii prompt. 1723212 1 418600 lmoura 2021-01-27 16:47:59 -0800 Created attachment 418600 Patch 1723311 2 418600 pnormand 2021-01-28 00:29:47 -0800 Comment on attachment 418600 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418600&action=review > Tools/ChangeLog:10 > + (WebkitFlatpak.run_in_sandbox): Avoid iterating mutating dict and What's wrong with that? 1723335 3 418600 aboya 2021-01-28 03:03:02 -0800 Comment on attachment 418600 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418600&action=review >> Tools/ChangeLog:10 >> + (WebkitFlatpak.run_in_sandbox): Avoid iterating mutating dict and > > What's wrong with that? It's not supported in Python, it's a case of iterator invalidation: e.g. a = {"a":1, "b": 2, "c": 3} for k in a.keys(): print(k) del a[k] RuntimeError: dictionary changed size during iteration 1723339 4 lmoura 2021-01-28 03:13:39 -0800 (In reply to Alicia Boya García from comment #3) > Comment on attachment 418600 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=418600&action=review > > >> Tools/ChangeLog:10 > >> + (WebkitFlatpak.run_in_sandbox): Avoid iterating mutating dict and > > > > What's wrong with that? > > It's not supported in Python, it's a case of iterator invalidation: > > e.g. > > a = {"a":1, "b": 2, "c": 3} > > for k in a.keys(): > print(k) > del a[k] > > RuntimeError: dictionary changed size during iteration This. Py2[1] had dict.keys()[1], returning a list, and dict.viewkeys()[2], which returned an iterator (a view) on them. Py3 changed the behavior of keys() to return the view[3]. [1] https://python.readthedocs.io/en/v2.7.2/library/stdtypes.html#dict.keys [2] https://python.readthedocs.io/en/v2.7.2/library/stdtypes.html#dict.viewkeys [3] https://docs.python.org/3/library/stdtypes.html#dict.keys 1723351 5 ews-feeder 2021-01-28 04:48:14 -0800 Committed r272011: <https://trac.webkit.org/changeset/272011> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418600. 1723352 6 webkit-bug-importer 2021-01-28 04:49:14 -0800 <rdar://problem/73704686> 418600 2021-01-27 16:47:59 -0800 2021-01-28 04:48:15 -0800 Patch bug-221068-20210127214758.patch text/plain 3602 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxOTkwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDQ5ZjM0N2VkZTE4Zjk2NDliNjc1ODUyYzk0YzQxYzVl NjNmNWRjZi4uZGFlNTIyYTQ3ZTg0OThkNzYwYTYxMjcxNjZkMzA4OTM3NzI3ZWNhMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDIxLTAxLTI3ICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAg ICAgIFtGbGF0cGFrIFNES10gQXZvaWQgIkludmFsaWQgYnl0ZSBzZXF1ZW5jZSBpbiBjb252ZXJz aW9uIGlucHV0IiBlcnJvcnMgYW5kIG90aGVyIGVuY29kaW5nIGlzc3VlcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIxMDY4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmbGF0cGFrL2ZsYXRwYWt1dGls cy5weToKKyAgICAgICAgKFdlYmtpdEZsYXRwYWsuZXhlY3V0ZV9jb21tYW5kKTogRGVjb2RlIHRo ZSBhcmd1bWVudHMgYmVmb3JlIHByaW50aW5nLgorICAgICAgICAoV2Via2l0RmxhdHBhay5ydW5f aW5fc2FuZGJveCk6IEF2b2lkIGl0ZXJhdGluZyBtdXRhdGluZyBkaWN0IGFuZAorICAgICAgICBl eHBvcnQgTEFORy4KKyAgICAgICAgKiBmbGF0cGFrL3dlYmtpdC1id3JhcDogSWdub3JlIExBTkcg YXMgaXQncyBleHBvcnRlZCBieQorICAgICAgICBmbGF0cGFrdXRpbHMucHkuCisKIDIwMjEtMDEt MjcgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtidWls ZC53ZWJraXQub3JnXSBBZGQgYmFzaWMgYXV0aGVudGljYXRpb24KZGlmZiAtLWdpdCBhL1Rvb2xz L2ZsYXRwYWsvZmxhdHBha3V0aWxzLnB5IGIvVG9vbHMvZmxhdHBhay9mbGF0cGFrdXRpbHMucHkK aW5kZXggNDUwOWU4OGZiYjQyNzc5YmVlNjM0NTM4YWI2YzViY2EzMWY4MjgxZC4uNzJkMjQzNDdj ZWQyZTY5MDIzN2Y3OTJjYTIxZjk0NDU5NDdkOGQ5OSAxMDA2NDQKLS0tIGEvVG9vbHMvZmxhdHBh ay9mbGF0cGFrdXRpbHMucHkKKysrIGIvVG9vbHMvZmxhdHBhay9mbGF0cGFrdXRpbHMucHkKQEAg LTM2LDYgKzM2LDcgQEAgaW1wb3J0IHJlCiBpbXBvcnQgcGxhdGZvcm0KIAogZnJvbSB3ZWJraXRw eS5jb21tb24uc3lzdGVtLmxvZ3V0aWxzIGltcG9ydCBjb25maWd1cmVfbG9nZ2luZworZnJvbSB3 ZWJraXRjb3JlcHkgaW1wb3J0IHN0cmluZ191dGlscwogaW1wb3J0IHRvbWwKIGltcG9ydCBqc29u CiAKQEAgLTUxNywxMyArNTE4LDEzIEBAIGNsYXNzIFdlYmtpdEZsYXRwYWs6CiAgICAgICAgIHNl bGYuc2NjYWNoZV9zY2hlZHVsZXIgPSBERUZBVUxUX1NDQ0FDSEVfU0NIRURVTEVSCiAKICAgICBk ZWYgZXhlY3V0ZV9jb21tYW5kKHNlbGYsIGFyZ3MsIHN0ZG91dD1Ob25lLCBzdGRlcnI9Tm9uZSwg ZW52PU5vbmUpOgotICAgICAgICBfbG9nLmRlYnVnKCdSdW5uaW5nOiAlc1xuJyAlICcgJy5qb2lu KGFyZ3MpKQorICAgICAgICBfbG9nLmRlYnVnKCdSdW5uaW5nOiAlc1xuJyAlICcgJy5qb2luKHN0 cmluZ191dGlscy5kZWNvZGUoYXJnKSBmb3IgYXJnIGluIGFyZ3MpKQogICAgICAgICByZXN1bHQg PSAwCiAgICAgICAgIHRyeToKICAgICAgICAgICAgIHJlc3VsdCA9IHN1YnByb2Nlc3MuY2hlY2tf Y2FsbChhcmdzLCBzdGRvdXQ9c3Rkb3V0LCBzdGRlcnI9c3RkZXJyLCBlbnY9ZW52KQogICAgICAg ICBleGNlcHQgc3VicHJvY2Vzcy5DYWxsZWRQcm9jZXNzRXJyb3IgYXMgZXJyOgogICAgICAgICAg ICAgaWYgc2VsZi52ZXJib3NlOgotICAgICAgICAgICAgICAgIGNtZCA9ICcgJy5qb2luKGVyci5j bWQpCisgICAgICAgICAgICAgICAgY21kID0gJyAnLmpvaW4oc3RyaW5nX3V0aWxzLmRlY29kZShh cmcpIGZvciBhcmcgaW4gZXJyLmNtZCkKICAgICAgICAgICAgICAgICBtZXNzYWdlID0gIiclcycg cmV0dXJuZWQgYSBub24temVybyBleGl0IGNvZGUuIiAlIGNtZAogICAgICAgICAgICAgICAgIGlm IHN0ZGVycjoKICAgICAgICAgICAgICAgICAgICAgd2l0aCBvcGVuKHN0ZGVyci5uYW1lLCAncicp IGFzIHN0ZGVycmY6CkBAIC04NDksMTMgKzg1MCwxNyBAQCBjbGFzcyBXZWJraXRGbGF0cGFrOgog ICAgICAgICBpZiBub3QgYnVpbGRpbmdfZ3N0IGFuZCBhcmdzWzBdICE9ICJzY2NhY2hlIjoKICAg ICAgICAgICAgIGV4dHJhX2ZsYXRwYWtfYXJncy5leHRlbmQoc2VsZi5zZXR1cF9nc3RidWlsZChi dWlsZGluZykpCiAKLSAgICAgICAgZmxhdHBha19lbnYgPSBvcy5lbnZpcm9uCi0gICAgICAgIGZv ciBlbnZ2YXIgaW4gZmxhdHBha19lbnYua2V5cygpOgotICAgICAgICAgICAgaWYgZW52dmFyLnN0 YXJ0c3dpdGgoIkxDXyIpIG9yIGVudnZhci5zdGFydHN3aXRoKCJMQU5HIik6CisgICAgICAgIGZs YXRwYWtfZW52ID0gb3MuZW52aXJvbi5jb3B5KCkKKyAgICAgICAgZm9yIGVudnZhciBpbiBsaXN0 KGZsYXRwYWtfZW52LmtleXMoKSk6CisgICAgICAgICAgICBpZiBlbnZ2YXIuc3RhcnRzd2l0aCgi TENfIikgb3IgZW52dmFyID09ICJMQU5HVUFHRSI6CiAgICAgICAgICAgICAgICAgZGVsIGZsYXRw YWtfZW52W2VudnZhcl0KICAgICAgICAgICAgICAgICBpZiBzZWxmLmZsYXRwYWtfdmVyc2lvbiA+ PSAoMSwgMTAsIDApOgogICAgICAgICAgICAgICAgICAgICBmbGF0cGFrX2NvbW1hbmQuYXBwZW5k KCItLXVuc2V0LWVudj0lcyIgJSBlbnZ2YXIpCiAKKyAgICAgICAgIyBBdm9pZCAnZXJyb3I6IElu dmFsaWQgYnl0ZSBzZXF1ZW5jZSBpbiBjb252ZXJzaW9uIGlucHV0JyBhZnRlciByZW1vdmluZwor ICAgICAgICAjIGFsbCBgTEFOR2AgdmFycy4KKyAgICAgICAgZmxhdHBha19lbnZbIkxBTkciXSA9 ICJlbl9VUy5VVEYtOCIKKwogICAgICAgICBmbGF0cGFrX2NvbW1hbmQgKz0gZXh0cmFfZmxhdHBh a19hcmdzICsgWyctLWNvbW1hbmQ9JXMnICUgYXJnc1swXSwgIm9yZy53ZWJraXQuU2RrIl0gKyBh cmdzWzE6XQogCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL2ZsYXRwYWsvd2Via2l0LWJ3cmFwIGIvVG9v bHMvZmxhdHBhay93ZWJraXQtYndyYXAKaW5kZXggOTU0ZThlYTNjMzA4ZGRkMzUyYzk0MzllZjA0 OTQyZDFkZjIyZmNiZC4uMmVjNzQxYzEyMDBiZDJlNzIzZDZlOGRmYmY4ZTUzZmFjYWRiOGEyYiAx MDA3NTUKLS0tIGEvVG9vbHMvZmxhdHBhay93ZWJraXQtYndyYXAKKysrIGIvVG9vbHMvZmxhdHBh ay93ZWJraXQtYndyYXAKQEAgLTczLDcgKzczLDYgQEAgZGVmIG1haW4oYXJnczogbGlzdCkgLT4g aW50OgogICAgIGZvciBlbnYgaW4gZW52aXJvbi5rZXlzKCk6CiAgICAgICAgIGlmIGVudi5zdGFy dHN3aXRoKCJMQ18iKSBvciBlbnYgPT0gIkxBTkdVQUdFIjoKICAgICAgICAgICAgIGJ3cmFwX2Fy Z3MuZXh0ZW5kKCgiLS11bnNldGVudiIsIGVudikpCi0gICAgYndyYXBfYXJncy5leHRlbmQoKCIt LXNldGVudiIsICJMQU5HIiwgImVuX1VTLlVURi04IikpCiAKICAgICBid3JhcF9hcmdzLmV4dGVu ZCgoIi0tc2V0ZW52IiwgIlBBVEgiLCAiL3Vzci9iaW46L3Vzci9saWIvc2RrL3J1c3Qtc3RhYmxl L2Jpbi8iKSkKIAo=