221056 2021-01-27 12:09:26 -0800 [macOS] Remove reference to deprecated SubmitDiagInfo.domains path 2021-01-28 09:28:37 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham pvollan oldest_to_newest 1723098 0 bfulgham 2021-01-27 12:09:26 -0800 We don't need access to this path, so let's remove it from our sandbox. 1723101 1 bfulgham 2021-01-27 12:11:43 -0800 <rdar://problem/73474697> 1723103 2 418573 bfulgham 2021-01-27 12:12:14 -0800 Created attachment 418573 Patch 1723104 3 418573 pvollan 2021-01-27 12:13:17 -0800 Comment on attachment 418573 Patch R=me. 1723159 4 418573 ap 2021-01-27 14:50:59 -0800 Comment on attachment 418573 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418573&action=review > Source/WebKit/ChangeLog:9 > + macOS does not use SubmitDiagInfo.domains anymore, and even when it did it failed safely. Does this include all supported macOS versions, or only the latest? 1723387 5 bfulgham 2021-01-28 09:24:50 -0800 (In reply to Alexey Proskuryakov from comment #4) > Comment on attachment 418573 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=418573&action=review > > > Source/WebKit/ChangeLog:9 > > + macOS does not use SubmitDiagInfo.domains anymore, and even when it did it failed safely. > > Does this include all supported macOS versions, or only the latest? All supported OS versions. 1723388 6 bfulgham 2021-01-28 09:25:17 -0800 (In reply to Brent Fulgham from comment #5) > (In reply to Alexey Proskuryakov from comment #4) > > Comment on attachment 418573 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=418573&action=review > > > > > Source/WebKit/ChangeLog:9 > > > + macOS does not use SubmitDiagInfo.domains anymore, and even when it did it failed safely. > > > > Does this include all supported macOS versions, or only the latest? > > All supported OS versions. (According to the responsible team using this path). 1723390 7 ews-feeder 2021-01-28 09:28:36 -0800 Committed r272016: <https://trac.webkit.org/changeset/272016> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418573. 418573 2021-01-27 12:12:14 -0800 2021-01-28 09:28:37 -0800 Patch bug-221056-20210127121213.patch text/plain 4599 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxOTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM1NWMyOWM4N2Q4NGQyYjVk YmM3MjU3ODdlM2M0NDYwY2RhYTNjZGMuLmM3NDU0YjgxNTFmMDE4ZGNlOWI5MDIyYmRkODc5ZGY1 OTMyYTZjNGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjEtMDEtMjcgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW21hY09TXSBSZW1vdmUgcmVm ZXJlbmNlIHRvIGRlcHJlY2F0ZWQgU3VibWl0RGlhZ0luZm8uZG9tYWlucyBwYXRoCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjEwNTYKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzczNDc0Njk3PgorICAgICAgICAKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbWFjT1MgZG9lcyBub3QgdXNlIFN1Ym1pdERpYWdJ bmZvLmRvbWFpbnMgYW55bW9yZSwgYW5kIGV2ZW4gd2hlbiBpdCBkaWQgaXQgZmFpbGVkIHNhZmVs eS4KKyAgICAgICAgVGhlcmUncyBubyByZWFzb24gdG8gaGF2ZSB0aGlzIGFjY2VzcyBpbiBhbnkg b2Ygb3VyIHNhbmRib3hlcywgYW5kIHdlIHNob3VsZCByZW1vdmUgaXQuCisKKyAgICAgICAgKiBH UFVQcm9jZXNzL21hYy9jb20uYXBwbGUuV2ViS2l0LkdQVVByb2Nlc3Muc2IuaW46CisgICAgICAg ICogTmV0d29ya1Byb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya1Byb2Nlc3Muc2Iu aW46CisgICAgICAgICogUGx1Z2luUHJvY2Vzcy9tYWMvY29tLmFwcGxlLldlYktpdC5wbHVnaW4t Y29tbW9uLnNiLmluOgorICAgICAgICAqIFdlYkF1dGhuUHJvY2Vzcy9tYWMvY29tLmFwcGxlLldl YktpdC5XZWJBdXRoblByb2Nlc3Muc2IuaW46CisgICAgICAgICogV2ViUHJvY2Vzcy9jb20uYXBw bGUuV2ViUHJvY2Vzcy5zYi5pbjoKKwogMjAyMS0wMS0yNyAgUGVyIEFybmUgIDxwdm9sbGFuQGFw cGxlLmNvbT4KIAogICAgICAgICBbbWFjT1NdIFJlbW92ZSBDRlBCUyBhY2Nlc3MgaW4gdGhlIFdl YkNvbnRlbnQgcHJvY2VzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL21h Yy9jb20uYXBwbGUuV2ViS2l0LkdQVVByb2Nlc3Muc2IuaW4gYi9Tb3VyY2UvV2ViS2l0L0dQVVBy b2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQuR1BVUHJvY2Vzcy5zYi5pbgppbmRleCBlZDY0ZTgy NTdlMDU0MjRjMWE1ZDRkMjc4NDNiZjBjZGQzNmJmYjE2Li5hN2E3ZGM3YTc0OGUwZmRmODIyNWZj NWFmYzViNTFhOTFmYTYwMWZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3Mv bWFjL2NvbS5hcHBsZS5XZWJLaXQuR1BVUHJvY2Vzcy5zYi5pbgorKysgYi9Tb3VyY2UvV2ViS2l0 L0dQVVByb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQuR1BVUHJvY2Vzcy5zYi5pbgpAQCAtNTI1 LDggKzUyNSw2IEBACiAgICAgKHN1YnBhdGggIi9MaWJyYXJ5L1NwZWVjaC9TeW50aGVzaXplcnMi KQogICAgIChyZWdleCAjIl4vcHJpdmF0ZS9ldGMvKGhvc3RzfGdyb3VwfHBhc3N3ZCkkIikKIAot ICAgIChsaXRlcmFsICIvTGlicmFyeS9BcHBsaWNhdGlvbiBTdXBwb3J0L0NyYXNoUmVwb3J0ZXIv U3VibWl0RGlhZ0luZm8uZG9tYWlucyIpCi0KICAgICA7OyBTeXN0ZW0gYW5kIHVzZXIgcHJlZmVy ZW5jZXMKICAgICAoaG9tZS1saXRlcmFsICIvLkNGVXNlclRleHRFbmNvZGluZyIpCiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQu TmV0d29ya1Byb2Nlc3Muc2IuaW4gYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL21hYy9j b20uYXBwbGUuV2ViS2l0Lk5ldHdvcmtQcm9jZXNzLnNiLmluCmluZGV4IDY2NWY3ZjM0YjY0ZTUw ZDlhMDM0ZWVmOTQwZWU1YzRhMzRlNDI0ZjMuLjdmMmEwZGU0ZjViODM4YTJjZjI4MTMxMTM3MDdi MmFiMWM1MjY4NjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvbWFj L2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya1Byb2Nlc3Muc2IuaW4KKysrIGIvU291cmNlL1dlYktp dC9OZXR3b3JrUHJvY2Vzcy9tYWMvY29tLmFwcGxlLldlYktpdC5OZXR3b3JrUHJvY2Vzcy5zYi5p bgpAQCAtMjQ1LDggKzI0NSw2IEBACiAgICAgKHN1YnBhdGggIi9MaWJyYXJ5L0ZyYW1ld29ya3Mi KQogICAgIChzdWJwYXRoICIvTGlicmFyeS9NYW5hZ2VkIFByZWZlcmVuY2VzIikKIAotICAgIChs aXRlcmFsICIvTGlicmFyeS9BcHBsaWNhdGlvbiBTdXBwb3J0L0NyYXNoUmVwb3J0ZXIvU3VibWl0 RGlhZ0luZm8uZG9tYWlucyIpCi0KICAgICA7OyBTeXN0ZW0gYW5kIHVzZXIgcHJlZmVyZW5jZXMK ICAgICAocmVnZXggIyJeL0xpYnJhcnkvTWFuYWdlZCBQcmVmZXJlbmNlcy9bXi9dKy9jb21cLmFw cGxlXC5uZXR3b3JrQ29ubmVjdFwucGxpc3QkIikKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9QbHVnaW5Qcm9jZXNzL21hYy9jb20uYXBwbGUuV2ViS2l0LnBsdWdpbi1jb21tb24uc2IuaW4g Yi9Tb3VyY2UvV2ViS2l0L1BsdWdpblByb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQucGx1Z2lu LWNvbW1vbi5zYi5pbgppbmRleCAxODM1MjZkOTUxYjRjNGQ5ODQzODlmMDNiZTkzYjc2MmQ4NTky ZTI4Li5kMTlhOWYyNWM5ZGNkZmRjNmMyZGU5NTk5ZWUxMDIzN2JmMTJmNDZjIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L1BsdWdpblByb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQucGx1Z2lu LWNvbW1vbi5zYi5pbgorKysgYi9Tb3VyY2UvV2ViS2l0L1BsdWdpblByb2Nlc3MvbWFjL2NvbS5h cHBsZS5XZWJLaXQucGx1Z2luLWNvbW1vbi5zYi5pbgpAQCAtMzM0LDggKzMzNCw2IEBACiAgICAg KHN1YnBhdGggIi9MaWJyYXJ5L1ZpZGVvL1BsdWctSW5zIikKICAgICAoaG9tZS1saWJyYXJ5LXN1 YnBhdGggIi9DYWNoZXMvUXVpY2tUaW1lIikKIAotICAgIChsaXRlcmFsICIvTGlicmFyeS9BcHBs aWNhdGlvbiBTdXBwb3J0L0NyYXNoUmVwb3J0ZXIvU3VibWl0RGlhZ0luZm8uZG9tYWlucyIpCi0K ICAgICAoaG9tZS1saWJyYXJ5LWxpdGVyYWwgIi9BcHBsaWNhdGlvbiBTdXBwb3J0L1N5bmNTZXJ2 aWNlcy9Mb2NhbC9DbGllbnRzV2l0aENoYW5nZXMvY29tLmFwcGxlLktleWNoYWluIikKIAogICAg IChzdWJwYXRoICIvTGlicmFyeS9Db2xvclN5bmMiKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9XZWJBdXRoblByb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQuV2ViQXV0aG5Qcm9jZXNzLnNi LmluIGIvU291cmNlL1dlYktpdC9XZWJBdXRoblByb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQu V2ViQXV0aG5Qcm9jZXNzLnNiLmluCmluZGV4IGIyZWRlZmUyYjRkYTY1MzQzMWIwZDEwNjBlOGZh NDEwMzBmN2NjYjkuLmIxNDM2NzRhNDFmYzI1NTQ1MTI5ZTM0ZGJhOWU1YjY0YzY5NWU5OTYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViQXV0aG5Qcm9jZXNzL21hYy9jb20uYXBwbGUuV2Vi S2l0LldlYkF1dGhuUHJvY2Vzcy5zYi5pbgorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYkF1dGhuUHJv Y2Vzcy9tYWMvY29tLmFwcGxlLldlYktpdC5XZWJBdXRoblByb2Nlc3Muc2IuaW4KQEAgLTIxMiw4 ICsyMTIsNiBAQAogICAgIChzdWJwYXRoICIvTGlicmFyeS9TcGVlY2gvU3ludGhlc2l6ZXJzIikK ICAgICAocmVnZXggIyJeL3ByaXZhdGUvZXRjLyhob3N0c3xncm91cHxwYXNzd2QpJCIpCiAKLSAg ICAobGl0ZXJhbCAiL0xpYnJhcnkvQXBwbGljYXRpb24gU3VwcG9ydC9DcmFzaFJlcG9ydGVyL1N1 Ym1pdERpYWdJbmZvLmRvbWFpbnMiKQotCiAgICAgOzsgU3lzdGVtIGFuZCB1c2VyIHByZWZlcmVu Y2VzCiAgICAgKGhvbWUtbGl0ZXJhbCAiLy5DRlVzZXJUZXh0RW5jb2RpbmciKQogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4g Yi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4KaW5k ZXggNjkyN2U3OTNiMjYzZjY3NjU3NDdiYTY1M2U0YjI2ZWU1N2Y1ZWIwMC4uNGFkMThhMjg4MTkw MDNjYWM2ZDE5NjIyZGViMjdkNDc5NTg4MzJhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9X ZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluCisrKyBiL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgpAQCAtNzk5LDggKzc5OSw2IEBA CiAgICAgKHN1YnBhdGggIi9MaWJyYXJ5L1NwZWVjaC9TeW50aGVzaXplcnMiKQogICAgIChyZWdl eCAjIl4vcHJpdmF0ZS9ldGMvKGhvc3RzfGdyb3VwfHBhc3N3ZCkkIikKIAotICAgIChsaXRlcmFs ICIvTGlicmFyeS9BcHBsaWNhdGlvbiBTdXBwb3J0L0NyYXNoUmVwb3J0ZXIvU3VibWl0RGlhZ0lu Zm8uZG9tYWlucyIpCi0KICAgICA7OyBTeXN0ZW0gYW5kIHVzZXIgcHJlZmVyZW5jZXMKICAgICAo aG9tZS1saXRlcmFsICIvLkNGVXNlclRleHRFbmNvZGluZyIpCiAK