221053 2021-01-27 11:44:37 -0800 [iOS] Conditionalize debugging support on internal builds 2021-01-27 12:53:29 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham pvollan webkit-bug-importer oldest_to_newest 1723087 0 bfulgham 2021-01-27 11:44:37 -0800 We should restrict use of the (debugging-support) rules in our iOS sandboxes to internal OS, since those features are not accessible to production uses. Since these restrictions don't impact end user debugging use cases, we'll also rename the rules to "internal-debugging-support". <rdar://problem/73520300> 1723089 1 418570 bfulgham 2021-01-27 11:48:31 -0800 Created attachment 418570 Patch 1723092 2 418570 pvollan 2021-01-27 11:55:31 -0800 Comment on attachment 418570 Patch R=me. 1723115 3 ews-feeder 2021-01-27 12:53:28 -0800 Committed r271976: <https://trac.webkit.org/changeset/271976> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418570. 418570 2021-01-27 11:48:31 -0800 2021-01-27 12:53:28 -0800 Patch bug-221053-20210127114830.patch text/plain 4890 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxOTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM1NWMyOWM4N2Q4NGQyYjVk YmM3MjU3ODdlM2M0NDYwY2RhYTNjZGMuLmQ2NDg4MjBiODBiNjUzNWM3OWNmNDgwMzJiNDczN2Zm ZjE2ZGUzMjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjEtMDEtMjcgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gQ29uZGl0aW9uYWxp emUgZGVidWdnaW5nIHN1cHBvcnQgb24gaW50ZXJuYWwgYnVpbGRzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjEwNTMKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzczNTIwMzAwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFdlIHNob3VsZCByZXN0cmljdCB1c2Ugb2YgdGhlIChkZWJ1Z2dpbmctc3VwcG9y dCkgcnVsZXMgaW4gb3VyIGlPUyBzYW5kYm94ZXMgdG8gaW50ZXJuYWwgT1MsIHNpbmNlIHRob3Nl CisgICAgICAgIGZlYXR1cmVzIGFyZSBub3QgYWNjZXNzaWJsZSB0byBwcm9kdWN0aW9uIHVzZXJz LgorCisgICAgICAgIFNpbmNlIHRoZXNlIHJlc3RyaWN0aW9ucyBkb24ndCBpbXBhY3QgZW5kIHVz ZXIgZGVidWdnaW5nIHVzZSBjYXNlcywgd2UnbGwgYWxzbyByZW5hbWUgdGhlIHJ1bGVzIHRvCisg ICAgICAgICJpbnRlcm5hbC1kZWJ1Z2dpbmctc3VwcG9ydCIuCisKKyAgICAgICAgKiBSZXNvdXJj ZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LkdQVS5zYjoKKyAgICAgICAg KiBSZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0Lk5ldHdvcmtp bmcuc2I6CisgICAgICAgICogUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxl LldlYktpdC5XZWJBdXRobi5zYjoKKyAgICAgICAgKiBSZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVz L2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2I6CisKIDIwMjEtMDEtMjcgIFBlciBB cm5lICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW21hY09TXSBSZW1vdmUgQ0ZQQlMg YWNjZXNzIGluIHRoZSBXZWJDb250ZW50IHByb2Nlc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5HUFUuc2Ig Yi9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5X ZWJLaXQuR1BVLnNiCmluZGV4IGY4Mjk1ZDEzYTY3YTVmMmE1N2E2ZDcxYWFmNjQ5OWJhMTkxY2E2 MmYuLjg2MGVjYTc3YjViMDBiNzg2MTFlOWZkZjRjNzM5MmNmMTU5OTFlMmYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldl YktpdC5HUFUuc2IKKysrIGIvU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVz L2lvcy9jb20uYXBwbGUuV2ViS2l0LkdQVS5zYgpAQCAtMjg3LDcgKzI4Nyw3IEBACiAgICAgKQog KQogCi0oZGVmaW5lLW9uY2UgKGRlYnVnZ2luZy1zdXBwb3J0KQorKGRlZmluZS1vbmNlIChpbnRl cm5hbC1kZWJ1Z2dpbmctc3VwcG9ydCkKICAgICAgICAgKGFsbG93IGZpbGUtcmVhZCogZmlsZS1t YXAtZXhlY3V0YWJsZQogICAgICAgICAgICAgICAgKHN1YnBhdGggIi9EZXZlbG9wZXIiKSkKIApA QCAtNTQ2LDcgKzU0Niw5IEBACiAgICAgICAgICAgICAgICAgICAoZnJvbnQtdXNlci1ob21lLXBy ZWZpeCAiL0xpYnJhcnkvQ2FjaGVzLyIpKSkpCiApCiAKLShkZWJ1Z2dpbmctc3VwcG9ydCkKKyh3 aXRoLWZpbHRlciAoc3lzdGVtLWF0dHJpYnV0ZSBhcHBsZS1pbnRlcm5hbCkKKyAgICAoaW50ZXJu YWwtZGVidWdnaW5nLXN1cHBvcnQpCispCiAKIChhbGxvdyBmaWxlLXJlYWQqCiAgICAgcmVxdWly ZWQtZXRjLWZpbGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94 UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya2luZy5zYiBiL1NvdXJjZS9XZWJL aXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5OZXR3b3Jr aW5nLnNiCmluZGV4IDAwNzVmMWI4Zjc0YmQzNDUzOTM0NThkOTU0MWUwOTZmYzdkOTY1YjUuLmFm ZWVmOWE2NDE3MjAwODdkODJiN2IxNzk0YjVkYjNmN2RjMGM3NDAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5O ZXR3b3JraW5nLnNiCisrKyBiL1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxl cy9pb3MvY29tLmFwcGxlLldlYktpdC5OZXR3b3JraW5nLnNiCkBAIC0yMzgsNyArMjM4LDcgQEAK ICAgICAgICAgKGlva2l0LXVzZXItY2xpZW50LWNsYXNzICJBcHBsZUtleVN0b3JlVXNlckNsaWVu dCIpIDs7IE5lZWRlZCBieSBOU1VSTENhY2hlCiApKQogCi0oZGVmaW5lLW9uY2UgKGRlYnVnZ2lu Zy1zdXBwb3J0KQorKGRlZmluZS1vbmNlIChpbnRlcm5hbC1kZWJ1Z2dpbmctc3VwcG9ydCkKICAg ICAgICAgOzsgPHJkYXI6Ly9wcm9ibGVtLzgzNzk3MDY+CiAgICAgICAgIDs7IDxyZGFyOi8vcHJv YmxlbS8xMjg2ODEwMT4KICAgICAgICAgOzsgPHJkYXI6Ly9wcm9ibGVtLzIyNzY2ODg3PgpAQCAt NDAwLDcgKzQwMCw5IEBACiAgICAgICAgICAgICAgICAoc3lzY3RsLW5hbWUtcHJlZml4ICJrZXJu LnByb2MuIikKICAgICAgICAgICAgICAgIChzeXNjdGwtbmFtZS1wcmVmaXggImtlcm4ucHJvY2Fy Z3MyLiIpKSkpCiAKLShkZWJ1Z2dpbmctc3VwcG9ydCkKKyh3aXRoLWZpbHRlciAoc3lzdGVtLWF0 dHJpYnV0ZSBhcHBsZS1pbnRlcm5hbCkKKyAgICAoaW50ZXJuYWwtZGVidWdnaW5nLXN1cHBvcnQp CispCiAKIChhbGxvdyBmaWxlLXJlYWQqCiAgICAgcmVxdWlyZWQtZXRjLWZpbGVzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBs ZS5XZWJLaXQuV2ViQXV0aG4uc2IgYi9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJv ZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQXV0aG4uc2IKaW5kZXggODUyMjdlM2Q2ZWQ0 YTJkNGYzNjAxOTk0NjI2NTg1OWJmOGI1NjFjYy4uYjgzYmI5M2Q1NDQyNTJjYmI4NjIzY2JiNzhj MDk2ZjIwMmFlYjRiNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJv eFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkF1dGhuLnNiCisrKyBiL1NvdXJjZS9X ZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJB dXRobi5zYgpAQCAtOTYsNyArOTYsNyBAQAogICAgIChhbGxvdyBmaWxlLXJlYWQqCiAgICAgICAg ICAgIChob21lLWxpdGVyYWwgIi9MaWJyYXJ5L0NhY2hlcy9jb20uYXBwbGUuaXR1bmVzc3RvcmVk L3VybC1yZXNvbHV0aW9uLnBsaXN0IikpKQogCi0oZGVmaW5lLW9uY2UgKGRlYnVnZ2luZy1zdXBw b3J0KQorKGRlZmluZS1vbmNlIChpbnRlcm5hbC1kZWJ1Z2dpbmctc3VwcG9ydCkKICAgICAgICAg KGFsbG93IGZpbGUtcmVhZCogZmlsZS1tYXAtZXhlY3V0YWJsZQogICAgICAgICAgICAgICAgKHN1 YnBhdGggIi9EZXZlbG9wZXIiKSkKIApAQCAtMzI2LDcgKzMyNiw5IEBACiAgICAgICAgICAgICAg ICAgICAoZnJvbnQtdXNlci1ob21lLXByZWZpeCAiL0xpYnJhcnkvQ2FjaGVzLyIpKSkpCiApCiAK LShkZWJ1Z2dpbmctc3VwcG9ydCkKKyh3aXRoLWZpbHRlciAoc3lzdGVtLWF0dHJpYnV0ZSBhcHBs ZS1pbnRlcm5hbCkKKyAgICAoaW50ZXJuYWwtZGVidWdnaW5nLXN1cHBvcnQpCispCiAKIChhbGxv dyBmaWxlLXJlYWQqCiAgICAgcmVxdWlyZWQtZXRjLWZpbGVzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2Vi Q29udGVudC5zYiBiL1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3Mv Y29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiCmluZGV4IDMwM2IyYTdkYTZlZDI1MGUxMmRm MDM5ZjdhZDRmM2I1M2JkNDU2YTAuLjRjYzlhYmJhMDIxMDIwMjE5NDJhNTMyOWI0NTg1NDlmNTkw NGZkZDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxl cy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiCisrKyBiL1NvdXJjZS9XZWJLaXQv UmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50 LnNiCkBAIC0yODcsNyArMjg3LDcgQEAKICAgICApCiApCiAKLShkZWZpbmUtb25jZSAoZGVidWdn aW5nLXN1cHBvcnQpCisoZGVmaW5lLW9uY2UgKGludGVybmFsLWRlYnVnZ2luZy1zdXBwb3J0KQog ICAgICAgICAoYWxsb3cgZmlsZS1yZWFkKiBmaWxlLW1hcC1leGVjdXRhYmxlCiAgICAgICAgICAg ICAgICAoc3VicGF0aCAiL0RldmVsb3BlciIpKQogCkBAIC01ODksNyArNTg5LDkgQEAKICAgICAg ICAgICAgICAgICAgIChmcm9udC11c2VyLWhvbWUtcHJlZml4ICIvTGlicmFyeS9DYWNoZXMvIikp KSkKICkKIAotKGRlYnVnZ2luZy1zdXBwb3J0KQorKHdpdGgtZmlsdGVyIChzeXN0ZW0tYXR0cmli dXRlIGFwcGxlLWludGVybmFsKQorICAgIChpbnRlcm5hbC1kZWJ1Z2dpbmctc3VwcG9ydCkKKykK IAogKGFsbG93IGZpbGUtcmVhZCoKICAgICByZXF1aXJlZC1ldGMtZmlsZXMK