221047 2021-01-27 09:53:28 -0800 [GTK] return-type-c-linkage warnings 2021-01-29 03:01:33 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand pnormand berto bugs-noreply cgarcia ews-watchlist gustavo oldest_to_newest 1723030 0 pnormand 2021-01-27 09:53:28 -0800 When building with clang: In file included from ../../Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:37: ../../Source/WebKit/NetworkProcess/soup/WebKitDirectoryInputStream.h:57:23: warning: 'webkitDirectoryInputStreamNew' has C-linkage specified, but returns user-defined type 'GRefPtr<GInputStream>' (aka 'GRefPtr<_GInputStream>') which is incompatible with C [-Wreturn-type-c-linkage] GRefPtr<GInputStream> webkitDirectoryInputStreamNew(GRefPtr<GFileEnumerator>&&, CString&& uri); ^ 1 warning generated. [6362/6762] Building CXX object Source/WebKit/CMakeFiles/WebKit.dir/__/__/DerivedSources/WebKit/unified-sources/UnifiedSource-72468c22-10.cpp.o In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-72468c22-10.cpp:1: In file included from ../../Source/WebKit/NetworkProcess/soup/WebKitDirectoryInputStream.cpp:27: ../../Source/WebKit/NetworkProcess/soup/WebKitDirectoryInputStream.h:57:23: warning: 'webkitDirectoryInputStreamNew' has C-linkage specified, but returns incomplete type 'GRefPtr<GInputStream>' (aka 'GRefPtr<_GInputStream>') which could be incompatible with C [-Wreturn-type-c-linkage] GRefPtr<GInputStream> webkitDirectoryInputStreamNew(GRefPtr<GFileEnumerator>&&, CString&& uri); ^ 1723657 1 cgarcia 2021-01-29 01:23:39 -0800 I guess it's because of the G_BEGIN_DECLS. This is a private object that is always going to be used from C++ code, so I guess we can just remove the G_BEGIN_DECLS/G_END_DECLS. Could you try remove those to confirm that fixes the warning? 1723661 2 pnormand 2021-01-29 01:59:20 -0800 That's the fix indeed. Good guess! 1723663 3 pnormand 2021-01-29 02:01:59 -0800 (In reply to Philippe Normand from comment #2) > That's the fix indeed. Good guess! Hum, sorry false alarm. I still see the warning. I'll check it further. 1723667 4 pnormand 2021-01-29 02:20:27 -0800 Misread the output, the same issue appears in WebKitDirectoryInputStream.h, removing G_*_DECLS in both files is the way to go. Sending patch 1723668 5 cgarcia 2021-01-29 02:21:16 -0800 (In reply to Philippe Normand from comment #3) > (In reply to Philippe Normand from comment #2) > > That's the fix indeed. Good guess! > > Hum, sorry false alarm. I still see the warning. I'll check it further. Maybe the one you are seeing now is from WebKitFormDataInputStream.h? 1723669 6 418713 pnormand 2021-01-29 02:23:09 -0800 Created attachment 418713 Patch 1723672 7 418713 cgarcia 2021-01-29 02:31:14 -0800 Comment on attachment 418713 Patch Thanks! 1723677 8 ews-feeder 2021-01-29 03:01:31 -0800 Committed r272057: <https://trac.webkit.org/changeset/272057> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418713. 418713 2021-01-29 02:23:09 -0800 2021-01-29 03:01:32 -0800 Patch bug-221047-20210129022308.patch text/plain 3563 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyMDUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWY5MTE2YmYxNjY0OGIy N2I5ZTRiYjIwMTAxMGNmZGFhYzU5M2JiOS4uOTZlZGU5YjE0MmYzYzZhY2M2YTBkYWYzYjNiZWQx MjZiMmMwODUzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTAxLTI5ICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSByZXR1 cm4tdHlwZS1jLWxpbmthZ2Ugd2FybmluZ3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIyMTA0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFJlbW92ZSBleHRlcm4gIkMiIGJyYWNlcywgdW4tbmVlZGVkIGZv ciBwcml2YXRlIEMrKyBvYmplY3RzLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3Vw L1dlYktpdEZvcm1EYXRhSW5wdXRTdHJlYW0uaDoKKwogMjAyMS0wMS0yOSAgWW91ZW5uIEZhYmxl dCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgVXNlIFdlYlJUQyBHUFUgcHJvY2VzcyBm bGFnIGZvciBNZWRpYVJlY29yZGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxv ZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU1NDFjOGQzOTk0ZWU2NjJjNWU3OTVi YTQ2Mjg3ODU5ODk5Yjk4YWIuLjhkNTk2NjQxMjI4ZWVhMzQ3MzBhNThkMmI2MTE3NTAzMjk1MDJl ODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEtMDEtMjkgIFBoaWxpcHBlIE5vcm1h bmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIHJldHVybi10eXBlLWMt bGlua2FnZSB3YXJuaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjIxMDQ3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUmVtb3ZlIGV4dGVybiAiQyIgYnJhY2VzLCB1bi1uZWVkZWQgZm9yIHByaXZhdGUg QysrIG9iamVjdHMuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9zb3VwL1dlYktpdERpcmVj dG9yeUlucHV0U3RyZWFtLmg6CisKIDIwMjEtMDEtMjkgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5A YXBwbGUuY29tPgogCiAgICAgICAgIFVzZSBXZWJSVEMgR1BVIHByb2Nlc3MgZmxhZyBmb3IgTWVk aWFSZWNvcmRlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9z b3VwL1dlYktpdEZvcm1EYXRhSW5wdXRTdHJlYW0uaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvc291cC9XZWJLaXRGb3JtRGF0YUlucHV0U3RyZWFtLmgKaW5kZXggOWZhZWMzZWZj OTI3YzRhNDE3ZjcyNGFiZTA5NjEzY2FjZTA5YmMyNy4uODlmMmE5NGE4N2QzNWUxMmUwZmUyYmEx N2U3MmUzOWRkYmFlZDJiZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9zb3VwL1dlYktpdEZvcm1EYXRhSW5wdXRTdHJlYW0uaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvV2ViS2l0Rm9ybURhdGFJbnB1dFN0cmVhbS5oCkBAIC0z MCw4ICszMCw2IEBACiAjaW5jbHVkZSA8d3RmL0ZvcndhcmQuaD4KICNpbmNsdWRlIDx3dGYvZ2xp Yi9HUmVmUHRyLmg+CiAKLUdfQkVHSU5fREVDTFMKLQogI2RlZmluZSBXRUJLSVRfVFlQRV9GT1JN X0RBVEFfSU5QVVRfU1RSRUFNICAgICAgICAgICAgKHdlYmtpdF9mb3JtX2RhdGFfaW5wdXRfc3Ry ZWFtX2dldF90eXBlICgpKQogI2RlZmluZSBXRUJLSVRfRk9STV9EQVRBX0lOUFVUX1NUUkVBTShv YmopICAgICAgICAgICAgKEdfVFlQRV9DSEVDS19JTlNUQU5DRV9DQVNUICgob2JqKSwgV0VCS0lU X1RZUEVfRk9STV9EQVRBX0lOUFVUX1NUUkVBTSwgV2ViS2l0Rm9ybURhdGFJbnB1dFN0cmVhbSkp CiAjZGVmaW5lIFdFQktJVF9JU19GT1JNX0RBVEFfSU5QVVRfU1RSRUFNKG9iaikgICAgICAgICAo R19UWVBFX0NIRUNLX0lOU1RBTkNFX1RZUEUgKChvYmopLCBXRUJLSVRfVFlQRV9GT1JNX0RBVEFf SU5QVVRfU1RSRUFNKSkKQEAgLTU3LDYgKzU1LDMgQEAgR1R5cGUgd2Via2l0X2Zvcm1fZGF0YV9p bnB1dF9zdHJlYW1fZ2V0X3R5cGUodm9pZCk7CiAKIEdSZWZQdHI8R0lucHV0U3RyZWFtPiB3ZWJr aXRGb3JtRGF0YUlucHV0U3RyZWFtTmV3KFJlZjxXZWJDb3JlOjpGb3JtRGF0YT4mJik7CiBHQnl0 ZXMqIHdlYmtpdEZvcm1EYXRhSW5wdXRTdHJlYW1SZWFkQWxsKFdlYktpdEZvcm1EYXRhSW5wdXRT dHJlYW0qKTsKLQotR19FTkRfREVDTFMKLQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3 b3JrUHJvY2Vzcy9zb3VwL1dlYktpdERpcmVjdG9yeUlucHV0U3RyZWFtLmggYi9Tb3VyY2UvV2Vi S2l0L05ldHdvcmtQcm9jZXNzL3NvdXAvV2ViS2l0RGlyZWN0b3J5SW5wdXRTdHJlYW0uaAppbmRl eCBiMzNmNmY5Yzc5NTc3ZjcxZTJiODJlMzIzZTc2YzQwYzAyNDU3YTJhLi43MTIxY2RjNzdjZDc1 ZTU0NzMwYmUwYTgwYjlmODVlNDEzYWYwMzYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05l dHdvcmtQcm9jZXNzL3NvdXAvV2ViS2l0RGlyZWN0b3J5SW5wdXRTdHJlYW0uaAorKysgYi9Tb3Vy Y2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL3NvdXAvV2ViS2l0RGlyZWN0b3J5SW5wdXRTdHJlYW0u aApAQCAtMjksOCArMjksNiBAQAogI2luY2x1ZGUgPHd0Zi9nbGliL0dSZWZQdHIuaD4KICNpbmNs dWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CiAKLUdfQkVHSU5fREVDTFMKLQogI2RlZmluZSBXRUJL SVRfVFlQRV9ESVJFQ1RPUllfSU5QVVRfU1RSRUFNICAgICAgICAgICAgKHdlYmtpdF9kaXJlY3Rv cnlfaW5wdXRfc3RyZWFtX2dldF90eXBlICgpKQogI2RlZmluZSBXRUJLSVRfRElSRUNUT1JZX0lO UFVUX1NUUkVBTShvYmopICAgICAgICAgICAgKEdfVFlQRV9DSEVDS19JTlNUQU5DRV9DQVNUICgo b2JqKSwgV0VCS0lUX1RZUEVfRElSRUNUT1JZX0lOUFVUX1NUUkVBTSwgV2ViS2l0RGlyZWN0b3J5 SW5wdXRTdHJlYW0pKQogI2RlZmluZSBXRUJLSVRfSVNfRElSRUNUT1JZX0lOUFVUX1NUUkVBTShv YmopICAgICAgICAgKEdfVFlQRV9DSEVDS19JTlNUQU5DRV9UWVBFICgob2JqKSwgV0VCS0lUX1RZ UEVfRElSRUNUT1JZX0lOUFVUX1NUUkVBTSkpCkBAIC01NSw2ICs1MywzIEBAIHN0cnVjdCBfV2Vi S2l0RGlyZWN0b3J5SW5wdXRTdHJlYW1DbGFzcyB7CiBHVHlwZSB3ZWJraXRfZGlyZWN0b3J5X2lu cHV0X3N0cmVhbV9nZXRfdHlwZSh2b2lkKTsKIAogR1JlZlB0cjxHSW5wdXRTdHJlYW0+IHdlYmtp dERpcmVjdG9yeUlucHV0U3RyZWFtTmV3KEdSZWZQdHI8R0ZpbGVFbnVtZXJhdG9yPiYmLCBDU3Ry aW5nJiYgdXJpKTsKLQotR19FTkRfREVDTFMKLQo=