221045 2021-01-27 08:57:20 -0800 [macOS] WebContent sandbox regex incorrect 2021-01-27 10:07:23 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham webkit-bug-importer oldest_to_newest 1723004 0 pvollan 2021-01-27 08:57:20 -0800 When the regex is intended to match the character '.', the pattern '\.' should be used. 1723005 1 pvollan 2021-01-27 08:57:43 -0800 <rdar://problem/73473985> 1723006 2 418551 pvollan 2021-01-27 08:58:53 -0800 Created attachment 418551 Patch 1723028 3 418551 bfulgham 2021-01-27 09:47:26 -0800 Comment on attachment 418551 Patch r=me. I'm embarrassed because I think I introduced those years ago. We might also consider switching away from regex, as the Sandbox team told us there are performance costs to using them. 1723039 4 pvollan 2021-01-27 10:03:46 -0800 (In reply to Brent Fulgham from comment #3) > Comment on attachment 418551 [details] > Patch > > r=me. I'm embarrassed because I think I introduced those years ago. We might > also consider switching away from regex, as the Sandbox team told us there > are performance costs to using them. These are easily mixed up in regex :) Yes, we should also look into switching away from regex. Thanks for reviewing! 1723046 5 ews-feeder 2021-01-27 10:07:22 -0800 Committed r271963: <https://trac.webkit.org/changeset/271963> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418551. 418551 2021-01-27 08:58:53 -0800 2021-01-27 10:07:23 -0800 Patch bug-221045-20210127085852.patch text/plain 1951 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNzE5NTQpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDIxLTAxLTI3ICBQZXIgQXJuZSAg PHB2b2xsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFttYWNPU10gV2ViQ29udGVudCBzYW5kYm94 IHJlZ2V4IGluY29ycmVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjIxMDQ1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MzQ3Mzk4NT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHRoZSByZWdl eCBpcyBpbnRlbmRlZCB0byBtYXRjaCB0aGUgY2hhcmFjdGVyICcuJywgdGhlIHBhdHRlcm4gJ1wu JyBzaG91bGQgYmUgdXNlZC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvY29tLmFwcGxlLldlYlBy b2Nlc3Muc2IuaW46CisKIDIwMjEtMDEtMjcgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3 ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJldmVydGluZyByMjcxOTQwLgpJbmRl eDogU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vz cy5zYi5pbgkocmV2aXNpb24gMjcxOTUwKQorKysgU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2Nv bS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluCSh3b3JraW5nIGNvcHkpCkBAIC00NDAsMTMgKzQ0MCwx MyBAQAogICAgICAgICAia2Vybi50Y3NtX2VuYWJsZSIKICAgICAgICAgImtlcm4udGNzbV9hdmFp bGFibGUiCiAgICAgICAgICJ2bS5mb290cHJpbnRfc3VzcGVuZCIpCi0gICAgKHN5c2N0bC1uYW1l LXJlZ2V4ICMiXmh3LihhY3RpdmV8YXZhaWwpY3B1IikKLSAgICAoc3lzY3RsLW5hbWUtcmVnZXgg IyJeaHcuKGJ1c2ZyZXF1ZW5jeXxjYWNoZWxpbmVzaXplfGNwdWZyZXF1ZW5jeSh8X21heCl8cGFn ZXNpemV8dGJmcmVxdWVuY3kpKHxfY29tcGF0KSIpCi0gICAgKHN5c2N0bC1uYW1lLXJlZ2V4ICMi Xmh3LmwuK2NhY2hlc2l6ZSIpCi0gICAgKHN5c2N0bC1uYW1lLXJlZ2V4ICMiXmh3Lihsb2dpY2Fs fHBoeXNpY2FsKWNwdV9tYXgiKQotICAgIChzeXNjdGwtbmFtZS1yZWdleCAjIl5ody5vcHRpb25h bFwuIikKLSAgICAoc3lzY3RsLW5hbWUtcmVnZXggIyJea2Vybi5vcyhyZWxlYXNlfHR5cGV8dmFy aWFudF9zdGF0dXN8dmVyc2lvbikiKQotICAgIChzeXNjdGwtbmFtZS1yZWdleCAjIl5uZXQucm91 dGV0YWJsZSIpCisgICAgKHN5c2N0bC1uYW1lLXJlZ2V4ICMiXmh3XC4oYWN0aXZlfGF2YWlsKWNw dSIpCisgICAgKHN5c2N0bC1uYW1lLXJlZ2V4ICMiXmh3XC4oYnVzZnJlcXVlbmN5fGNhY2hlbGlu ZXNpemV8Y3B1ZnJlcXVlbmN5KHxfbWF4KXxwYWdlc2l6ZXx0YmZyZXF1ZW5jeSkofF9jb21wYXQp IikKKyAgICAoc3lzY3RsLW5hbWUtcmVnZXggIyJeaHdcLmwuK2NhY2hlc2l6ZSIpCisgICAgKHN5 c2N0bC1uYW1lLXJlZ2V4ICMiXmh3XC4obG9naWNhbHxwaHlzaWNhbCljcHVfbWF4IikKKyAgICAo c3lzY3RsLW5hbWUtcmVnZXggIyJeaHdcLm9wdGlvbmFsXC4iKQorICAgIChzeXNjdGwtbmFtZS1y ZWdleCAjIl5rZXJuXC5vcyhyZWxlYXNlfHR5cGV8dmFyaWFudF9zdGF0dXN8dmVyc2lvbikiKQor ICAgIChzeXNjdGwtbmFtZS1yZWdleCAjIl5uZXRcLnJvdXRldGFibGUiKQogKQogCiAoYWxsb3cg c3lzY3RsLXdyaXRlCg==