22103 2008-11-06 09:40:47 -0800 REGRESSION (r37126-r37300): Changing fonts in preferences does not immediately update WebViews 2008-11-10 09:06:47 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED InRadar, Regression P1 Major --- 1 mitz darin aroben oldest_to_newest 97822 0 mitz 2008-11-06 09:40:47 -0800 Changes to the standard font family and size are not reflected in all open WebViews until style recalc is forced. To reproduce: open Safari Preferences, go to Appearance, and change the standard font size. Notice how the font size in open windows does not change until you reorder a window to the front. 97823 1 mitz 2008-11-06 09:41:06 -0800 <rdar://problem/6349376> 98113 2 darin 2008-11-09 16:32:42 -0800 Hyatt somehow broke this when he changed FrameView::invalidateRect to call Chrome::repaint which calls ChromeClient::repaint, which does nothing at all when _usesDocumentViews is true! I'm not sure which part of that is wrong. Frame::setNeedsReapplyStyles calls FrameView::invalidate which calls the set of functions above. 98148 3 25015 darin 2008-11-10 07:22:22 -0800 Created attachment 25015 patch 98162 4 25015 aroben 2008-11-10 08:26:33 -0800 Comment on attachment 25015 patch r=me 98163 5 aroben 2008-11-10 08:27:04 -0800 I wonder if we can use LayoutTestController's new ability to modify preferences to make a regression test for this? 98166 6 darin 2008-11-10 09:01:47 -0800 (In reply to comment #5) > I wonder if we can use LayoutTestController's new ability to modify preferences > to make a regression test for this? Not in any obvious way. The symptom goes away when you do any layout or repainting, and I don't think DRT has any ability to test that sort of problem. 98168 7 darin 2008-11-10 09:06:47 -0800 http://trac.webkit.org/projects/webkit/changeset/38264 25015 2008-11-10 07:22:22 -0800 2008-11-10 08:26:33 -0800 patch StyleChangePatch.txt text/plain 5357 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzODI1OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMzYgQEAKKzIwMDgtMTEtMTAgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4 IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjEwMworICAgICAgICAg IENoYW5naW5nIGZvbnRzIGluIHByZWZlcmVuY2VzIGRvZXMgbm90IGltbWVkaWF0ZWx5IHVwZGF0 ZSBXZWJWaWV3cworCisgICAgICAgIFRoaXMgYnJva2Ugd2hlbiB0aGUgbWVhbmluZyBvZiBGcmFt ZVZpZXc6OmludmFsaWRhdGUgY2hhbmdlZC4KKyAgICAgICAgSSBjaGFuZ2VkIHNldE5lZWRzUmVh cHBseVN0eWxlcyB0byBubyBsb25nZXIgZGVwZW5kIG9uIGludmFsaWRhdGUuCisKKyAgICAgICAg KiBkb20vRG9jdW1lbnQuY3BwOiAoV2ViQ29yZTo6RG9jdW1lbnQ6OnNob3VsZFNjaGVkdWxlTGF5 b3V0KToKKyAgICAgICAgUmVtb3ZlZCB0aGUgcGFydCBvZiB0aGlzIGZ1bmN0aW9uIHRoYXQgZHVw bGljYXRlZCB3aGF0J3MgYWxyZWFkeSBpbgorICAgICAgICBGcmFtZVZpZXc6Om5lZWRzTGF5b3V0 LCBzaW5jZSB0aGUgY29weSBoZXJlIGxlZnQgb3V0IGEgZmV3IGtleSB0aGluZ3MuCisgICAgICAg IEZvciBleGFtcGxlLCBpdCBkaWRuJ3QgaGFuZGxlIHRoZSBmYWN0IHRoYXQgIm5lZWRzIHJlYXBw bHkgc3R5bGVzIgorICAgICAgICBjb3VudHMgYXMgbmVlZGluZyBsYXlvdXQuCisKKyAgICAgICAg KiBwYWdlL0ZyYW1lLmNwcDogKFdlYkNvcmU6OkZyYW1lOjpzZXROZWVkc1JlYXBwbHlTdHlsZXMp OiBUaGlzIGNhbGxlZAorICAgICAgICBGcmFtZVZpZXc6OmludmFsaWRhdGUgYmVmb3JlLiBUaGVy ZSB3ZXJlIHR3byB0aGluZ3Mgd3Jvbmcgd2l0aCB0aGF0LgorICAgICAgICAxKSBJdCByZXF1ZXN0 ZWQgdGhhdCB0aGUgZW50aXJlIHZpZXcgcmVwYWludCBldmVuIGlmIHRoZSBzdHlsZSBjaGFuZ2UK KyAgICAgICAgZGlkbid0IG5lY2Vzc2l0YXRlIHRoYXQuIDIpIEZyYW1lVmlldzo6aW52YWxpZGF0 ZSBubyBsb25nZXIgY2F1c2VzIGFueQorICAgICAgICByZXBhaW50aW5nIGF0IGFsbCBpbiBjZXJ0 YWluIGNhc2VzLCBiZWNhdXNlIG9mIEh5YXR0J3MgY2hhbmdlcyB0byBob3cKKyAgICAgICAgd2lk Z2V0cyBhbmQgdGhlIGhvc3Qgd2luZG93IGFyZSBpbnZvbHZlZCBpbiB0aGUgcmVwYWludGluZyBw cm9jZXNzLgorICAgICAgICBTbyBjYWxsIEZyYW1lVmlldzo6c2NoZWR1bGVSZWxheW91dCBpbnN0 ZWFkLCB3aGljaCBpcyBtb3JlIHByZWNpc2VseQorICAgICAgICB3aGF0IHdlIHdhbnQgYW5kIG5l ZWQgaGVyZS4KKworICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkZyYW1lVmlldzo6c2NoZWR1bGVSZWxheW91dCk6IEFkZCBhIGNhbGwgdG8gbmVlZHNMYXlv dXQgaGVyZQorICAgICAgICBzbyB0aGF0IERvY3VtZW50OjpzaG91bGRTY2hlZHVsZUxheW91dCBk b2Vzbid0IGhhdmUgdG8gcmVwbGljYXRlIHRoZQorICAgICAgICBsb2dpYyB0aGF0J3MgaW4gbmVl ZHNMYXlvdXQgYW5kIGNhbiBpbnN0ZWFkIHJlbHkgb24gdGhlIGZhY3QgdGhhdCBpdAorICAgICAg ICB3YXMgYWxyZWFkeSBjYWxsZWQuCisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6Om5lZWRz TGF5b3V0KTogVHdlYWtlZCB0aGUgY29tbWVudHMgYW5kIGZvcm1hdHRpbmcKKyAgICAgICAgaW4g dGhpcyBmdW5jdGlvbi4KKwogMjAwOC0xMS0xMCAgVG9tIENvb2tzZXkgIDx0aG9tYXMuY29va3Nl eUB0cm9sbHRlY2guY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvciBBcm5lIFZlc3Riw7gu CkluZGV4OiBXZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9k b20vRG9jdW1lbnQuY3BwCShyZXZpc2lvbiAzODI0NykKKysrIFdlYkNvcmUvZG9tL0RvY3VtZW50 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTYyMiwxMyArMTYyMiwxNCBAQCB2b2lkIERvY3VtZW50 OjpzZXRQYXJzaW5nKGJvb2wgYikKIAogYm9vbCBEb2N1bWVudDo6c2hvdWxkU2NoZWR1bGVMYXlv dXQoKQogewotICAgIC8vIFdlIGNhbiB1cGRhdGUgbGF5b3V0IGlmOgotICAgIC8vIChhKSB3ZSBh Y3R1YWxseSBuZWVkIGEgbGF5b3V0Ci0gICAgLy8gKGIpIG91ciBzdHlsZXNoZWV0cyBhcmUgYWxs IGxvYWRlZAotICAgIC8vIChjKSB3ZSBoYXZlIGEgPGJvZHk+Ci0gICAgcmV0dXJuIChyZW5kZXJl cigpICYmIHJlbmRlcmVyKCktPm5lZWRzTGF5b3V0KCkgJiYgaGF2ZVN0eWxlc2hlZXRzTG9hZGVk KCkgJiYKLSAgICAgICAgICAgIGRvY3VtZW50RWxlbWVudCgpICYmIGRvY3VtZW50RWxlbWVudCgp LT5yZW5kZXJlcigpICYmCi0gICAgICAgICAgICAoIWRvY3VtZW50RWxlbWVudCgpLT5oYXNUYWdO YW1lKGh0bWxUYWcpIHx8IGJvZHkoKSkpOworICAgIC8vIFRoaXMgZnVuY3Rpb24gd2lsbCBvbmx5 IGJlIGNhbGxlZCB3aGVuIEZyYW1lVmlldyB0aGlua3MgYSBsYXlvdXQgaXMgbmVlZGVkLgorICAg IC8vIFRoaXMgZW5mb3JjZXMgYSBjb3VwbGUgZXh0cmEgcnVsZXMuCisgICAgLy8KKyAgICAvLyAg ICAoYSkgT25seSBzY2hlZHVsZSBhIGxheW91dCBvbmNlIHRoZSBzdHlsZXNoZWV0cyBhcmUgbG9h ZGVkLgorICAgIC8vICAgIChiKSBPbmx5IHNjaGVkdWxlIGxheW91dCBvbmNlIHdlIGhhdmUgYSBi b2R5IGVsZW1lbnQuCisKKyAgICByZXR1cm4gaGF2ZVN0eWxlc2hlZXRzTG9hZGVkKCkKKyAgICAg ICAgJiYgYm9keSgpIHx8IChkb2N1bWVudEVsZW1lbnQoKSAmJiAhZG9jdW1lbnRFbGVtZW50KCkt Pmhhc1RhZ05hbWUoaHRtbFRhZykpOwogfQogCiBpbnQgRG9jdW1lbnQ6Om1pbmltdW1MYXlvdXRE ZWxheSgpCkluZGV4OiBXZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvcGFnZS9GcmFtZS5jcHAJKHJldmlzaW9uIDM4MjQ3KQorKysgV2ViQ29yZS9wYWdlL0ZyYW1l LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzM5LDEwICs3MzksMTAgQEAgdm9pZCBGcmFtZTo6c2V0 TmVlZHNSZWFwcGx5U3R5bGVzKCkKIAogICAgIGQtPm1fbmVlZHNSZWFwcGx5U3R5bGVzID0gdHJ1 ZTsKIAotICAgIC8vIEludmFsaWRhdGUgdGhlIEZyYW1lVmlldyBzbyB0aGF0IEZyYW1lVmlldzo6 bGF5b3V0IHdpbGwgZ2V0IGNhbGxlZCwKLSAgICAvLyB3aGljaCBjYWxscyByZWFwcGx5U3R5bGVz LgorICAgIC8vIEZyYW1lVmlldydzICJsYXlvdXQiIHRpbWVyIGluY2x1ZGVzIHJlYXBwbHlTdHls ZXMsIHNvIGRlc3BpdGUgaXRzCisgICAgLy8gbmFtZSwgaXQncyB3aGF0IHdlIHdhbnQgdG8gY2Fs bCBoZXJlLgogICAgIGlmICh2aWV3KCkpCi0gICAgICAgIHZpZXcoKS0+aW52YWxpZGF0ZSgpOwor ICAgICAgICB2aWV3KCktPnNjaGVkdWxlUmVsYXlvdXQoKTsKIH0KIAogYm9vbCBGcmFtZTo6bmVl ZHNSZWFwcGx5U3R5bGVzKCkgY29uc3QKSW5kZXg6IFdlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCShyZXZpc2lvbiAzODI0 NykKKysrIFdlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NDYs NyArNzQ2LDggQEAgdm9pZCBGcmFtZVZpZXc6OnNjaGVkdWxlUmVsYXlvdXQoKQogICAgIH0KICAg ICBpZiAoIWQtPm1fbGF5b3V0U2NoZWR1bGluZ0VuYWJsZWQpCiAgICAgICAgIHJldHVybjsKLQor ICAgIGlmICghbmVlZHNMYXlvdXQoKSkKKyAgICAgICAgcmV0dXJuOwogICAgIGlmICghbV9mcmFt ZS0+ZG9jdW1lbnQoKSB8fCAhbV9mcmFtZS0+ZG9jdW1lbnQoKS0+c2hvdWxkU2NoZWR1bGVMYXlv dXQoKSkKICAgICAgICAgcmV0dXJuOwogCkBAIC04MTgsMTQgKzgxOSwxOCBAQCBib29sIEZyYW1l Vmlldzo6bGF5b3V0UGVuZGluZygpIGNvbnN0CiAKIGJvb2wgRnJhbWVWaWV3OjpuZWVkc0xheW91 dCgpIGNvbnN0CiB7Ci0gICAgLy8gSXQgaXMgcG9zc2libGUgdGhhdCBvdXIgZG9jdW1lbnQgd2ls bCBub3QgaGF2ZSBhIGJvZHkgeWV0LiBJZiB0aGlzIGlzIHRoZSBjYXNlLCAKLSAgICAvLyB0aGVu IHdlIGFyZSBub3QgYWxsb3dlZCB0byBzY2hlZHVsZSBsYXlvdXRzIHlldCwgc28gd2Ugd29uJ3Qg YmUgcGVuZGluZyBsYXlvdXQuCisgICAgLy8gVGhpcyBjYW4gcmV0dXJuIHRydWUgaW4gY2FzZXMg d2hlcmUgdGhlIGRvY3VtZW50IGRvZXMgbm90IGhhdmUgYSBib2R5IHlldC4KKyAgICAvLyBEb2N1 bWVudDo6c2hvdWxkU2NoZWR1bGVMYXlvdXQgdGFrZXMgY2FyZSBvZiBwcmV2ZW50aW5nIHVzIGZy b20gc2NoZWR1bGluZworICAgIC8vIGxheW91dCBpbiB0aGF0IGNhc2UuCiAgICAgaWYgKCFtX2Zy YW1lKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgUmVuZGVyVmlldyogcm9vdCA9IG1fZnJh bWUtPmNvbnRlbnRSZW5kZXJlcigpOwotICAgIERvY3VtZW50ICogZG9jID0gbV9mcmFtZS0+ZG9j dW1lbnQoKTsKLSAgICAvLyBkb2MtPmhhc0NoYW5nZWRDaGlsZCgpIGNvbmRpdGlvbiBjYW4gb2Nj dXIgd2hlbiB1c2luZyBXZWJLaXQgT2JqQyBpbnRlcmZhY2UKLSAgICByZXR1cm4gbGF5b3V0UGVu ZGluZygpIHx8IChyb290ICYmIHJvb3QtPm5lZWRzTGF5b3V0KCkpIHx8IGQtPm1fbGF5b3V0Um9v dCB8fCAoZG9jICYmIGRvYy0+aGFzQ2hhbmdlZENoaWxkKCkpIHx8IG1fZnJhbWUtPm5lZWRzUmVh cHBseVN0eWxlcygpOworICAgIERvY3VtZW50KiBkb2N1bWVudCA9IG1fZnJhbWUtPmRvY3VtZW50 KCk7CisgICAgcmV0dXJuIGxheW91dFBlbmRpbmcoKQorICAgICAgICB8fCAocm9vdCAmJiByb290 LT5uZWVkc0xheW91dCgpKQorICAgICAgICB8fCBkLT5tX2xheW91dFJvb3QKKyAgICAgICAgfHwg KGRvY3VtZW50ICYmIGRvY3VtZW50LT5oYXNDaGFuZ2VkQ2hpbGQoKSkgLy8gY2FuIG9jY3VyIHdo ZW4gdXNpbmcgV2ViS2l0IE9iakMgaW50ZXJmYWNlCisgICAgICAgIHx8IG1fZnJhbWUtPm5lZWRz UmVhcHBseVN0eWxlcygpOwogfQogCiB2b2lkIEZyYW1lVmlldzo6c2V0TmVlZHNMYXlvdXQoKQo=