221027 2021-01-27 00:48:30 -0800 REGRESSION(r271929): MobileSafari hangs upon launch due to a trivial deadlock in IOSurfacePool::setPoolSize 2021-01-27 13:17:02 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 221010 1 rniwa rniwa cdumez saam simon.fraser thorton webkit-bug-importer oldest_to_newest 1722852 0 rniwa 2021-01-27 00:48:30 -0800 We hang inside IOSurfacePool::setPoolSize(unsigned long) via IOSurfacePool::discardAllSurfacesInternal() as the latter tries to grab the lock while setPoolSize holds a locker. 1722855 1 418511 rniwa 2021-01-27 00:53:27 -0800 Created attachment 418511 Patch 1722887 2 418511 rniwa 2021-01-27 03:06:22 -0800 Comment on attachment 418511 Patch Clearing flags on attachment: 418511 Committed r271943: <https://trac.webkit.org/changeset/271943> 1722889 3 rniwa 2021-01-27 03:06:25 -0800 All reviewed patches have been landed. Closing bug. 1722891 4 webkit-bug-importer 2021-01-27 03:07:14 -0800 <rdar://problem/73656115> 1722982 5 418511 cdumez 2021-01-27 07:38:12 -0800 Comment on attachment 418511 Patch Thanks for fixing. 1723122 6 418511 saam 2021-01-27 13:17:02 -0800 Comment on attachment 418511 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418511&action=review > Source/WebCore/platform/graphics/cg/IOSurfacePool.cpp:332 > +void IOSurfacePool::discardAllSurfacesInternal() nit: A style I like in JSC is we do this by keeping the same function name, and requiring a locker to be passed in. So, we'd have: void discardAllSurfaces() and void discardAllSurfaces(const LockHolder&) and the former would call the latter with the locker as an argument. Same with `evict` 418511 2021-01-27 00:53:27 -0800 2021-01-27 03:06:22 -0800 Patch bug-221027-20210127005326.patch text/plain 2694 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxOTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmJhYTcxZTMyM2JjYzJk MmE5MGMyZjA5MzMwN2I2ZTdkMTc1NDdmNi4uYWUwNGY2OWY2YWFmYmIwN2RlYTg2ZmZmMDNhOTM4 NTIxN2QzODJhZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTAxLTI3ICBSeW9z dWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjI3MTky OSk6IE1vYmlsZVNhZmFyaSBoYW5ncyB1cG9uIGxhdW5jaCBkdWUgdG8gYSB0cml2aWFsIGRlYWRs b2NrIGluIElPU3VyZmFjZVBvb2w6OnNldFBvb2xTaXplCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjEwMjcKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBdm9pZCB0aGUgZGVhZGxvY2sgYnkgbm90IGdyYWJi aW5nIHRoZSBsb2NrIGluIElPU3VyZmFjZVBvb2w6OmV2aWN0IHdoZW4gZGlzY2FyZGluZyBhbGwg c3VyZmFjZXMuCisgICAgICAgIFRvIGRvIHRoaXMsIHdlIGV4dHJhY3QgdGhlIGNvZGUgaW4gZGlz Y2FyZEFsbFN1cmZhY2VzIGFzIGRpc2NhcmRBbGxTdXJmYWNlc0ludGVybmFsIGFuZCB1c2UgaXQg aW4gZXZpY3QuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jZy9JT1N1cmZhY2VQb29s LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklPU3VyZmFjZVBvb2w6OmV2aWN0KTogQ2FsbHMgZGlz Y2FyZEFsbFN1cmZhY2VzSW50ZXJuYWwuCisgICAgICAgIChXZWJDb3JlOjpJT1N1cmZhY2VQb29s OjpkaXNjYXJkQWxsU3VyZmFjZXMpOgorICAgICAgICAoV2ViQ29yZTo6SU9TdXJmYWNlUG9vbDo6 ZGlzY2FyZEFsbFN1cmZhY2VzSW50ZXJuYWwpOiBFeHRyYWN0ZWQgb3V0IG9mIGRpc2NhcmRBbGxT dXJmYWNlcy4KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jZy9JT1N1cmZhY2VQb29sLmg6 CisKIDIwMjEtMDEtMjYgIFJvYiBCdWlzICA8cmJ1aXNAaWdhbGlhLmNvbT4KIAogICAgICAgICBS ZWZhY3RvciBjb21wdXRlUHJlZmVycmVkTG9naWNhbFdpZHRocwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSU9TdXJmYWNlUG9vbC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9JT1N1cmZhY2VQb29sLmNwcAppbmRleCAzMzk4 NzJjMTE3YmVjYjY2ZTZiNjFlYTliOGIzZmNmNzQ2YjkyMDE0Li43ZmY2NjQ3NmNlMmRmMjdhOWJk NDExZTliY2Q3MzE0NGRhYTI4Y2Q0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jZy9JT1N1cmZhY2VQb29sLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jZy9JT1N1cmZhY2VQb29sLmNwcApAQCAtMjQxLDcgKzI0MSw3IEBAIHZv aWQgSU9TdXJmYWNlUG9vbDo6ZXZpY3Qoc2l6ZV90IGFkZGl0aW9uYWxTaXplKQogICAgIERVTVBf UE9PTF9TVEFUSVNUSUNTKCJiZWZvcmUgZXZpY3QiKTsKIAogICAgIGlmIChhZGRpdGlvbmFsU2l6 ZSA+PSBtX21heGltdW1CeXRlc0NhY2hlZCkgewotICAgICAgICBkaXNjYXJkQWxsU3VyZmFjZXMo KTsKKyAgICAgICAgZGlzY2FyZEFsbFN1cmZhY2VzSW50ZXJuYWwoKTsKICAgICAgICAgRFVNUF9Q T09MX1NUQVRJU1RJQ1MoImFmdGVyIGV2aWN0IGFsbCIpOwogICAgICAgICByZXR1cm47CiAgICAg fQpAQCAtMzI2LDYgKzMyNiwxMSBAQCB2b2lkIElPU3VyZmFjZVBvb2w6OnNjaGVkdWxlQ29sbGVj dGlvblRpbWVyKCkKIHZvaWQgSU9TdXJmYWNlUG9vbDo6ZGlzY2FyZEFsbFN1cmZhY2VzKCkKIHsK ICAgICBhdXRvIGxvY2tlciA9IGhvbGRMb2NrKG1fbG9jayk7CisgICAgZGlzY2FyZEFsbFN1cmZh Y2VzSW50ZXJuYWwoKTsKK30KKwordm9pZCBJT1N1cmZhY2VQb29sOjpkaXNjYXJkQWxsU3VyZmFj ZXNJbnRlcm5hbCgpCit7CiAgICAgbV9ieXRlc0NhY2hlZCA9IDA7CiAgICAgbV9pblVzZUJ5dGVz Q2FjaGVkID0gMDsKICAgICBtX3N1cmZhY2VEZXRhaWxzLmNsZWFyKCk7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9JT1N1cmZhY2VQb29sLmggYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9JT1N1cmZhY2VQb29sLmgKaW5kZXggYzY5 NGU0ZTU1ZjQ1NWQ0Yjg4M2U3NTJiOTdkYjIzYTVhYTc5ZWE5Zi4uNzY4ODYwZjIwMDliNGM5NDhi NDdlM2E4NDgwZWQzYzk4Njk3NzdjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY2cvSU9TdXJmYWNlUG9vbC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2NnL0lPU3VyZmFjZVBvb2wuaApAQCAtOTcsNiArOTcsOCBAQCBwcml2YXRl OgogCiAgICAgdm9pZCBwbGF0Zm9ybUdhcmJhZ2VDb2xsZWN0Tm93KCk7CiAKKyAgICB2b2lkIGRp c2NhcmRBbGxTdXJmYWNlc0ludGVybmFsKCk7CisKICAgICB2b2lkIHNob3dQb29sU3RhdGlzdGlj cyhjb25zdCBjaGFyKik7CiAKICAgICBSdW5Mb29wOjpUaW1lcjxJT1N1cmZhY2VQb29sPiBtX2Nv bGxlY3Rpb25UaW1lcjsK